René's URL Explorer Experiment


Title: GH-123894: Simplify ascii decode using unaligned loads by rhpvorderman · Pull Request #123895 · python/cpython · GitHub

Open Graph Title: GH-123894: Simplify ascii decode using unaligned loads by rhpvorderman · Pull Request #123895 · python/cpython

X Title: GH-123894: Simplify ascii decode using unaligned loads by rhpvorderman · Pull Request #123895 · python/cpython

Description: When working on #120212 I noticed that the code for ascii_decode could be worded much simpler. The current code prevents unaligned loads, but on x86-64 unaligned loads are not necessarily slower. By using memcpy the compiler is allowed to force aligned loads on platforms that require it, while allowing unaligned loads on platforms that support it. It simplifies the code and allows for easier manual unrolling if that is desired at a later point. EDIT: I feel that this does not warrant a NEWS entry. So I haven't written one. Issue: gh-123894

Open Graph Description: When working on #120212 I noticed that the code for ascii_decode could be worded much simpler. The current code prevents unaligned loads, but on x86-64 unaligned loads are not necessarily slower. B...

X Description: When working on #120212 I noticed that the code for ascii_decode could be worded much simpler. The current code prevents unaligned loads, but on x86-64 unaligned loads are not necessarily slower. B...

Opengraph URL: https://github.com/python/cpython/pull/123895

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:40469c70-a6c8-d58e-aad1-c8ff77796e96
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A36:3CBB3E:37F9775:4756759:6B023984
html-safe-nonce0c6bba65d9beaaa1acf35db13c0ba2f2f5663ad869cd6e114718c76f162aa993
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTM2OjNDQkIzRTozN0Y5Nzc1OjQ3NTY3NTk6NkIwMjM5ODQiLCJ2aXNpdG9yX2lkIjoiNTk4Nzk1MTUyMzY0MzE0NDU4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc1f94370744c6c93c0490b9840bac9dcdd0906ec9208eacc514f4c5ca095c952
hovercard-subject-tagpull_request:2062858063
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/123895/files
twitter:imagehttps://avatars.githubusercontent.com/u/26142226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/26142226?s=400&v=4
og:image:altWhen working on #120212 I noticed that the code for ascii_decode could be worded much simpler. The current code prevents unaligned loads, but on x86-64 unaligned loads are not necessarily slower. B...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/123895/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F123895%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F123895%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/123895/files
Reloadhttps://github.com/python/cpython/pull/123895/files
Reloadhttps://github.com/python/cpython/pull/123895/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
rhpvordermanhttps://github.com/rhpvorderman
python:mainhttps://github.com/python/cpython/tree/main
rhpvorderman:unrolled_ascii_decodehttps://github.com/rhpvorderman/cpython/tree/unrolled_ascii_decode
Conversation 9 https://github.com/python/cpython/pull/123895
Commits 1 https://github.com/python/cpython/pull/123895/commits
Checks 0 https://github.com/python/cpython/pull/123895/checks
Files changed https://github.com/python/cpython/pull/123895/files
Please reload this pagehttps://github.com/python/cpython/pull/123895/files
GH-123894: Simplify ascii decode using unaligned loads https://github.com/python/cpython/pull/123895/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/123895/files
a8a1a93 Simplify ascii decode using unaligned loads rhpvorderman Sep 10, 2024 https://github.com/python/cpython/pull/123895/commits/a8a1a93e583d41436f0f3c70fa8356319be472c4
Clear filters https://github.com/python/cpython/pull/123895/files
Please reload this pagehttps://github.com/python/cpython/pull/123895/files
Please reload this pagehttps://github.com/python/cpython/pull/123895/files
Objects/unicodeobject.chttps://github.com/python/cpython/pull/123895/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
View file https://github.com/rhpvorderman/cpython/blob/a8a1a93e583d41436f0f3c70fa8356319be472c4/Objects/unicodeobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/123895/{{ revealButtonHref }}
https://github.com/python/cpython/pull/123895/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
picnixzhttps://github.com/picnixz
Sep 10, 2024https://github.com/python/cpython/pull/123895/files#r1751758282
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/123895/files
rhpvordermanhttps://github.com/rhpvorderman
Sep 10, 2024https://github.com/python/cpython/pull/123895/files#r1751779205
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/123895/files
picnixzhttps://github.com/picnixz
Sep 10, 2024https://github.com/python/cpython/pull/123895/files#r1751760124
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/123895/files
rhpvordermanhttps://github.com/rhpvorderman
Sep 10, 2024https://github.com/python/cpython/pull/123895/files#r1751767266
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/123895/files
rhpvordermanhttps://github.com/rhpvorderman
Sep 10, 2024https://github.com/python/cpython/pull/123895/files#r1751774586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://godbolt.org/z/a9xdjfoq4https://godbolt.org/z/a9xdjfoq4
Please reload this pagehttps://github.com/python/cpython/pull/123895/files
picnixzhttps://github.com/picnixz
Sep 10, 2024https://github.com/python/cpython/pull/123895/files#r1751789472
Please reload this pagehttps://github.com/python/cpython/pull/123895/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/123895/files
https://github.com/python/cpython/pull/123895/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.