Title: bpo-36305: Fixes to path handling and parsing in pathlib by kmaork · Pull Request #12361 · python/cpython · GitHub
Open Graph Title: bpo-36305: Fixes to path handling and parsing in pathlib by kmaork · Pull Request #12361 · python/cpython
X Title: bpo-36305: Fixes to path handling and parsing in pathlib by kmaork · Pull Request #12361 · python/cpython
Description: The bugs This PR fixes three bugs with path parsing in pathlib. The following examples show these bugs (when the cwd is C:\d): WindowsPath('C:a').absolute() should return WindowsPath('C:\\d\\a') but returns WindowsPath('C:a'). This is caused by flawed logic in the parse_parts method of the _Flavour class. WindowsPath('./b:a').absolute() should return WindowsPath('C:\\d\\b:a') but returns WindowsPath('b:a'). This is caused by the limited interface of parse_parts, and affects the Path.absolute, Path.expanduser and Path.__rtruediv__ methods. WindowsPath('./b:a').resolve() should return WindowsPath('C:\\d\\b:a') but returns WindowsPath('b:a'). This is caused by missing logic in the resolve method and in Path.__str__ The fixes To fix the first bug, I fixed a flaw in the parse_parts method. The second one was more complicated, as with the current interface of parse_parts (called by _parse_args), the bug can't be fixed. Let's take a simple example: WindowsPath(WindowsPath('./a:b')) and WindowsPath('a:b') - before the bugfix, they are equal. That happens because in both cases, parse_parts is called with ['a:b']. This part can be interpreted in two ways - either as the relative path 'b' with the drive 'a:', or as a file 'a' with the NTFS data-stream 'b'. That means that in some cases, passing the flattened _parts of a path to parse_parts is lossy. Therefore we have to a modify parse_parts's interface to enable passing more detailed information about the given parts. What I decided to do was allow passing tuples in addition to strings, thus supporting the old interface. The tuples would contain the drive, root and path parts, enough information to determine the correct parsing of path parts with data-streams, and maybe more future edge cases. After modifying parse_parts's interface, I changed _parse_args to use it and made Path.absolute, Path.expanduser and Path.__rtruediv__ pass Path objects to _parse_args instead of path parts, to preserve the path information. To solve the third bug I had to make small changes to both the resolve method and to Path.__str__. Notes In addition to the changes in the code, I've added regression tests and modified old incorrect tests. Details about drive-relative paths can be found here. https://bugs.python.org/issue36305
Open Graph Description: The bugs This PR fixes three bugs with path parsing in pathlib. The following examples show these bugs (when the cwd is C:\d): WindowsPath('C:a').absolute() should return WindowsPath('...
X Description: The bugs This PR fixes three bugs with path parsing in pathlib. The following examples show these bugs (when the cwd is C:\d): WindowsPath('C:a').absolute() should return WindowsPa...
Opengraph URL: https://github.com/python/cpython/pull/12361
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8fb4ea6d-6c38-4e87-2d8a-6c7a17e3532c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E14E:1D772C:8757E6:B7CB71:696AB658 |
| html-safe-nonce | fd0c32a19f5860b8f70e9c8da4a41457cda51ba4c185f6125beeb0b7ff8b4795 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTRFOjFENzcyQzo4NzU3RTY6QjdDQjcxOjY5NkFCNjU4IiwidmlzaXRvcl9pZCI6IjIzMjA2ODQ4MDMwNDk1Njc4MzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8fef6885560f31842f675933ca366ea531223cf1cec4feafdad4779dbf0d5947 |
| hovercard-subject-tag | pull_request:261718371 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/12361/files |
| twitter:image | https://avatars.githubusercontent.com/u/7690337?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/7690337?s=400&v=4 |
| og:image:alt | The bugs This PR fixes three bugs with path parsing in pathlib. The following examples show these bugs (when the cwd is C:\d): WindowsPath('C:a').absolute() should return WindowsPath('... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4fa1799b6a53c2d30c950d74230781bef9e7f61138c72c7727e4b83f0743752b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 41f276818bd204c4a30a0281fb3c576298d9474c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width