René's URL Explorer Experiment


Title: bpo-36305: Fixes to path handling and parsing in pathlib by kmaork · Pull Request #12361 · python/cpython · GitHub

Open Graph Title: bpo-36305: Fixes to path handling and parsing in pathlib by kmaork · Pull Request #12361 · python/cpython

X Title: bpo-36305: Fixes to path handling and parsing in pathlib by kmaork · Pull Request #12361 · python/cpython

Description: The bugs This PR fixes three bugs with path parsing in pathlib. The following examples show these bugs (when the cwd is C:\d): WindowsPath('C:a').absolute() should return WindowsPath('C:\\d\\a') b...

Open Graph Description: The bugs This PR fixes three bugs with path parsing in pathlib. The following examples show these bugs (when the cwd is C:\d): WindowsPath('C:a').absolute() should return WindowsPath('...

X Description: The bugs This PR fixes three bugs with path parsing in pathlib. The following examples show these bugs (when the cwd is C:\d): WindowsPath('C:a').absolute() should return WindowsPa...

Opengraph URL: https://github.com/python/cpython/pull/12361

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0a9ff23f-38e3-0461-d021-769f2a2fa53b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC76:B7306:1219426:19328CB:696A8E34
html-safe-nonce0b7fbee8d1f5d071451c0f5eec29389888e29a5f8cc5127bc740b86882d4e1a5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzc2OkI3MzA2OjEyMTk0MjY6MTkzMjhDQjo2OTZBOEUzNCIsInZpc2l0b3JfaWQiOiIyOTkwNDUyMzc5ODI4Nzg0NjkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd78abadb7c647b5170902ed44cd350d4f72b387e9d9520e5aa916448c66978e8
hovercard-subject-tagpull_request:261718371
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/12361/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e8663a282ee7f5d3b9040a29c76dba314461fc88d8c966606ce6ea292909cfd3/python/cpython/pull/12361
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e8663a282ee7f5d3b9040a29c76dba314461fc88d8c966606ce6ea292909cfd3/python/cpython/pull/12361
og:image:altThe bugs This PR fixes three bugs with path parsing in pathlib. The following examples show these bugs (when the cwd is C:\d): WindowsPath('C:a').absolute() should return WindowsPath('...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekmaork
hostnamegithub.com
expected-hostnamegithub.com
Noned2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec1dbca8981c5e3d6a69bce2f1d289e732b86241d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/12361#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F12361
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F12361
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/12361
Reloadhttps://github.com/python/cpython/pull/12361
Reloadhttps://github.com/python/cpython/pull/12361
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/12361
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/12361
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/12361#issue-comment-box
kmaorkhttps://github.com/kmaork
python:mainhttps://github.com/python/cpython/tree/main
kmaork:fix-issue-36305https://github.com/kmaork/cpython/tree/fix-issue-36305
bpo-36305: Fixes to path handling and parsing in pathlib https://github.com/python/cpython/pull/12361#top
kmaorkhttps://github.com/kmaork
python:mainhttps://github.com/python/cpython/tree/main
kmaork:fix-issue-36305https://github.com/kmaork/cpython/tree/fix-issue-36305
Conversation 15 https://github.com/python/cpython/pull/12361
Commits 3 https://github.com/python/cpython/pull/12361/commits
Checks 0 https://github.com/python/cpython/pull/12361/checks
Files changed https://github.com/python/cpython/pull/12361/files
Please reload this pagehttps://github.com/python/cpython/pull/12361
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/kmaork
kmaorkhttps://github.com/kmaork
Mar 15, 2019https://github.com/python/cpython/pull/12361#issue-421728725
Please reload this pagehttps://github.com/python/cpython/pull/12361
herehttps://docs.microsoft.com/en-us/windows/desktop/fileio/naming-a-file#fully-qualified-vs-relative-paths
https://bugs.python.org/issue36305https://bugs.python.org/issue36305
Please reload this pagehttps://github.com/python/cpython/pull/12361
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Mar 15, 2019https://github.com/python/cpython/pull/12361#event-2207773098
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 15, 2019https://github.com/python/cpython/pull/12361#event-2207773126
https://github.com/eryksun
eryksunhttps://github.com/eryksun
Mar 16, 2019 https://github.com/python/cpython/pull/12361#pullrequestreview-215305607
View reviewed changes https://github.com/python/cpython/pull/12361/files
Lib/pathlib.pyhttps://github.com/python/cpython/pull/12361/files#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c
eryksunhttps://github.com/eryksun
Mar 16, 2019https://github.com/python/cpython/pull/12361#discussion_r266193353
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/12361
kmaorkhttps://github.com/kmaork
Mar 16, 2019https://github.com/python/cpython/pull/12361#discussion_r266195899
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/12361
https://github.com/eryksun
eryksunhttps://github.com/eryksun
Mar 16, 2019https://github.com/python/cpython/pull/12361#issuecomment-473509661
Please reload this pagehttps://github.com/python/cpython/pull/12361
https://github.com/eryksun
eryksunhttps://github.com/eryksun
Mar 16, 2019 https://github.com/python/cpython/pull/12361#pullrequestreview-215306023
View reviewed changes https://github.com/python/cpython/pull/12361/files
Lib/test/test_pathlib.pyhttps://github.com/python/cpython/pull/12361/files#diff-3dd97d2dc8816848d0b0c442e8fdeec9650b3de77935289a93f37ac6396ee17f
eryksunhttps://github.com/eryksun
Mar 16, 2019https://github.com/python/cpython/pull/12361#discussion_r266193727
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/12361
eryksunhttps://github.com/eryksun
Mar 16, 2019https://github.com/python/cpython/pull/12361#discussion_r266193809
Please reload this pagehttps://github.com/python/cpython/pull/12361
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/12361
pfmoorehttps://github.com/pfmoore
Mar 23, 2019https://github.com/python/cpython/pull/12361#discussion_r268398513
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/12361
kmaorkhttps://github.com/kmaork
Mar 23, 2019https://github.com/python/cpython/pull/12361#discussion_r268400507
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/12361
https://github.com/kmaork
kmaorkhttps://github.com/kmaork
Mar 16, 2019https://github.com/python/cpython/pull/12361#event-2208398639
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
May 28, 2019 https://github.com/python/cpython/pull/12361#ref-pullrequest-449168843
Fix handling relative path in normalize_local_path_uri() on Windows. neuro-inc/apolo-cli#815 https://github.com/neuro-inc/apolo-cli/pull/815
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
May 28, 2019 14:43https://github.com/python/cpython/pull/12361#event-2372075275
https://github.com/kmaork
Fixed bugs with drive-relative paths and NTFS ADS paths in pathlibhttps://github.com/python/cpython/pull/12361/commits/15aadf9b0e4551c157c04ae60592c84e4caae01d
15aadf9https://github.com/python/cpython/pull/12361/commits/15aadf9b0e4551c157c04ae60592c84e4caae01d
https://github.com/kmaork
kmaorkhttps://github.com/kmaork
force-pushedhttps://github.com/python/cpython/compare/e254a4b5f04d0e1df0365d8e19a757b738fc4883..15aadf9b0e4551c157c04ae60592c84e4caae01d
e254a4bhttps://github.com/python/cpython/commit/e254a4b5f04d0e1df0365d8e19a757b738fc4883
15aadf9https://github.com/python/cpython/commit/15aadf9b0e4551c157c04ae60592c84e4caae01d
Compare https://github.com/python/cpython/compare/e254a4b5f04d0e1df0365d8e19a757b738fc4883..15aadf9b0e4551c157c04ae60592c84e4caae01d
June 13, 2019 21:37https://github.com/python/cpython/pull/12361#event-2411990933
https://github.com/csabella
csabellahttps://github.com/csabella
Jan 16, 2020https://github.com/python/cpython/pull/12361#issuecomment-575123391
Please reload this pagehttps://github.com/python/cpython/pull/12361
bpo-34775https://bugs.python.org/issue34775
Please reload this pagehttps://github.com/python/cpython/pull/12361
kmaorkhttps://github.com/kmaork
January 16, 2020 19:15https://github.com/python/cpython/pull/12361#commits-pushed-c827f98
https://github.com/kmaork
Merge branch 'master' into fix-issue-36305https://github.com/python/cpython/pull/12361/commits/c827f982c328731129dcb033d1e21e800d6f8488
c827f98https://github.com/python/cpython/pull/12361/commits/c827f982c328731129dcb033d1e21e800d6f8488
https://github.com/kmaork
Merge branch 'master' into fix-issue-36305https://github.com/python/cpython/pull/12361/commits/64fc34274ff891042963ebce19106620a86ba410
64fc342https://github.com/python/cpython/pull/12361/commits/64fc34274ff891042963ebce19106620a86ba410
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Apr 17, 2020https://github.com/python/cpython/pull/12361#issuecomment-615384742
Please reload this pagehttps://github.com/python/cpython/pull/12361
@pfmoorehttps://github.com/pfmoore
@zoobahttps://github.com/zooba
@kmaorkhttps://github.com/kmaork
Please reload this pagehttps://github.com/python/cpython/pull/12361
https://github.com/kmaork
kmaorkhttps://github.com/kmaork
May 2, 2020https://github.com/python/cpython/pull/12361#issuecomment-622992168
Please reload this pagehttps://github.com/python/cpython/pull/12361
@pitrouhttps://github.com/pitrou
@pfmoorehttps://github.com/pfmoore
@zoobahttps://github.com/zooba
Please reload this pagehttps://github.com/python/cpython/pull/12361
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
topic-pathlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-pathlib
Jun 21, 2022https://github.com/python/cpython/pull/12361#event-6849705796
https://github.com/python/cpython/pull/12361
kmaorkhttps://github.com/python/cpython/pull/12361
Jun 21, 2022 https://github.com/python/cpython/pull/12361#ref-issue-1199007897
Inconsistent behavior of pathlib.WindowsPath with drive paths #80486 https://github.com/python/cpython/issues/80486
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Jun 25, 2022https://github.com/python/cpython/pull/12361#issuecomment-1166362094
@pitrouhttps://github.com/pitrou
@pfmoorehttps://github.com/pfmoore
@zoobahttps://github.com/zooba
Please reload this pagehttps://github.com/python/cpython/pull/12361
https://github.com/ezio-melotti
ezio-melottihttps://github.com/ezio-melotti
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jul 13, 2022https://github.com/python/cpython/pull/12361#event-6988866485
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Feb 17, 2023 https://github.com/python/cpython/pull/12361#pullrequestreview-1304318591
View reviewed changes https://github.com/python/cpython/pull/12361/files/64fc34274ff891042963ebce19106620a86ba410
barneygalehttps://github.com/barneygale
Please reload this pagehttps://github.com/python/cpython/pull/12361
https://github.com/python/cpython/pull/12361#pullrequestreview-1304318591
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#101667https://github.com/python/cpython/pull/101667
Please reload this pagehttps://github.com/python/cpython/pull/12361
Lib/test/test_pathlib.pyhttps://github.com/python/cpython/pull/12361/files/64fc34274ff891042963ebce19106620a86ba410#diff-3dd97d2dc8816848d0b0c442e8fdeec9650b3de77935289a93f37ac6396ee17f
barneygalehttps://github.com/barneygale
Feb 17, 2023https://github.com/python/cpython/pull/12361#discussion_r1110451710
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/12361
Lib/test/test_pathlib.pyhttps://github.com/python/cpython/pull/12361/files/64fc34274ff891042963ebce19106620a86ba410#diff-3dd97d2dc8816848d0b0c442e8fdeec9650b3de77935289a93f37ac6396ee17f
barneygalehttps://github.com/barneygale
Feb 17, 2023https://github.com/python/cpython/pull/12361#discussion_r1110452164
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/12361
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 17, 2023https://github.com/python/cpython/pull/12361#event-8551838250
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Mar 10, 2023https://github.com/python/cpython/pull/12361#issuecomment-1464139616
#102454https://github.com/python/cpython/pull/102454
@kmaorkhttps://github.com/kmaork
Please reload this pagehttps://github.com/python/cpython/pull/12361
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Mar 10, 2023https://github.com/python/cpython/pull/12361#event-8720422284
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F12361
https://github.com/eryksun
eryksun https://github.com/eryksun
https://github.com/python/cpython/pull/12361/files/b72e391d003debb10f0a5ee9dd3c0f205c708ab1
https://github.com/pfmoore
pfmoore https://github.com/pfmoore
https://github.com/python/cpython/pull/12361/files/e254a4b5f04d0e1df0365d8e19a757b738fc4883
https://github.com/barneygale
barneygale https://github.com/barneygale
https://github.com/python/cpython/pull/12361/files/64fc34274ff891042963ebce19106620a86ba410
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
topic-pathlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-pathlib
Please reload this pagehttps://github.com/python/cpython/pull/12361
https://github.com/kmaork
https://github.com/eryksun
https://github.com/csabella
https://github.com/pitrou
https://github.com/barneygale
https://github.com/pfmoore
https://github.com/brettcannon
https://github.com/the-knights-who-say-ni
https://github.com/ezio-melotti
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.