René's URL Explorer Experiment


Title: bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). by ericsnowcurrently · Pull Request #12360 · python/cpython · GitHub

Open Graph Title: bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). by ericsnowcurrently · Pull Request #12360 · python/cpython

X Title: bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). by ericsnowcurrently · Pull Request #12360 · python/cpython

Description: This is effectively an un-revert of #11617 and #12024 (reverted in #12159). Portions of those were merged in other PRs (with lower risk) and this represents the remainder. Note that I found 3 different bugs in the original PRs and have fixed them here. @vstinner, would you mind running this against that VM you set up, to see if it causes the original problem? I expect it won't. https://bugs.python.org/issue33608

Open Graph Description: This is effectively an un-revert of #11617 and #12024 (reverted in #12159). Portions of those were merged in other PRs (with lower risk) and this represents the remainder. Note that I found 3 dif...

X Description: This is effectively an un-revert of #11617 and #12024 (reverted in #12159). Portions of those were merged in other PRs (with lower risk) and this represents the remainder. Note that I found 3 dif...

Opengraph URL: https://github.com/python/cpython/pull/12360

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e59a81b5-b216-9892-c872-331ac2f22b2d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD528:33AEDC:67161:88F10:6A512295
html-safe-nonce2ec337156c445bc96ae76d47a003d9fedb5d2b15ad40c419fe721f3856c685ce
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTI4OjMzQUVEQzo2NzE2MTo4OEYxMDo2QTUxMjI5NSIsInZpc2l0b3JfaWQiOiI5MDM5MDQxODc3NzY5MjY1ODEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca798a8602c41aabc964390147bb43e921462b60652129e6f829158867d6f8b2a
hovercard-subject-tagpull_request:261717445
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/12360/files
twitter:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
og:image:altThis is effectively an un-revert of #11617 and #12024 (reverted in #12159). Portions of those were merged in other PRs (with lower risk) and this represents the remainder. Note that I found 3 dif...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None689b683944b0d7f015d0e776452c970832fa81b82dc15284469b556ecced715b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release942b51ed3bd5feee3d5e2719f890a5fe286edbbb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/12360/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F12360%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F12360%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/12360/files
Reloadhttps://github.com/python/cpython/pull/12360/files
Reloadhttps://github.com/python/cpython/pull/12360/files
Please reload this pagehttps://github.com/python/cpython/pull/12360/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/12360/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:masterhttps://github.com/python/cpython/tree/master
ericsnowcurrently:pending-calls-unreverthttps://github.com/ericsnowcurrently/cpython/tree/pending-calls-unrevert
Conversation 9 https://github.com/python/cpython/pull/12360
Commits 14 https://github.com/python/cpython/pull/12360/commits
Checks 0 https://github.com/python/cpython/pull/12360/checks
Files changed https://github.com/python/cpython/pull/12360/files
Please reload this pagehttps://github.com/python/cpython/pull/12360/files
bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). https://github.com/python/cpython/pull/12360/files#top
Show all changes 14 commits https://github.com/python/cpython/pull/12360/files
f8e70b4 Move pending calls from _PyRuntimeState to PyIntepreterState. ericsnowcurrently Jul 13, 2018 https://github.com/python/cpython/pull/12360/commits/f8e70b485855dbb709b56ea16a9686ababcefa1d
991e3fb Release the pending calls lock *after* updating the eval breaker flag. ericsnowcurrently Mar 15, 2019 https://github.com/python/cpython/pull/12360/commits/991e3fb840e7684a44abf0743dba84f798ca55eb
69b620e Explicitly pass the interpreter to the stateful ceval macros. ericsnowcurrently Sep 10, 2018 https://github.com/python/cpython/pull/12360/commits/69b620ea1c4fd19e0743c355b713d3f7c18706d2
8993d23 Use the internal function. ericsnowcurrently Sep 14, 2018 https://github.com/python/cpython/pull/12360/commits/8993d237fdf825272d6b5bd7a55078982dd26b32
6655676 Add a NEWS entry. ericsnowcurrently Sep 15, 2018 https://github.com/python/cpython/pull/12360/commits/66556769c2d24a438a40913ec8856fe4539773a2
d716131 Optionally lock a pending call to a specific thread. ericsnowcurrently Sep 15, 2018 https://github.com/python/cpython/pull/12360/commits/d71613160298471fb1e64c19cb60e1c4953f1a5d
1cdc3b2 Move core-only field to end of struct. ericsnowcurrently Feb 1, 2019 https://github.com/python/cpython/pull/12360/commits/1cdc3b20916033111324d687e58b4e6b5f70d299
158151f Factor out struct _ceval_interpreter_state. ericsnowcurrently Feb 1, 2019 https://github.com/python/cpython/pull/12360/commits/158151f9a81ea7ad646d2f67c0433b963126aa08
0c83e6f Add a TODO. ericsnowcurrently Feb 18, 2019 https://github.com/python/cpython/pull/12360/commits/0c83e6f92129881b039edf1862e15420dd131bde
40ab9ab Use _Py_AddPendingCall() for releasing shared data. ericsnowcurrently Sep 14, 2018 https://github.com/python/cpython/pull/12360/commits/40ab9ab02d6f98322f514aecbe57820a53d57d36
f354a86 Check the result of adding the pending call (for releasing XID). ericsnowcurrently Jan 28, 2019 https://github.com/python/cpython/pull/12360/commits/f354a86647857b155fd4df83f2a54b2196a6b694
279ff04 Make a copy of data-to-be-deleted. ericsnowcurrently Jan 29, 2019 https://github.com/python/cpython/pull/12360/commits/279ff04bf1072d422cbe5b9230ecc558c70f9ec0
e356cad Fix the pending-for-other-thread case. ericsnowcurrently Apr 5, 2019 https://github.com/python/cpython/pull/12360/commits/e356cad82502cb0bf5b90c5802ea0ca0d31cd8f7
48a23ef Drop out-of-date code. ericsnowcurrently Apr 5, 2019 https://github.com/python/cpython/pull/12360/commits/48a23ef33c351a82082a35be958d868551d0297b
Clear filters https://github.com/python/cpython/pull/12360/files
Please reload this pagehttps://github.com/python/cpython/pull/12360/files
Please reload this pagehttps://github.com/python/cpython/pull/12360/files
ceval.h https://github.com/python/cpython/pull/12360/files#diff-ebdfffaf18bedcdb18ef52479aec307e5f9853560ebaabc481808e84458a1400
pycore_ceval.h https://github.com/python/cpython/pull/12360/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
pycore_pystate.h https://github.com/python/cpython/pull/12360/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
test_capi.py https://github.com/python/cpython/pull/12360/files#diff-a537c794ffb51531649e2b81f9ae6978c25077de6aa10c9134576ac628fcc345
2018-09-15-12-13-46.bpo-33608.avmvVP.rst https://github.com/python/cpython/pull/12360/files#diff-9180afc508bd25efb07dc85c316ba046bcb38b63d0c8fc078688e29a46cf3aaf
_testcapimodule.c https://github.com/python/cpython/pull/12360/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
signalmodule.c https://github.com/python/cpython/pull/12360/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
ceval.c https://github.com/python/cpython/pull/12360/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
ceval_gil.h https://github.com/python/cpython/pull/12360/files#diff-a752fe0b500ba9e2a169c27f43c58c1e354039fffa5ad64852e0978006f45660
pylifecycle.c https://github.com/python/cpython/pull/12360/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
pystate.c https://github.com/python/cpython/pull/12360/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
Include/ceval.hhttps://github.com/python/cpython/pull/12360/files#diff-ebdfffaf18bedcdb18ef52479aec307e5f9853560ebaabc481808e84458a1400
View file https://github.com/ericsnowcurrently/cpython/blob/48a23ef33c351a82082a35be958d868551d0297b/Include/ceval.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/12360/{{ revealButtonHref }}
https://github.com/python/cpython/pull/12360/files#diff-ebdfffaf18bedcdb18ef52479aec307e5f9853560ebaabc481808e84458a1400
https://github.com/python/cpython/pull/12360/files#diff-ebdfffaf18bedcdb18ef52479aec307e5f9853560ebaabc481808e84458a1400
Include/internal/pycore_ceval.hhttps://github.com/python/cpython/pull/12360/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
View file https://github.com/ericsnowcurrently/cpython/blob/48a23ef33c351a82082a35be958d868551d0297b/Include/internal/pycore_ceval.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/12360/{{ revealButtonHref }}
https://github.com/python/cpython/pull/12360/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
https://github.com/python/cpython/pull/12360/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
https://github.com/python/cpython/pull/12360/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
https://github.com/python/cpython/pull/12360/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
Include/internal/pycore_pystate.hhttps://github.com/python/cpython/pull/12360/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
View file https://github.com/ericsnowcurrently/cpython/blob/48a23ef33c351a82082a35be958d868551d0297b/Include/internal/pycore_pystate.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/12360/{{ revealButtonHref }}
https://github.com/python/cpython/pull/12360/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
https://github.com/python/cpython/pull/12360/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
https://github.com/python/cpython/pull/12360/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
https://github.com/python/cpython/pull/12360/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
Lib/test/test_capi.pyhttps://github.com/python/cpython/pull/12360/files#diff-a537c794ffb51531649e2b81f9ae6978c25077de6aa10c9134576ac628fcc345
View file https://github.com/ericsnowcurrently/cpython/blob/48a23ef33c351a82082a35be958d868551d0297b/Lib/test/test_capi.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/12360/{{ revealButtonHref }}
https://github.com/python/cpython/pull/12360/files#diff-a537c794ffb51531649e2b81f9ae6978c25077de6aa10c9134576ac628fcc345
https://github.com/python/cpython/pull/12360/files#diff-a537c794ffb51531649e2b81f9ae6978c25077de6aa10c9134576ac628fcc345
Misc/NEWS.d/next/Core and Builtins/2018-09-15-12-13-46.bpo-33608.avmvVP.rsthttps://github.com/python/cpython/pull/12360/files#diff-9180afc508bd25efb07dc85c316ba046bcb38b63d0c8fc078688e29a46cf3aaf
View file https://github.com/ericsnowcurrently/cpython/blob/48a23ef33c351a82082a35be958d868551d0297b/Misc/NEWS.d/next/Core%20and%20Builtins/2018-09-15-12-13-46.bpo-33608.avmvVP.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/12360/{{ revealButtonHref }}
Modules/_testcapimodule.chttps://github.com/python/cpython/pull/12360/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
View file https://github.com/ericsnowcurrently/cpython/blob/48a23ef33c351a82082a35be958d868551d0297b/Modules/_testcapimodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/12360/{{ revealButtonHref }}
https://github.com/python/cpython/pull/12360/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
https://github.com/python/cpython/pull/12360/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
Modules/signalmodule.chttps://github.com/python/cpython/pull/12360/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
View file https://github.com/ericsnowcurrently/cpython/blob/48a23ef33c351a82082a35be958d868551d0297b/Modules/signalmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/12360/{{ revealButtonHref }}
https://github.com/python/cpython/pull/12360/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/12360/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/12360/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/12360/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/12360/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
Please reload this pagehttps://github.com/python/cpython/pull/12360/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.