René's URL Explorer Experiment


Title: gh-97588: Move ctypes struct/union layout logic to Python by encukou · Pull Request #123352 · python/cpython · GitHub

Open Graph Title: gh-97588: Move ctypes struct/union layout logic to Python by encukou · Pull Request #123352 · python/cpython

X Title: gh-97588: Move ctypes struct/union layout logic to Python by encukou · Pull Request #123352 · python/cpython

Description: As discussed in #97702, moving this logic to Python should make it easier to fix the various struct layout bugs in ctypes. This PR should be strictly a refactoring of the code in main, except the _...

Open Graph Description: As discussed in #97702, moving this logic to Python should make it easier to fix the various struct layout bugs in ctypes. This PR should be strictly a refactoring of the code in main, except the _...

X Description: As discussed in #97702, moving this logic to Python should make it easier to fix the various struct layout bugs in ctypes. This PR should be strictly a refactoring of the code in main, except the _...

Opengraph URL: https://github.com/python/cpython/pull/123352

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dfd1a0d0-900d-65bd-a951-8312c7bb4c7a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA76A:26177F:B3E0DD:E79F65:696B24F6
html-safe-noncef9d9f3e3377f7b657b371e6654301951192b6cea2333232e702542993cdf2fa7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzZBOjI2MTc3RjpCM0UwREQ6RTc5RjY1OjY5NkIyNEY2IiwidmlzaXRvcl9pZCI6IjUyMzg0Njk3MDkwNDM1NjA4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacec9d2e8e842471b04b4a20e8dc2698c9a0bdfbf9a6f3fec36c34a1cf8d153cce
hovercard-subject-tagpull_request:2037856064
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/123352/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a65f8288e514879e952e4fd76760697b03ea918ab8b8608650be47603c4b0c3d/python/cpython/pull/123352
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a65f8288e514879e952e4fd76760697b03ea918ab8b8608650be47603c4b0c3d/python/cpython/pull/123352
og:image:altAs discussed in #97702, moving this logic to Python should make it easier to fix the various struct layout bugs in ctypes. This PR should be strictly a refactoring of the code in main, except the _...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/123352#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F123352
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F123352
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/123352
Reloadhttps://github.com/python/cpython/pull/123352
Reloadhttps://github.com/python/cpython/pull/123352
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/123352
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/123352
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/123352#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:ctypes-pypackhttps://github.com/encukou/cpython/tree/ctypes-pypack
gh-97588: Move ctypes struct/union layout logic to Python https://github.com/python/cpython/pull/123352#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:ctypes-pypackhttps://github.com/encukou/cpython/tree/ctypes-pypack
Conversation 79 https://github.com/python/cpython/pull/123352
Commits 95 https://github.com/python/cpython/pull/123352/commits
Checks 0 https://github.com/python/cpython/pull/123352/checks
Files changed 12 https://github.com/python/cpython/pull/123352/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/encukou
encukouhttps://github.com/encukou
Aug 26, 2024https://github.com/python/cpython/pull/123352#issue-2487339527
Please reload this pagehttps://github.com/python/cpython/pull/123352
#97702https://github.com/python/cpython/pull/97702
ctypes: bit field data does not survive round trip #97588https://github.com/python/cpython/issues/97588
Please reload this pagehttps://github.com/python/cpython/pull/123352
encukouhttps://github.com/encukou
August 26, 2024 16:14https://github.com/python/cpython/pull/123352#commits-pushed-ac1d0a3
https://github.com/encukou
Add classes that will implement the struct packinghttps://github.com/python/cpython/pull/123352/commits/ac1d0a3049dfbe80366fdeaf35d27a4402086d16
ac1d0a3https://github.com/python/cpython/pull/123352/commits/ac1d0a3049dfbe80366fdeaf35d27a4402086d16
https://github.com/encukou
Instantiate the layout and take _align_ from ithttps://github.com/python/cpython/pull/123352/commits/b35a97ca9b6c9df6a205bdfb7800f536f5d7c0ca
b35a97chttps://github.com/python/cpython/pull/123352/commits/b35a97ca9b6c9df6a205bdfb7800f536f5d7c0ca
https://github.com/encukou
Get base size and align; etc.https://github.com/python/cpython/pull/123352/commits/2cc8b40c85cfe1e6fbc3221d2b70df776b27180c
2cc8b40https://github.com/python/cpython/pull/123352/commits/2cc8b40c85cfe1e6fbc3221d2b70df776b27180c
https://github.com/encukou
Sorta start creating CField objectshttps://github.com/python/cpython/pull/123352/commits/a9fd94ae8290a41d8a1d7a6adfd9e1b098f0db22
a9fd94ahttps://github.com/python/cpython/pull/123352/commits/a9fd94ae8290a41d8a1d7a6adfd9e1b098f0db22
https://github.com/encukou
Turn constructor into initializerhttps://github.com/python/cpython/pull/123352/commits/c4d3c662cac35a27c6e74e8849d9139ce778e53c
c4d3c66https://github.com/python/cpython/pull/123352/commits/c4d3c662cac35a27c6e74e8849d9139ce778e53c
https://github.com/encukou
Use goto for error handlinghttps://github.com/python/cpython/pull/123352/commits/cbb308166111a4505b4134d301e9408fea6e1a8f
cbb3081https://github.com/python/cpython/pull/123352/commits/cbb308166111a4505b4134d301e9408fea6e1a8f
https://github.com/encukou
Handle Py_DECREF(prop) in the error blockhttps://github.com/python/cpython/pull/123352/commits/1adb23a49b31140a32907eda6fcf967a721e3742
1adb23ahttps://github.com/python/cpython/pull/123352/commits/1adb23a49b31140a32907eda6fcf967a721e3742
https://github.com/encukou
Pass bit_size and name to CFieldhttps://github.com/python/cpython/pull/123352/commits/01ee4f89989ea044415038a93411391d2a3a4d6d
01ee4f8https://github.com/python/cpython/pull/123352/commits/01ee4f89989ea044415038a93411391d2a3a4d6d
https://github.com/encukou
Use name from prophttps://github.com/python/cpython/pull/123352/commits/eb7666cc096f962b5908dbc9447d6e4f8fbf3159
eb7666chttps://github.com/python/cpython/pull/123352/commits/eb7666cc096f962b5908dbc9447d6e4f8fbf3159
https://github.com/encukou
Use desc from prophttps://github.com/python/cpython/pull/123352/commits/be6113ff26286b65633c01ddafa320ccf2fb8a44
be6113fhttps://github.com/python/cpython/pull/123352/commits/be6113ff26286b65633c01ddafa320ccf2fb8a44
https://github.com/encukou
Use bit_size from prop; avoid pairhttps://github.com/python/cpython/pull/123352/commits/a7f05f92768a5c171ae099630d52f308f89c36de
a7f05f9https://github.com/python/cpython/pull/123352/commits/a7f05f92768a5c171ae099630d52f308f89c36de
https://github.com/encukou
Pass None for undefined bit_size, not -1https://github.com/python/cpython/pull/123352/commits/ef24a0c8a409a44f3edd78f68bf2f0088961ac01
ef24a0chttps://github.com/python/cpython/pull/123352/commits/ef24a0c8a409a44f3edd78f68bf2f0088961ac01
https://github.com/encukou
Fix a refleakhttps://github.com/python/cpython/pull/123352/commits/728ec0a6db208be91b3c47aa87a374ab245ae121
728ec0ahttps://github.com/python/cpython/pull/123352/commits/728ec0a6db208be91b3c47aa87a374ab245ae121
https://github.com/encukou
Move bitsize check to CField initializerhttps://github.com/python/cpython/pull/123352/commits/5ef81b3560c005b158de3b6cf2f6ca132109a04b
5ef81b3https://github.com/python/cpython/pull/123352/commits/5ef81b3560c005b158de3b6cf2f6ca132109a04b
https://github.com/encukou
desc is protohttps://github.com/python/cpython/pull/123352/commits/16c2d775508ba1c37748a5cd024ecfb6b56c6551
16c2d77https://github.com/python/cpython/pull/123352/commits/16c2d775508ba1c37748a5cd024ecfb6b56c6551
https://github.com/encukou
Remove the unused TYPEFLAG_HASBITFIELD and TYPEFLAG_HASUNIONhttps://github.com/python/cpython/pull/123352/commits/14fd92d860938d3cd2405223a7be16292431a6ec
14fd92dhttps://github.com/python/cpython/pull/123352/commits/14fd92d860938d3cd2405223a7be16292431a6ec
https://github.com/encukou
Use -1 for "not is_bitfield"https://github.com/python/cpython/pull/123352/commits/e3337c23b5bb18eddc2042c0a169722a40a0288f
e3337c2https://github.com/python/cpython/pull/123352/commits/e3337c23b5bb18eddc2042c0a169722a40a0288f
https://github.com/encukou
Handle _swappedbytes_ in Pythonhttps://github.com/python/cpython/pull/123352/commits/f3c678d19d482c1238b4c7d14c811970af0927ca
f3c678dhttps://github.com/python/cpython/pull/123352/commits/f3c678d19d482c1238b4c7d14c811970af0927ca
https://github.com/encukou
Put layout mode in the fieldhttps://github.com/python/cpython/pull/123352/commits/0c47fa24983304747c07b14a283d0244c21e8ba9
0c47fa2https://github.com/python/cpython/pull/123352/commits/0c47fa24983304747c07b14a283d0244c21e8ba9
https://github.com/encukou
error handlinghttps://github.com/python/cpython/pull/123352/commits/2eefab13a7772d6f7063155c3f1e85d9c5628e81
2eefab1https://github.com/python/cpython/pull/123352/commits/2eefab13a7772d6f7063155c3f1e85d9c5628e81
https://github.com/encukou
Take out is_bitfield arghttps://github.com/python/cpython/pull/123352/commits/5b1723c1b4520335147a033f62f58a1ec1581a4f
5b1723chttps://github.com/python/cpython/pull/123352/commits/5b1723c1b4520335147a033f62f58a1ec1581a4f
https://github.com/encukou
Keep _pack_ on the fieldhttps://github.com/python/cpython/pull/123352/commits/9507752540704990e20837092c320e0000252426
9507752https://github.com/python/cpython/pull/123352/commits/9507752540704990e20837092c320e0000252426
https://github.com/encukou
Stick the index in the structhttps://github.com/python/cpython/pull/123352/commits/dc859c34784664d6256494edd00ba8aad5afe92f
dc859c3https://github.com/python/cpython/pull/123352/commits/dc859c34784664d6256494edd00ba8aad5afe92f
https://github.com/encukou
Add packstate struct, with pfield_sizehttps://github.com/python/cpython/pull/123352/commits/beeab0b0fb45d92539fbadd28fe1b0a52843065e
beeab0bhttps://github.com/python/cpython/pull/123352/commits/beeab0b0fb45d92539fbadd28fe1b0a52843065e
https://github.com/encukou
Put pbitoffs in the statehttps://github.com/python/cpython/pull/123352/commits/accb589cc48988ba1dc7655b083496b36949f076
accb589https://github.com/python/cpython/pull/123352/commits/accb589cc48988ba1dc7655b083496b36949f076
https://github.com/encukou
Put the size in the statehttps://github.com/python/cpython/pull/123352/commits/71fbfb8b3aa8d7001b9b99769064817effbc6d37
71fbfb8https://github.com/python/cpython/pull/123352/commits/71fbfb8b3aa8d7001b9b99769064817effbc6d37
https://github.com/encukou
Add offset to the statehttps://github.com/python/cpython/pull/123352/commits/9c6e3b0f82510ba17f78f81ed36fe04135a8a883
9c6e3b0https://github.com/python/cpython/pull/123352/commits/9c6e3b0f82510ba17f78f81ed36fe04135a8a883
https://github.com/encukou
Put align in the statehttps://github.com/python/cpython/pull/123352/commits/a6f8fdcae806b004703a08b3d3948b1f155b844a
a6f8fdchttps://github.com/python/cpython/pull/123352/commits/a6f8fdcae806b004703a08b3d3948b1f155b844a
https://github.com/encukou
Move getfunc/setfunc to __new__https://github.com/python/cpython/pull/123352/commits/6803815c2db66c5541e60c7630bfdd528846dfae
6803815https://github.com/python/cpython/pull/123352/commits/6803815c2db66c5541e60c7630bfdd528846dfae
https://github.com/encukou
Start verifying the internal pack statehttps://github.com/python/cpython/pull/123352/commits/e0fc0afaa3d6d731d63014dc953ce02b21343a84
e0fc0afhttps://github.com/python/cpython/pull/123352/commits/e0fc0afaa3d6d731d63014dc953ce02b21343a84
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 27, 2024https://github.com/python/cpython/pull/123352#event-14030244448
https://github.com/picnixz
picnixzhttps://github.com/picnixz
August 27, 2024 15:13https://github.com/python/cpython/pull/123352#event-14030684116
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Aug 27, 2024 https://github.com/python/cpython/pull/123352#pullrequestreview-2263769011
View reviewed changes https://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1
picnixzhttps://github.com/picnixz
Please reload this pagehttps://github.com/python/cpython/pull/123352
https://github.com/python/cpython/pull/123352#pullrequestreview-2263769011
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/cfield.chttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/cfield.chttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/cfield.chttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/stgdict.chttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-a75c1edda81c7e4ede83ebbd84c2638023c1b91de15b504f574ba7e08b8b0883
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/stgdict.chttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-a75c1edda81c7e4ede83ebbd84c2638023c1b91de15b504f574ba7e08b8b0883
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/stgdict.chttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-a75c1edda81c7e4ede83ebbd84c2638023c1b91de15b504f574ba7e08b8b0883
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/stgdict.chttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-a75c1edda81c7e4ede83ebbd84c2638023c1b91de15b504f574ba7e08b8b0883
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/stgdict.chttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-a75c1edda81c7e4ede83ebbd84c2638023c1b91de15b504f574ba7e08b8b0883
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/stgdict.chttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-a75c1edda81c7e4ede83ebbd84c2638023c1b91de15b504f574ba7e08b8b0883
Please reload this pagehttps://github.com/python/cpython/pull/123352
https://github.com/picnixz
picnixzhttps://github.com/picnixz
August 27, 2024 15:50https://github.com/python/cpython/pull/123352#event-14031291974
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Aug 27, 2024 https://github.com/python/cpython/pull/123352#pullrequestreview-2263836790
View reviewed changes https://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1
picnixzhttps://github.com/picnixz
https://github.com/python/cpython/pull/123352#pullrequestreview-2263836790
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/test/test_ctypes/test_bitfields.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-c7e816339c51e08db1e9e20af20c515dad11b1d60656a61d8b1590c900974834
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/test/test_ctypes/test_bitfields.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-c7e816339c51e08db1e9e20af20c515dad11b1d60656a61d8b1590c900974834
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
encukouhttps://github.com/encukou
August 28, 2024 15:56https://github.com/python/cpython/pull/123352#commits-pushed-ff4bcf5
https://github.com/encukou
https://github.com/picnixz
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/123352/commits/ff4bcf5e000e4ecba946cae3633cf2c80f275a71
ff4bcf5https://github.com/python/cpython/pull/123352/commits/ff4bcf5e000e4ecba946cae3633cf2c80f275a71
https://github.com/encukou
Move bit_size checks to assertions; they're checked in Pythonhttps://github.com/python/cpython/pull/123352/commits/6b9a8b70b50afed855abb006041e90c215cdbb75
6b9a8b7https://github.com/python/cpython/pull/123352/commits/6b9a8b70b50afed855abb006041e90c215cdbb75
https://github.com/encukou
Move i declaration to for loopshttps://github.com/python/cpython/pull/123352/commits/991bab3e70152b483c6aeac29b0f6824420ab09e
991bab3https://github.com/python/cpython/pull/123352/commits/991bab3e70152b483c6aeac29b0f6824420ab09e
https://github.com/encukou
Remove a clearly unneeded asserthttps://github.com/python/cpython/pull/123352/commits/298c8225a0aca6969c172678011a3021c06c4338
298c822https://github.com/python/cpython/pull/123352/commits/298c8225a0aca6969c172678011a3021c06c4338
https://github.com/encukou
Add rudimentary test for bitfields in Unionhttps://github.com/python/cpython/pull/123352/commits/3088e5db24d84916175ddcb5eca590dbc2a1d2ac
3088e5dhttps://github.com/python/cpython/pull/123352/commits/3088e5db24d84916175ddcb5eca590dbc2a1d2ac
https://github.com/encukou
Improve error message for _field_ element unpackinghttps://github.com/python/cpython/pull/123352/commits/511e25d5ac91ddf9ff586d7fa6f6111710ce5c95
511e25dhttps://github.com/python/cpython/pull/123352/commits/511e25d5ac91ddf9ff586d7fa6f6111710ce5c95
https://github.com/encukou
encukouhttps://github.com/encukou
Aug 28, 2024 https://github.com/python/cpython/pull/123352#pullrequestreview-2266194327
View reviewed changes https://github.com/python/cpython/pull/123352/files/ff4bcf5e000e4ecba946cae3633cf2c80f275a71
encukouhttps://github.com/encukou
https://github.com/python/cpython/pull/123352#pullrequestreview-2266194327
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/cfield.chttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/stgdict.chttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-a75c1edda81c7e4ede83ebbd84c2638023c1b91de15b504f574ba7e08b8b0883
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/stgdict.chttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-a75c1edda81c7e4ede83ebbd84c2638023c1b91de15b504f574ba7e08b8b0883
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/stgdict.chttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-a75c1edda81c7e4ede83ebbd84c2638023c1b91de15b504f574ba7e08b8b0883
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/stgdict.chttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-a75c1edda81c7e4ede83ebbd84c2638023c1b91de15b504f574ba7e08b8b0883
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
https://github.com/picnixz
picnixzhttps://github.com/picnixz
August 28, 2024 15:32https://github.com/python/cpython/pull/123352#event-14049169344
https://github.com/encukou
Use correct length modifierhttps://github.com/python/cpython/pull/123352/commits/0689e59d21c47cf9d5b34eba160a01a0aa3be02e
0689e59https://github.com/python/cpython/pull/123352/commits/0689e59d21c47cf9d5b34eba160a01a0aa3be02e
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Aug 28, 2024 https://github.com/python/cpython/pull/123352#pullrequestreview-2266636618
View reviewed changes https://github.com/python/cpython/pull/123352/files/511e25d5ac91ddf9ff586d7fa6f6111710ce5c95
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/511e25d5ac91ddf9ff586d7fa6f6111710ce5c95#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/ctypes/_layout.pyhttps://github.com/python/cpython/pull/123352/files/511e25d5ac91ddf9ff586d7fa6f6111710ce5c95#diff-9cda20d6f1c0d900e6cec9c95a7d81fd6aed75854342a03ca7aab8e3c2787d56
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/cfield.chttps://github.com/python/cpython/pull/123352/files/511e25d5ac91ddf9ff586d7fa6f6111710ce5c95#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1
Please reload this pagehttps://github.com/python/cpython/pull/123352
Modules/_ctypes/cfield.chttps://github.com/python/cpython/pull/123352/files/511e25d5ac91ddf9ff586d7fa6f6111710ce5c95#diff-2952ec5c776412a52a7a69a6cf735e480d7454e3862d2b8e02f34c927f600aa1
Please reload this pagehttps://github.com/python/cpython/pull/123352
Lib/test/test_ctypes/test_bitfields.pyhttps://github.com/python/cpython/pull/123352/files/49214079a0a711272676ad599aca1aa1b15c6fc1#diff-c7e816339c51e08db1e9e20af20c515dad11b1d60656a61d8b1590c900974834
Please reload this pagehttps://github.com/python/cpython/pull/123352
encukouhttps://github.com/encukou
August 28, 2024 18:00https://github.com/python/cpython/pull/123352#commits-pushed-a7c3724
https://github.com/encukou
Avoid a case where MSC and GCC's __attribute__((ms_struct)) disagreehttps://github.com/python/cpython/pull/123352/commits/a7c3724f02b032cce97c7470687e1dcabbe32c52
a7c3724https://github.com/python/cpython/pull/123352/commits/a7c3724f02b032cce97c7470687e1dcabbe32c52
https://github.com/encukou
Adjust Windows assertionshttps://github.com/python/cpython/pull/123352/commits/bd53c2888012797be8164d96e83f813b88491129
bd53c28https://github.com/python/cpython/pull/123352/commits/bd53c2888012797be8164d96e83f813b88491129
https://github.com/encukou
https://github.com/picnixz
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/123352/commits/b387d30953b6fef68b9a32cb04c7f1a5b8a10ca5
b387d30https://github.com/python/cpython/pull/123352/commits/b387d30953b6fef68b9a32cb04c7f1a5b8a10ca5
https://github.com/encukou
Remove unused last_fieldhttps://github.com/python/cpython/pull/123352/commits/9cf18cdcca0475c176fcb7b7369bc411e9ce25f5
9cf18cdhttps://github.com/python/cpython/pull/123352/commits/9cf18cdcca0475c176fcb7b7369bc411e9ce25f5
https://github.com/encukou
Remove the bitfield-in-union test, for nowhttps://github.com/python/cpython/pull/123352/commits/96a5c0d6caac06975b6700304b8f3a43cf4fc874
96a5c0dhttps://github.com/python/cpython/pull/123352/commits/96a5c0d6caac06975b6700304b8f3a43cf4fc874
https://github.com/encukou
encukouhttps://github.com/encukou
Sep 2, 2024https://github.com/python/cpython/pull/123352#issuecomment-2324996638
Please reload this pagehttps://github.com/python/cpython/pull/123352
Please reload this pagehttps://github.com/python/cpython/pull/123352
https://github.com/encukou
encukouhttps://github.com/encukou
Sep 4, 2024https://github.com/python/cpython/pull/123352#issuecomment-2328909330
Please reload this pagehttps://github.com/python/cpython/pull/123352
Please reload this pagehttps://github.com/python/cpython/pull/123352
https://github.com/encukou
encukouhttps://github.com/encukou
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Sep 4, 2024https://github.com/python/cpython/pull/123352#event-14130345839
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 4, 2024https://github.com/python/cpython/pull/123352#issuecomment-2328912264
@encukouhttps://github.com/encukou
96a5c0dhttps://github.com/python/cpython/commit/96a5c0d6caac06975b6700304b8f3a43cf4fc874
Please reload this pagehttps://github.com/python/cpython/pull/123352
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Sep 4, 2024https://github.com/python/cpython/pull/123352#event-14130346580
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 4, 2024https://github.com/python/cpython/pull/123352#issuecomment-2328979189
Please reload this pagehttps://github.com/python/cpython/pull/123352
https://github.com/encukou
encukouhttps://github.com/encukou
ce9f84ahttps://github.com/python/cpython/commit/ce9f84a47bfbafedd09a25d0f6f0c8209550fb6c
Sep 5, 2024https://github.com/python/cpython/pull/123352#event-14143531829
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 5, 2024https://github.com/python/cpython/pull/123352#event-14143532438
https://github.com/encukou
encukouhttps://github.com/encukou
September 5, 2024 09:20https://github.com/python/cpython/pull/123352#event-14143533030
https://github.com/brianschubert
brianschuberthttps://github.com/brianschubert
Nov 17, 2024 https://github.com/python/cpython/pull/123352#ref-issue-2666523198
Struct fields with size > 65535 bytes throw TypeError #126937 https://github.com/python/cpython/issues/126937
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F123352
https://github.com/picnixz
picnixz https://github.com/picnixz
https://github.com/python/cpython/pull/123352/files/511e25d5ac91ddf9ff586d7fa6f6111710ce5c95
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/123352
https://github.com/encukou
https://github.com/bedevere-bot
https://github.com/picnixz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.