René's URL Explorer Experiment


Title: GH-123040: Specialize shadowed `LOAD_ATTR`. by markshannon · Pull Request #123219 · python/cpython · GitHub

Open Graph Title: GH-123040: Specialize shadowed `LOAD_ATTR`. by markshannon · Pull Request #123219 · python/cpython

X Title: GH-123040: Specialize shadowed `LOAD_ATTR`. by markshannon · Pull Request #123219 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This PR specializes LOAD_ATTR for shadowed attributes, where the shadowing doesn't change the attribute. Stats show a 30% reduction in specialization failures for LOAD_ATTR. Performance might s...

X Description: This PR specializes LOAD_ATTR for shadowed attributes, where the shadowing doesn't change the attribute. Stats show a 30% reduction in specialization failures for LOAD_ATTR. Performance mig...

Opengraph URL: https://github.com/python/cpython/pull/123219

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f7983847-3f84-87fd-61d8-e2b7df1b41e2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCAF0:323A96:5EAC1D:89F92F:6A4E0E28
html-safe-nonce235bcd5f648aee60c64a6b571903371dbf65883a49469c3eb3b99bcf287cf1e6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUYwOjMyM0E5Njo1RUFDMUQ6ODlGOTJGOjZBNEUwRTI4IiwidmlzaXRvcl9pZCI6IjcxNDQ4ODExNTYxNDMzMjA2MTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac56131f5820d0e5505cdf1876d566fc9eba727eee94855acec0be8d3d293d2fca
hovercard-subject-tagpull_request:2031636041
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/123219/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/499b5321ffb40b08908114437d44a1dd086cac12fa5d26c5bf831575c2a98233/python/cpython/pull/123219
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/499b5321ffb40b08908114437d44a1dd086cac12fa5d26c5bf831575c2a98233/python/cpython/pull/123219
og:image:altThis PR specializes LOAD_ATTR for shadowed attributes, where the shadowing doesn't change the attribute. Stats show a 30% reduction in specialization failures for LOAD_ATTR. Performance might s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemarkshannon
hostnamegithub.com
expected-hostnamegithub.com
Nonedf0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release51470c353b8a1f52a88d3e3cc2014b17ab8cc1ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/123219#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F123219
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F123219
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/123219
Reloadhttps://github.com/python/cpython/pull/123219
Reloadhttps://github.com/python/cpython/pull/123219
Please reload this pagehttps://github.com/python/cpython/pull/123219
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/123219
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
markshannonhttps://github.com/markshannon
python:mainhttps://github.com/python/cpython/tree/main
faster-cpython:specialize-shadowed-load-attrhttps://github.com/faster-cpython/cpython/tree/specialize-shadowed-load-attr
Conversationhttps://github.com/python/cpython/pull/123219
Commits12 (12)https://github.com/python/cpython/pull/123219/commits
Checkshttps://github.com/python/cpython/pull/123219/checks
Files changedhttps://github.com/python/cpython/pull/123219/files
GH-123040: Specialize shadowed LOAD_ATTR.https://github.com/python/cpython/pull/123219#top
markshannonhttps://github.com/markshannon
python:mainhttps://github.com/python/cpython/tree/main
faster-cpython:specialize-shadowed-load-attrhttps://github.com/faster-cpython/cpython/tree/specialize-shadowed-load-attr
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Aug 22, 2024https://github.com/python/cpython/pull/123219#issue-2480213028
Please reload this pagehttps://github.com/python/cpython/pull/123219
Statshttps://github.com/faster-cpython/benchmarking-public/blob/main/results/bm-20240821-3.14.0a0-975089f/bm-20240821-azure-x86_64-faster%252dcpython-specialize_shadowed_-3.14.0a0-975089f-pystats-vs-base.md
Performancehttps://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20240821-3.14.0a0-975089f
Unnecessary specialization failures of LOAD_ATTR and STORE_ATTR when attributes are shadowed by the object's class. #123040https://github.com/python/cpython/issues/123040
Please reload this pagehttps://github.com/python/cpython/pull/123219
markshannonhttps://github.com/markshannon
August 16, 2024 15:15https://github.com/python/cpython/pull/123219#commits-pushed-5e4c3d3
https://github.com/markshannon
Specialize LOAD_ATTR for instance values, even when shadowing class a…https://github.com/python/cpython/pull/123219/commits/5e4c3d3a70d94c54f2b5626b35f4d9780aee2a86
5e4c3d3https://github.com/python/cpython/pull/123219/commits/5e4c3d3a70d94c54f2b5626b35f4d9780aee2a86
https://github.com/markshannon
Don't count as shadowed unless optimization failshttps://github.com/python/cpython/pull/123219/commits/a983591215d42f846521d8ff8c8ad88ecf57b028
a983591https://github.com/python/cpython/pull/123219/commits/a983591215d42f846521d8ff8c8ad88ecf57b028
https://github.com/markshannon
Add LOAD_ATTR_CLASS_WITH_METACLASS_CHECK specialization and handle cl…https://github.com/python/cpython/pull/123219/commits/c0b471104d40470d4039574abdf30fa4ed565745
c0b4711https://github.com/python/cpython/pull/123219/commits/c0b471104d40470d4039574abdf30fa4ed565745
https://github.com/markshannon
Merge branch 'main' into specialize-shadowed-load-attrhttps://github.com/python/cpython/pull/123219/commits/5dfc5299953e85145f5a02379023ef0b55eb7a8c
5dfc529https://github.com/python/cpython/pull/123219/commits/5dfc5299953e85145f5a02379023ef0b55eb7a8c
https://github.com/markshannon
Merge branch 'specialize-load-attr-class-shadowed' into specialize-sh…https://github.com/python/cpython/pull/123219/commits/b0f4953c078c387e30a76993b53f8c6a288b8ad5
b0f4953https://github.com/python/cpython/pull/123219/commits/b0f4953c078c387e30a76993b53f8c6a288b8ad5
https://github.com/markshannon
Differentiate between split keys and non-string keys in statshttps://github.com/python/cpython/pull/123219/commits/6f4843a44111f3b04f137d7bfc1380837070df54
6f4843ahttps://github.com/python/cpython/pull/123219/commits/6f4843a44111f3b04f137d7bfc1380837070df54
https://github.com/markshannon
Merge branch 'main' into specialize-shadowed-load-attrhttps://github.com/python/cpython/pull/123219/commits/02137b30a615915ea3664b636d6ce60fbcc27d3b
02137b3https://github.com/python/cpython/pull/123219/commits/02137b30a615915ea3664b636d6ce60fbcc27d3b
https://github.com/markshannon
Reorganize codehttps://github.com/python/cpython/pull/123219/commits/ba7b63c2aec5a721ba9c33cd14862756d4fb12b5
ba7b63chttps://github.com/python/cpython/pull/123219/commits/ba7b63c2aec5a721ba9c33cd14862756d4fb12b5
https://github.com/markshannon
Merge branch 'main' into specialize-shadowed-load-attrhttps://github.com/python/cpython/pull/123219/commits/975089fe78955672bb89cadb20940dfbf56df80a
975089fhttps://github.com/python/cpython/pull/123219/commits/975089fe78955672bb89cadb20940dfbf56df80a
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Aug 22, 2024 https://github.com/python/cpython/pull/123219#ref-issue-2468488242
Unnecessary specialization failures of LOAD_ATTR and STORE_ATTR when attributes are shadowed by the object's class. #123040 https://github.com/python/cpython/issues/123040
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 22, 2024https://github.com/python/cpython/pull/123219#event-13973692880
https://github.com/markshannon
markshannonhttps://github.com/markshannon
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Aug 22, 2024https://github.com/python/cpython/pull/123219#event-13973697854
https://github.com/markshannon
Make function statichttps://github.com/python/cpython/pull/123219/commits/b7dbcc8bc87c775d0fddb8985b2361e013797d9c
b7dbcc8https://github.com/python/cpython/pull/123219/commits/b7dbcc8bc87c775d0fddb8985b2361e013797d9c
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Aug 22, 2024 https://github.com/python/cpython/pull/123219#pullrequestreview-2254235927
View reviewed changes https://github.com/python/cpython/pull/123219/files/975089fe78955672bb89cadb20940dfbf56df80a
iritkatrielhttps://github.com/iritkatriel
https://github.com/python/cpython/pull/123219#pullrequestreview-2254235927
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Statshttps://github.com/faster-cpython/benchmarking-public/blob/main/results/bm-20240821-3.14.0a0-975089f/bm-20240821-azure-x86_64-faster%252dcpython-specialize_shadowed_-3.14.0a0-975089f-pystats-vs-base.md
Performancehttps://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20240821-3.14.0a0-975089f
Please reload this pagehttps://github.com/python/cpython/pull/123219
Python/specialize.chttps://github.com/python/cpython/pull/123219/files/975089fe78955672bb89cadb20940dfbf56df80a#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
Please reload this pagehttps://github.com/python/cpython/pull/123219
Python/specialize.chttps://github.com/python/cpython/pull/123219/files/975089fe78955672bb89cadb20940dfbf56df80a#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
Please reload this pagehttps://github.com/python/cpython/pull/123219
Python/specialize.chttps://github.com/python/cpython/pull/123219/files/975089fe78955672bb89cadb20940dfbf56df80a#diff-22e653d878778ca28317261f7826545288d02fd9980cf485d0329f28a34993f2
Please reload this pagehttps://github.com/python/cpython/pull/123219
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Aug 22, 2024https://github.com/python/cpython/pull/123219#issuecomment-2304661984
Please reload this pagehttps://github.com/python/cpython/pull/123219
Please reload this pagehttps://github.com/python/cpython/pull/123219
markshannonhttps://github.com/markshannon
August 22, 2024 14:27https://github.com/python/cpython/pull/123219#commits-pushed-4b37d6c
https://github.com/markshannon
Tidy logic in _Py_Specialize_LoadAttrhttps://github.com/python/cpython/pull/123219/commits/4b37d6cf959c2f38e040f2a06ea1cb3b6c0fb7ab
4b37d6chttps://github.com/python/cpython/pull/123219/commits/4b37d6cf959c2f38e040f2a06ea1cb3b6c0fb7ab
https://github.com/markshannon
Fix compiler wanring and clarify commenthttps://github.com/python/cpython/pull/123219/commits/cc92e97639d66d7a6c9d66a65d710197c9a457b0
cc92e97https://github.com/python/cpython/pull/123219/commits/cc92e97639d66d7a6c9d66a65d710197c9a457b0
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Aug 22, 2024https://github.com/python/cpython/pull/123219#issuecomment-2304776328
@brandtbucherhttps://github.com/brandtbucher
@Fidget-Spinnerhttps://github.com/Fidget-Spinner
Please reload this pagehttps://github.com/python/cpython/pull/123219
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Aug 23, 2024 https://github.com/python/cpython/pull/123219#pullrequestreview-2256033814
View reviewed changes https://github.com/python/cpython/pull/123219/files/cc92e97639d66d7a6c9d66a65d710197c9a457b0
brandtbucherhttps://github.com/brandtbucher
https://github.com/python/cpython/pull/123219#pullrequestreview-2256033814
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/123219
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 23, 2024https://github.com/python/cpython/pull/123219#event-13986252039
https://github.com/markshannon
markshannonhttps://github.com/markshannon
5d3201fhttps://github.com/python/cpython/commit/5d3201fe3f76aeba33e9e5956ba80a116e422bd0
Aug 23, 2024https://github.com/python/cpython/pull/123219#event-13990604224
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Aug 23, 2024https://github.com/python/cpython/pull/123219#event-13990605015
https://github.com/markshannon
markshannonhttps://github.com/markshannon
August 23, 2024 09:48https://github.com/python/cpython/pull/123219#event-13990910797
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F123219
https://github.com/iritkatriel
iritkatriel https://github.com/iritkatriel
https://github.com/python/cpython/pull/123219/files/975089fe78955672bb89cadb20940dfbf56df80a
https://github.com/brandtbucher
brandtbucher https://github.com/brandtbucher
https://github.com/python/cpython/pull/123219/files/cc92e97639d66d7a6c9d66a65d710197c9a457b0
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/123219
https://github.com/markshannon
https://github.com/iritkatriel
https://github.com/brandtbucher
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.