René's URL Explorer Experiment


Title: gh-117578: Fix inlining regression in PyType_GetModuleByDef() by neonene · Pull Request #123100 · python/cpython · GitHub

Open Graph Title: gh-117578: Fix inlining regression in PyType_GetModuleByDef() by neonene · Pull Request #123100 · python/cpython

X Title: gh-117578: Fix inlining regression in PyType_GetModuleByDef() by neonene · Pull Request #123100 · python/cpython

Description: On main and 3.13, there are cases where the get_module_by_def function in typeobject.c is not inlined in its wrapper functions: Wrappers Windows callee: get_module_by_def() PyType_GetModuleB...

Open Graph Description: On main and 3.13, there are cases where the get_module_by_def function in typeobject.c is not inlined in its wrapper functions: Wrappers Windows callee: get_module_by_def() PyType_GetModuleB...

X Description: On main and 3.13, there are cases where the get_module_by_def function in typeobject.c is not inlined in its wrapper functions: Wrappers Windows callee: get_module_by_def() PyType_GetModuleB...

Opengraph URL: https://github.com/python/cpython/pull/123100

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:272c38db-f75f-ac3e-756e-cf4744ee7b0f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDA48:22F528:3FF228:5A49CE:696A202A
html-safe-nonce7ff80a91e466590fa176fed0cf87db5964c5a31f6dfa3f4f01e23fe64ea5a6d1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTQ4OjIyRjUyODozRkYyMjg6NUE0OUNFOjY5NkEyMDJBIiwidmlzaXRvcl9pZCI6IjU3NDg5MTI2NTM0NDYyOTE0OTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac370113f060a8eb7780f3f8e2cd05a0e32d67d3f5d50762e7dfe0d5204858a6ae
hovercard-subject-tagpull_request:2023993689
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/123100/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1428f49ac28e69e8e05447901504eab28057494a5d0f3ec2a8f299c4ea5b3337/python/cpython/pull/123100
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1428f49ac28e69e8e05447901504eab28057494a5d0f3ec2a8f299c4ea5b3337/python/cpython/pull/123100
og:image:altOn main and 3.13, there are cases where the get_module_by_def function in typeobject.c is not inlined in its wrapper functions: Wrappers Windows callee: get_module_by_def() PyType_GetModuleB...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameneonene
hostnamegithub.com
expected-hostnamegithub.com
None014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released515f6f09fa57a93bf90355cb894eb84ca4f458f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/123100#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F123100
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F123100
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/123100
Reloadhttps://github.com/python/cpython/pull/123100
Reloadhttps://github.com/python/cpython/pull/123100
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/123100
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/123100
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/123100#issue-comment-box
neonenehttps://github.com/neonene
python:mainhttps://github.com/python/cpython/tree/main
gh-117578: Fix inlining regression in PyType_GetModuleByDef() https://github.com/python/cpython/pull/123100#top
neonenehttps://github.com/neonene
python:mainhttps://github.com/python/cpython/tree/main
Conversation 6 https://github.com/python/cpython/pull/123100
Commits 4 https://github.com/python/cpython/pull/123100/commits
Checks 0 https://github.com/python/cpython/pull/123100/checks
Files changed https://github.com/python/cpython/pull/123100/files
Please reload this pagehttps://github.com/python/cpython/pull/123100
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/neonene
neonenehttps://github.com/neonene
Aug 17, 2024https://github.com/python/cpython/pull/123100#issue-2471489907
Please reload this pagehttps://github.com/python/cpython/pull/123100
@encukouhttps://github.com/encukou
PyType_GetModuleByDef family for binary functions performance #117578https://github.com/python/cpython/issues/117578
Please reload this pagehttps://github.com/python/cpython/pull/123100
https://github.com/neonene
add Py_ALWAYS_INLINEhttps://github.com/python/cpython/pull/123100/commits/01c332251186c0f2abb4a136010078b9e4626845
01c3322https://github.com/python/cpython/pull/123100/commits/01c332251186c0f2abb4a136010078b9e4626845
https://github.com/neonene
neonenehttps://github.com/neonene
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/ce4b9c8464706a58d0c98c2b0deeec07e7496ccc/.github/CODEOWNERS#L30
August 17, 2024 11:40https://github.com/python/cpython/pull/123100#event-13919673228
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Aug 17, 2024 https://github.com/python/cpython/pull/123100#ref-issue-2229162006
PyType_GetModuleByDef family for binary functions performance #117578 https://github.com/python/cpython/issues/117578
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Aug 17, 2024https://github.com/python/cpython/pull/123100#event-13919673375
https://github.com/neonene
neonenehttps://github.com/neonene
Aug 17, 2024https://github.com/python/cpython/pull/123100#event-13919855274
https://github.com/encukou
encukouhttps://github.com/encukou
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Aug 19, 2024https://github.com/python/cpython/pull/123100#event-13926511838
https://github.com/encukou
encukouhttps://github.com/encukou
Aug 19, 2024https://github.com/python/cpython/pull/123100#issuecomment-2296363755
Please reload this pagehttps://github.com/python/cpython/pull/123100
neonenehttps://github.com/neonene
August 20, 2024 19:18https://github.com/python/cpython/pull/123100#commits-pushed-f740a5d
https://github.com/neonene
benchmark setup: /Ob3, __declspec(noinline)https://github.com/python/cpython/pull/123100/commits/f740a5d2526de59fadf8aa4d0bc0089f7008ceeb
f740a5dhttps://github.com/python/cpython/pull/123100/commits/f740a5d2526de59fadf8aa4d0bc0089f7008ceeb
https://github.com/neonene
unsafe experiment: do not respect TLS accesshttps://github.com/python/cpython/pull/123100/commits/6e62c38ce334b1a04778097ff232bad08ae4a5e9
6e62c38https://github.com/python/cpython/pull/123100/commits/6e62c38ce334b1a04778097ff232bad08ae4a5e9
https://github.com/neonene
revert benchmark stuffhttps://github.com/python/cpython/pull/123100/commits/89754d7ff47259fc886c101f27033fd234dd3202
89754d7https://github.com/python/cpython/pull/123100/commits/89754d7ff47259fc886c101f27033fd234dd3202
https://github.com/neonene
neonenehttps://github.com/neonene
Aug 20, 2024https://github.com/python/cpython/pull/123100#issuecomment-2298566533
Please reload this pagehttps://github.com/python/cpython/pull/123100
the faster-cpython repohttps://github.com/faster-cpython/ideas/issues/692
telco testhttps://github.com/python/pyperformance/blob/main/pyperformance/data-files/benchmarks/bm_telco/run_benchmark.py
f740a5dhttps://github.com/python/cpython/commit/f740a5d2526de59fadf8aa4d0bc0089f7008ceeb
#103324 (comment)https://github.com/python/cpython/pull/103324#issuecomment-1522399740
respect alternativehttps://github.com/python/cpython/pull/115401/files
(experiment)https://github.com/python/cpython/pull/123100/commits/6e62c38ce334b1a04778097ff232bad08ae4a5e9
example patcheshttps://github.com/python/cpython/issues/119663#issuecomment-2150763226
taken from 3.12https://github.com/python/cpython/blob/3.12/Modules/_decimal/_decimal.c
Please reload this pagehttps://github.com/python/cpython/pull/123100
https://github.com/neonene
neonenehttps://github.com/neonene
Aug 20, 2024https://github.com/python/cpython/pull/123100#issuecomment-2299890437
Please reload this pagehttps://github.com/python/cpython/pull/123100
https://github.com/neonene
neonenehttps://github.com/neonene
Aug 21, 2024https://github.com/python/cpython/pull/123100#issuecomment-2301643675
Please reload this pagehttps://github.com/python/cpython/pull/123100
Please reload this pagehttps://github.com/python/cpython/pull/123100
https://github.com/neonene
neonenehttps://github.com/neonene
Aug 21, 2024https://github.com/python/cpython/pull/123100#issuecomment-2303316132
Please reload this pagehttps://github.com/python/cpython/pull/123100
https://github.com/neonene
neonenehttps://github.com/neonene
Aug 26, 2024https://github.com/python/cpython/pull/123100#issuecomment-2309201074
PyType_GetBaseByToken()https://github.com/python/cpython/pull/121079/files#diff-071237c57ffb81dd4303eb5f02e5c5a661891a31c746c8f55a97a39659ad95d6
Please reload this pagehttps://github.com/python/cpython/pull/123100
https://github.com/neonene
neonenehttps://github.com/neonene
Aug 26, 2024https://github.com/python/cpython/pull/123100#event-14006777805
https://github.com/neonene
neonenehttps://github.com/neonene
September 20, 2024 03:42https://github.com/python/cpython/pull/123100#event-14333521313
https://github.com/neonene
neonenehttps://github.com/neonene
Sep 27, 2024 https://github.com/python/cpython/pull/123100#ref-pullrequest-2553460216
gh-124688: _decimal: Get a module state from ctx objects for performance #124691 https://github.com/python/cpython/pull/124691
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F123100
https://github.com/markshannon
markshannon https://github.com/markshannon
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/123100
https://github.com/neonene
https://github.com/encukou
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.