| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:54fb4beb-86c3-15fc-492f-b61effc74a26 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8B86:26ECEB:42E5CCC:54F5AFC:6B0215A8 |
| html-safe-nonce | a8622ccdb20e1788df6f9d78a940619bb796d761467f68e7271bdc51146f7693 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Qjg2OjI2RUNFQjo0MkU1Q0NDOjU0RjVBRkM6NkIwMjE1QTgiLCJ2aXNpdG9yX2lkIjoiMjg3MDAxOTMwMjE0NzM2NDI2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6f776ad75ae1ec6c5540a493c6cf31a15f8c5832d0729a97a99409a413df6021 |
| hovercard-subject-tag | pull_request:2013800993 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/122902/files |
| twitter:image | https://avatars.githubusercontent.com/u/1430751?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1430751?s=400&v=4 |
| og:image:alt | Change to find_max_char to speedup string creation.
See issue #122901.
Issue: gh-122901 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/122902/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122902%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122902%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/122902/files |
| Reload | https://github.com/python/cpython/pull/122902/files |
| Reload | https://github.com/python/cpython/pull/122902/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| StanFromIreland | https://github.com/StanFromIreland |
| python:main | https://github.com/python/cpython/tree/main |
| ruema:feature/speedup_find_max_char | https://github.com/ruema/cpython/tree/feature/speedup_find_max_char |
|
Conversation
52
| https://github.com/python/cpython/pull/122902 |
|
Commits
16
| https://github.com/python/cpython/pull/122902/commits |
|
Checks
54
| https://github.com/python/cpython/pull/122902/checks |
|
Files changed
| https://github.com/python/cpython/pull/122902/files |
| Please reload this page | https://github.com/python/cpython/pull/122902/files |
|
gh-122901: Speed up str creation from non-ASCII data with a branch-free find_max_char()
| https://github.com/python/cpython/pull/122902/files#top |
|
Show all changes
16 commits
| https://github.com/python/cpython/pull/122902/files |
|
b0f8321
Improve performance of find_max_char
ruema Aug 11, 2024
| https://github.com/python/cpython/pull/122902/commits/b0f832188ddd578ed7f492bd72c1f19903cbfc55 |
|
a43c1fc
missing ) added
ruema Aug 11, 2024
| https://github.com/python/cpython/pull/122902/commits/a43c1fc69953e2606b9e6aeb2b289a32dd282630 |
|
d597175
bugfix for unaligned short strings.
ruema Aug 11, 2024
| https://github.com/python/cpython/pull/122902/commits/d597175261366d38546cc8010fd76f3f2a74d32b |
|
4a8b4d1
Merge branch 'main' into feature/speedup_find_max_char
StanFromIreland Oct 30, 2026
| https://github.com/python/cpython/pull/122902/commits/4a8b4d1bcf45545d67e6deb33435c407129cbaa5 |
|
fe362fe
Re-write and move the news entry
StanFromIreland Oct 30, 2026
| https://github.com/python/cpython/pull/122902/commits/fe362fe54236e3e0696ca4ef327be787d0424bbb |
|
1650b4b
Fix alignment prologue to actually align the pointer (+ some PEP 7 nits)
StanFromIreland Oct 30, 2026
| https://github.com/python/cpython/pull/122902/commits/1650b4b2914b2b805e07d55576f830592f8f3f6a |
|
f524f84
Little nits
StanFromIreland Oct 30, 2026
| https://github.com/python/cpython/pull/122902/commits/f524f84c4650094dc34b217bbaaabf00bb0171ec |
|
1daa7ee
Use four accumulators and a 16-word block so the loop is fast when no…
StanFromIreland Oct 30, 2026
| https://github.com/python/cpython/pull/122902/commits/1daa7ee9cd0c46f37a82997ff367c1f6389badf6 |
|
c0f99d1
Load words with `memcpy` and finish with one overlapping read
StanFromIreland Oct 31, 2026
| https://github.com/python/cpython/pull/122902/commits/c0f99d1efd23470fa685e7d8007b84ab5e2b2ec4 |
|
c14a157
Bénédikt's review suggestions
StanFromIreland Oct 31, 2026
| https://github.com/python/cpython/pull/122902/commits/c14a157ded1c70a5fb327932d2399a16a1e112c7 |
|
0d6bed1
Style nit.
StanFromIreland Nov 6, 2026
| https://github.com/python/cpython/pull/122902/commits/0d6bed1aef449be68933da38ab7d615f26913681 |
|
03dd976
Align the pointer first and use plain word loads in the loops
StanFromIreland Nov 6, 2026
| https://github.com/python/cpython/pull/122902/commits/03dd976dfffcf75962eac9ab4eb504ad9852866e |
|
ce16f35
Read the short tail from the buffer start
StanFromIreland Nov 6, 2026
| https://github.com/python/cpython/pull/122902/commits/ce16f352a85bc67b685965aaa0f6d617441f7c13 |
|
864423a
Apply Victor's suggestions
StanFromIreland Nov 7, 2026
| https://github.com/python/cpython/pull/122902/commits/864423a77b8e9abb8febe37539b9f9c33eafe699 |
|
ca3ce0c
Test blocks before folding into the acc
StanFromIreland Nov 8, 2026
| https://github.com/python/cpython/pull/122902/commits/ca3ce0c1c64d8b905563236410205159fef638d8 |
|
0803510
Use `for` loop instead
StanFromIreland Nov 8, 2026
| https://github.com/python/cpython/pull/122902/commits/08035102f82675f1622ab2b3b550eeff32be5f13 |
|
Clear filters
| https://github.com/python/cpython/pull/122902/files |
| Please reload this page | https://github.com/python/cpython/pull/122902/files |
| Please reload this page | https://github.com/python/cpython/pull/122902/files |
|
2024-08-11-12-06-23.gh-issue-122901.B2Huom.rst
| https://github.com/python/cpython/pull/122902/files#diff-864c9f1862ec88ae55a46740c8076873b32ee0d5f4d4762353246bcb33c6c7a7 |
|
find_max_char.h
| https://github.com/python/cpython/pull/122902/files#diff-8956a8f467b218ff8cccf2c348fd30f9225a7bb47cd1df7e469e047f8233f930 |
| Misc/NEWS.d/next/Core_and_Builtins/2024-08-11-12-06-23.gh-issue-122901.B2Huom.rst | https://github.com/python/cpython/pull/122902/files#diff-864c9f1862ec88ae55a46740c8076873b32ee0d5f4d4762353246bcb33c6c7a7 |
|
View file
| https://github.com/ruema/cpython/blob/08035102f82675f1622ab2b3b550eeff32be5f13/Misc/NEWS.d/next/Core_and_Builtins/2024-08-11-12-06-23.gh-issue-122901.B2Huom.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/122902/{{ revealButtonHref }} |
| Objects/stringlib/find_max_char.h | https://github.com/python/cpython/pull/122902/files#diff-8956a8f467b218ff8cccf2c348fd30f9225a7bb47cd1df7e469e047f8233f930 |
|
View file
| https://github.com/ruema/cpython/blob/08035102f82675f1622ab2b3b550eeff32be5f13/Objects/stringlib/find_max_char.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/122902/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/122902/files#diff-8956a8f467b218ff8cccf2c348fd30f9225a7bb47cd1df7e469e047f8233f930 |
| Please reload this page | https://github.com/python/cpython/pull/122902/files |
| Please reload this page | https://github.com/python/cpython/pull/122902/files |
| Please reload this page | https://github.com/python/cpython/pull/122902/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |