René's URL Explorer Experiment


Title: gh-122311: Improve and unify pickle errors by serhiy-storchaka · Pull Request #122771 · python/cpython · GitHub

Open Graph Title: gh-122311: Improve and unify pickle errors by serhiy-storchaka · Pull Request #122771 · python/cpython

X Title: gh-122311: Improve and unify pickle errors by serhiy-storchaka · Pull Request #122771 · python/cpython

Description: Raise PicklingError instead of UnicodeEncodeError, ValueError and AttributeError in both implementations. Chain the original exception to the pickle-specific one as __context__. Include the error message of ImportError and some AttributeError in the PicklingError error message. Unify error messages between Python and C implementations. Refer to documented __reduce__ and __newobj__ callables instead of internal methods (e.g. save_reduce()) or pickle opcodes (e.g. NEWOBJ). Include more details in error messages (what expected, what got). Avoid including a potentially long repr of an arbitrary object in error messages. Issue: gh-122311

Open Graph Description: Raise PicklingError instead of UnicodeEncodeError, ValueError and AttributeError in both implementations. Chain the original exception to the pickle-specific one as __context__. Include the error m...

X Description: Raise PicklingError instead of UnicodeEncodeError, ValueError and AttributeError in both implementations. Chain the original exception to the pickle-specific one as __context__. Include the error m...

Opengraph URL: https://github.com/python/cpython/pull/122771

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c8d4ff53-e856-fa6d-534f-320660406cc0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD1EE:24A400:1395B18:1AA4DB2:6A557CBF
html-safe-nonce843faa7c8777e22ce6e91e33cf6f961ed3e861911a197ebd8141629b4bcbbb4d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUVFOjI0QTQwMDoxMzk1QjE4OjFBQTREQjI6NkE1NTdDQkYiLCJ2aXNpdG9yX2lkIjoiODcxOTQ4OTI3NTc5MDcyMDE5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac28416ede10cd583efd95ec7e9b9b5ac14edd2d69be88e7b62fe753f8b65fe70f
hovercard-subject-tagpull_request:2008083643
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/122771/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:altRaise PicklingError instead of UnicodeEncodeError, ValueError and AttributeError in both implementations. Chain the original exception to the pickle-specific one as __context__. Include the error m...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release617ea94e2807dc3052601c560530bb3f8259bc9a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/122771/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122771%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122771%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/122771/files
Reloadhttps://github.com/python/cpython/pull/122771/files
Reloadhttps://github.com/python/cpython/pull/122771/files
Please reload this pagehttps://github.com/python/cpython/pull/122771/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/122771/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:pickle-errorshttps://github.com/serhiy-storchaka/cpython/tree/pickle-errors
Conversation 3 https://github.com/python/cpython/pull/122771
Commits 2 https://github.com/python/cpython/pull/122771/commits
Checks 0 https://github.com/python/cpython/pull/122771/checks
Files changed https://github.com/python/cpython/pull/122771/files
Please reload this pagehttps://github.com/python/cpython/pull/122771/files
gh-122311: Improve and unify pickle errors https://github.com/python/cpython/pull/122771/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/122771/files
43d94f2 gh-122311: Improve and unify pickle errors serhiy-storchaka Aug 5, 2024 https://github.com/python/cpython/pull/122771/commits/43d94f20da0c48edd944cf2a00cdc6050dd4d676
3f43170 Merge branch 'main' into pickle-errors serhiy-storchaka Sep 3, 2024 https://github.com/python/cpython/pull/122771/commits/3f4317094d87c4e8615cfb61871c5871b942d1e2
Clear filters https://github.com/python/cpython/pull/122771/files
Please reload this pagehttps://github.com/python/cpython/pull/122771/files
Please reload this pagehttps://github.com/python/cpython/pull/122771/files
pickle.py https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
pickletester.py https://github.com/python/cpython/pull/122771/files#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
2024-08-07-11-57-41.gh-issue-122311.LDExnJ.rst https://github.com/python/cpython/pull/122771/files#diff-759d200893024327a572831d6ee9c29e533d18aab38bcc2646b11409bf5b2e17
_pickle.c https://github.com/python/cpython/pull/122771/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
Lib/pickle.pyhttps://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
View file https://github.com/serhiy-storchaka/cpython/blob/3f4317094d87c4e8615cfb61871c5871b942d1e2/Lib/pickle.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122771/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
AA-Turnerhttps://github.com/AA-Turner
Aug 7, 2024https://github.com/python/cpython/pull/122771/files#r1707074041
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/122771/files
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 7, 2024https://github.com/python/cpython/pull/122771/files#r1707274783
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/122771/files
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
https://github.com/python/cpython/pull/122771/files#diff-0e6904a03cced1cde99717e889a6a20715fd002d7186a64e77477c2d99c32a47
Please reload this pagehttps://github.com/python/cpython/pull/122771/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.