René's URL Explorer Experiment


Title: gh-121284: Fix email address header folding with parsed encoded-word by medmunds · Pull Request #122754 · python/cpython · GitHub

Open Graph Title: gh-121284: Fix email address header folding with parsed encoded-word by medmunds · Pull Request #122754 · python/cpython

X Title: gh-121284: Fix email address header folding with parsed encoded-word by medmunds · Pull Request #122754 · python/cpython

Description: Fixes #121284. [This fixes a #security-issue. PSRT instructed me to handle the fix publicly.] Email generators using email.policy.default may convert an RFC 2047 encoded-word to unencoded form during header refolding. In a structured header, this could allow 'specials' chars outside a quoted-string, leading to invalid address headers and enabling spoofing. This change ensures a parsed encoded-word that contains specials is kept as an encoded-word while the header is refolded. The issue is very similar to PR #122753 (and has the same security implications), but this PR involves refolding an encoded-word; the other PR involves refolding a quoted-string. The fixes required are different. Issue: gh-121284

Open Graph Description: Fixes #121284. [This fixes a #security-issue. PSRT instructed me to handle the fix publicly.] Email generators using email.policy.default may convert an RFC 2047 encoded-word to unencoded form duri...

X Description: Fixes #121284. [This fixes a #security-issue. PSRT instructed me to handle the fix publicly.] Email generators using email.policy.default may convert an RFC 2047 encoded-word to unencoded form duri...

Opengraph URL: https://github.com/python/cpython/pull/122754

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:127b1d96-d2b6-720d-35dc-7479dcf4d28f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA4B6:283776:FBFD45:151B75F:6B005B75
html-safe-nonce7b423a65509d1fe08cdd8b90964f8c93b971e24e95e988e38edfa7d520658dde
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEI2OjI4Mzc3NjpGQkZENDU6MTUxQjc1Rjo2QjAwNUI3NSIsInZpc2l0b3JfaWQiOiIzNTcwNTU0MTUyMDI5MjgxMTQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca7ef4fcfc79e456756442c12da34795111db0b7719653ad76876d7bfb78f1cf3
hovercard-subject-tagpull_request:2006708663
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/122754/files
twitter:imagehttps://avatars.githubusercontent.com/u/639984?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/639984?s=400&v=4
og:image:altFixes #121284. [This fixes a #security-issue. PSRT instructed me to handle the fix publicly.] Email generators using email.policy.default may convert an RFC 2047 encoded-word to unencoded form duri...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeacd927ba6112e3b01ba99c762bd699a4a4f5df7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/122754/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122754%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122754%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/122754/files
Reloadhttps://github.com/python/cpython/pull/122754/files
Reloadhttps://github.com/python/cpython/pull/122754/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
medmunds:fix-issue-121284https://github.com/medmunds/cpython/tree/fix-issue-121284
Conversation 16 https://github.com/python/cpython/pull/122754
Commits 8 https://github.com/python/cpython/pull/122754/commits
Checks 0 https://github.com/python/cpython/pull/122754/checks
Files changed https://github.com/python/cpython/pull/122754/files
Please reload this pagehttps://github.com/python/cpython/pull/122754/files
gh-121284: Fix email address header folding with parsed encoded-word https://github.com/python/cpython/pull/122754/files#top
Show all changes 8 commits https://github.com/python/cpython/pull/122754/files
c540c9f gh-121284: Fix email address header folding with parsed encoded-word medmunds Aug 6, 2024 https://github.com/python/cpython/pull/122754/commits/c540c9f6a5e1d7ebe14e2a4b737e8b1e76a7bb1b
9c05613 Merge branch 'main' into fix-issue-121284 medmunds Oct 21, 2024 https://github.com/python/cpython/pull/122754/commits/9c05613a85ff25b034e203d9807c1fb14fd5cda9
a8d23d2 Merge branch 'main' into fix-issue-121284 medmunds Jan 18, 2025 https://github.com/python/cpython/pull/122754/commits/a8d23d21087d74f21478b3acf128e57804719875
45159cd Be more specific in news medmunds Jan 18, 2025 https://github.com/python/cpython/pull/122754/commits/45159cd073c5ec45edd374842a06aa3cdae25aba
e63ec20 Merge branch 'main' into fix-issue-121284 medmunds Mar 5, 2025 https://github.com/python/cpython/pull/122754/commits/e63ec20b97b45db2ea87bd66935e71045f6841d2
c249511 squash! gh-121284: Fix email address header folding with parsed encod… medmunds Mar 5, 2025 https://github.com/python/cpython/pull/122754/commits/c249511d5e81d523a260d7369b1518574ddf5aca
1da1d57 Merge branch 'main' into fix-issue-121284 encukou Mar 17, 2025 https://github.com/python/cpython/pull/122754/commits/1da1d57c025d154f42f8f41370ff6f6322c4b7a3
ede0ce8 Merge branch 'main' into fix-issue-121284 bitdancer Mar 17, 2025 https://github.com/python/cpython/pull/122754/commits/ede0ce8612e6988ba3cf65d401066f161d2ee3a0
Clear filters https://github.com/python/cpython/pull/122754/files
Please reload this pagehttps://github.com/python/cpython/pull/122754/files
Please reload this pagehttps://github.com/python/cpython/pull/122754/files
_header_value_parser.py https://github.com/python/cpython/pull/122754/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
test__header_value_parser.py https://github.com/python/cpython/pull/122754/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
2024-08-06-12-27-34.gh-issue-121284.8rwPxe.rst https://github.com/python/cpython/pull/122754/files#diff-eb34c78935feef51c9fbcc5e7f7ed3fd11726c9a5d21ad45744723672d321d4e
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L448
Lib/email/_header_value_parser.pyhttps://github.com/python/cpython/pull/122754/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
View file https://github.com/medmunds/cpython/blob/ede0ce8612e6988ba3cf65d401066f161d2ee3a0/Lib/email/_header_value_parser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122754/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122754/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/122754/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/122754/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/122754/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/122754/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/122754/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/122754/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/122754/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/122754/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/122754/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L448
Lib/test/test_email/test__header_value_parser.pyhttps://github.com/python/cpython/pull/122754/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
View file https://github.com/medmunds/cpython/blob/ede0ce8612e6988ba3cf65d401066f161d2ee3a0/Lib/test/test_email/test__header_value_parser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122754/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122754/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
https://github.com/python/cpython/pull/122754/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
Misc/NEWS.d/next/Security/2024-08-06-12-27-34.gh-issue-121284.8rwPxe.rsthttps://github.com/python/cpython/pull/122754/files#diff-eb34c78935feef51c9fbcc5e7f7ed3fd11726c9a5d21ad45744723672d321d4e
View file https://github.com/medmunds/cpython/blob/ede0ce8612e6988ba3cf65d401066f161d2ee3a0/Misc/NEWS.d/next/Security/2024-08-06-12-27-34.gh-issue-121284.8rwPxe.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122754/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.