René's URL Explorer Experiment


Title: gh-80222: Fix email address header folding with long quoted-string by medmunds · Pull Request #122753 · python/cpython · GitHub

Open Graph Title: gh-80222: Fix email address header folding with long quoted-string by medmunds · Pull Request #122753 · python/cpython

X Title: gh-80222: Fix email address header folding with long quoted-string by medmunds · Pull Request #122753 · python/cpython

Description: Fixes #80222 (bpo-36041). Email generators using email.policy.default could incorrectly omit the quote ('"') characters from a quoted-string during header refolding, leading to invalid address headers and enabling header spoofing. This change restores the quote characters on a bare-quoted-string as the header is refolded, and escapes backslash and quote chars in the string. Fix is adapted from PR #12054. [This fixes a #security-issue. PSRT instructed me to handle the fix publicly.] Issue: gh-80222

Open Graph Description: Fixes #80222 (bpo-36041). Email generators using email.policy.default could incorrectly omit the quote ('"') characters from a quoted-string during header refolding, leading to invalid...

X Description: Fixes #80222 (bpo-36041). Email generators using email.policy.default could incorrectly omit the quote ('"') characters from a quoted-string during header refolding, leadin...

Opengraph URL: https://github.com/python/cpython/pull/122753

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:aa7179b2-47fa-10c6-aa90-b21456b45dd7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id898E:2FD3CB:E8DA34:139C052:6B005B97
html-safe-noncea75a94064c1a2c5eb24e753046bab63826f1295be024f059a6aa8758b6cec3ee
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OThFOjJGRDNDQjpFOERBMzQ6MTM5QzA1Mjo2QjAwNUI5NyIsInZpc2l0b3JfaWQiOiI3MzkwNDkxMjc5MDQzMzUzNDk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4ed4637192d12b7071f5b1c2f22638f06353fcc376e4ac66246e177c613a8a16
hovercard-subject-tagpull_request:2006698250
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/122753/files
twitter:imagehttps://avatars.githubusercontent.com/u/639984?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/639984?s=400&v=4
og:image:altFixes #80222 (bpo-36041). Email generators using email.policy.default could incorrectly omit the quote ('"') characters from a quoted-string during header refolding, leading to invalid...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeacd927ba6112e3b01ba99c762bd699a4a4f5df7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/122753/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122753%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122753%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/122753/files
Reloadhttps://github.com/python/cpython/pull/122753/files
Reloadhttps://github.com/python/cpython/pull/122753/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
bitdancerhttps://github.com/bitdancer
python:mainhttps://github.com/python/cpython/tree/main
medmunds:fix-issue-80222https://github.com/medmunds/cpython/tree/fix-issue-80222
Conversation 25 https://github.com/python/cpython/pull/122753
Commits 4 https://github.com/python/cpython/pull/122753/commits
Checks 0 https://github.com/python/cpython/pull/122753/checks
Files changed https://github.com/python/cpython/pull/122753/files
Please reload this pagehttps://github.com/python/cpython/pull/122753/files
gh-80222: Fix email address header folding with long quoted-string https://github.com/python/cpython/pull/122753/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/122753/files
73f3ffd gh-80222: Fix email address header folding with long quoted-string medmunds Aug 6, 2024 https://github.com/python/cpython/pull/122753/commits/73f3ffd089acf866b6f48e6413bf58c9de936983
4df13d9 Merge branch 'main' into fix-issue-80222 medmunds Oct 21, 2024 https://github.com/python/cpython/pull/122753/commits/4df13d9de4e4e9b9c187e59ea78bdc14dc06b569
c268499 Merge branch 'main' into fix-issue-80222 medmunds Jan 18, 2025 https://github.com/python/cpython/pull/122753/commits/c2684996342574cff6765b7c982ce45e908f960b
6926474 Address review comments medmunds Jan 18, 2025 https://github.com/python/cpython/pull/122753/commits/69264749d46df2ad428e56b47cfa685997adacb3
Clear filters https://github.com/python/cpython/pull/122753/files
Please reload this pagehttps://github.com/python/cpython/pull/122753/files
Please reload this pagehttps://github.com/python/cpython/pull/122753/files
_header_value_parser.py https://github.com/python/cpython/pull/122753/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
test__header_value_parser.py https://github.com/python/cpython/pull/122753/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
2024-08-06-11-43-08.gh-issue-80222.wfR4BU.rst https://github.com/python/cpython/pull/122753/files#diff-d4313229c4f6b5c4551e07ab0c76409b99e6671340d9d3b0990c533e5d6b9747
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L448
Lib/email/_header_value_parser.pyhttps://github.com/python/cpython/pull/122753/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
View file https://github.com/medmunds/cpython/blob/69264749d46df2ad428e56b47cfa685997adacb3/Lib/email/_header_value_parser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122753/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122753/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/122753/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/122753/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/122753/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L448
Lib/test/test_email/test__header_value_parser.pyhttps://github.com/python/cpython/pull/122753/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
View file https://github.com/medmunds/cpython/blob/69264749d46df2ad428e56b47cfa685997adacb3/Lib/test/test_email/test__header_value_parser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122753/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122753/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
https://github.com/python/cpython/pull/122753/files#diff-903868bb695b972a6c6c6fec7fdf1aedd13ef65e7e076aef8b0964a9ff004839
Misc/NEWS.d/next/Security/2024-08-06-11-43-08.gh-issue-80222.wfR4BU.rsthttps://github.com/python/cpython/pull/122753/files#diff-d4313229c4f6b5c4551e07ab0c76409b99e6671340d9d3b0990c533e5d6b9747
View file https://github.com/medmunds/cpython/blob/69264749d46df2ad428e56b47cfa685997adacb3/Misc/NEWS.d/next/Security/2024-08-06-11-43-08.gh-issue-80222.wfR4BU.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122753/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.