René's URL Explorer Experiment


Title: gh-122697: Fix free-threading memory leaks at shutdown by colesbury · Pull Request #122703 · python/cpython · GitHub

Open Graph Title: gh-122697: Fix free-threading memory leaks at shutdown by colesbury · Pull Request #122703 · python/cpython

X Title: gh-122697: Fix free-threading memory leaks at shutdown by colesbury · Pull Request #122703 · python/cpython

Description: We were not properly accounting for interpreter memory leaks at shutdown and had two sources of leaks: Objects that use deferred reference counting and were reachable via static types outlive the final GC. We now disable deferred reference counting on all objects if we are calling the GC due to interpreter shutdown. _PyMem_FreeDelayed did not properly check for interpreter shutdown so we had some memory blocks that were enqueued to be freed, but never actually freed. Issue: gh-122697

Open Graph Description: We were not properly accounting for interpreter memory leaks at shutdown and had two sources of leaks: Objects that use deferred reference counting and were reachable via static types outlive the...

X Description: We were not properly accounting for interpreter memory leaks at shutdown and had two sources of leaks: Objects that use deferred reference counting and were reachable via static types outlive the...

Opengraph URL: https://github.com/python/cpython/pull/122703

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:98d01bb3-1731-860b-76c3-9a49b41aaee7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCCB0:2C4BED:40CF3FB:523D7FA:6B021F64
html-safe-nonce85e8f52ef5ed92dd5c54ecf983b056b8cdc53fd16866083b32d29bfe15aca8fc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0IwOjJDNEJFRDo0MENGM0ZCOjUyM0Q3RkE6NkIwMjFGNjQiLCJ2aXNpdG9yX2lkIjoiMTY2ODgxNjUxODY2MDgzMTczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc09bbfce829442a0716a19d26df4743a1cc550827a9ebdfef4581242ffd8b94c
hovercard-subject-tagpull_request:2004665395
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/122703/files
twitter:imagehttps://avatars.githubusercontent.com/u/655866?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/655866?s=400&v=4
og:image:altWe were not properly accounting for interpreter memory leaks at shutdown and had two sources of leaks: Objects that use deferred reference counting and were reachable via static types outlive the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/122703/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122703%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122703%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/122703/files
Reloadhttps://github.com/python/cpython/pull/122703/files
Reloadhttps://github.com/python/cpython/pull/122703/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
colesbury:gh-122697-memory-leakshttps://github.com/colesbury/cpython/tree/gh-122697-memory-leaks
Conversation 13 https://github.com/python/cpython/pull/122703
Commits 10 https://github.com/python/cpython/pull/122703/commits
Checks 0 https://github.com/python/cpython/pull/122703/checks
Files changed https://github.com/python/cpython/pull/122703/files
Please reload this pagehttps://github.com/python/cpython/pull/122703/files
gh-122697: Fix free-threading memory leaks at shutdown https://github.com/python/cpython/pull/122703/files#top
Show all changes 10 commits https://github.com/python/cpython/pull/122703/files
c9d7132 gh-122697: Fix free-threading memory leaks at shutdown colesbury Aug 5, 2024 https://github.com/python/cpython/pull/122703/commits/c9d71321b919bf8ecba9b1ac7835af5686bd48e1
04f9582 Add blurb colesbury Aug 5, 2024 https://github.com/python/cpython/pull/122703/commits/04f958286eedb7ba23b9615fcd2000630fc6d178
28d6768 Adjust comment colesbury Aug 5, 2024 https://github.com/python/cpython/pull/122703/commits/28d67681053c41ce0cd49bb42f92367979a03ab3
dcb709d Merge branch 'main' into gh-122697-memory-leaks colesbury Aug 6, 2024 https://github.com/python/cpython/pull/122703/commits/dcb709da583c8b1d3435f6acdacaf60568feb4fa
7fc200b Use interpreter shutdown instead of runtime shutdown colesbury Aug 7, 2024 https://github.com/python/cpython/pull/122703/commits/7fc200bf0c4416bd05b14d7d1508b69168595095
05db2d8 Update Misc/NEWS.d/next/Core_and_Builtins/2024-08-05-19-28-12.gh-issu… colesbury Aug 7, 2024 https://github.com/python/cpython/pull/122703/commits/05db2d8fbfefb4f870e78b66c83d2e359baf44aa
44db4e0 Merge branch 'main' into gh-122697-memory-leaks colesbury Aug 7, 2024 https://github.com/python/cpython/pull/122703/commits/44db4e0ee04960d0172759814a17df31cf10f3c2
33cc40c Add missing call to _PyType_FinalizeIdPool colesbury Aug 7, 2024 https://github.com/python/cpython/pull/122703/commits/33cc40caf0085d925d1c57ee2da89eea53409526
312f860 Fix includes colesbury Aug 7, 2024 https://github.com/python/cpython/pull/122703/commits/312f8605dab2589a85e2436dfb32eb33b151c0b3
70e25f5 Add missing Py_GIL_DISABLED ifdef guard colesbury Aug 7, 2024 https://github.com/python/cpython/pull/122703/commits/70e25f577d0a726206e0ead5def93cc16455457a
Clear filters https://github.com/python/cpython/pull/122703/files
Please reload this pagehttps://github.com/python/cpython/pull/122703/files
Please reload this pagehttps://github.com/python/cpython/pull/122703/files
2024-08-05-19-28-12.gh-issue-122697.17MvYl.rst https://github.com/python/cpython/pull/122703/files#diff-be7ef6a1a72ad197cf9580cd7394099abe2218f5bed2ad028690fc7b43043d28
obmalloc.c https://github.com/python/cpython/pull/122703/files#diff-399a22135f328b4e42b0722ef216587945eedf2d8c103a584a3dca5b30650329
gc_free_threading.c https://github.com/python/cpython/pull/122703/files#diff-4722ae850a2da3e12f50815c0e3932627ebe67edeaa8b7f28a94f20c8698204d
pylifecycle.c https://github.com/python/cpython/pull/122703/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
pystate.c https://github.com/python/cpython/pull/122703/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
Misc/NEWS.d/next/Core_and_Builtins/2024-08-05-19-28-12.gh-issue-122697.17MvYl.rsthttps://github.com/python/cpython/pull/122703/files#diff-be7ef6a1a72ad197cf9580cd7394099abe2218f5bed2ad028690fc7b43043d28
View file https://github.com/colesbury/cpython/blob/70e25f577d0a726206e0ead5def93cc16455457a/Misc/NEWS.d/next/Core_and_Builtins/2024-08-05-19-28-12.gh-issue-122697.17MvYl.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122703/{{ revealButtonHref }}
Objects/obmalloc.chttps://github.com/python/cpython/pull/122703/files#diff-399a22135f328b4e42b0722ef216587945eedf2d8c103a584a3dca5b30650329
View file https://github.com/colesbury/cpython/blob/70e25f577d0a726206e0ead5def93cc16455457a/Objects/obmalloc.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122703/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122703/files#diff-399a22135f328b4e42b0722ef216587945eedf2d8c103a584a3dca5b30650329
kumaraditya303https://github.com/kumaraditya303
Aug 7, 2024https://github.com/python/cpython/pull/122703/files#r1706933006
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/122703/files
colesburyhttps://github.com/colesbury
Aug 7, 2024https://github.com/python/cpython/pull/122703/files#r1707225418
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/122703/files
https://github.com/python/cpython/pull/122703/files#diff-399a22135f328b4e42b0722ef216587945eedf2d8c103a584a3dca5b30650329
https://github.com/python/cpython/pull/122703/files#diff-399a22135f328b4e42b0722ef216587945eedf2d8c103a584a3dca5b30650329
https://github.com/python/cpython/pull/122703/files#diff-399a22135f328b4e42b0722ef216587945eedf2d8c103a584a3dca5b30650329
Python/gc_free_threading.chttps://github.com/python/cpython/pull/122703/files#diff-4722ae850a2da3e12f50815c0e3932627ebe67edeaa8b7f28a94f20c8698204d
View file https://github.com/colesbury/cpython/blob/70e25f577d0a726206e0ead5def93cc16455457a/Python/gc_free_threading.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122703/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122703/files#diff-4722ae850a2da3e12f50815c0e3932627ebe67edeaa8b7f28a94f20c8698204d
https://github.com/python/cpython/pull/122703/files#diff-4722ae850a2da3e12f50815c0e3932627ebe67edeaa8b7f28a94f20c8698204d
https://github.com/python/cpython/pull/122703/files#diff-4722ae850a2da3e12f50815c0e3932627ebe67edeaa8b7f28a94f20c8698204d
https://github.com/python/cpython/pull/122703/files#diff-4722ae850a2da3e12f50815c0e3932627ebe67edeaa8b7f28a94f20c8698204d
https://github.com/python/cpython/pull/122703/files#diff-4722ae850a2da3e12f50815c0e3932627ebe67edeaa8b7f28a94f20c8698204d
https://github.com/python/cpython/pull/122703/files#diff-4722ae850a2da3e12f50815c0e3932627ebe67edeaa8b7f28a94f20c8698204d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L318
Python/pylifecycle.chttps://github.com/python/cpython/pull/122703/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
View file https://github.com/colesbury/cpython/blob/70e25f577d0a726206e0ead5def93cc16455457a/Python/pylifecycle.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122703/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122703/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/pull/122703/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/pull/122703/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/pull/122703/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L319
Python/pystate.chttps://github.com/python/cpython/pull/122703/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
View file https://github.com/colesbury/cpython/blob/70e25f577d0a726206e0ead5def93cc16455457a/Python/pystate.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122703/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122703/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/122703/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.