| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2a101925-63ed-4782-561d-ba0c2bae09ed |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AD10:2F21B4:6A23C9:894612:696B1405 |
| html-safe-nonce | 7031901e4a83e9385c54ef67cf1e957444096c7529eb0e3f5588e58fea508d71 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDEwOjJGMjFCNDo2QTIzQzk6ODk0NjEyOjY5NkIxNDA1IiwidmlzaXRvcl9pZCI6IjIzNjE1NTA3OTgzOTU3NDExODkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 58e7cf24b5cddabf080961ab43c34d4e4c0ebec32830ffb4f997641abc45235e |
| hovercard-subject-tag | pull_request:2003365887 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/122682/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/40c4b5e4939c5f0bb4bcbb85ac082c824bef3990b878812d46b87406960bce3f/python/cpython/pull/122682 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/40c4b5e4939c5f0bb4bcbb85ac082c824bef3990b878812d46b87406960bce3f/python/cpython/pull/122682 |
| og:image:alt | Issue: Merge m_atan2() and c_atan2() helper functions (or replace libm's atan2) #122681
For reviewers: as it mentioned in the issue, I think it worth to try removing these workarounds. Most... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | skirpichev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/122682#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122682 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122682 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/122682 |
| Reload | https://github.com/python/cpython/pull/122682 |
| Reload | https://github.com/python/cpython/pull/122682 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/122682 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/122682 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/122682#issue-comment-box |
| vstinner | https://github.com/vstinner |
| python:main | https://github.com/python/cpython/tree/main |
| skirpichev:m_atan2-122681 | https://github.com/skirpichev/cpython/tree/m_atan2-122681 |
|
gh-122681: merge m_atan2() and c_atan2() helper functions
| https://github.com/python/cpython/pull/122682#top |
| vstinner | https://github.com/vstinner |
| python:main | https://github.com/python/cpython/tree/main |
| skirpichev:m_atan2-122681 | https://github.com/skirpichev/cpython/tree/m_atan2-122681 |
|
Conversation
10
| https://github.com/python/cpython/pull/122682 |
|
Commits
7
| https://github.com/python/cpython/pull/122682/commits |
|
Checks
0
| https://github.com/python/cpython/pull/122682/checks |
|
Files changed
| https://github.com/python/cpython/pull/122682/files |
| Please reload this page | https://github.com/python/cpython/pull/122682 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
| Aug 5, 2024 | https://github.com/python/cpython/pull/122682#issue-2447874238 |
| Please reload this page | https://github.com/python/cpython/pull/122682 |
| Merge m_atan2() and c_atan2() helper functions (or replace libm's atan2) #122681 | https://github.com/python/cpython/issues/122681 |
| #122715 | https://github.com/python/cpython/pull/122715 |
| Please reload this page | https://github.com/python/cpython/pull/122682 |
|
| https://github.com/skirpichev |
| pythongh-122681 | https://github.com/python/cpython/issues/122681 |
| : merge m_atan2() and c_atan2() helper functions | https://github.com/python/cpython/pull/122682/commits/dc453f6f9edc917536cf5cc7d38ea70e909f9028 |
| dc453f6 | https://github.com/python/cpython/pull/122682/commits/dc453f6f9edc917536cf5cc7d38ea70e909f9028 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Aug 5, 2024
| https://github.com/python/cpython/pull/122682#ref-issue-2447862291 |
|
Merge m_atan2() and c_atan2() helper functions (or replace libm's atan2)
#122681
| https://github.com/python/cpython/issues/122681 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Aug 5, 2024 | https://github.com/python/cpython/pull/122682#event-13759941090 |
| https://github.com/terryjreedy |
| terryjreedy | https://github.com/terryjreedy |
| mdickinson | https://github.com/mdickinson |
| August 5, 2024 08:16 | https://github.com/python/cpython/pull/122682#event-13760187309 |
| skirpichev | https://github.com/skirpichev |
| August 5, 2024 11:34 | https://github.com/python/cpython/pull/122682#commits-pushed-5a2f3fe |
|
| https://github.com/skirpichev |
| Merge branch 'main' into m_atan2-122681 | https://github.com/python/cpython/pull/122682/commits/5a2f3fe2ce54bbe2fb71e117a0a779fe3b592752 |
| 5a2f3fe | https://github.com/python/cpython/pull/122682/commits/5a2f3fe2ce54bbe2fb71e117a0a779fe3b592752 |
|
| https://github.com/skirpichev |
| XXX pin attrs | https://github.com/python/cpython/pull/122682/commits/128281b9ca35ad9f317da9a410f07bbe2966cfdf |
| 128281b | https://github.com/python/cpython/pull/122682/commits/128281b9ca35ad9f317da9a410f07bbe2966cfdf |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
|
Aug 5, 2024
| https://github.com/python/cpython/pull/122682#ref-pullrequest-2448088283 |
|
gh-122686: pin attrs package (for hypothesis workflow)
#122687
| https://github.com/python/cpython/pull/122687 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Aug 5, 2024
| https://github.com/python/cpython/pull/122682#pullrequestreview-2219578438 |
|
View reviewed changes
| https://github.com/python/cpython/pull/122682/files/128281b9ca35ad9f317da9a410f07bbe2966cfdf |
| Tools/requirements-hypothesis.txt | https://github.com/python/cpython/pull/122682/files/128281b9ca35ad9f317da9a410f07bbe2966cfdf#diff-01fc738a263614c69eea7119acc6e09f7eb6b4deda8893d141fa81dd82ac3516 |
| Please reload this page | https://github.com/python/cpython/pull/122682 |
| Modules/_math.h | https://github.com/python/cpython/pull/122682/files/128281b9ca35ad9f317da9a410f07bbe2966cfdf#diff-fe38c026be6ce7988a3391668a3e03a17a945fa1fd901c77e39399387176e264 |
| vstinner | https://github.com/vstinner |
| Aug 5, 2024 | https://github.com/python/cpython/pull/122682#discussion_r1704464746 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/122682 |
| skirpichev | https://github.com/skirpichev |
| Aug 6, 2024 | https://github.com/python/cpython/pull/122682#discussion_r1704853136 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #122715 | https://github.com/python/cpython/pull/122715 |
| Please reload this page | https://github.com/python/cpython/pull/122682 |
| vstinner | https://github.com/vstinner |
| Aug 6, 2024 | https://github.com/python/cpython/pull/122682#discussion_r1705254716 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277783 | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277783 |
| Please reload this page | https://github.com/python/cpython/pull/122682 |
| Misc/NEWS.d/next/Library/2024-08-05-10-52-51.gh-issue-122681.q0T58t.rst | https://github.com/python/cpython/pull/122682/files/128281b9ca35ad9f317da9a410f07bbe2966cfdf#diff-1cec66a619329e96c3d66e2354fc01b4670a945e662c50678235fb266043341e |
| Please reload this page | https://github.com/python/cpython/pull/122682 |
| skirpichev | https://github.com/skirpichev |
| August 6, 2024 05:51 | https://github.com/python/cpython/pull/122682#commits-pushed-6a11322 |
|
| https://github.com/skirpichev |
| Revert "XXX pin attrs" | https://github.com/python/cpython/pull/122682/commits/6a11322494b1ca667f57cdd5b339d1a72efdda09 |
| 6a11322 | https://github.com/python/cpython/pull/122682/commits/6a11322494b1ca667f57cdd5b339d1a72efdda09 |
| 128281b | https://github.com/skirpichev/cpython/commit/128281b9ca35ad9f317da9a410f07bbe2966cfdf |
|
| https://github.com/skirpichev |
| revert news entry too | https://github.com/python/cpython/pull/122682/commits/128023cb3f8eea877c458fe0614aa26c71c4b1f8 |
| 128023c | https://github.com/python/cpython/pull/122682/commits/128023cb3f8eea877c458fe0614aa26c71c4b1f8 |
|
| https://github.com/skirpichev |
| Merge branch 'master' into m_atan2-122681 | https://github.com/python/cpython/pull/122682/commits/2f06e6e10483eeb6e7a2ad3647650335c7e710ba |
| 2f06e6e | https://github.com/python/cpython/pull/122682/commits/2f06e6e10483eeb6e7a2ad3647650335c7e710ba |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Aug 6, 2024 | https://github.com/python/cpython/pull/122682#event-13774911811 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Aug 6, 2024
| https://github.com/python/cpython/pull/122682#pullrequestreview-2220844963 |
|
View reviewed changes
| https://github.com/python/cpython/pull/122682/files/a4a4d4681a5d7d91ae8b3dcf057549e3d89de43f |
| vstinner | https://github.com/vstinner |
| https://github.com/python/cpython/pull/122682#pullrequestreview-2220844963 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/122682 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Aug 6, 2024 | https://github.com/python/cpython/pull/122682#event-13776053430 |
|
| https://github.com/vstinner |
| Merge branch 'main' into m_atan2-122681 | https://github.com/python/cpython/pull/122682/commits/a4a4d4681a5d7d91ae8b3dcf057549e3d89de43f |
| a4a4d46 | https://github.com/python/cpython/pull/122682/commits/a4a4d4681a5d7d91ae8b3dcf057549e3d89de43f |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Aug 6, 2024 | https://github.com/python/cpython/pull/122682#issuecomment-2270880766 |
| Please reload this page | https://github.com/python/cpython/pull/122682 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| 0b433aa | https://github.com/python/cpython/commit/0b433aa9df6b5bb84e77ff97e59b7bcd04f2199a |
| Aug 6, 2024 | https://github.com/python/cpython/pull/122682#event-13778115503 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Aug 6, 2024 | https://github.com/python/cpython/pull/122682#event-13778116138 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Aug 6, 2024 | https://github.com/python/cpython/pull/122682#issuecomment-2271200393 |
| Please reload this page | https://github.com/python/cpython/pull/122682 |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
| August 6, 2024 12:48 | https://github.com/python/cpython/pull/122682#event-13778186249 |
| brandtbucher | https://github.com/brandtbucher |
|
Aug 7, 2024
| https://github.com/python/cpython/pull/122682#ref-commit-bc422ed |
|
| https://github.com/skirpichev |
|
| https://github.com/brandtbucher |
| pythongh-122681 | https://github.com/python/cpython/issues/122681 |
| : merge m_atan2() and c_atan2() helper functions ( | https://github.com/brandtbucher/cpython/commit/bc422ede22e17c74607fbb52200208a43b65246c |
| pyth… | https://github.com/python/cpython/pull/122682 |
| bc422ed | https://github.com/brandtbucher/cpython/commit/bc422ede22e17c74607fbb52200208a43b65246c |
| …on#122682 | https://github.com/python/cpython/pull/122682 |
| blhsing | https://github.com/blhsing |
|
Aug 22, 2024
| https://github.com/python/cpython/pull/122682#ref-commit-094aa0b |
|
| https://github.com/skirpichev |
|
| https://github.com/blhsing |
| pythongh-122681 | https://github.com/python/cpython/issues/122681 |
| : merge m_atan2() and c_atan2() helper functions ( | https://github.com/blhsing/cpython/commit/094aa0b7d1882990c13090015195a6898b355c06 |
| pyth… | https://github.com/python/cpython/pull/122682 |
| 094aa0b | https://github.com/blhsing/cpython/commit/094aa0b7d1882990c13090015195a6898b355c06 |
| …on#122682 | https://github.com/python/cpython/pull/122682 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122682 |
|
| https://github.com/vstinner |
|
vstinner
| https://github.com/vstinner |
|
| https://github.com/python/cpython/pull/122682/files/a4a4d4681a5d7d91ae8b3dcf057549e3d89de43f |
|
| https://github.com/mdickinson |
|
mdickinson
| https://github.com/mdickinson |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/122682 |
|
| https://github.com/skirpichev |
|
| https://github.com/vstinner |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |