René's URL Explorer Experiment


Title: [3.12] gh-121650: Encode newlines in headers, and verify headers are sound (GH-122233) by encukou · Pull Request #122599 · python/cpython · GitHub

Open Graph Title: [3.12] gh-121650: Encode newlines in headers, and verify headers are sound (GH-122233) by encukou · Pull Request #122599 · python/cpython

X Title: [3.12] gh-121650: Encode newlines in headers, and verify headers are sound (GH-122233) by encukou · Pull Request #122599 · python/cpython

Description: Encode header parts that contain newlines Per RFC 2047: [...] these encoding schemes allow the encoding of arbitrary octet values, mail readers that implement this decoding should also ensure that display of the decoded data on the recipient's terminal will not cause unwanted side-effects It seems that the "quoted-word" scheme is a valid way to include a newline character in a header value, just like we already allow undecodable bytes or control characters. They do need to be properly quoted when serialized to text, though. Verify that email headers are well-formed This should fail for custom fold() implementations that aren't careful about newlines. Co-authored-by: Bas Bloemsaat bas@bloemsaat.org Co-authored-by: Serhiy Storchaka storchaka@gmail.com (cherry picked from commit 0976339) 📚 Documentation preview 📚: https://cpython-previews--122599.org.readthedocs.build/

Open Graph Description: Encode header parts that contain newlines Per RFC 2047: [...] these encoding schemes allow the encoding of arbitrary octet values, mail readers that implement this decoding should also ensure tha...

X Description: Encode header parts that contain newlines Per RFC 2047: [...] these encoding schemes allow the encoding of arbitrary octet values, mail readers that implement this decoding should also ensure tha...

Opengraph URL: https://github.com/python/cpython/pull/122599

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c971f646-6cd1-77e8-ffe6-5550435038ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8BF2:200835:1D8D70:28C6C0:6B006717
html-safe-nonce1bff9b90e70f6a173cc236dd08ceb2a9d30f5deab3866a56e4b3ab01921a38fb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkYyOjIwMDgzNToxRDhENzA6MjhDNkMwOjZCMDA2NzE3IiwidmlzaXRvcl9pZCI6Ijg4NTk4ODAzNjIxNTk5MjUwMTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf8f8ce5e580020033641f5368c13c31db74c3145d55401a913ef642b093dfb7f
hovercard-subject-tagpull_request:2000397502
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/122599/files
twitter:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
og:image:altEncode header parts that contain newlines Per RFC 2047: [...] these encoding schemes allow the encoding of arbitrary octet values, mail readers that implement this decoding should also ensure tha...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None25854482a1773a7c1ebb8be3d2bc1c6e61d82d78126be63b5044474a86d44d9e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4f5c239e31f1f680e6bbc419ff92d774da616ec
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/122599/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122599%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122599%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/122599/files
Reloadhttps://github.com/python/cpython/pull/122599/files
Reloadhttps://github.com/python/cpython/pull/122599/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Yhg1shttps://github.com/Yhg1s
python:3.12https://github.com/python/cpython/tree/3.12
encukou:backport-0976339-3.12https://github.com/encukou/cpython/tree/backport-0976339-3.12
Conversation 1 https://github.com/python/cpython/pull/122599
Commits 2 https://github.com/python/cpython/pull/122599/commits
Checks 0 https://github.com/python/cpython/pull/122599/checks
Files changed https://github.com/python/cpython/pull/122599/files
Please reload this pagehttps://github.com/python/cpython/pull/122599/files
[3.12] gh-121650: Encode newlines in headers, and verify headers are sound (GH-122233) https://github.com/python/cpython/pull/122599/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/122599/files
e58aec9 gh-121650: Encode newlines in headers, and verify headers are sound (… encukou Jul 30, 2024 https://github.com/python/cpython/pull/122599/commits/e58aec9cbfdebf45ee863eded142358e9e98531d
7e3b041 Document changes as made in 3.12.5 encukou Aug 2, 2024 https://github.com/python/cpython/pull/122599/commits/7e3b0413643c574ce42b8a1e2c48a1fb0f45d385
Clear filters https://github.com/python/cpython/pull/122599/files
Please reload this pagehttps://github.com/python/cpython/pull/122599/files
Please reload this pagehttps://github.com/python/cpython/pull/122599/files
email.errors.rst https://github.com/python/cpython/pull/122599/files#diff-989a7dee50b1d9c26c815478e284fd12c60740efae71e49ed0386e19b8e6179d
email.policy.rst https://github.com/python/cpython/pull/122599/files#diff-a5687513db54ac9075c71b08c55d32726189212b2002c425fa3a9c0f6045bc61
3.12.rst https://github.com/python/cpython/pull/122599/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b
_header_value_parser.py https://github.com/python/cpython/pull/122599/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
_policybase.py https://github.com/python/cpython/pull/122599/files#diff-241bfb445ff0612f84a53fa742a6414f0d570c31c0ee4289405007d084e82515
errors.py https://github.com/python/cpython/pull/122599/files#diff-6b53981eabbf3b2dac54ddb7efc6c1097124bd8148e2264cc1ac30851b45518e
generator.py https://github.com/python/cpython/pull/122599/files#diff-f3456051a56ce9da075c457c0db3a708d03973338ba5419e77fe0a80c10c50c3
test_generator.py https://github.com/python/cpython/pull/122599/files#diff-3e803f38579321b7277ac415d5b293438114eeb1afc9aa2bb4db75adc56b1ffa
test_policy.py https://github.com/python/cpython/pull/122599/files#diff-28c8506700752b35e5100aa83721a7d5968f7a1db805e57035acc76412fce712
2024-07-27-16-10-41.gh-issue-121650.nf6oc9.rst https://github.com/python/cpython/pull/122599/files#diff-9a46e79907cb4d4d6e0e263a15fb3e5441910000ace7087ac38b365e9f743c80
https://github.com/python/cpython/blob/3.12/.github/CODEOWNERS#L86
Doc/library/email.errors.rsthttps://github.com/python/cpython/pull/122599/files#diff-989a7dee50b1d9c26c815478e284fd12c60740efae71e49ed0386e19b8e6179d
View file https://github.com/encukou/cpython/blob/7e3b0413643c574ce42b8a1e2c48a1fb0f45d385/Doc/library/email.errors.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122599/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122599/files#diff-989a7dee50b1d9c26c815478e284fd12c60740efae71e49ed0386e19b8e6179d
https://github.com/python/cpython/pull/122599/files#diff-989a7dee50b1d9c26c815478e284fd12c60740efae71e49ed0386e19b8e6179d
https://github.com/python/cpython/blob/3.12/.github/CODEOWNERS#L86
Doc/library/email.policy.rsthttps://github.com/python/cpython/pull/122599/files#diff-a5687513db54ac9075c71b08c55d32726189212b2002c425fa3a9c0f6045bc61
View file https://github.com/encukou/cpython/blob/7e3b0413643c574ce42b8a1e2c48a1fb0f45d385/Doc/library/email.policy.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122599/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122599/files#diff-a5687513db54ac9075c71b08c55d32726189212b2002c425fa3a9c0f6045bc61
https://github.com/python/cpython/pull/122599/files#diff-a5687513db54ac9075c71b08c55d32726189212b2002c425fa3a9c0f6045bc61
Doc/whatsnew/3.12.rsthttps://github.com/python/cpython/pull/122599/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b
View file https://github.com/encukou/cpython/blob/7e3b0413643c574ce42b8a1e2c48a1fb0f45d385/Doc/whatsnew/3.12.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122599/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122599/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b
https://github.com/python/cpython/blob/3.12/.github/CODEOWNERS#L86
Lib/email/_header_value_parser.pyhttps://github.com/python/cpython/pull/122599/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
View file https://github.com/encukou/cpython/blob/7e3b0413643c574ce42b8a1e2c48a1fb0f45d385/Lib/email/_header_value_parser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122599/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122599/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/122599/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/122599/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/pull/122599/files#diff-4f8d778d571b7faffb42100d1f6d0374134750c72f94c0840e9368c351b41845
https://github.com/python/cpython/blob/3.12/.github/CODEOWNERS#L86
Lib/email/_policybase.pyhttps://github.com/python/cpython/pull/122599/files#diff-241bfb445ff0612f84a53fa742a6414f0d570c31c0ee4289405007d084e82515
View file https://github.com/encukou/cpython/blob/7e3b0413643c574ce42b8a1e2c48a1fb0f45d385/Lib/email/_policybase.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122599/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122599/files#diff-241bfb445ff0612f84a53fa742a6414f0d570c31c0ee4289405007d084e82515
https://github.com/python/cpython/pull/122599/files#diff-241bfb445ff0612f84a53fa742a6414f0d570c31c0ee4289405007d084e82515
https://github.com/python/cpython/pull/122599/files#diff-241bfb445ff0612f84a53fa742a6414f0d570c31c0ee4289405007d084e82515
https://github.com/python/cpython/blob/3.12/.github/CODEOWNERS#L86
Lib/email/errors.pyhttps://github.com/python/cpython/pull/122599/files#diff-6b53981eabbf3b2dac54ddb7efc6c1097124bd8148e2264cc1ac30851b45518e
View file https://github.com/encukou/cpython/blob/7e3b0413643c574ce42b8a1e2c48a1fb0f45d385/Lib/email/errors.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122599/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122599/files#diff-6b53981eabbf3b2dac54ddb7efc6c1097124bd8148e2264cc1ac30851b45518e
https://github.com/python/cpython/pull/122599/files#diff-6b53981eabbf3b2dac54ddb7efc6c1097124bd8148e2264cc1ac30851b45518e
https://github.com/python/cpython/blob/3.12/.github/CODEOWNERS#L86
Lib/email/generator.pyhttps://github.com/python/cpython/pull/122599/files#diff-f3456051a56ce9da075c457c0db3a708d03973338ba5419e77fe0a80c10c50c3
View file https://github.com/encukou/cpython/blob/7e3b0413643c574ce42b8a1e2c48a1fb0f45d385/Lib/email/generator.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122599/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122599/files#diff-f3456051a56ce9da075c457c0db3a708d03973338ba5419e77fe0a80c10c50c3
https://github.com/python/cpython/pull/122599/files#diff-f3456051a56ce9da075c457c0db3a708d03973338ba5419e77fe0a80c10c50c3
https://github.com/python/cpython/pull/122599/files#diff-f3456051a56ce9da075c457c0db3a708d03973338ba5419e77fe0a80c10c50c3
https://github.com/python/cpython/pull/122599/files#diff-f3456051a56ce9da075c457c0db3a708d03973338ba5419e77fe0a80c10c50c3
https://github.com/python/cpython/blob/3.12/.github/CODEOWNERS#L86
Lib/test/test_email/test_generator.pyhttps://github.com/python/cpython/pull/122599/files#diff-3e803f38579321b7277ac415d5b293438114eeb1afc9aa2bb4db75adc56b1ffa
View file https://github.com/encukou/cpython/blob/7e3b0413643c574ce42b8a1e2c48a1fb0f45d385/Lib/test/test_email/test_generator.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122599/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122599/files#diff-3e803f38579321b7277ac415d5b293438114eeb1afc9aa2bb4db75adc56b1ffa
https://github.com/python/cpython/pull/122599/files#diff-3e803f38579321b7277ac415d5b293438114eeb1afc9aa2bb4db75adc56b1ffa
https://github.com/python/cpython/pull/122599/files#diff-3e803f38579321b7277ac415d5b293438114eeb1afc9aa2bb4db75adc56b1ffa
https://github.com/python/cpython/pull/122599/files#diff-3e803f38579321b7277ac415d5b293438114eeb1afc9aa2bb4db75adc56b1ffa
https://github.com/python/cpython/pull/122599/files#diff-3e803f38579321b7277ac415d5b293438114eeb1afc9aa2bb4db75adc56b1ffa
https://github.com/python/cpython/blob/3.12/.github/CODEOWNERS#L86
Lib/test/test_email/test_policy.pyhttps://github.com/python/cpython/pull/122599/files#diff-28c8506700752b35e5100aa83721a7d5968f7a1db805e57035acc76412fce712
View file https://github.com/encukou/cpython/blob/7e3b0413643c574ce42b8a1e2c48a1fb0f45d385/Lib/test/test_email/test_policy.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122599/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122599/files#diff-28c8506700752b35e5100aa83721a7d5968f7a1db805e57035acc76412fce712
https://github.com/python/cpython/pull/122599/files#diff-28c8506700752b35e5100aa83721a7d5968f7a1db805e57035acc76412fce712
https://github.com/python/cpython/pull/122599/files#diff-28c8506700752b35e5100aa83721a7d5968f7a1db805e57035acc76412fce712
https://github.com/python/cpython/pull/122599/files#diff-28c8506700752b35e5100aa83721a7d5968f7a1db805e57035acc76412fce712
Misc/NEWS.d/next/Library/2024-07-27-16-10-41.gh-issue-121650.nf6oc9.rsthttps://github.com/python/cpython/pull/122599/files#diff-9a46e79907cb4d4d6e0e263a15fb3e5441910000ace7087ac38b365e9f743c80
View file https://github.com/encukou/cpython/blob/7e3b0413643c574ce42b8a1e2c48a1fb0f45d385/Misc/NEWS.d/next/Library/2024-07-27-16-10-41.gh-issue-121650.nf6oc9.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122599/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.