René's URL Explorer Experiment


Title: gh-122527: Fix a crash on deallocation of `PyStructSequence` by colesbury · Pull Request #122577 · python/cpython · GitHub

Open Graph Title: gh-122527: Fix a crash on deallocation of `PyStructSequence` by colesbury · Pull Request #122577 · python/cpython

X Title: gh-122527: Fix a crash on deallocation of `PyStructSequence` by colesbury · Pull Request #122577 · python/cpython

Description: The PyStructSequence destructor would crash if it was deallocated after its type's dictionary was cleared by the GC, because it couldn't compute the "real size" of the instance. This could occur with relatively straightforward code in the free-threaded build or with a reference cycle involving the type in the default build, due to differing orders in which tp_clear() was called. Account for the non-sequence fields in tp_basicsize and use that, along with Py_SIZE(), to compute the "real" size of a PyStructSequence in the dealloc function. This avoids the accesses to the type's dictionary during dealloc, which were unsafe. Issue: gh-122527

Open Graph Description: The PyStructSequence destructor would crash if it was deallocated after its type's dictionary was cleared by the GC, because it couldn't compute the "real size" of the instance. T...

X Description: The PyStructSequence destructor would crash if it was deallocated after its type's dictionary was cleared by the GC, because it couldn't compute the "real size" of...

Opengraph URL: https://github.com/python/cpython/pull/122577

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ee872eae-954c-5731-460b-37eaf80f8002
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED54:23DB5F:10E7608:1536CC6:6B024218
html-safe-noncef9ba0f244e7039a5696dd00f10d38a2714af6681baf8714899003aafd673c64f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDU0OjIzREI1RjoxMEU3NjA4OjE1MzZDQzY6NkIwMjQyMTgiLCJ2aXNpdG9yX2lkIjoiNjY1NzUyMjA5NDU2NzQ3MzY4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8782739bfb8d48db60e5a071db3a7061883ff166e5321134911c6404fa12413e
hovercard-subject-tagpull_request:1999227313
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/122577/files
twitter:imagehttps://avatars.githubusercontent.com/u/655866?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/655866?s=400&v=4
og:image:altThe PyStructSequence destructor would crash if it was deallocated after its type's dictionary was cleared by the GC, because it couldn't compute the "real size" of the instance. T...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/122577/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122577%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122577%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/122577/files
Reloadhttps://github.com/python/cpython/pull/122577/files
Reloadhttps://github.com/python/cpython/pull/122577/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
colesbury:gh-122527-structseqhttps://github.com/colesbury/cpython/tree/gh-122527-structseq
Conversation 12 https://github.com/python/cpython/pull/122577
Commits 2 https://github.com/python/cpython/pull/122577/commits
Checks 0 https://github.com/python/cpython/pull/122577/checks
Files changed https://github.com/python/cpython/pull/122577/files
Please reload this pagehttps://github.com/python/cpython/pull/122577/files
gh-122527: Fix a crash on deallocation of PyStructSequence https://github.com/python/cpython/pull/122577/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/122577/files
e677b27 gh-122527: Fix a crash on deallocation of `PyStructSequence` colesbury Aug 1, 2024 https://github.com/python/cpython/pull/122577/commits/e677b2793f7f4261964d8d93493b341134d7964c
fc79413 Add missing cast colesbury Aug 1, 2024 https://github.com/python/cpython/pull/122577/commits/fc79413595ced665963e45b9ea9762c23365ae27
Clear filters https://github.com/python/cpython/pull/122577/files
Please reload this pagehttps://github.com/python/cpython/pull/122577/files
Please reload this pagehttps://github.com/python/cpython/pull/122577/files
test_structseq.py https://github.com/python/cpython/pull/122577/files#diff-4a637803c745f86a5ed3a3bb336b12697a2635ab209994b8c989b8cfae0085ef
test_sys.py https://github.com/python/cpython/pull/122577/files#diff-f3ae0e3fbb12fe0717e2d9d8801f5d9f3091c34254d1302b228422d7d07fdc5d
2024-08-01-19-13-58.gh-issue-122527.eztso6.rst https://github.com/python/cpython/pull/122577/files#diff-099e5e3d5c0fc520a5c05de0fdaf0763792738ca4f2941db85b6a73a540fa083
structseq.c https://github.com/python/cpython/pull/122577/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
Lib/test/test_structseq.pyhttps://github.com/python/cpython/pull/122577/files#diff-4a637803c745f86a5ed3a3bb336b12697a2635ab209994b8c989b8cfae0085ef
View file https://github.com/colesbury/cpython/blob/fc79413595ced665963e45b9ea9762c23365ae27/Lib/test/test_structseq.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122577/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122577/files#diff-4a637803c745f86a5ed3a3bb336b12697a2635ab209994b8c989b8cfae0085ef
https://github.com/python/cpython/pull/122577/files#diff-4a637803c745f86a5ed3a3bb336b12697a2635ab209994b8c989b8cfae0085ef
https://github.com/python/cpython/pull/122577/files#diff-4a637803c745f86a5ed3a3bb336b12697a2635ab209994b8c989b8cfae0085ef
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 12, 2024https://github.com/python/cpython/pull/122577/files#r1713735559
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/122577/files
Lib/test/test_sys.pyhttps://github.com/python/cpython/pull/122577/files#diff-f3ae0e3fbb12fe0717e2d9d8801f5d9f3091c34254d1302b228422d7d07fdc5d
View file https://github.com/colesbury/cpython/blob/fc79413595ced665963e45b9ea9762c23365ae27/Lib/test/test_sys.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122577/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122577/files#diff-f3ae0e3fbb12fe0717e2d9d8801f5d9f3091c34254d1302b228422d7d07fdc5d
https://github.com/python/cpython/pull/122577/files#diff-f3ae0e3fbb12fe0717e2d9d8801f5d9f3091c34254d1302b228422d7d07fdc5d
Misc/NEWS.d/next/Core_and_Builtins/2024-08-01-19-13-58.gh-issue-122527.eztso6.rsthttps://github.com/python/cpython/pull/122577/files#diff-099e5e3d5c0fc520a5c05de0fdaf0763792738ca4f2941db85b6a73a540fa083
View file https://github.com/colesbury/cpython/blob/fc79413595ced665963e45b9ea9762c23365ae27/Misc/NEWS.d/next/Core_and_Builtins/2024-08-01-19-13-58.gh-issue-122527.eztso6.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122577/{{ revealButtonHref }}
Objects/structseq.chttps://github.com/python/cpython/pull/122577/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
View file https://github.com/colesbury/cpython/blob/fc79413595ced665963e45b9ea9762c23365ae27/Objects/structseq.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/122577/{{ revealButtonHref }}
https://github.com/python/cpython/pull/122577/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 12, 2024https://github.com/python/cpython/pull/122577/files#r1713730496
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/122577/files
colesburyhttps://github.com/colesbury
Aug 12, 2024https://github.com/python/cpython/pull/122577/files#r1713857356
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/122577/files
https://github.com/python/cpython/pull/122577/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/122577/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/122577/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/122577/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/122577/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/122577/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/122577/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/122577/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/122577/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/122577/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com/python/cpython/pull/122577/files#diff-6088e5bc32426d02181ea56f5c4acbfc2fef3094c476b8081b22772fe205ccbd
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.