René's URL Explorer Experiment


Title: gh-120974: Make asyncio `swap_current_task` safe in free-threaded build by colesbury · Pull Request #122317 · python/cpython · GitHub

Open Graph Title: gh-120974: Make asyncio `swap_current_task` safe in free-threaded build by colesbury · Pull Request #122317 · python/cpython

X Title: gh-120974: Make asyncio `swap_current_task` safe in free-threaded build by colesbury · Pull Request #122317 · python/cpython

Description: Use a critical section around the modifications to current_tasks so that the swapping is atomic. Issue: asyncio thread-safety issues in the free-threaded build #120974

Open Graph Description: Use a critical section around the modifications to current_tasks so that the swapping is atomic. Issue: asyncio thread-safety issues in the free-threaded build #120974

X Description: Use a critical section around the modifications to current_tasks so that the swapping is atomic. Issue: asyncio thread-safety issues in the free-threaded build #120974

Opengraph URL: https://github.com/python/cpython/pull/122317

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f6033aea-0b5f-9bd1-122b-707376b43c70
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB7DC:15273F:73933:A50CA:696A43E5
html-safe-nonce2bd864366607b522f70e931d2f376f9a8f1de5605fe45705f18ce905c2a337e2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0RDOjE1MjczRjo3MzkzMzpBNTBDQTo2OTZBNDNFNSIsInZpc2l0b3JfaWQiOiI0MDEzNzE1MDg4MTI2NjU3NTA5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacac009cd485c074befb4432a1a594b922074b3f632ad32c148b377557dfe45605
hovercard-subject-tagpull_request:1989781953
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/122317/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f691552aa6f8140a3476d85073afaa603d893fb1b4fdfdd575f90b08eb51240b/python/cpython/pull/122317
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f691552aa6f8140a3476d85073afaa603d893fb1b4fdfdd575f90b08eb51240b/python/cpython/pull/122317
og:image:altUse a critical section around the modifications to current_tasks so that the swapping is atomic. Issue: asyncio thread-safety issues in the free-threaded build #120974
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecolesbury
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/122317#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122317
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122317
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/122317
Reloadhttps://github.com/python/cpython/pull/122317
Reloadhttps://github.com/python/cpython/pull/122317
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/122317
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/122317
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/122317#issue-comment-box
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
colesbury:gh-120974-asyncio-swap-current-taskhttps://github.com/colesbury/cpython/tree/gh-120974-asyncio-swap-current-task
gh-120974: Make asyncio swap_current_task safe in free-threaded build https://github.com/python/cpython/pull/122317#top
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
colesbury:gh-120974-asyncio-swap-current-taskhttps://github.com/colesbury/cpython/tree/gh-120974-asyncio-swap-current-task
Conversation 7 https://github.com/python/cpython/pull/122317
Commits 2 https://github.com/python/cpython/pull/122317/commits
Checks 0 https://github.com/python/cpython/pull/122317/checks
Files changed 3 https://github.com/python/cpython/pull/122317/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Jul 26, 2024https://github.com/python/cpython/pull/122317#issue-2432601341
Please reload this pagehttps://github.com/python/cpython/pull/122317
asyncio thread-safety issues in the free-threaded build #120974https://github.com/python/cpython/issues/120974
Please reload this pagehttps://github.com/python/cpython/pull/122317
https://github.com/colesbury
pythongh-120974https://github.com/python/cpython/issues/120974
: Make asynciohttps://github.com/python/cpython/pull/122317/commits/846f6f8b857447f2b59cf653ebcdf17bd4faf925
swap_current_taskhttps://github.com/python/cpython/pull/122317/commits/846f6f8b857447f2b59cf653ebcdf17bd4faf925
safe in free-thread…https://github.com/python/cpython/pull/122317/commits/846f6f8b857447f2b59cf653ebcdf17bd4faf925
846f6f8https://github.com/python/cpython/pull/122317/commits/846f6f8b857447f2b59cf653ebcdf17bd4faf925
https://github.com/colesbury
colesburyhttps://github.com/colesbury
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Jul 26, 2024https://github.com/python/cpython/pull/122317#event-13663665788
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Fidget-Spinnerhttps://github.com/Fidget-Spinner
kumaraditya303https://github.com/kumaraditya303
July 26, 2024 16:48https://github.com/python/cpython/pull/122317#event-13663665813
https://github.com/colesbury
colesburyhttps://github.com/colesbury
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
gvanrossumhttps://github.com/gvanrossum
markshannonhttps://github.com/markshannon
methanehttps://github.com/methane
willingchttps://github.com/willingc
code ownershttps://github.com/python/cpython/blob/64857d849f3079a73367525ce93fd7a463b83908/.github/CODEOWNERS#L20
July 26, 2024 16:48https://github.com/python/cpython/pull/122317#event-13663665954
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 26, 2024 https://github.com/python/cpython/pull/122317#ref-issue-2371165212
asyncio thread-safety issues in the free-threaded build #120974 https://github.com/python/cpython/issues/120974
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 26, 2024https://github.com/python/cpython/pull/122317#event-13663667016
https://github.com/colesbury
colesburyhttps://github.com/colesbury
Jul 26, 2024https://github.com/python/cpython/pull/122317#issuecomment-2253129689
Please reload this pagehttps://github.com/python/cpython/pull/122317
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jul 26, 2024https://github.com/python/cpython/pull/122317#issuecomment-2253129792
@colesburyhttps://github.com/colesbury
846f6f8https://github.com/python/cpython/commit/846f6f8b857447f2b59cf653ebcdf17bd4faf925
Please reload this pagehttps://github.com/python/cpython/pull/122317
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Jul 27, 2024 https://github.com/python/cpython/pull/122317#pullrequestreview-2203215781
View reviewed changes https://github.com/python/cpython/pull/122317/files/846f6f8b857447f2b59cf653ebcdf17bd4faf925
Modules/_asynciomodule.chttps://github.com/python/cpython/pull/122317/files/846f6f8b857447f2b59cf653ebcdf17bd4faf925#diff-6bd9e39980b88a721d902bcd915bbb3f24762f7f253430c45e52c42a2c5afd01
Please reload this pagehttps://github.com/python/cpython/pull/122317
https://github.com/colesbury
Use _PyDict_GetItemRef_KnownHash_LockHeldhttps://github.com/python/cpython/pull/122317/commits/7df06fc125a729db1383bda439fb3dbcb457f975
7df06fchttps://github.com/python/cpython/pull/122317/commits/7df06fc125a729db1383bda439fb3dbcb457f975
https://github.com/colesbury
colesburyhttps://github.com/colesbury
kumaraditya303https://github.com/kumaraditya303
July 29, 2024 16:52https://github.com/python/cpython/pull/122317#event-13683592735
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Jul 31, 2024 https://github.com/python/cpython/pull/122317#pullrequestreview-2209101841
View reviewed changes https://github.com/python/cpython/pull/122317/files/7df06fc125a729db1383bda439fb3dbcb457f975
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 31, 2024https://github.com/python/cpython/pull/122317#event-13703750372
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
b5e6fb3https://github.com/python/cpython/commit/b5e6fb39a246bf7ee470d58632cdf588bb9d0298
Aug 2, 2024https://github.com/python/cpython/pull/122317#event-13741943765
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Aug 2, 2024https://github.com/python/cpython/pull/122317#issuecomment-2265414758
@colesburyhttps://github.com/colesbury
@kumaraditya303https://github.com/kumaraditya303
Please reload this pagehttps://github.com/python/cpython/pull/122317
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Aug 2, 2024https://github.com/python/cpython/pull/122317#event-13741944423
miss-islingtonhttps://github.com/miss-islington
Aug 2, 2024 https://github.com/python/cpython/pull/122317#ref-commit-6a87edc
https://github.com/colesbury
https://github.com/miss-islington
pythongh-120974https://github.com/python/cpython/issues/120974
: Make asynciohttps://github.com/miss-islington/cpython/commit/6a87edc44295db7bb5104124d7bd20ad6037e0c7
swap_current_taskhttps://github.com/miss-islington/cpython/commit/6a87edc44295db7bb5104124d7bd20ad6037e0c7
safe in free-thread…https://github.com/miss-islington/cpython/commit/6a87edc44295db7bb5104124d7bd20ad6037e0c7
6a87edchttps://github.com/miss-islington/cpython/commit/6a87edc44295db7bb5104124d7bd20ad6037e0c7
pythonGH-122317https://github.com/python/cpython/pull/122317
pythongh-120974https://github.com/python/cpython/issues/120974
b5e6fb3https://github.com/miss-islington/cpython/commit/b5e6fb39a246bf7ee470d58632cdf588bb9d0298
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Aug 2, 2024https://github.com/python/cpython/pull/122317#issuecomment-2265415086
GH-122612https://github.com/python/cpython/pull/122612
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/122317
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Aug 2, 2024https://github.com/python/cpython/pull/122317#event-13741946888
kumaraditya303https://github.com/kumaraditya303
Aug 2, 2024 https://github.com/python/cpython/pull/122317#ref-commit-c1efeb3
https://github.com/miss-islington
https://github.com/colesbury
[3.13]https://github.com/python/cpython/commit/c1efeb32345e93d423665e91a61ce34a482e0271
gh-120974https://github.com/python/cpython/issues/120974
: Make asynciohttps://github.com/python/cpython/commit/c1efeb32345e93d423665e91a61ce34a482e0271
swap_current_taskhttps://github.com/python/cpython/commit/c1efeb32345e93d423665e91a61ce34a482e0271
safe in free-threa…https://github.com/python/cpython/commit/c1efeb32345e93d423665e91a61ce34a482e0271
c1efeb3https://github.com/python/cpython/commit/c1efeb32345e93d423665e91a61ce34a482e0271
GH-122317https://github.com/python/cpython/pull/122317
#122612https://github.com/python/cpython/pull/122612
gh-120974https://github.com/python/cpython/issues/120974
GH-122317https://github.com/python/cpython/pull/122317
gh-120974https://github.com/python/cpython/issues/120974
b5e6fb3https://github.com/python/cpython/commit/b5e6fb39a246bf7ee470d58632cdf588bb9d0298
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 2, 2024https://github.com/python/cpython/pull/122317#issuecomment-2265533445
c1efeb3https://github.com/python/cpython/commit/c1efeb32345e93d423665e91a61ce34a482e0271
the buildbot page in the devguidehttps://devguide.python.org/buildbots/
https://buildbot.python.org/#builders/1386/builds/461https://buildbot.python.org/#builders/1386/builds/461
c1efeb3https://github.com/python/cpython/commit/c1efeb32345e93d423665e91a61ce34a482e0271
https://buildbot.python.org/#builders/1386/builds/461https://buildbot.python.org/#builders/1386/builds/461
Please reload this pagehttps://github.com/python/cpython/pull/122317
brandtbucherhttps://github.com/brandtbucher
Aug 7, 2024 https://github.com/python/cpython/pull/122317#ref-commit-475aeda
https://github.com/colesbury
https://github.com/brandtbucher
pythongh-120974https://github.com/python/cpython/issues/120974
: Make asynciohttps://github.com/brandtbucher/cpython/commit/475aeda6c0e6365f63ec1c045e13daa10818c3be
swap_current_taskhttps://github.com/brandtbucher/cpython/commit/475aeda6c0e6365f63ec1c045e13daa10818c3be
safe in free-thread…https://github.com/brandtbucher/cpython/commit/475aeda6c0e6365f63ec1c045e13daa10818c3be
475aedahttps://github.com/brandtbucher/cpython/commit/475aeda6c0e6365f63ec1c045e13daa10818c3be
python#122317https://github.com/python/cpython/pull/122317
pythongh-120974https://github.com/python/cpython/issues/120974
blhsinghttps://github.com/blhsing
Aug 22, 2024 https://github.com/python/cpython/pull/122317#ref-commit-d3909a4
https://github.com/colesbury
https://github.com/blhsing
pythongh-120974https://github.com/python/cpython/issues/120974
: Make asynciohttps://github.com/blhsing/cpython/commit/d3909a4955d3ec370d01b2d6893dd077d97fdcb7
swap_current_taskhttps://github.com/blhsing/cpython/commit/d3909a4955d3ec370d01b2d6893dd077d97fdcb7
safe in free-thread…https://github.com/blhsing/cpython/commit/d3909a4955d3ec370d01b2d6893dd077d97fdcb7
d3909a4https://github.com/blhsing/cpython/commit/d3909a4955d3ec370d01b2d6893dd077d97fdcb7
python#122317https://github.com/python/cpython/pull/122317
pythongh-120974https://github.com/python/cpython/issues/120974
https://github.com/colesbury
colesburyhttps://github.com/colesbury
October 30, 2024 16:43https://github.com/python/cpython/pull/122317#event-15012256080
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122317
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/122317/files/7df06fc125a729db1383bda439fb3dbcb457f975
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/methane
methane https://github.com/methane
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/willingc
willingc https://github.com/willingc
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/122317
https://github.com/colesbury
https://github.com/bedevere-bot
https://github.com/kumaraditya303
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.