| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bf2b0956-fd69-d7ce-08e9-e1a6adb1b476 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D36E:9E08E:927CFE:B78B8B:6B0217E4 |
| html-safe-nonce | f648a3a266e00b0ba4341be8637fd183e771ce8a112820d6cf10995aa8a07bd9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzZFOjlFMDhFOjkyN0NGRTpCNzhCOEI6NkIwMjE3RTQiLCJ2aXNpdG9yX2lkIjoiNTMwOTQ2MDIzMjYzMDU3MzAyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | bc722387be4d2bde813b336375ec8ef3e150bdde2cb96d09104348d1538f8fe1 |
| hovercard-subject-tag | pull_request:1987897269 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/122289/files |
| twitter:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| og:image:alt | This is a smaller PR compared to the one for the C implementation and is probably easier to review. Below are the benchmarks reported on the issue:
+------------------------------------------+-----... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/122289/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122289%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122289%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/122289/files |
| Reload | https://github.com/python/cpython/pull/122289/files |
| Reload | https://github.com/python/cpython/pull/122289/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| barneygale | https://github.com/barneygale |
| python:main | https://github.com/python/cpython/tree/main |
| picnixz:fnmatch-py-implementation | https://github.com/picnixz/cpython/tree/fnmatch-py-implementation |
|
Conversation
52
| https://github.com/python/cpython/pull/122289 |
|
Commits
18
| https://github.com/python/cpython/pull/122289/commits |
|
Checks
0
| https://github.com/python/cpython/pull/122289/checks |
|
Files changed
| https://github.com/python/cpython/pull/122289/files |
| Please reload this page | https://github.com/python/cpython/pull/122289/files |
|
gh-122288: Improve performances of fnmatch.translate
| https://github.com/python/cpython/pull/122289/files#top |
|
Show all changes
18 commits
| https://github.com/python/cpython/pull/122289/files |
|
7f15063
improve performances of `fnmatch.translate`
picnixz Jul 25, 2024
| https://github.com/python/cpython/pull/122289/commits/7f15063ad1d0f39f3df43fc54cfa1bc31fe0cbb6 |
|
83d0904
add tests
picnixz Jul 25, 2024
| https://github.com/python/cpython/pull/122289/commits/83d0904e3ef34cbc3a3980813e4c9e4d9989791f |
|
275a1c7
blurb
picnixz Jul 25, 2024
| https://github.com/python/cpython/pull/122289/commits/275a1c78624444cc0c10625e219f0791c30168c4 |
|
e60d057
fix usages
picnixz Jul 25, 2024
| https://github.com/python/cpython/pull/122289/commits/e60d057bccf37c24b4723eddee7cc66dc9c9c48e |
|
03217d7
keep legacy version for glob
picnixz Jul 25, 2024
| https://github.com/python/cpython/pull/122289/commits/03217d7b6dec482a4caa3c2d79b5fbb2041da75b |
|
804da13
actually not needed...
picnixz Jul 25, 2024
| https://github.com/python/cpython/pull/122289/commits/804da13fae3ee48f93a5064273af3401a3c8334d |
|
06a3652
Merge branch 'main' into fnmatch-py-implementation
picnixz Jul 25, 2024
| https://github.com/python/cpython/pull/122289/commits/06a3652b993b94ceb6c0106d537ab1b638a71ea6 |
|
baa6ce3
reduce the number of calls to `str.join`
picnixz Aug 17, 2024
| https://github.com/python/cpython/pull/122289/commits/baa6ce37b3f5908d311e7342f7314896c07edb34 |
|
80b22e0
micro-optimization on `re.sub`
picnixz Aug 18, 2024
| https://github.com/python/cpython/pull/122289/commits/80b22e005087f23cac1551d0daabae4cc00f3f34 |
|
7a9a87c
address Barney's review
picnixz Aug 19, 2024
| https://github.com/python/cpython/pull/122289/commits/7a9a87ce23a5599274a5426ac7103d001eb6c073 |
|
90539bc
Update Misc/NEWS.d/next/Library/2024-07-25-18-06-51.gh-issue-122288.-…
picnixz Aug 23, 2024
| https://github.com/python/cpython/pull/122289/commits/90539bcd17d3bb3eaf65cbfa18be236a88accc94 |
|
1d52949
use lower-case parameter names
picnixz Aug 27, 2024
| https://github.com/python/cpython/pull/122289/commits/1d52949cc8300437001c8342cb27441f1d8e3cbe |
|
0226437
rename variable `indices` to `star_indices`
picnixz Aug 28, 2024
| https://github.com/python/cpython/pull/122289/commits/02264371c101929b1e7774ce0c103127887c0bb2 |
|
01a5173
remove ambiguous comment about '?' case
picnixz Aug 28, 2024
| https://github.com/python/cpython/pull/122289/commits/01a51734dcd8031935432fb36997353e764fd616 |
|
bb6c3ee
change the cache size for `re.escape`
picnixz Aug 28, 2024
| https://github.com/python/cpython/pull/122289/commits/bb6c3eef37c79f7544e2d5c38c6f7ee19417ad52 |
|
c14ce4f
Update Lib/fnmatch.py
picnixz Oct 18, 2024
| https://github.com/python/cpython/pull/122289/commits/c14ce4f7abc18ca5c427c1c3da4d4131f3f3984e |
|
38d3427
Update Lib/test/test_fnmatch.py
picnixz Oct 22, 2024
| https://github.com/python/cpython/pull/122289/commits/38d342701d84370b2b2f713934f848d153f091ac |
|
78fde7a
Merge branch 'main' into fnmatch-py-implementation
picnixz Nov 11, 2024
| https://github.com/python/cpython/pull/122289/commits/78fde7a854eb8f704ff6f7e426dc6f2f1f0017f0 |
|
Clear filters
| https://github.com/python/cpython/pull/122289/files |
| Please reload this page | https://github.com/python/cpython/pull/122289/files |
| Please reload this page | https://github.com/python/cpython/pull/122289/files |
|
fnmatch.py
| https://github.com/python/cpython/pull/122289/files#diff-5078809c85d4fa8475e78198661cd5800368dc1e0f958b93513aac70155dd789 |
|
glob.py
| https://github.com/python/cpython/pull/122289/files#diff-aca8a30d5728898dc8623ab33adb548567e7a0092079954afa1b594b7f83c828 |
|
test_fnmatch.py
| https://github.com/python/cpython/pull/122289/files#diff-c2b05f64bbe1e260a84112533f35dcef70f5cf0cb658d8baed555de6ea1a1927 |
|
2024-07-25-18-06-51.gh-issue-122288.-_xxOR.rst
| https://github.com/python/cpython/pull/122289/files#diff-a40f3851a206e5980899ef5a533365d4735ff17a9b2655a0533107e588fedf61 |
| Lib/fnmatch.py | https://github.com/python/cpython/pull/122289/files#diff-5078809c85d4fa8475e78198661cd5800368dc1e0f958b93513aac70155dd789 |
|
View file
| https://github.com/picnixz/cpython/blob/78fde7a854eb8f704ff6f7e426dc6f2f1f0017f0/Lib/fnmatch.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/122289/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/122289/files#diff-5078809c85d4fa8475e78198661cd5800368dc1e0f958b93513aac70155dd789 |
| Please reload this page | https://github.com/python/cpython/pull/122289/files |
|
| https://github.com/python/cpython/pull/122289/files#diff-5078809c85d4fa8475e78198661cd5800368dc1e0f958b93513aac70155dd789 |
|
| https://github.com/python/cpython/pull/122289/files#diff-5078809c85d4fa8475e78198661cd5800368dc1e0f958b93513aac70155dd789 |
|
| https://github.com/python/cpython/pull/122289/files#diff-5078809c85d4fa8475e78198661cd5800368dc1e0f958b93513aac70155dd789 |
| Please reload this page | https://github.com/python/cpython/pull/122289/files |
| Please reload this page | https://github.com/python/cpython/pull/122289/files |
| Lib/glob.py | https://github.com/python/cpython/pull/122289/files#diff-aca8a30d5728898dc8623ab33adb548567e7a0092079954afa1b594b7f83c828 |
|
View file
| https://github.com/picnixz/cpython/blob/78fde7a854eb8f704ff6f7e426dc6f2f1f0017f0/Lib/glob.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/122289/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/122289/files#diff-aca8a30d5728898dc8623ab33adb548567e7a0092079954afa1b594b7f83c828 |
|
| https://github.com/python/cpython/pull/122289/files#diff-aca8a30d5728898dc8623ab33adb548567e7a0092079954afa1b594b7f83c828 |
| Lib/test/test_fnmatch.py | https://github.com/python/cpython/pull/122289/files#diff-c2b05f64bbe1e260a84112533f35dcef70f5cf0cb658d8baed555de6ea1a1927 |
|
View file
| https://github.com/picnixz/cpython/blob/78fde7a854eb8f704ff6f7e426dc6f2f1f0017f0/Lib/test/test_fnmatch.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/122289/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/122289/files#diff-c2b05f64bbe1e260a84112533f35dcef70f5cf0cb658d8baed555de6ea1a1927 |
|
| https://github.com/python/cpython/pull/122289/files#diff-c2b05f64bbe1e260a84112533f35dcef70f5cf0cb658d8baed555de6ea1a1927 |
| Misc/NEWS.d/next/Library/2024-07-25-18-06-51.gh-issue-122288.-_xxOR.rst | https://github.com/python/cpython/pull/122289/files#diff-a40f3851a206e5980899ef5a533365d4735ff17a9b2655a0533107e588fedf61 |
|
View file
| https://github.com/picnixz/cpython/blob/78fde7a854eb8f704ff6f7e426dc6f2f1f0017f0/Misc/NEWS.d/next/Library/2024-07-25-18-06-51.gh-issue-122288.-_xxOR.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/122289/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |