René's URL Explorer Experiment


Title: gh-122247: Move instruction instrumentation sanity check after tracing check by gaogaotiantian · Pull Request #122251 · python/cpython · GitHub

Open Graph Title: gh-122247: Move instruction instrumentation sanity check after tracing check by gaogaotiantian · Pull Request #122251 · python/cpython

X Title: gh-122247: Move instruction instrumentation sanity check after tracing check by gaogaotiantian · Pull Request #122251 · python/cpython

Description: Due to #117133, code objects are not always up to date. We do not instrument them if we are tracing - because no events will be generated anyway. Therefore, we should check tstate->tracing first fo...

Open Graph Description: Due to #117133, code objects are not always up to date. We do not instrument them if we are tracing - because no events will be generated anyway. Therefore, we should check tstate->tracing first...

X Description: Due to #117133, code objects are not always up to date. We do not instrument them if we are tracing - because no events will be generated anyway. Therefore, we should check tstate->tracing f...

Opengraph URL: https://github.com/python/cpython/pull/122251

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:aeedf9ee-3e5e-83c0-99ca-4a43ed7b3b46
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA660:35B8D6:1CFD525:27F8505:696AAEC1
html-safe-noncebae16b0e014e049995da43ccdeecd311b1a523d973c33265eb21ece874a8427d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjYwOjM1QjhENjoxQ0ZENTI1OjI3Rjg1MDU6Njk2QUFFQzEiLCJ2aXNpdG9yX2lkIjoiNDI2MDQ1NzEyODE3MTA1NjgzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5abb5e67414da5f6fc3dd58682090b7369497c61b4fdbaa238f640b76dbed0ee
hovercard-subject-tagpull_request:1986427904
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/122251/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6f187ae8330aabe230546a67d5ba8401c22a46880a0cc307625e9038db3ccec0/python/cpython/pull/122251
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6f187ae8330aabe230546a67d5ba8401c22a46880a0cc307625e9038db3ccec0/python/cpython/pull/122251
og:image:altDue to #117133, code objects are not always up to date. We do not instrument them if we are tracing - because no events will be generated anyway. Therefore, we should check tstate->tracing first...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegaogaotiantian
hostnamegithub.com
expected-hostnamegithub.com
None4fa1799b6a53c2d30c950d74230781bef9e7f61138c72c7727e4b83f0743752b
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release41f276818bd204c4a30a0281fb3c576298d9474c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/122251#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122251
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122251
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/122251
Reloadhttps://github.com/python/cpython/pull/122251
Reloadhttps://github.com/python/cpython/pull/122251
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/122251
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/122251
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/122251#issue-comment-box
gaogaotiantianhttps://github.com/gaogaotiantian
python:mainhttps://github.com/python/cpython/tree/main
gaogaotiantian:fix-instruction-asserthttps://github.com/gaogaotiantian/cpython/tree/fix-instruction-assert
gh-122247: Move instruction instrumentation sanity check after tracing check https://github.com/python/cpython/pull/122251#top
gaogaotiantianhttps://github.com/gaogaotiantian
python:mainhttps://github.com/python/cpython/tree/main
gaogaotiantian:fix-instruction-asserthttps://github.com/gaogaotiantian/cpython/tree/fix-instruction-assert
Conversation 5 https://github.com/python/cpython/pull/122251
Commits 2 https://github.com/python/cpython/pull/122251/commits
Checks 0 https://github.com/python/cpython/pull/122251/checks
Files changed https://github.com/python/cpython/pull/122251/files
Please reload this pagehttps://github.com/python/cpython/pull/122251
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
Jul 25, 2024https://github.com/python/cpython/pull/122251#issue-2428692680
Please reload this pagehttps://github.com/python/cpython/pull/122251
#117133https://github.com/python/cpython/pull/117133
Instrumentation assertion failure when calling the registered handler explicitly #122247https://github.com/python/cpython/issues/122247
Please reload this pagehttps://github.com/python/cpython/pull/122251
gaogaotiantianhttps://github.com/gaogaotiantian
July 24, 2024 17:16https://github.com/python/cpython/pull/122251#commits-pushed-2681852
https://github.com/gaogaotiantian
Move instruction instrumentation sanity check after tracing checkhttps://github.com/python/cpython/pull/122251/commits/2681852c131c9500f85042fbcde677c362010a2e
2681852https://github.com/python/cpython/pull/122251/commits/2681852c131c9500f85042fbcde677c362010a2e
https://github.com/gaogaotiantian
Remove deepfreezehttps://github.com/python/cpython/pull/122251/commits/26de053c867c37ba86966501a51b5648968247bf
26de053https://github.com/python/cpython/pull/122251/commits/26de053c867c37ba86966501a51b5648968247bf
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Jul 25, 2024https://github.com/python/cpython/pull/122251#event-13637668816
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
markshannonhttps://github.com/markshannon
July 25, 2024 00:21https://github.com/python/cpython/pull/122251#event-13637668830
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 25, 2024 https://github.com/python/cpython/pull/122251#ref-issue-2428534510
Instrumentation assertion failure when calling the registered handler explicitly #122247 https://github.com/python/cpython/issues/122247
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 25, 2024https://github.com/python/cpython/pull/122251#event-13637669680
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 25, 2024https://github.com/python/cpython/pull/122251#event-13637669791
https://github.com/encukou
encukouhttps://github.com/encukou
Aug 2, 2024https://github.com/python/cpython/pull/122251#issuecomment-2265025964
Please reload this pagehttps://github.com/python/cpython/pull/122251
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
Aug 7, 2024https://github.com/python/cpython/pull/122251#issuecomment-2272597265
Please reload this pagehttps://github.com/python/cpython/pull/122251
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Aug 7, 2024 https://github.com/python/cpython/pull/122251#pullrequestreview-2225404687
View reviewed changes https://github.com/python/cpython/pull/122251/files/26de053c867c37ba86966501a51b5648968247bf
markshannonhttps://github.com/markshannon
https://github.com/python/cpython/pull/122251#pullrequestreview-2225404687
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/122251
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 7, 2024https://github.com/python/cpython/pull/122251#event-13793602099
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
57d7c3ehttps://github.com/python/cpython/commit/57d7c3e78fb635a0c6ccce38ec3e2f4284d5fac7
Aug 8, 2024https://github.com/python/cpython/pull/122251#event-13800934293
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Aug 8, 2024https://github.com/python/cpython/pull/122251#event-13800934559
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Aug 8, 2024https://github.com/python/cpython/pull/122251#issuecomment-2274929641
@gaogaotiantianhttps://github.com/gaogaotiantian
Please reload this pagehttps://github.com/python/cpython/pull/122251
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
August 8, 2024 04:30https://github.com/python/cpython/pull/122251#event-13800934694
miss-islingtonhttps://github.com/miss-islington
Aug 8, 2024 https://github.com/python/cpython/pull/122251#ref-commit-82fec96
https://github.com/gaogaotiantian
https://github.com/miss-islington
pythongh-122247https://github.com/python/cpython/issues/122247
: Move instruction instrumentation sanity check after …https://github.com/miss-islington/cpython/commit/82fec9691f486bcd5f462ab3424182c9d77367bc
82fec96https://github.com/miss-islington/cpython/commit/82fec9691f486bcd5f462ab3424182c9d77367bc
pythonGH-122251https://github.com/python/cpython/pull/122251
57d7c3ehttps://github.com/miss-islington/cpython/commit/57d7c3e78fb635a0c6ccce38ec3e2f4284d5fac7
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Aug 8, 2024https://github.com/python/cpython/pull/122251#issuecomment-2274929793
GH-122812https://github.com/python/cpython/pull/122812
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/122251
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Aug 8, 2024https://github.com/python/cpython/pull/122251#event-13800935541
encukouhttps://github.com/encukou
Aug 16, 2024 https://github.com/python/cpython/pull/122251#ref-commit-1f70715
https://github.com/miss-islington
https://github.com/gaogaotiantian
[3.13]https://github.com/python/cpython/commit/1f7071572e49fc8576c72902135a4ddecc6f81c3
gh-122247https://github.com/python/cpython/issues/122247
: Move instruction instrumentation sanity check after…https://github.com/python/cpython/commit/1f7071572e49fc8576c72902135a4ddecc6f81c3
1f70715https://github.com/python/cpython/commit/1f7071572e49fc8576c72902135a4ddecc6f81c3
GH-122251https://github.com/python/cpython/pull/122251
GH-122812https://github.com/python/cpython/pull/122812
57d7c3ehttps://github.com/python/cpython/commit/57d7c3e78fb635a0c6ccce38ec3e2f4284d5fac7
blhsinghttps://github.com/blhsing
Aug 22, 2024 https://github.com/python/cpython/pull/122251#ref-commit-18f71aa
https://github.com/gaogaotiantian
https://github.com/blhsing
pythongh-122247https://github.com/python/cpython/issues/122247
: Move instruction instrumentation sanity check after …https://github.com/blhsing/cpython/commit/18f71aa344f61fd080cca16d1dbdced6323e39dc
18f71aahttps://github.com/blhsing/cpython/commit/18f71aa344f61fd080cca16d1dbdced6323e39dc
python#122251https://github.com/python/cpython/pull/122251
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122251
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/python/cpython/pull/122251/files/26de053c867c37ba86966501a51b5648968247bf
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/122251
https://github.com/gaogaotiantian
https://github.com/encukou
https://github.com/markshannon
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.