René's URL Explorer Experiment


Title: gh-121650: Encode newlines in headers, and verify headers are sound by encukou · Pull Request #122233 · python/cpython · GitHub

Open Graph Title: gh-121650: Encode newlines in headers, and verify headers are sound by encukou · Pull Request #122233 · python/cpython

X Title: gh-121650: Encode newlines in headers, and verify headers are sound by encukou · Pull Request #122233 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Re: #121812 Hello @basbloemsaat, I've spent the day reading through the email module, and RFCs, and I believe I found a better place to fix the issue. This involved lots of experimentation, so ...

X Description: Re: #121812 Hello @basbloemsaat, I've spent the day reading through the email module, and RFCs, and I believe I found a better place to fix the issue. This involved lots of experimentation,...

Opengraph URL: https://github.com/python/cpython/pull/122233

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:065aa2d6-badd-798c-3af2-776287c97ee6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB8E:3A7693:2D41117:3DC0700:6B005B72
html-safe-noncef4afe26c6205090ef5185c32d1ab48d903487470995a3b11605236a7aa39fe1c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjhFOjNBNzY5MzoyRDQxMTE3OjNEQzA3MDA6NkIwMDVCNzIiLCJ2aXNpdG9yX2lkIjoiMzk4NzczMTc5ODczMjg1NjE3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0c087fe4201d29d4098905552e0a21051f1a19594fabc1e3f294c83e7194af80
hovercard-subject-tagpull_request:1985517043
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/122233/commits
twitter:imagehttps://opengraph.githubassets.com/0e5648c653c4d4125ed6e970e4a91438aadf2646628f69bc94368726c1bd4a34/python/cpython/pull/122233
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0e5648c653c4d4125ed6e970e4a91438aadf2646628f69bc94368726c1bd4a34/python/cpython/pull/122233
og:image:altRe: #121812 Hello @basbloemsaat, I've spent the day reading through the email module, and RFCs, and I believe I found a better place to fix the issue. This involved lots of experimentation, so ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
None29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeacd927ba6112e3b01ba99c762bd699a4a4f5df7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/122233/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122233%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122233%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/122233/commits
Reloadhttps://github.com/python/cpython/pull/122233/commits
Reloadhttps://github.com/python/cpython/pull/122233/commits
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:gh-121650-email-newlines-in-headershttps://github.com/encukou/cpython/tree/gh-121650-email-newlines-in-headers
Conversationhttps://github.com/python/cpython/pull/122233
Commits12 (12)https://github.com/python/cpython/pull/122233/commits
Checkshttps://github.com/python/cpython/pull/122233/checks
Files changedhttps://github.com/python/cpython/pull/122233/files
gh-121650: Encode newlines in headers, and verify headers are soundhttps://github.com/python/cpython/pull/122233/commits#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:gh-121650-email-newlines-in-headershttps://github.com/encukou/cpython/tree/gh-121650-email-newlines-in-headers
Verify that email headers are well-formedhttps://github.com/python/cpython/pull/122233/commits/921cbfd2165abdfe387bc283996ed9cde11f717d
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
921cbfdhttps://github.com/python/cpython/pull/122233/commits/921cbfd2165abdfe387bc283996ed9cde11f717d
https://github.com/python/cpython/tree/921cbfd2165abdfe387bc283996ed9cde11f717d
Encode header parts that contain newlineshttps://github.com/python/cpython/pull/122233/commits/bd7f922f6214364923aa5959ee5d9733f600ce85
encukouhttps://github.com/python/cpython/commits?author=encukou
basbloemsaathttps://github.com/python/cpython/commits?author=basbloemsaat
bd7f922https://github.com/python/cpython/pull/122233/commits/bd7f922f6214364923aa5959ee5d9733f600ce85
https://github.com/python/cpython/tree/bd7f922f6214364923aa5959ee5d9733f600ce85
Add tests and documentationhttps://github.com/python/cpython/pull/122233/commits/59c06c3dd1a8435e76aa53d43d89ea9866181a4b
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
59c06c3https://github.com/python/cpython/pull/122233/commits/59c06c3dd1a8435e76aa53d43d89ea9866181a4b
https://github.com/python/cpython/tree/59c06c3dd1a8435e76aa53d43d89ea9866181a4b
Add a blurbhttps://github.com/python/cpython/pull/122233/commits/8e7d6f18f97f599326dc8964b5a61d49fd0e6e21
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
8e7d6f1https://github.com/python/cpython/pull/122233/commits/8e7d6f18f97f599326dc8964b5a61d49fd0e6e21
https://github.com/python/cpython/tree/8e7d6f18f97f599326dc8964b5a61d49fd0e6e21
Add the news to 3.13; there's still hope for backportinghttps://github.com/python/cpython/pull/122233/commits/ef65562ecb31be7af25de53de56fc8a27eb08c39
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
ef65562https://github.com/python/cpython/pull/122233/commits/ef65562ecb31be7af25de53de56fc8a27eb08c39
https://github.com/python/cpython/tree/ef65562ecb31be7af25de53de56fc8a27eb08c39
Don't mark up ``True``https://github.com/python/cpython/pull/122233/commits/64dcb445ebad1f59342e51b0d58611985a6f9dcb
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
64dcb44https://github.com/python/cpython/pull/122233/commits/64dcb445ebad1f59342e51b0d58611985a6f9dcb
https://github.com/python/cpython/tree/64dcb445ebad1f59342e51b0d58611985a6f9dcb
Document HeaderWriteErrorhttps://github.com/python/cpython/pull/122233/commits/af4173361d85f6e7c9cdd4164fefda02d7d871b3
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
af41733https://github.com/python/cpython/pull/122233/commits/af4173361d85f6e7c9cdd4164fefda02d7d871b3
https://github.com/python/cpython/tree/af4173361d85f6e7c9cdd4164fefda02d7d871b3
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/122233/commits/596a25b66e10b821148d99098e427ed5734298e0
encukouhttps://github.com/python/cpython/commits?author=encukou
serhiy-storchakahttps://github.com/python/cpython/commits?author=serhiy-storchaka
596a25bhttps://github.com/python/cpython/pull/122233/commits/596a25b66e10b821148d99098e427ed5734298e0
https://github.com/python/cpython/tree/596a25b66e10b821148d99098e427ed5734298e0
Add missing colonhttps://github.com/python/cpython/pull/122233/commits/d7f5fc6499ce6495f8cc85656b1e463ded03a6d5
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
d7f5fc6https://github.com/python/cpython/pull/122233/commits/d7f5fc6499ce6495f8cc85656b1e463ded03a6d5
https://github.com/python/cpython/tree/d7f5fc6499ce6495f8cc85656b1e463ded03a6d5
Only set want_encoding to True; don't reset it to Falsehttps://github.com/python/cpython/pull/122233/commits/a768a812fb87aef95fb12a031f6720a65aaa74f1
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
a768a81https://github.com/python/cpython/pull/122233/commits/a768a812fb87aef95fb12a031f6720a65aaa74f1
https://github.com/python/cpython/tree/a768a812fb87aef95fb12a031f6720a65aaa74f1
Merge branch 'main' into gh-121650-email-newlines-in-headershttps://github.com/python/cpython/pull/122233/commits/eb43fe4f3f985c935a1e0c7dc7178618e3f8f490
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
eb43fe4https://github.com/python/cpython/pull/122233/commits/eb43fe4f3f985c935a1e0c7dc7178618e3f8f490
https://github.com/python/cpython/tree/eb43fe4f3f985c935a1e0c7dc7178618e3f8f490
Update Lib/email/_header_value_parser.pyhttps://github.com/python/cpython/pull/122233/commits/f793b966f801605e56ff06f6b85eac0b8dd4aeea
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/python/cpython/commits?author=serhiy-storchaka
f793b96https://github.com/python/cpython/pull/122233/commits/f793b966f801605e56ff06f6b85eac0b8dd4aeea
https://github.com/python/cpython/tree/f793b966f801605e56ff06f6b85eac0b8dd4aeea
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.