| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/commits(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:065aa2d6-badd-798c-3af2-776287c97ee6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BB8E:3A7693:2D41117:3DC0700:6B005B72 |
| html-safe-nonce | f4afe26c6205090ef5185c32d1ab48d903487470995a3b11605236a7aa39fe1c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjhFOjNBNzY5MzoyRDQxMTE3OjNEQzA3MDA6NkIwMDVCNzIiLCJ2aXNpdG9yX2lkIjoiMzk4NzczMTc5ODczMjg1NjE3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0c087fe4201d29d4098905552e0a21051f1a19594fabc1e3f294c83e7194af80 |
| hovercard-subject-tag | pull_request:1985517043 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/122233/commits |
| twitter:image | https://opengraph.githubassets.com/0e5648c653c4d4125ed6e970e4a91438aadf2646628f69bc94368726c1bd4a34/python/cpython/pull/122233 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0e5648c653c4d4125ed6e970e4a91438aadf2646628f69bc94368726c1bd4a34/python/cpython/pull/122233 |
| og:image:alt | Re: #121812
Hello @basbloemsaat,
I've spent the day reading through the email module, and RFCs, and I believe I found a better place to fix the issue.
This involved lots of experimentation, so ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | encukou |
| hostname | github.com |
| expected-hostname | github.com |
| None | 29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | eacd927ba6112e3b01ba99c762bd699a4a4f5df7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/cpython/pull/122233/commits#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122233%2Fcommits |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122233%2Fcommits |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/122233/commits |
| Reload | https://github.com/python/cpython/pull/122233/commits |
| Reload | https://github.com/python/cpython/pull/122233/commits |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| https://github.com/python/cpython |
| encukou | https://github.com/encukou |
| python:main | https://github.com/python/cpython/tree/main |
| encukou:gh-121650-email-newlines-in-headers | https://github.com/encukou/cpython/tree/gh-121650-email-newlines-in-headers |
| Conversation | https://github.com/python/cpython/pull/122233 |
| Commits12 (12) | https://github.com/python/cpython/pull/122233/commits |
| Checks | https://github.com/python/cpython/pull/122233/checks |
| Files changed | https://github.com/python/cpython/pull/122233/files |
| gh-121650: Encode newlines in headers, and verify headers are sound | https://github.com/python/cpython/pull/122233/commits#top |
| encukou | https://github.com/encukou |
| python:main | https://github.com/python/cpython/tree/main |
| encukou:gh-121650-email-newlines-in-headers | https://github.com/encukou/cpython/tree/gh-121650-email-newlines-in-headers |
| Verify that email headers are well-formed | https://github.com/python/cpython/pull/122233/commits/921cbfd2165abdfe387bc283996ed9cde11f717d |
| https://github.com/encukou |
| encukou | https://github.com/python/cpython/commits?author=encukou |
| 921cbfd | https://github.com/python/cpython/pull/122233/commits/921cbfd2165abdfe387bc283996ed9cde11f717d |
| https://github.com/python/cpython/tree/921cbfd2165abdfe387bc283996ed9cde11f717d |
| Encode header parts that contain newlines | https://github.com/python/cpython/pull/122233/commits/bd7f922f6214364923aa5959ee5d9733f600ce85 |
| encukou | https://github.com/python/cpython/commits?author=encukou |
| basbloemsaat | https://github.com/python/cpython/commits?author=basbloemsaat |
| bd7f922 | https://github.com/python/cpython/pull/122233/commits/bd7f922f6214364923aa5959ee5d9733f600ce85 |
| https://github.com/python/cpython/tree/bd7f922f6214364923aa5959ee5d9733f600ce85 |
| Add tests and documentation | https://github.com/python/cpython/pull/122233/commits/59c06c3dd1a8435e76aa53d43d89ea9866181a4b |
| https://github.com/encukou |
| encukou | https://github.com/python/cpython/commits?author=encukou |
| 59c06c3 | https://github.com/python/cpython/pull/122233/commits/59c06c3dd1a8435e76aa53d43d89ea9866181a4b |
| https://github.com/python/cpython/tree/59c06c3dd1a8435e76aa53d43d89ea9866181a4b |
| Add a blurb | https://github.com/python/cpython/pull/122233/commits/8e7d6f18f97f599326dc8964b5a61d49fd0e6e21 |
| https://github.com/encukou |
| encukou | https://github.com/python/cpython/commits?author=encukou |
| 8e7d6f1 | https://github.com/python/cpython/pull/122233/commits/8e7d6f18f97f599326dc8964b5a61d49fd0e6e21 |
| https://github.com/python/cpython/tree/8e7d6f18f97f599326dc8964b5a61d49fd0e6e21 |
| Add the news to 3.13; there's still hope for backporting | https://github.com/python/cpython/pull/122233/commits/ef65562ecb31be7af25de53de56fc8a27eb08c39 |
| https://github.com/encukou |
| encukou | https://github.com/python/cpython/commits?author=encukou |
| ef65562 | https://github.com/python/cpython/pull/122233/commits/ef65562ecb31be7af25de53de56fc8a27eb08c39 |
| https://github.com/python/cpython/tree/ef65562ecb31be7af25de53de56fc8a27eb08c39 |
| Don't mark up ``True`` | https://github.com/python/cpython/pull/122233/commits/64dcb445ebad1f59342e51b0d58611985a6f9dcb |
| https://github.com/encukou |
| encukou | https://github.com/python/cpython/commits?author=encukou |
| 64dcb44 | https://github.com/python/cpython/pull/122233/commits/64dcb445ebad1f59342e51b0d58611985a6f9dcb |
| https://github.com/python/cpython/tree/64dcb445ebad1f59342e51b0d58611985a6f9dcb |
| Document HeaderWriteError | https://github.com/python/cpython/pull/122233/commits/af4173361d85f6e7c9cdd4164fefda02d7d871b3 |
| https://github.com/encukou |
| encukou | https://github.com/python/cpython/commits?author=encukou |
| af41733 | https://github.com/python/cpython/pull/122233/commits/af4173361d85f6e7c9cdd4164fefda02d7d871b3 |
| https://github.com/python/cpython/tree/af4173361d85f6e7c9cdd4164fefda02d7d871b3 |
| Apply suggestions from code review | https://github.com/python/cpython/pull/122233/commits/596a25b66e10b821148d99098e427ed5734298e0 |
| encukou | https://github.com/python/cpython/commits?author=encukou |
| serhiy-storchaka | https://github.com/python/cpython/commits?author=serhiy-storchaka |
| 596a25b | https://github.com/python/cpython/pull/122233/commits/596a25b66e10b821148d99098e427ed5734298e0 |
| https://github.com/python/cpython/tree/596a25b66e10b821148d99098e427ed5734298e0 |
| Add missing colon | https://github.com/python/cpython/pull/122233/commits/d7f5fc6499ce6495f8cc85656b1e463ded03a6d5 |
| https://github.com/encukou |
| encukou | https://github.com/python/cpython/commits?author=encukou |
| d7f5fc6 | https://github.com/python/cpython/pull/122233/commits/d7f5fc6499ce6495f8cc85656b1e463ded03a6d5 |
| https://github.com/python/cpython/tree/d7f5fc6499ce6495f8cc85656b1e463ded03a6d5 |
| Only set want_encoding to True; don't reset it to False | https://github.com/python/cpython/pull/122233/commits/a768a812fb87aef95fb12a031f6720a65aaa74f1 |
| https://github.com/encukou |
| encukou | https://github.com/python/cpython/commits?author=encukou |
| a768a81 | https://github.com/python/cpython/pull/122233/commits/a768a812fb87aef95fb12a031f6720a65aaa74f1 |
| https://github.com/python/cpython/tree/a768a812fb87aef95fb12a031f6720a65aaa74f1 |
| Merge branch 'main' into gh-121650-email-newlines-in-headers | https://github.com/python/cpython/pull/122233/commits/eb43fe4f3f985c935a1e0c7dc7178618e3f8f490 |
| https://github.com/encukou |
| encukou | https://github.com/python/cpython/commits?author=encukou |
| eb43fe4 | https://github.com/python/cpython/pull/122233/commits/eb43fe4f3f985c935a1e0c7dc7178618e3f8f490 |
| https://github.com/python/cpython/tree/eb43fe4f3f985c935a1e0c7dc7178618e3f8f490 |
| Update Lib/email/_header_value_parser.py | https://github.com/python/cpython/pull/122233/commits/f793b966f801605e56ff06f6b85eac0b8dd4aeea |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/python/cpython/commits?author=serhiy-storchaka |
| f793b96 | https://github.com/python/cpython/pull/122233/commits/f793b966f801605e56ff06f6b85eac0b8dd4aeea |
| https://github.com/python/cpython/tree/f793b966f801605e56ff06f6b85eac0b8dd4aeea |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |