René's URL Explorer Experiment


Title: gh-122179: Fix hashlib.file_digest and non-blocking I/O by srittau · Pull Request #122183 · python/cpython · GitHub

Open Graph Title: gh-122179: Fix hashlib.file_digest and non-blocking I/O by srittau · Pull Request #122183 · python/cpython

X Title: gh-122179: Fix hashlib.file_digest and non-blocking I/O by srittau · Pull Request #122183 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Issue: hashlib.file_digest() can't handle non-blocking I/O #122179

X Description: Issue: hashlib.file_digest() can't handle non-blocking I/O #122179

Opengraph URL: https://github.com/python/cpython/pull/122183

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1a560cf5-aede-9bf8-f36f-68bc9e281b3a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9348:1DF7D7:82B0C:B63D0:6B005151
html-safe-nonceaad78f6f53794ee8bf9e033d06f03e332cad52b3bcc5293deb3f7116140a9042
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzQ4OjFERjdENzo4MkIwQzpCNjNEMDo2QjAwNTE1MSIsInZpc2l0b3JfaWQiOiIzODY1NDg4MjU0ODcwNTA3ODU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca72c53d04c120bf3219dba2b25b0f67e4782034cb0387f524a1fee4a708160d3
hovercard-subject-tagpull_request:1983635942
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/122183/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1a7affa353967890ffe436bf118d5842371fce048e12ce94e4ded1b61df8b035/python/cpython/pull/122183
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1a7affa353967890ffe436bf118d5842371fce048e12ce94e4ded1b61df8b035/python/cpython/pull/122183
og:image:altIssue: hashlib.file_digest() can't handle non-blocking I/O #122179
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesrittau
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/122183#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122183
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122183
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/122183
Reloadhttps://github.com/python/cpython/pull/122183
Reloadhttps://github.com/python/cpython/pull/122183
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
srittau:file-digest-readintohttps://github.com/srittau/cpython/tree/file-digest-readinto
Conversationhttps://github.com/python/cpython/pull/122183
Commits6 (6)https://github.com/python/cpython/pull/122183/commits
Checkshttps://github.com/python/cpython/pull/122183/checks
Files changedhttps://github.com/python/cpython/pull/122183/files
gh-122179: Fix hashlib.file_digest and non-blocking I/Ohttps://github.com/python/cpython/pull/122183#top
gpsheadhttps://github.com/gpshead
python:mainhttps://github.com/python/cpython/tree/main
srittau:file-digest-readintohttps://github.com/srittau/cpython/tree/file-digest-readinto
https://github.com/srittau
srittauhttps://github.com/srittau
Jul 23, 2024https://github.com/python/cpython/pull/122183#issue-2425540454
Please reload this pagehttps://github.com/python/cpython/pull/122183
hashlib.file_digest() can't handle non-blocking I/O #122179https://github.com/python/cpython/issues/122179
Please reload this pagehttps://github.com/python/cpython/pull/122183
https://github.com/srittau
Fix hashlib.file_digest and non-blocking I/Ohttps://github.com/python/cpython/pull/122183/commits/b7a1e6e73834dc8ca6e40f55b3787a0ba9d150b1
b7a1e6ehttps://github.com/python/cpython/pull/122183/commits/b7a1e6e73834dc8ca6e40f55b3787a0ba9d150b1
https://github.com/srittau
srittauhttps://github.com/srittau
gpsheadhttps://github.com/gpshead
tiranhttps://github.com/tiran
code ownershttps://github.com/python/cpython/blob/2c1b1e7a07eba0138b9858c6f2bea3cae9af0808/.github/CODEOWNERS#L86
July 23, 2024 15:46https://github.com/python/cpython/pull/122183#event-13617947936
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 23, 2024 https://github.com/python/cpython/pull/122183#ref-issue-2425364066
hashlib.file_digest() can't handle non-blocking I/O #122179 https://github.com/python/cpython/issues/122179
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jul 23, 2024https://github.com/python/cpython/pull/122183#event-13617949171
https://github.com/srittau
Remove trailing spacehttps://github.com/python/cpython/pull/122183/commits/d571850fd03417c97efaa04375a575876c7ec90a
d571850https://github.com/python/cpython/pull/122183/commits/d571850fd03417c97efaa04375a575876c7ec90a
https://github.com/srittau
srittauhttps://github.com/srittau
Jul 23, 2024https://github.com/python/cpython/pull/122183#issuecomment-2245619975
Please reload this pagehttps://github.com/python/cpython/pull/122183
https://github.com/Zheaoli
Zheaolihttps://github.com/Zheaoli
Jul 23, 2024 https://github.com/python/cpython/pull/122183#pullrequestreview-2194549227
View reviewed changes https://github.com/python/cpython/pull/122183/files/d571850fd03417c97efaa04375a575876c7ec90a
Lib/hashlib.pyhttps://github.com/python/cpython/pull/122183/files/d571850fd03417c97efaa04375a575876c7ec90a#diff-7b5c7281635ea9d475e73fab120a94e42f591eae502af924184140acab4cc189
Please reload this pagehttps://github.com/python/cpython/pull/122183
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
Jul 23, 2024 https://github.com/python/cpython/pull/122183#pullrequestreview-2195126260
View reviewed changes https://github.com/python/cpython/pull/122183/files/d571850fd03417c97efaa04375a575876c7ec90a
Lib/test/test_hashlib.pyhttps://github.com/python/cpython/pull/122183/files/d571850fd03417c97efaa04375a575876c7ec90a#diff-b19facaf857653d4f07afbb090181f595ef4c9381f2abcd2917abd4f3529e8fe
Please reload this pagehttps://github.com/python/cpython/pull/122183
srittauhttps://github.com/srittau
August 1, 2024 17:43https://github.com/python/cpython/pull/122183#commits-pushed-5669cce
https://github.com/srittau
Add documentation around this behaviorhttps://github.com/python/cpython/pull/122183/commits/5669cce42111b0ec0a44f213794cf7123e392472
5669ccehttps://github.com/python/cpython/pull/122183/commits/5669cce42111b0ec0a44f213794cf7123e392472
https://github.com/srittau
Merge branch 'main' into file-digest-readintohttps://github.com/python/cpython/pull/122183/commits/d4b385fff22fa428e37b06f0b49f1af1b451fe2b
d4b385fhttps://github.com/python/cpython/pull/122183/commits/d4b385fff22fa428e37b06f0b49f1af1b451fe2b
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
Feb 27, 2025 https://github.com/python/cpython/pull/122183#pullrequestreview-2648785359
View reviewed changes https://github.com/python/cpython/pull/122183/files/218fd357065556030f1609c73b3db14d6928c61d
cmaloneyhttps://github.com/cmaloney
https://github.com/python/cpython/pull/122183#pullrequestreview-2648785359
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/122183
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 27, 2025https://github.com/python/cpython/pull/122183#event-16501797002
https://github.com/srittau
Merge branch 'main' into file-digest-readintohttps://github.com/python/cpython/pull/122183/commits/218fd357065556030f1609c73b3db14d6928c61d
218fd35https://github.com/python/cpython/pull/122183/commits/218fd357065556030f1609c73b3db14d6928c61d
https://github.com/picnixz
picnixzhttps://github.com/picnixz
April 14, 2025 09:51https://github.com/python/cpython/pull/122183#event-17245734917
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Apr 14, 2025 https://github.com/python/cpython/pull/122183#pullrequestreview-2763796950
View reviewed changes https://github.com/python/cpython/pull/122183/files/218fd357065556030f1609c73b3db14d6928c61d
picnixzhttps://github.com/picnixz
https://github.com/python/cpython/pull/122183#pullrequestreview-2763796950
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/122183
Doc/library/hashlib.rsthttps://github.com/python/cpython/pull/122183/files/218fd357065556030f1609c73b3db14d6928c61d#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
Please reload this pagehttps://github.com/python/cpython/pull/122183
Lib/test/test_hashlib.pyhttps://github.com/python/cpython/pull/122183/files/d571850fd03417c97efaa04375a575876c7ec90a#diff-b19facaf857653d4f07afbb090181f595ef4c9381f2abcd2917abd4f3529e8fe
Please reload this pagehttps://github.com/python/cpython/pull/122183
https://github.com/srittau
Add versionchangedhttps://github.com/python/cpython/pull/122183/commits/612f7d43f0c9d3332953f44c1392b0a682234ffd
612f7d4https://github.com/python/cpython/pull/122183/commits/612f7d43f0c9d3332953f44c1392b0a682234ffd
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Apr 21, 2025 https://github.com/python/cpython/pull/122183#pullrequestreview-2782256228
View reviewed changes https://github.com/python/cpython/pull/122183/files/612f7d43f0c9d3332953f44c1392b0a682234ffd
Lib/hashlib.pyhttps://github.com/python/cpython/pull/122183/files/d571850fd03417c97efaa04375a575876c7ec90a#diff-7b5c7281635ea9d475e73fab120a94e42f591eae502af924184140acab4cc189
Please reload this pagehttps://github.com/python/cpython/pull/122183
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 21, 2025https://github.com/python/cpython/pull/122183#event-17343603644
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Apr 21, 2025https://github.com/python/cpython/pull/122183#event-17343606810
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
2b47f46https://github.com/python/cpython/commit/2b47f46d7dc30d27b2486991fea4acd83553294b
Apr 21, 2025https://github.com/python/cpython/pull/122183#event-17343619802
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Apr 21, 2025https://github.com/python/cpython/pull/122183#issuecomment-2819519620
@srittauhttps://github.com/srittau
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/122183
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 21, 2025https://github.com/python/cpython/pull/122183#event-17343620481
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Apr 21, 2025https://github.com/python/cpython/pull/122183#issuecomment-2819519687
@srittauhttps://github.com/srittau
@gpsheadhttps://github.com/gpshead
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/122183
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
gpsheadhttps://github.com/gpshead
Apr 21, 2025https://github.com/python/cpython/pull/122183#event-17343621158
gpsheadhttps://github.com/gpshead
Apr 21, 2025 https://github.com/python/cpython/pull/122183#ref-commit-cdabbc1
https://github.com/gpshead
https://github.com/srittau
[3.13]https://github.com/python/cpython/commit/cdabbc126fb16420903166ad788d39e01230c966
gh-122179https://github.com/python/cpython/issues/122179
: Fix hashlib.file_digest and non-blocking I/O (https://github.com/python/cpython/commit/cdabbc126fb16420903166ad788d39e01230c966
GH-13…https://github.com/python/cpython/pull/132787
cdabbc1https://github.com/python/cpython/commit/cdabbc126fb16420903166ad788d39e01230c966
…2787https://github.com/python/cpython/pull/132787
gh-122179https://github.com/python/cpython/issues/122179
GH-122183https://github.com/python/cpython/pull/122183
2b47f46https://github.com/python/cpython/commit/2b47f46d7dc30d27b2486991fea4acd83553294b
https://github.com/srittau
srittauhttps://github.com/srittau
April 21, 2025 22:35https://github.com/python/cpython/pull/122183#event-17344269855
https://github.com/hugovk
hugovkhttps://github.com/hugovk
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
May 20, 2025https://github.com/python/cpython/pull/122183#event-17730844133
https://github.com/moreati
moreatihttps://github.com/moreati
Oct 2, 2025 https://github.com/python/cpython/pull/122183#pullrequestreview-3293685777
View reviewed changes https://github.com/python/cpython/pull/122183/files/612f7d43f0c9d3332953f44c1392b0a682234ffd
Doc/library/hashlib.rsthttps://github.com/python/cpython/pull/122183/files/612f7d43f0c9d3332953f44c1392b0a682234ffd#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
moreatihttps://github.com/moreati
Oct 2, 2025https://github.com/python/cpython/pull/122183#discussion_r2398091513
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/122183
cmaloneyhttps://github.com/cmaloney
Oct 2, 2025https://github.com/python/cpython/pull/122183#discussion_r2398149530
Please reload this pagehttps://github.com/python/cpython/pull/122183
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
.readintohttps://docs.python.org/3/library/io.html#io.RawIOBase.readinto
Please reload this pagehttps://github.com/python/cpython/pull/122183
moreatihttps://github.com/moreati
Oct 2, 2025https://github.com/python/cpython/pull/122183#discussion_r2398169781
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/122183
https://github.com/moreati
moreatihttps://github.com/moreati
Oct 2, 2025 https://github.com/python/cpython/pull/122183#ref-issue-3476996352
[docs] incorrect BlockingIOError pre-condition in versionchanged note of hashlib.file_digest() #139495 https://github.com/python/cpython/issues/139495
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F122183
https://github.com/cmaloney
cmaloney https://github.com/cmaloney
https://github.com/python/cpython/pull/122183/files/612f7d43f0c9d3332953f44c1392b0a682234ffd
https://github.com/picnixz
picnixz https://github.com/picnixz
https://github.com/python/cpython/pull/122183/files/218fd357065556030f1609c73b3db14d6928c61d
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/122183/files/612f7d43f0c9d3332953f44c1392b0a682234ffd
https://github.com/tiran
tiran https://github.com/tiran
https://github.com/moreati
moreati https://github.com/moreati
https://github.com/python/cpython/pull/122183/files/612f7d43f0c9d3332953f44c1392b0a682234ffd
https://github.com/Zheaoli
Zheaoli https://github.com/Zheaoli
https://github.com/python/cpython/pull/122183/files/d571850fd03417c97efaa04375a575876c7ec90a
Please reload this pagehttps://github.com/python/cpython/pull/122183
https://github.com/gpshead
gpshead https://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/122183
https://github.com/srittau
https://github.com/gpshead
https://github.com/moreati
https://github.com/cmaloney
https://github.com/Zheaoli
https://github.com/picnixz
https://github.com/hugovk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.