| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7e6e5931-2616-2238-f1e8-2c73ed453729 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AC28:F3929:19C725:22C2E8:6B006562 |
| html-safe-nonce | 9443f78a03a26158075b2e0eca86819a97884210f330e06d3f7a37479df1ec7a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzI4OkYzOTI5OjE5QzcyNToyMkMyRTg6NkIwMDY1NjIiLCJ2aXNpdG9yX2lkIjoiNDIwMTIyOTYyNzk3MDA1MzQ3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 186e981f91a6df6d7db3a734d7a601ed39fa1f04c90cfa7159b5a826a1eb71f3 |
| hovercard-subject-tag | pull_request:1970120992 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/121812/files |
| twitter:image | https://avatars.githubusercontent.com/u/1586868?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1586868?s=400&v=4 |
| og:image:alt | @encukou as promised, the fix for this issue.
This PR fixes both issues addressed in the issue, both the newlines at the end as well as the encoded newlines.
As this has security implication, it ma... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 25854482a1773a7c1ebb8be3d2bc1c6e61d82d78126be63b5044474a86d44d9e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e4f5c239e31f1f680e6bbc419ff92d774da616ec |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/121812/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121812%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121812%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/121812/files |
| Reload | https://github.com/python/cpython/pull/121812/files |
| Reload | https://github.com/python/cpython/pull/121812/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| basbloemsaat | https://github.com/basbloemsaat |
| python:main | https://github.com/python/cpython/tree/main |
|
Conversation
14
| https://github.com/python/cpython/pull/121812 |
|
Commits
12
| https://github.com/python/cpython/pull/121812/commits |
|
Checks
0
| https://github.com/python/cpython/pull/121812/checks |
|
Files changed
| https://github.com/python/cpython/pull/121812/files |
| Please reload this page | https://github.com/python/cpython/pull/121812/files |
|
gh-121650 : detect newlines in headers
| https://github.com/python/cpython/pull/121812/files#top |
|
Show all changes
12 commits
| https://github.com/python/cpython/pull/121812/files |
|
d3ca18a
detect line splits, also at the end
basbloemsaat Jul 14, 2024
| https://github.com/python/cpython/pull/121812/commits/d3ca18a98e6876811a6dab9a23af15862e37466d |
|
891d4f8
also detect encoded newlines
basbloemsaat Jul 15, 2024
| https://github.com/python/cpython/pull/121812/commits/891d4f8d5d6d11ab4273431996542a07429fd145 |
|
67d4121
Merge branch 'main' into fix-issue-121650-detect-newlines-in-headers
basbloemsaat Jul 15, 2024
| https://github.com/python/cpython/pull/121812/commits/67d412194e6b2ecc80466ad283ca6960ed83aef9 |
|
62ceb40
Update Lib/email/policy.py
basbloemsaat Jul 16, 2024
| https://github.com/python/cpython/pull/121812/commits/62ceb4089683a8182d590cd9e38ff8e8bc7a15b6 |
|
aa4fd24
Update Misc/NEWS.d/next/Library/2024-07-15-21-43-38.gh-issue-121650.A…
basbloemsaat Jul 16, 2024
| https://github.com/python/cpython/pull/121812/commits/aa4fd24dc7179d147e8e8cabdd4a50caf82f6be8 |
|
23fdf74
also check parsed headers for newlines and returns
basbloemsaat Jul 16, 2024
| https://github.com/python/cpython/pull/121812/commits/23fdf74761707639c59003fc15d85bd5b40550a9 |
|
d210941
More specific update blurb
basbloemsaat Jul 16, 2024
| https://github.com/python/cpython/pull/121812/commits/d2109413c52c3f18b5ee8b15bd6247cec393911e |
|
118c709
Merge branch 'main' into fix-issue-121650-detect-newlines-in-headers
basbloemsaat Jul 16, 2024
| https://github.com/python/cpython/pull/121812/commits/118c709a89bab255b46e8abc7d8d031223432ff8 |
|
08e5fe1
Merge branch 'main' into fix-issue-121650-detect-newlines-in-headers
basbloemsaat Jul 19, 2024
| https://github.com/python/cpython/pull/121812/commits/08e5fe16f86693da98079ca66bc9220f10478747 |
|
c5e9264
Merge branch 'fix-issue-121650-detect-newlines-in-headers' of github.…
basbloemsaat Jul 19, 2024
| https://github.com/python/cpython/pull/121812/commits/c5e9264dca68b6c43ce9a9fa675911d269d1a180 |
|
5a163b5
check all headers for newlines
basbloemsaat Jul 19, 2024
| https://github.com/python/cpython/pull/121812/commits/5a163b54833062dccc3db0019feb612af028ccea |
|
0efe290
Merge branch 'main' into fix-issue-121650-detect-newlines-in-headers
basbloemsaat Jul 22, 2024
| https://github.com/python/cpython/pull/121812/commits/0efe2900ab136e2f3273137a08c3d0477795ef6e |
|
Clear filters
| https://github.com/python/cpython/pull/121812/files |
| Please reload this page | https://github.com/python/cpython/pull/121812/files |
| Please reload this page | https://github.com/python/cpython/pull/121812/files |
|
policy.py
| https://github.com/python/cpython/pull/121812/files#diff-822b8571646f0dbd32f38e0a6e4ad11a9166f13e1802c1c0a4fb98782c8ffaea |
|
test_policy.py
| https://github.com/python/cpython/pull/121812/files#diff-28c8506700752b35e5100aa83721a7d5968f7a1db805e57035acc76412fce712 |
|
2024-07-15-21-43-38.gh-issue-121650.A0FkCh.rst
| https://github.com/python/cpython/pull/121812/files#diff-950b01de0f90cb334aace5c655c8b5926383051022c0c67e571dbac5c2e5fe42 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L448 |
| Lib/email/policy.py | https://github.com/python/cpython/pull/121812/files#diff-822b8571646f0dbd32f38e0a6e4ad11a9166f13e1802c1c0a4fb98782c8ffaea |
|
View file
| https://github.com/python/cpython/blob/0efe2900ab136e2f3273137a08c3d0477795ef6e/Lib/email/policy.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/121812/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/121812/files#diff-822b8571646f0dbd32f38e0a6e4ad11a9166f13e1802c1c0a4fb98782c8ffaea |
|
| https://github.com/python/cpython/pull/121812/files#diff-822b8571646f0dbd32f38e0a6e4ad11a9166f13e1802c1c0a4fb98782c8ffaea |
|
| https://github.com/python/cpython/pull/121812/files#diff-822b8571646f0dbd32f38e0a6e4ad11a9166f13e1802c1c0a4fb98782c8ffaea |
|
| https://github.com/python/cpython/pull/121812/files#diff-822b8571646f0dbd32f38e0a6e4ad11a9166f13e1802c1c0a4fb98782c8ffaea |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L448 |
| Lib/test/test_email/test_policy.py | https://github.com/python/cpython/pull/121812/files#diff-28c8506700752b35e5100aa83721a7d5968f7a1db805e57035acc76412fce712 |
|
View file
| https://github.com/python/cpython/blob/0efe2900ab136e2f3273137a08c3d0477795ef6e/Lib/test/test_email/test_policy.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/121812/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/121812/files#diff-28c8506700752b35e5100aa83721a7d5968f7a1db805e57035acc76412fce712 |
| Misc/NEWS.d/next/Library/2024-07-15-21-43-38.gh-issue-121650.A0FkCh.rst | https://github.com/python/cpython/pull/121812/files#diff-950b01de0f90cb334aace5c655c8b5926383051022c0c67e571dbac5c2e5fe42 |
|
View file
| https://github.com/python/cpython/blob/0efe2900ab136e2f3273137a08c3d0477795ef6e/Misc/NEWS.d/next/Library/2024-07-15-21-43-38.gh-issue-121650.A0FkCh.rst |
|
Open in desktop
| https://desktop.github.com |
| Please reload this page | https://github.com/python/cpython/pull/121812/files |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/121812/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |