René's URL Explorer Experiment


Title: gh-121650 : detect newlines in headers by basbloemsaat · Pull Request #121812 · python/cpython · GitHub

Open Graph Title: gh-121650 : detect newlines in headers by basbloemsaat · Pull Request #121812 · python/cpython

X Title: gh-121650 : detect newlines in headers by basbloemsaat · Pull Request #121812 · python/cpython

Description: @encukou as promised, the fix for this issue. This PR fixes both issues addressed in the issue, both the newlines at the end as well as the encoded newlines. As this has security implication, it may need to be backported as well. Issue: gh-121650

Open Graph Description: @encukou as promised, the fix for this issue. This PR fixes both issues addressed in the issue, both the newlines at the end as well as the encoded newlines. As this has security implication, it ma...

X Description: @encukou as promised, the fix for this issue. This PR fixes both issues addressed in the issue, both the newlines at the end as well as the encoded newlines. As this has security implication, it ma...

Opengraph URL: https://github.com/python/cpython/pull/121812

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7e6e5931-2616-2238-f1e8-2c73ed453729
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC28:F3929:19C725:22C2E8:6B006562
html-safe-nonce9443f78a03a26158075b2e0eca86819a97884210f330e06d3f7a37479df1ec7a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzI4OkYzOTI5OjE5QzcyNToyMkMyRTg6NkIwMDY1NjIiLCJ2aXNpdG9yX2lkIjoiNDIwMTIyOTYyNzk3MDA1MzQ3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac186e981f91a6df6d7db3a734d7a601ed39fa1f04c90cfa7159b5a826a1eb71f3
hovercard-subject-tagpull_request:1970120992
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/121812/files
twitter:imagehttps://avatars.githubusercontent.com/u/1586868?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1586868?s=400&v=4
og:image:alt@encukou as promised, the fix for this issue. This PR fixes both issues addressed in the issue, both the newlines at the end as well as the encoded newlines. As this has security implication, it ma...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None25854482a1773a7c1ebb8be3d2bc1c6e61d82d78126be63b5044474a86d44d9e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4f5c239e31f1f680e6bbc419ff92d774da616ec
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/121812/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121812%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121812%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/121812/files
Reloadhttps://github.com/python/cpython/pull/121812/files
Reloadhttps://github.com/python/cpython/pull/121812/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
basbloemsaathttps://github.com/basbloemsaat
python:mainhttps://github.com/python/cpython/tree/main
Conversation 14 https://github.com/python/cpython/pull/121812
Commits 12 https://github.com/python/cpython/pull/121812/commits
Checks 0 https://github.com/python/cpython/pull/121812/checks
Files changed https://github.com/python/cpython/pull/121812/files
Please reload this pagehttps://github.com/python/cpython/pull/121812/files
gh-121650 : detect newlines in headers https://github.com/python/cpython/pull/121812/files#top
Show all changes 12 commits https://github.com/python/cpython/pull/121812/files
d3ca18a detect line splits, also at the end basbloemsaat Jul 14, 2024 https://github.com/python/cpython/pull/121812/commits/d3ca18a98e6876811a6dab9a23af15862e37466d
891d4f8 also detect encoded newlines basbloemsaat Jul 15, 2024 https://github.com/python/cpython/pull/121812/commits/891d4f8d5d6d11ab4273431996542a07429fd145
67d4121 Merge branch 'main' into fix-issue-121650-detect-newlines-in-headers basbloemsaat Jul 15, 2024 https://github.com/python/cpython/pull/121812/commits/67d412194e6b2ecc80466ad283ca6960ed83aef9
62ceb40 Update Lib/email/policy.py basbloemsaat Jul 16, 2024 https://github.com/python/cpython/pull/121812/commits/62ceb4089683a8182d590cd9e38ff8e8bc7a15b6
aa4fd24 Update Misc/NEWS.d/next/Library/2024-07-15-21-43-38.gh-issue-121650.A… basbloemsaat Jul 16, 2024 https://github.com/python/cpython/pull/121812/commits/aa4fd24dc7179d147e8e8cabdd4a50caf82f6be8
23fdf74 also check parsed headers for newlines and returns basbloemsaat Jul 16, 2024 https://github.com/python/cpython/pull/121812/commits/23fdf74761707639c59003fc15d85bd5b40550a9
d210941 More specific update blurb basbloemsaat Jul 16, 2024 https://github.com/python/cpython/pull/121812/commits/d2109413c52c3f18b5ee8b15bd6247cec393911e
118c709 Merge branch 'main' into fix-issue-121650-detect-newlines-in-headers basbloemsaat Jul 16, 2024 https://github.com/python/cpython/pull/121812/commits/118c709a89bab255b46e8abc7d8d031223432ff8
08e5fe1 Merge branch 'main' into fix-issue-121650-detect-newlines-in-headers basbloemsaat Jul 19, 2024 https://github.com/python/cpython/pull/121812/commits/08e5fe16f86693da98079ca66bc9220f10478747
c5e9264 Merge branch 'fix-issue-121650-detect-newlines-in-headers' of github.… basbloemsaat Jul 19, 2024 https://github.com/python/cpython/pull/121812/commits/c5e9264dca68b6c43ce9a9fa675911d269d1a180
5a163b5 check all headers for newlines basbloemsaat Jul 19, 2024 https://github.com/python/cpython/pull/121812/commits/5a163b54833062dccc3db0019feb612af028ccea
0efe290 Merge branch 'main' into fix-issue-121650-detect-newlines-in-headers basbloemsaat Jul 22, 2024 https://github.com/python/cpython/pull/121812/commits/0efe2900ab136e2f3273137a08c3d0477795ef6e
Clear filters https://github.com/python/cpython/pull/121812/files
Please reload this pagehttps://github.com/python/cpython/pull/121812/files
Please reload this pagehttps://github.com/python/cpython/pull/121812/files
policy.py https://github.com/python/cpython/pull/121812/files#diff-822b8571646f0dbd32f38e0a6e4ad11a9166f13e1802c1c0a4fb98782c8ffaea
test_policy.py https://github.com/python/cpython/pull/121812/files#diff-28c8506700752b35e5100aa83721a7d5968f7a1db805e57035acc76412fce712
2024-07-15-21-43-38.gh-issue-121650.A0FkCh.rst https://github.com/python/cpython/pull/121812/files#diff-950b01de0f90cb334aace5c655c8b5926383051022c0c67e571dbac5c2e5fe42
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L448
Lib/email/policy.pyhttps://github.com/python/cpython/pull/121812/files#diff-822b8571646f0dbd32f38e0a6e4ad11a9166f13e1802c1c0a4fb98782c8ffaea
View file https://github.com/python/cpython/blob/0efe2900ab136e2f3273137a08c3d0477795ef6e/Lib/email/policy.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/121812/{{ revealButtonHref }}
https://github.com/python/cpython/pull/121812/files#diff-822b8571646f0dbd32f38e0a6e4ad11a9166f13e1802c1c0a4fb98782c8ffaea
https://github.com/python/cpython/pull/121812/files#diff-822b8571646f0dbd32f38e0a6e4ad11a9166f13e1802c1c0a4fb98782c8ffaea
https://github.com/python/cpython/pull/121812/files#diff-822b8571646f0dbd32f38e0a6e4ad11a9166f13e1802c1c0a4fb98782c8ffaea
https://github.com/python/cpython/pull/121812/files#diff-822b8571646f0dbd32f38e0a6e4ad11a9166f13e1802c1c0a4fb98782c8ffaea
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L448
Lib/test/test_email/test_policy.pyhttps://github.com/python/cpython/pull/121812/files#diff-28c8506700752b35e5100aa83721a7d5968f7a1db805e57035acc76412fce712
View file https://github.com/python/cpython/blob/0efe2900ab136e2f3273137a08c3d0477795ef6e/Lib/test/test_email/test_policy.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/121812/{{ revealButtonHref }}
https://github.com/python/cpython/pull/121812/files#diff-28c8506700752b35e5100aa83721a7d5968f7a1db805e57035acc76412fce712
Misc/NEWS.d/next/Library/2024-07-15-21-43-38.gh-issue-121650.A0FkCh.rsthttps://github.com/python/cpython/pull/121812/files#diff-950b01de0f90cb334aace5c655c8b5926383051022c0c67e571dbac5c2e5fe42
View file https://github.com/python/cpython/blob/0efe2900ab136e2f3273137a08c3d0477795ef6e/Misc/NEWS.d/next/Library/2024-07-15-21-43-38.gh-issue-121650.A0FkCh.rst
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/python/cpython/pull/121812/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/121812/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.