| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/commits(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:3026d302-c34d-ed48-dd60-a9096e93a6f6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8E44:31F9AC:A100E:E00E5:6B00623F |
| html-safe-nonce | cf9070d22b6b33b68c1d34808fe82c84bb73827d4b0646e412a83d30da8f9dcd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTQ0OjMxRjlBQzpBMTAwRTpFMDBFNTo2QjAwNjIzRiIsInZpc2l0b3JfaWQiOiI4MTAyODExMzIxNjE3MTEzNjYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b04b04c31aa0c542030ad0c0e6ae65c68b38ccdf7a657b9e415ef71e9e8e8548 |
| hovercard-subject-tag | pull_request:1970120992 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/121812/commits |
| twitter:image | https://opengraph.githubassets.com/6e4643b84207f72a249d322a3497683a5f7afad66118c72069b906a462669677/python/cpython/pull/121812 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6e4643b84207f72a249d322a3497683a5f7afad66118c72069b906a462669677/python/cpython/pull/121812 |
| og:image:alt | @encukou as promised, the fix for this issue.
This PR fixes both issues addressed in the issue, both the newlines at the end as well as the encoded newlines.
As this has security implication, it ma... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | basbloemsaat |
| hostname | github.com |
| expected-hostname | github.com |
| None | 25854482a1773a7c1ebb8be3d2bc1c6e61d82d78126be63b5044474a86d44d9e |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e4f5c239e31f1f680e6bbc419ff92d774da616ec |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/cpython/pull/121812/commits#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121812%2Fcommits |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121812%2Fcommits |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/121812/commits |
| Reload | https://github.com/python/cpython/pull/121812/commits |
| Reload | https://github.com/python/cpython/pull/121812/commits |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| https://github.com/python/cpython |
| basbloemsaat | https://github.com/basbloemsaat |
| python:main | https://github.com/python/cpython/tree/main |
| Conversation | https://github.com/python/cpython/pull/121812 |
| Commits12 (12) | https://github.com/python/cpython/pull/121812/commits |
| Checks | https://github.com/python/cpython/pull/121812/checks |
| Files changed | https://github.com/python/cpython/pull/121812/files |
| gh-121650 : detect newlines in headers | https://github.com/python/cpython/pull/121812/commits#top |
| basbloemsaat | https://github.com/basbloemsaat |
| python:main | https://github.com/python/cpython/tree/main |
| detect line splits, also at the end | https://github.com/python/cpython/pull/121812/commits/d3ca18a98e6876811a6dab9a23af15862e37466d |
| https://github.com/basbloemsaat |
| basbloemsaat | https://github.com/python/cpython/commits?author=basbloemsaat |
| d3ca18a | https://github.com/python/cpython/pull/121812/commits/d3ca18a98e6876811a6dab9a23af15862e37466d |
| https://github.com/python/cpython/tree/d3ca18a98e6876811a6dab9a23af15862e37466d |
| also detect encoded newlines | https://github.com/python/cpython/pull/121812/commits/891d4f8d5d6d11ab4273431996542a07429fd145 |
| https://github.com/basbloemsaat |
| basbloemsaat | https://github.com/python/cpython/commits?author=basbloemsaat |
| 891d4f8 | https://github.com/python/cpython/pull/121812/commits/891d4f8d5d6d11ab4273431996542a07429fd145 |
| https://github.com/python/cpython/tree/891d4f8d5d6d11ab4273431996542a07429fd145 |
| Merge branch 'main' into fix-issue-121650-detect-newlines-in-headers | https://github.com/python/cpython/pull/121812/commits/67d412194e6b2ecc80466ad283ca6960ed83aef9 |
| https://github.com/basbloemsaat |
| basbloemsaat | https://github.com/python/cpython/commits?author=basbloemsaat |
| 67d4121 | https://github.com/python/cpython/pull/121812/commits/67d412194e6b2ecc80466ad283ca6960ed83aef9 |
| https://github.com/python/cpython/tree/67d412194e6b2ecc80466ad283ca6960ed83aef9 |
| Update Lib/email/policy.py | https://github.com/python/cpython/pull/121812/commits/62ceb4089683a8182d590cd9e38ff8e8bc7a15b6 |
| basbloemsaat | https://github.com/python/cpython/commits?author=basbloemsaat |
| ZeroIntensity | https://github.com/python/cpython/commits?author=ZeroIntensity |
| 62ceb40 | https://github.com/python/cpython/pull/121812/commits/62ceb4089683a8182d590cd9e38ff8e8bc7a15b6 |
| https://github.com/python/cpython/tree/62ceb4089683a8182d590cd9e38ff8e8bc7a15b6 |
| Update Misc/NEWS.d/next/Library/2024-07-15-21-43-38.gh-issue-121650.A0FkCh.rst | https://github.com/python/cpython/pull/121812/commits/aa4fd24dc7179d147e8e8cabdd4a50caf82f6be8 |
| basbloemsaat | https://github.com/python/cpython/commits?author=basbloemsaat |
| ZeroIntensity | https://github.com/python/cpython/commits?author=ZeroIntensity |
| aa4fd24 | https://github.com/python/cpython/pull/121812/commits/aa4fd24dc7179d147e8e8cabdd4a50caf82f6be8 |
| https://github.com/python/cpython/tree/aa4fd24dc7179d147e8e8cabdd4a50caf82f6be8 |
| also check parsed headers for newlines and returns | https://github.com/python/cpython/pull/121812/commits/23fdf74761707639c59003fc15d85bd5b40550a9 |
| https://github.com/basbloemsaat |
| basbloemsaat | https://github.com/python/cpython/commits?author=basbloemsaat |
| 23fdf74 | https://github.com/python/cpython/pull/121812/commits/23fdf74761707639c59003fc15d85bd5b40550a9 |
| https://github.com/python/cpython/tree/23fdf74761707639c59003fc15d85bd5b40550a9 |
| More specific update blurb | https://github.com/python/cpython/pull/121812/commits/d2109413c52c3f18b5ee8b15bd6247cec393911e |
| https://github.com/basbloemsaat |
| basbloemsaat | https://github.com/python/cpython/commits?author=basbloemsaat |
| d210941 | https://github.com/python/cpython/pull/121812/commits/d2109413c52c3f18b5ee8b15bd6247cec393911e |
| https://github.com/python/cpython/tree/d2109413c52c3f18b5ee8b15bd6247cec393911e |
| Merge branch 'main' into fix-issue-121650-detect-newlines-in-headers | https://github.com/python/cpython/pull/121812/commits/118c709a89bab255b46e8abc7d8d031223432ff8 |
| https://github.com/basbloemsaat |
| basbloemsaat | https://github.com/python/cpython/commits?author=basbloemsaat |
| 118c709 | https://github.com/python/cpython/pull/121812/commits/118c709a89bab255b46e8abc7d8d031223432ff8 |
| https://github.com/python/cpython/tree/118c709a89bab255b46e8abc7d8d031223432ff8 |
| Merge branch 'main' into fix-issue-121650-detect-newlines-in-headers | https://github.com/python/cpython/pull/121812/commits/08e5fe16f86693da98079ca66bc9220f10478747 |
| https://github.com/basbloemsaat |
| basbloemsaat | https://github.com/python/cpython/commits?author=basbloemsaat |
| 08e5fe1 | https://github.com/python/cpython/pull/121812/commits/08e5fe16f86693da98079ca66bc9220f10478747 |
| https://github.com/python/cpython/tree/08e5fe16f86693da98079ca66bc9220f10478747 |
| Merge branch 'fix-issue-121650-detect-newlines-in-headers' of github.com:basbloemsaat/cpython into fix-issue-121650-detect-newlines-in-headers | https://github.com/python/cpython/pull/121812/commits/c5e9264dca68b6c43ce9a9fa675911d269d1a180 |
| https://github.com/basbloemsaat |
| basbloemsaat | https://github.com/python/cpython/commits?author=basbloemsaat |
| c5e9264 | https://github.com/python/cpython/pull/121812/commits/c5e9264dca68b6c43ce9a9fa675911d269d1a180 |
| https://github.com/python/cpython/tree/c5e9264dca68b6c43ce9a9fa675911d269d1a180 |
| check all headers for newlines | https://github.com/python/cpython/pull/121812/commits/5a163b54833062dccc3db0019feb612af028ccea |
| https://github.com/basbloemsaat |
| basbloemsaat | https://github.com/python/cpython/commits?author=basbloemsaat |
| 5a163b5 | https://github.com/python/cpython/pull/121812/commits/5a163b54833062dccc3db0019feb612af028ccea |
| https://github.com/python/cpython/tree/5a163b54833062dccc3db0019feb612af028ccea |
| Merge branch 'main' into fix-issue-121650-detect-newlines-in-headers | https://github.com/python/cpython/pull/121812/commits/0efe2900ab136e2f3273137a08c3d0477795ef6e |
| https://github.com/basbloemsaat |
| basbloemsaat | https://github.com/python/cpython/commits?author=basbloemsaat |
| 0efe290 | https://github.com/python/cpython/pull/121812/commits/0efe2900ab136e2f3273137a08c3d0477795ef6e |
| https://github.com/python/cpython/tree/0efe2900ab136e2f3273137a08c3d0477795ef6e |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |