René's URL Explorer Experiment


Title: gh-121650 : detect newlines in headers by basbloemsaat · Pull Request #121812 · python/cpython · GitHub

Open Graph Title: gh-121650 : detect newlines in headers by basbloemsaat · Pull Request #121812 · python/cpython

X Title: gh-121650 : detect newlines in headers by basbloemsaat · Pull Request #121812 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: @encukou as promised, the fix for this issue. This PR fixes both issues addressed in the issue, both the newlines at the end as well as the encoded newlines. As this has security implication, it ma...

X Description: @encukou as promised, the fix for this issue. This PR fixes both issues addressed in the issue, both the newlines at the end as well as the encoded newlines. As this has security implication, it ma...

Opengraph URL: https://github.com/python/cpython/pull/121812

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:3026d302-c34d-ed48-dd60-a9096e93a6f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E44:31F9AC:A100E:E00E5:6B00623F
html-safe-noncecf9070d22b6b33b68c1d34808fe82c84bb73827d4b0646e412a83d30da8f9dcd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTQ0OjMxRjlBQzpBMTAwRTpFMDBFNTo2QjAwNjIzRiIsInZpc2l0b3JfaWQiOiI4MTAyODExMzIxNjE3MTEzNjYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb04b04c31aa0c542030ad0c0e6ae65c68b38ccdf7a657b9e415ef71e9e8e8548
hovercard-subject-tagpull_request:1970120992
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/121812/commits
twitter:imagehttps://opengraph.githubassets.com/6e4643b84207f72a249d322a3497683a5f7afad66118c72069b906a462669677/python/cpython/pull/121812
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6e4643b84207f72a249d322a3497683a5f7afad66118c72069b906a462669677/python/cpython/pull/121812
og:image:alt@encukou as promised, the fix for this issue. This PR fixes both issues addressed in the issue, both the newlines at the end as well as the encoded newlines. As this has security implication, it ma...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebasbloemsaat
hostnamegithub.com
expected-hostnamegithub.com
None25854482a1773a7c1ebb8be3d2bc1c6e61d82d78126be63b5044474a86d44d9e
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4f5c239e31f1f680e6bbc419ff92d774da616ec
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/121812/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121812%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121812%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/121812/commits
Reloadhttps://github.com/python/cpython/pull/121812/commits
Reloadhttps://github.com/python/cpython/pull/121812/commits
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
basbloemsaathttps://github.com/basbloemsaat
python:mainhttps://github.com/python/cpython/tree/main
Conversationhttps://github.com/python/cpython/pull/121812
Commits12 (12)https://github.com/python/cpython/pull/121812/commits
Checkshttps://github.com/python/cpython/pull/121812/checks
Files changedhttps://github.com/python/cpython/pull/121812/files
gh-121650 : detect newlines in headershttps://github.com/python/cpython/pull/121812/commits#top
basbloemsaathttps://github.com/basbloemsaat
python:mainhttps://github.com/python/cpython/tree/main
detect line splits, also at the endhttps://github.com/python/cpython/pull/121812/commits/d3ca18a98e6876811a6dab9a23af15862e37466d
https://github.com/basbloemsaat
basbloemsaathttps://github.com/python/cpython/commits?author=basbloemsaat
d3ca18ahttps://github.com/python/cpython/pull/121812/commits/d3ca18a98e6876811a6dab9a23af15862e37466d
https://github.com/python/cpython/tree/d3ca18a98e6876811a6dab9a23af15862e37466d
also detect encoded newlineshttps://github.com/python/cpython/pull/121812/commits/891d4f8d5d6d11ab4273431996542a07429fd145
https://github.com/basbloemsaat
basbloemsaathttps://github.com/python/cpython/commits?author=basbloemsaat
891d4f8https://github.com/python/cpython/pull/121812/commits/891d4f8d5d6d11ab4273431996542a07429fd145
https://github.com/python/cpython/tree/891d4f8d5d6d11ab4273431996542a07429fd145
Merge branch 'main' into fix-issue-121650-detect-newlines-in-headershttps://github.com/python/cpython/pull/121812/commits/67d412194e6b2ecc80466ad283ca6960ed83aef9
https://github.com/basbloemsaat
basbloemsaathttps://github.com/python/cpython/commits?author=basbloemsaat
67d4121https://github.com/python/cpython/pull/121812/commits/67d412194e6b2ecc80466ad283ca6960ed83aef9
https://github.com/python/cpython/tree/67d412194e6b2ecc80466ad283ca6960ed83aef9
Update Lib/email/policy.pyhttps://github.com/python/cpython/pull/121812/commits/62ceb4089683a8182d590cd9e38ff8e8bc7a15b6
basbloemsaathttps://github.com/python/cpython/commits?author=basbloemsaat
ZeroIntensityhttps://github.com/python/cpython/commits?author=ZeroIntensity
62ceb40https://github.com/python/cpython/pull/121812/commits/62ceb4089683a8182d590cd9e38ff8e8bc7a15b6
https://github.com/python/cpython/tree/62ceb4089683a8182d590cd9e38ff8e8bc7a15b6
Update Misc/NEWS.d/next/Library/2024-07-15-21-43-38.gh-issue-121650.A0FkCh.rsthttps://github.com/python/cpython/pull/121812/commits/aa4fd24dc7179d147e8e8cabdd4a50caf82f6be8
basbloemsaathttps://github.com/python/cpython/commits?author=basbloemsaat
ZeroIntensityhttps://github.com/python/cpython/commits?author=ZeroIntensity
aa4fd24https://github.com/python/cpython/pull/121812/commits/aa4fd24dc7179d147e8e8cabdd4a50caf82f6be8
https://github.com/python/cpython/tree/aa4fd24dc7179d147e8e8cabdd4a50caf82f6be8
also check parsed headers for newlines and returnshttps://github.com/python/cpython/pull/121812/commits/23fdf74761707639c59003fc15d85bd5b40550a9
https://github.com/basbloemsaat
basbloemsaathttps://github.com/python/cpython/commits?author=basbloemsaat
23fdf74https://github.com/python/cpython/pull/121812/commits/23fdf74761707639c59003fc15d85bd5b40550a9
https://github.com/python/cpython/tree/23fdf74761707639c59003fc15d85bd5b40550a9
More specific update blurbhttps://github.com/python/cpython/pull/121812/commits/d2109413c52c3f18b5ee8b15bd6247cec393911e
https://github.com/basbloemsaat
basbloemsaathttps://github.com/python/cpython/commits?author=basbloemsaat
d210941https://github.com/python/cpython/pull/121812/commits/d2109413c52c3f18b5ee8b15bd6247cec393911e
https://github.com/python/cpython/tree/d2109413c52c3f18b5ee8b15bd6247cec393911e
Merge branch 'main' into fix-issue-121650-detect-newlines-in-headershttps://github.com/python/cpython/pull/121812/commits/118c709a89bab255b46e8abc7d8d031223432ff8
https://github.com/basbloemsaat
basbloemsaathttps://github.com/python/cpython/commits?author=basbloemsaat
118c709https://github.com/python/cpython/pull/121812/commits/118c709a89bab255b46e8abc7d8d031223432ff8
https://github.com/python/cpython/tree/118c709a89bab255b46e8abc7d8d031223432ff8
Merge branch 'main' into fix-issue-121650-detect-newlines-in-headershttps://github.com/python/cpython/pull/121812/commits/08e5fe16f86693da98079ca66bc9220f10478747
https://github.com/basbloemsaat
basbloemsaathttps://github.com/python/cpython/commits?author=basbloemsaat
08e5fe1https://github.com/python/cpython/pull/121812/commits/08e5fe16f86693da98079ca66bc9220f10478747
https://github.com/python/cpython/tree/08e5fe16f86693da98079ca66bc9220f10478747
Merge branch 'fix-issue-121650-detect-newlines-in-headers' of github.com:basbloemsaat/cpython into fix-issue-121650-detect-newlines-in-headershttps://github.com/python/cpython/pull/121812/commits/c5e9264dca68b6c43ce9a9fa675911d269d1a180
https://github.com/basbloemsaat
basbloemsaathttps://github.com/python/cpython/commits?author=basbloemsaat
c5e9264https://github.com/python/cpython/pull/121812/commits/c5e9264dca68b6c43ce9a9fa675911d269d1a180
https://github.com/python/cpython/tree/c5e9264dca68b6c43ce9a9fa675911d269d1a180
check all headers for newlineshttps://github.com/python/cpython/pull/121812/commits/5a163b54833062dccc3db0019feb612af028ccea
https://github.com/basbloemsaat
basbloemsaathttps://github.com/python/cpython/commits?author=basbloemsaat
5a163b5https://github.com/python/cpython/pull/121812/commits/5a163b54833062dccc3db0019feb612af028ccea
https://github.com/python/cpython/tree/5a163b54833062dccc3db0019feb612af028ccea
Merge branch 'main' into fix-issue-121650-detect-newlines-in-headershttps://github.com/python/cpython/pull/121812/commits/0efe2900ab136e2f3273137a08c3d0477795ef6e
https://github.com/basbloemsaat
basbloemsaathttps://github.com/python/cpython/commits?author=basbloemsaat
0efe290https://github.com/python/cpython/pull/121812/commits/0efe2900ab136e2f3273137a08c3d0477795ef6e
https://github.com/python/cpython/tree/0efe2900ab136e2f3273137a08c3d0477795ef6e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.