René's URL Explorer Experiment


Title: gh-121650 : detect newlines in headers by basbloemsaat · Pull Request #121812 · python/cpython · GitHub

Open Graph Title: gh-121650 : detect newlines in headers by basbloemsaat · Pull Request #121812 · python/cpython

X Title: gh-121650 : detect newlines in headers by basbloemsaat · Pull Request #121812 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: @encukou as promised, the fix for this issue. This PR fixes both issues addressed in the issue, both the newlines at the end as well as the encoded newlines. As this has security implication, it ma...

X Description: @encukou as promised, the fix for this issue. This PR fixes both issues addressed in the issue, both the newlines at the end as well as the encoded newlines. As this has security implication, it ma...

Opengraph URL: https://github.com/python/cpython/pull/121812

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d01343da-7125-a3e8-5fe3-85f040f5c9c4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD50:DD1C:2C237EE:3C4F960:6B005C58
html-safe-noncead0b638692e4f06a1ab6704bbcdcf503b14b029af28f87c3a981ae77f204c646
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDUwOkREMUM6MkMyMzdFRTozQzRGOTYwOjZCMDA1QzU4IiwidmlzaXRvcl9pZCI6IjYwMjcyMzc0MTc3MDA4NDI1ODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacef5069db50da54c9688509218477bd91557f2b4b6e17ddc7b1cab1ccabf476eb
hovercard-subject-tagpull_request:1970120992
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/121812/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6e4643b84207f72a249d322a3497683a5f7afad66118c72069b906a462669677/python/cpython/pull/121812
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6e4643b84207f72a249d322a3497683a5f7afad66118c72069b906a462669677/python/cpython/pull/121812
og:image:alt@encukou as promised, the fix for this issue. This PR fixes both issues addressed in the issue, both the newlines at the end as well as the encoded newlines. As this has security implication, it ma...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebasbloemsaat
hostnamegithub.com
expected-hostnamegithub.com
None29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeacd927ba6112e3b01ba99c762bd699a4a4f5df7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/121812#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121812
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121812
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/121812
Reloadhttps://github.com/python/cpython/pull/121812
Reloadhttps://github.com/python/cpython/pull/121812
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
basbloemsaathttps://github.com/basbloemsaat
python:mainhttps://github.com/python/cpython/tree/main
Conversationhttps://github.com/python/cpython/pull/121812
Commits12 (12)https://github.com/python/cpython/pull/121812/commits
Checkshttps://github.com/python/cpython/pull/121812/checks
Files changedhttps://github.com/python/cpython/pull/121812/files
gh-121650 : detect newlines in headershttps://github.com/python/cpython/pull/121812#top
basbloemsaathttps://github.com/basbloemsaat
python:mainhttps://github.com/python/cpython/tree/main
https://github.com/basbloemsaat
basbloemsaathttps://github.com/basbloemsaat
Jul 15, 2024https://github.com/python/cpython/pull/121812#issue-2409507744
Please reload this pagehttps://github.com/python/cpython/pull/121812
@encukouhttps://github.com/encukou
email.policy.default - gotcha with re-using parsed headers with embedded newlines #121650https://github.com/python/cpython/issues/121650
Please reload this pagehttps://github.com/python/cpython/pull/121812
basbloemsaathttps://github.com/basbloemsaat
July 14, 2024 14:31https://github.com/python/cpython/pull/121812#commits-pushed-d3ca18a
https://github.com/basbloemsaat
detect line splits, also at the endhttps://github.com/python/cpython/pull/121812/commits/d3ca18a98e6876811a6dab9a23af15862e37466d
d3ca18ahttps://github.com/python/cpython/pull/121812/commits/d3ca18a98e6876811a6dab9a23af15862e37466d
https://github.com/basbloemsaat
also detect encoded newlineshttps://github.com/python/cpython/pull/121812/commits/891d4f8d5d6d11ab4273431996542a07429fd145
891d4f8https://github.com/python/cpython/pull/121812/commits/891d4f8d5d6d11ab4273431996542a07429fd145
https://github.com/basbloemsaat
basbloemsaathttps://github.com/basbloemsaat
code ownerhttps://github.com/python/cpython/blob/8b209fd4f8a9bf9603888bda2c44b5cfd4ebf47a/.github/CODEOWNERS#L138
July 15, 2024 19:53https://github.com/python/cpython/pull/121812#event-13510372000
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 15, 2024 https://github.com/python/cpython/pull/121812#ref-issue-2406021585
email.policy.default - gotcha with re-using parsed headers with embedded newlines #121650 https://github.com/python/cpython/issues/121650
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jul 15, 2024https://github.com/python/cpython/pull/121812#event-13510372894
https://github.com/basbloemsaat
Merge branch 'main' into fix-issue-121650-detect-newlines-in-headershttps://github.com/python/cpython/pull/121812/commits/67d412194e6b2ecc80466ad283ca6960ed83aef9
67d4121https://github.com/python/cpython/pull/121812/commits/67d412194e6b2ecc80466ad283ca6960ed83aef9
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Jul 15, 2024 https://github.com/python/cpython/pull/121812#pullrequestreview-2178696864
View reviewed changes https://github.com/python/cpython/pull/121812/files/67d412194e6b2ecc80466ad283ca6960ed83aef9
ZeroIntensityhttps://github.com/ZeroIntensity
https://github.com/python/cpython/pull/121812#pullrequestreview-2178696864
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#121650https://github.com/python/cpython/issues/121650
Please reload this pagehttps://github.com/python/cpython/pull/121812
Lib/email/policy.pyhttps://github.com/python/cpython/pull/121812/files/67d412194e6b2ecc80466ad283ca6960ed83aef9#diff-822b8571646f0dbd32f38e0a6e4ad11a9166f13e1802c1c0a4fb98782c8ffaea
Please reload this pagehttps://github.com/python/cpython/pull/121812
Misc/NEWS.d/next/Library/2024-07-15-21-43-38.gh-issue-121650.A0FkCh.rsthttps://github.com/python/cpython/pull/121812/files/67d412194e6b2ecc80466ad283ca6960ed83aef9#diff-950b01de0f90cb334aace5c655c8b5926383051022c0c67e571dbac5c2e5fe42
Please reload this pagehttps://github.com/python/cpython/pull/121812
Misc/NEWS.d/next/Library/2024-07-15-21-43-38.gh-issue-121650.A0FkCh.rsthttps://github.com/python/cpython/pull/121812/files/67d412194e6b2ecc80466ad283ca6960ed83aef9#diff-950b01de0f90cb334aace5c655c8b5926383051022c0c67e571dbac5c2e5fe42
Please reload this pagehttps://github.com/python/cpython/pull/121812
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jul 15, 2024https://github.com/python/cpython/pull/121812#event-13511347223
basbloemsaathttps://github.com/basbloemsaat
July 16, 2024 09:36https://github.com/python/cpython/pull/121812#commits-pushed-62ceb40
https://github.com/basbloemsaat
https://github.com/ZeroIntensity
Update Lib/email/policy.pyhttps://github.com/python/cpython/pull/121812/commits/62ceb4089683a8182d590cd9e38ff8e8bc7a15b6
62ceb40https://github.com/python/cpython/pull/121812/commits/62ceb4089683a8182d590cd9e38ff8e8bc7a15b6
https://github.com/basbloemsaat
https://github.com/ZeroIntensity
Update Misc/NEWS.d/next/Library/2024-07-15-21-43-38.gh-issue-121650.A…https://github.com/python/cpython/pull/121812/commits/aa4fd24dc7179d147e8e8cabdd4a50caf82f6be8
aa4fd24https://github.com/python/cpython/pull/121812/commits/aa4fd24dc7179d147e8e8cabdd4a50caf82f6be8
https://github.com/basbloemsaat
also check parsed headers for newlines and returnshttps://github.com/python/cpython/pull/121812/commits/23fdf74761707639c59003fc15d85bd5b40550a9
23fdf74https://github.com/python/cpython/pull/121812/commits/23fdf74761707639c59003fc15d85bd5b40550a9
https://github.com/basbloemsaat
More specific update blurbhttps://github.com/python/cpython/pull/121812/commits/d2109413c52c3f18b5ee8b15bd6247cec393911e
d210941https://github.com/python/cpython/pull/121812/commits/d2109413c52c3f18b5ee8b15bd6247cec393911e
https://github.com/basbloemsaat
basbloemsaathttps://github.com/basbloemsaat
Jul 16, 2024https://github.com/python/cpython/pull/121812#issuecomment-2230324611
Please reload this pagehttps://github.com/python/cpython/pull/121812
#121650https://github.com/python/cpython/issues/121650
Please reload this pagehttps://github.com/python/cpython/pull/121812
https://github.com/basbloemsaat
basbloemsaathttps://github.com/basbloemsaat
ZeroIntensityhttps://github.com/ZeroIntensity
July 16, 2024 09:13https://github.com/python/cpython/pull/121812#event-13517718032
https://github.com/basbloemsaat
Merge branch 'main' into fix-issue-121650-detect-newlines-in-headershttps://github.com/python/cpython/pull/121812/commits/118c709a89bab255b46e8abc7d8d031223432ff8
118c709https://github.com/python/cpython/pull/121812/commits/118c709a89bab255b46e8abc7d8d031223432ff8
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Jul 16, 2024 https://github.com/python/cpython/pull/121812#pullrequestreview-2180298262
View reviewed changes https://github.com/python/cpython/pull/121812/files/c5e9264dca68b6c43ce9a9fa675911d269d1a180
ZeroIntensityhttps://github.com/ZeroIntensity
https://github.com/python/cpython/pull/121812#pullrequestreview-2180298262
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#121650https://github.com/python/cpython/issues/121650
Please reload this pagehttps://github.com/python/cpython/pull/121812
https://github.com/encukou
encukouhttps://github.com/encukou
Jul 16, 2024https://github.com/python/cpython/pull/121812#issuecomment-2231228700
@warsawhttps://github.com/warsaw
@bitdancerhttps://github.com/bitdancer
@maxkinghttps://github.com/maxking
email expertshttps://devguide.python.org/core-developers/experts/#stdlib
Please reload this pagehttps://github.com/python/cpython/pull/121812
https://github.com/encukou
encukouhttps://github.com/encukou
Jul 16, 2024 https://github.com/python/cpython/pull/121812#pullrequestreview-2180608938
View reviewed changes https://github.com/python/cpython/pull/121812/files/118c709a89bab255b46e8abc7d8d031223432ff8
encukouhttps://github.com/encukou
https://github.com/python/cpython/pull/121812#pullrequestreview-2180608938
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/121812
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 16, 2024https://github.com/python/cpython/pull/121812#event-13523255820
https://github.com/encukou
encukouhttps://github.com/encukou
stale reviewhttps://github.com/python/cpython/pull/121812#pullrequestreview-2180608938
July 19, 2024 16:06https://github.com/python/cpython/pull/121812#event-13577087321
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jul 19, 2024https://github.com/python/cpython/pull/121812#event-13577087918
https://github.com/encukou
encukouhttps://github.com/encukou
Jul 19, 2024https://github.com/python/cpython/pull/121812#issuecomment-2239526315
Please reload this pagehttps://github.com/python/cpython/pull/121812
https://github.com/basbloemsaat
basbloemsaathttps://github.com/basbloemsaat
Jul 19, 2024https://github.com/python/cpython/pull/121812#issuecomment-2239706171
Please reload this pagehttps://github.com/python/cpython/pull/121812
basbloemsaathttps://github.com/basbloemsaat
July 19, 2024 19:28https://github.com/python/cpython/pull/121812#commits-pushed-08e5fe1
https://github.com/basbloemsaat
Merge branch 'main' into fix-issue-121650-detect-newlines-in-headershttps://github.com/python/cpython/pull/121812/commits/08e5fe16f86693da98079ca66bc9220f10478747
08e5fe1https://github.com/python/cpython/pull/121812/commits/08e5fe16f86693da98079ca66bc9220f10478747
https://github.com/basbloemsaat
Merge branch 'fix-issue-121650-detect-newlines-in-headers' of github.…https://github.com/python/cpython/pull/121812/commits/c5e9264dca68b6c43ce9a9fa675911d269d1a180
c5e9264https://github.com/python/cpython/pull/121812/commits/c5e9264dca68b6c43ce9a9fa675911d269d1a180
https://github.com/basbloemsaat
check all headers for newlineshttps://github.com/python/cpython/pull/121812/commits/5a163b54833062dccc3db0019feb612af028ccea
5a163b5https://github.com/python/cpython/pull/121812/commits/5a163b54833062dccc3db0019feb612af028ccea
https://github.com/basbloemsaat
basbloemsaathttps://github.com/basbloemsaat
encukouhttps://github.com/encukou
July 19, 2024 22:07https://github.com/python/cpython/pull/121812#event-13583108094
https://github.com/basbloemsaat
basbloemsaathttps://github.com/basbloemsaat
Jul 19, 2024https://github.com/python/cpython/pull/121812#issuecomment-2240354049
Please reload this pagehttps://github.com/python/cpython/pull/121812
@encukouhttps://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/121812
https://github.com/basbloemsaat
Merge branch 'main' into fix-issue-121650-detect-newlines-in-headershttps://github.com/python/cpython/pull/121812/commits/0efe2900ab136e2f3273137a08c3d0477795ef6e
0efe290https://github.com/python/cpython/pull/121812/commits/0efe2900ab136e2f3273137a08c3d0477795ef6e
https://github.com/encukou
encukouhttps://github.com/encukou
Jul 24, 2024 https://github.com/python/cpython/pull/121812#ref-pullrequest-2427663399
gh-121650: Encode newlines in headers, and verify headers are sound #122233 https://github.com/python/cpython/pull/122233
https://github.com/encukou
encukouhttps://github.com/encukou
Jul 24, 2024https://github.com/python/cpython/pull/121812#issuecomment-2248034440
#122233https://github.com/python/cpython/pull/122233
Please reload this pagehttps://github.com/python/cpython/pull/121812
https://github.com/encukou
encukouhttps://github.com/encukou
Aug 1, 2024https://github.com/python/cpython/pull/121812#issuecomment-2263132209
#122233https://github.com/python/cpython/pull/122233
@basbloemsaathttps://github.com/basbloemsaat
Please reload this pagehttps://github.com/python/cpython/pull/121812
https://github.com/encukou
encukouhttps://github.com/encukou
Aug 1, 2024https://github.com/python/cpython/pull/121812#event-13726639239
https://github.com/basbloemsaat
basbloemsaathttps://github.com/basbloemsaat
August 1, 2024 15:06https://github.com/python/cpython/pull/121812#event-13727726001
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121812
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
https://github.com/python/cpython/pull/121812/files/c5e9264dca68b6c43ce9a9fa675911d269d1a180
https://github.com/encukou
encukou https://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/121812
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/121812
https://github.com/basbloemsaat
https://github.com/encukou
https://github.com/ZeroIntensity
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.