René's URL Explorer Experiment


Title: bpo-19764: Implemented support for subprocess.Popen(close_fds=True) on Windows by segevfiner · Pull Request #1218 · python/cpython · GitHub

Open Graph Title: bpo-19764: Implemented support for subprocess.Popen(close_fds=True) on Windows by segevfiner · Pull Request #1218 · python/cpython

X Title: bpo-19764: Implemented support for subprocess.Popen(close_fds=True) on Windows by segevfiner · Pull Request #1218 · python/cpython

Description: Even though Python marks any handles it opens as non-inheritable there is still a race when using subprocess.Popen since creating a process with redirected stdio requires temporarily creating inheritable handles. By implementing support for subprocess.Popen(close_fds=True) we fix this race. In order to implement this we use PROC_THREAD_ATTRIBUTE_HANDLE_LIST which is available since Windows Vista. Which allows to pass an explicit list of handles to inherit when creating a process. This commit also adds STARTUPINFO.lpAttributeList["handle_list"] which can be used to control PROC_THREAD_ATTRIBUTE_HANDLE_LIST directly. https://bugs.python.org/issue19764

Open Graph Description: Even though Python marks any handles it opens as non-inheritable there is still a race when using subprocess.Popen since creating a process with redirected stdio requires temporarily creating inher...

X Description: Even though Python marks any handles it opens as non-inheritable there is still a race when using subprocess.Popen since creating a process with redirected stdio requires temporarily creating inher...

Opengraph URL: https://github.com/python/cpython/pull/1218

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fec7a1fe-8ecc-8d22-e437-324d3a1e0fcc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD51A:1179A2:50A8A1:6B92F0:6A5048CB
html-safe-nonce0638d90d3fbf1048f81174cf9354d42eba04068e910d3c528771a96eceffac86
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTFBOjExNzlBMjo1MEE4QTE6NkI5MkYwOjZBNTA0OENCIiwidmlzaXRvcl9pZCI6IjE1MDcxNTM4MDg5MTU5NzQzNDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7c586f28ee15fbbd10bfc0b7dde936612802ce3b17df3bf9cc40cc6bf449e9b9
hovercard-subject-tagpull_request:116850318
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/1218/files
twitter:imagehttps://avatars.githubusercontent.com/u/24731903?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/24731903?s=400&v=4
og:image:altEven though Python marks any handles it opens as non-inheritable there is still a race when using subprocess.Popen since creating a process with redirected stdio requires temporarily creating inher...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5741a45fe07e5f377d0d4c524a92e3056acc51bb
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/1218/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1218%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1218%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/1218/files
Reloadhttps://github.com/python/cpython/pull/1218/files
Reloadhttps://github.com/python/cpython/pull/1218/files
Please reload this pagehttps://github.com/python/cpython/pull/1218/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/1218/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
segevfiner:windows-subprocess-close-fdshttps://github.com/segevfiner/cpython/tree/windows-subprocess-close-fds
Conversation 45 https://github.com/python/cpython/pull/1218
Commits 24 https://github.com/python/cpython/pull/1218/commits
Checks 0 https://github.com/python/cpython/pull/1218/checks
Files changed https://github.com/python/cpython/pull/1218/files
Please reload this pagehttps://github.com/python/cpython/pull/1218/files
bpo-19764: Implemented support for subprocess.Popen(close_fds=True) on Windows https://github.com/python/cpython/pull/1218/files#top
Show all changes 24 commits https://github.com/python/cpython/pull/1218/files
7e68016 bpo-19764: Implemented support for subprocess.Popen(close_fds=True) o… segevfiner Apr 20, 2017 https://github.com/python/cpython/pull/1218/commits/7e680162690327c35ddde943c6b065e686d464d3
ad07b10 bpo-19764: Convert subprocess.Handle to int in handle_list segevfiner Apr 20, 2017 https://github.com/python/cpython/pull/1218/commits/ad07b107b825ad7b70897143cba3ed615312dcf1
9ad94f3 bpo-19764: Fixed the handle_list warning with close_fds=True segevfiner Apr 21, 2017 https://github.com/python/cpython/pull/1218/commits/9ad94f36432bb83d5e83548870b895f6af461bac
24f3f39 bpo-19764: Added a test for the overriding close_fds warning segevfiner Apr 21, 2017 https://github.com/python/cpython/pull/1218/commits/24f3f3920613f73b7a2cbe3f6a06833d5a5f9857
1eab242 bpo-19764: The warning should be emitted for handle_list and close_fd… segevfiner Apr 21, 2017 https://github.com/python/cpython/pull/1218/commits/1eab24290b9005e0abf63dc52ae2206cfa053ab2
5b3cccc Minor fixes in _winapi.c segevfiner May 31, 2017 https://github.com/python/cpython/pull/1218/commits/5b3cccc0e1333db6b6140f15bdf07b89d7972404
c84449c bpo-19764: Addressed review comments by haypo segevfiner Jun 6, 2017 https://github.com/python/cpython/pull/1218/commits/c84449c179fe59a94d4f3e80aa529c3cb8a97ae2
f849f92 Merge remote-tracking branch 'upstream/master' into windows-subproces… segevfiner Jun 6, 2017 https://github.com/python/cpython/pull/1218/commits/f849f9203f3aaefd98b11a15aabcb996542e70eb
0e60d28 bpo-19764: Simplified the handle_list cast to list segevfiner Jun 6, 2017 https://github.com/python/cpython/pull/1218/commits/0e60d28d4c1f50dec9608aeecf833f242ed0d8cd
167590b bpo-19764: Add some extra documentation about handle_list segevfiner Jun 7, 2017 https://github.com/python/cpython/pull/1218/commits/167590b4f20d226e31925eed75dedfb2a4aba5e2
59af91f bpo-19764: Documentation update segevfiner Jun 7, 2017 https://github.com/python/cpython/pull/1218/commits/59af91f1aa87d509e5274cf20ced97258c92405d
d4a9cdb bpo-19764: Fixed bad reStructuredText markup segevfiner Jun 8, 2017 https://github.com/python/cpython/pull/1218/commits/d4a9cdbcebb2ebf050297549d264638c20d61e18
15424fa Merge remote-tracking branch 'upstream/master' into windows-subproces… segevfiner Jun 10, 2017 https://github.com/python/cpython/pull/1218/commits/15424fa55de0939ba43e430bc80072a2dea57062
dc1e551 Merge remote-tracking branch 'upstream/master' into windows-subproces… segevfiner Jun 24, 2017 https://github.com/python/cpython/pull/1218/commits/dc1e5516fe4aec16da7b4a3f188dec34f2ce4500
d99af74 Merge branch 'master' into windows-subprocess-close-fds segevfiner Jul 2, 2017 https://github.com/python/cpython/pull/1218/commits/d99af74103ba0278c63eaa876248319047e56022
c63e045 Merge remote-tracking branch 'upstream/master' into windows-subproces… segevfiner Jul 6, 2017 https://github.com/python/cpython/pull/1218/commits/c63e0454859c644c06c7b4f548e0aa5d235ed483
f50ca37 Merge branch 'master' into windows-subprocess-close-fds segevfiner Aug 4, 2017 https://github.com/python/cpython/pull/1218/commits/f50ca378e324d9697ed11fec286a7438cba065a8
38b4526 Merge remote-tracking branch 'upstream/master' into windows-subproces… segevfiner Aug 18, 2017 https://github.com/python/cpython/pull/1218/commits/38b45262386220c8a9ef6d0b70e6452fd60485e2
8e5d21f bpo-19764: Fix whitespace segevfiner Aug 18, 2017 https://github.com/python/cpython/pull/1218/commits/8e5d21f1cf5f4c982bd8a8d09497fadb5e2e565f
208274c bpo-19764: Add NEWS.d entry segevfiner Aug 18, 2017 https://github.com/python/cpython/pull/1218/commits/208274c8df26b5dca9cbc332500316023529fcf5
869b54c Merge branch 'master' into windows-subprocess-close-fds segevfiner Sep 19, 2017 https://github.com/python/cpython/pull/1218/commits/869b54c6210d256ac6efae1e31da9ee9b49caf56
66b74f6 Merge remote-tracking branch 'upstream/master' into windows-subproces… segevfiner Nov 17, 2017 https://github.com/python/cpython/pull/1218/commits/66b74f62ace47d52a0d382869bd5ec26fcdd4758
ba19bd8 Merge remote-tracking branch 'upstream/master' into windows-subproces… segevfiner Dec 16, 2017 https://github.com/python/cpython/pull/1218/commits/ba19bd8062d629315aa9c9e47cf5fa3b0c1f8179
3b0426e Add Segev Finer to Misc/ACKS segevfiner Dec 16, 2017 https://github.com/python/cpython/pull/1218/commits/3b0426e188575ef5fe7a8e63072f7897ce70e169
Clear filters https://github.com/python/cpython/pull/1218/files
Please reload this pagehttps://github.com/python/cpython/pull/1218/files
Please reload this pagehttps://github.com/python/cpython/pull/1218/files
subprocess.rst https://github.com/python/cpython/pull/1218/files#diff-346949b57abf9f17798d03d93244ab8f54b1cebcef518df03b21134bf7411f1d
3.7.rst https://github.com/python/cpython/pull/1218/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
subprocess.py https://github.com/python/cpython/pull/1218/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
test_subprocess.py https://github.com/python/cpython/pull/1218/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
ACKS https://github.com/python/cpython/pull/1218/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
2017-08-18-18-00-24.bpo-19764.ODpc9y.rst https://github.com/python/cpython/pull/1218/files#diff-e64873d90202f9021a51160ddad5a552b17d32cf54f7f622d203ccd48f3e2298
_winapi.c https://github.com/python/cpython/pull/1218/files#diff-42415407f8d0ef2d42e29d13d979f633e3543770e62c3871e1101ad532d336a8
_winapi.c.h https://github.com/python/cpython/pull/1218/files#diff-3626cfe34cfaa6c7e1968337739eb33869d4a73f830c5ca1a41bd68161311e81
Doc/library/subprocess.rsthttps://github.com/python/cpython/pull/1218/files#diff-346949b57abf9f17798d03d93244ab8f54b1cebcef518df03b21134bf7411f1d
View file https://github.com/segevfiner/cpython/blob/3b0426e188575ef5fe7a8e63072f7897ce70e169/Doc/library/subprocess.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1218/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1218/files#diff-346949b57abf9f17798d03d93244ab8f54b1cebcef518df03b21134bf7411f1d
https://github.com/python/cpython/pull/1218/files#diff-346949b57abf9f17798d03d93244ab8f54b1cebcef518df03b21134bf7411f1d
https://github.com/python/cpython/pull/1218/files#diff-346949b57abf9f17798d03d93244ab8f54b1cebcef518df03b21134bf7411f1d
https://github.com/python/cpython/pull/1218/files#diff-346949b57abf9f17798d03d93244ab8f54b1cebcef518df03b21134bf7411f1d
https://github.com/python/cpython/pull/1218/files#diff-346949b57abf9f17798d03d93244ab8f54b1cebcef518df03b21134bf7411f1d
https://github.com/python/cpython/pull/1218/files#diff-346949b57abf9f17798d03d93244ab8f54b1cebcef518df03b21134bf7411f1d
Doc/whatsnew/3.7.rsthttps://github.com/python/cpython/pull/1218/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
View file https://github.com/segevfiner/cpython/blob/3b0426e188575ef5fe7a8e63072f7897ce70e169/Doc/whatsnew/3.7.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1218/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1218/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
https://github.com/python/cpython/pull/1218/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
https://github.com/python/cpython/pull/1218/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
https://github.com/python/cpython/pull/1218/files#diff-830b405713d1c40982ffa918864e39c40c1b318d79b8dd2b523646dc3bd18b52
Lib/subprocess.pyhttps://github.com/python/cpython/pull/1218/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
View file https://github.com/segevfiner/cpython/blob/3b0426e188575ef5fe7a8e63072f7897ce70e169/Lib/subprocess.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1218/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1218/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
vstinnerhttps://github.com/vstinner
Jun 6, 2017https://github.com/python/cpython/pull/1218/files#r120390835
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218/files
eryksunhttps://github.com/eryksun
Jun 7, 2017https://github.com/python/cpython/pull/1218/files#r120517053
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218/files
segevfinerhttps://github.com/segevfiner
Jun 7, 2017https://github.com/python/cpython/pull/1218/files#r120535796
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218/files
eryksunhttps://github.com/eryksun
Jun 7, 2017https://github.com/python/cpython/pull/1218/files#r120546336
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218/files
segevfinerhttps://github.com/segevfiner
Jun 7, 2017https://github.com/python/cpython/pull/1218/files#r120697927
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218/files
https://github.com/python/cpython/pull/1218/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/1218/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/1218/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/1218/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/1218/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/1218/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/1218/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/1218/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
https://github.com/python/cpython/pull/1218/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
Lib/test/test_subprocess.pyhttps://github.com/python/cpython/pull/1218/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
View file https://github.com/segevfiner/cpython/blob/3b0426e188575ef5fe7a8e63072f7897ce70e169/Lib/test/test_subprocess.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1218/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1218/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
https://github.com/python/cpython/pull/1218/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
https://github.com/python/cpython/pull/1218/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
Misc/ACKShttps://github.com/python/cpython/pull/1218/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
View file https://github.com/segevfiner/cpython/blob/3b0426e188575ef5fe7a8e63072f7897ce70e169/Misc/ACKS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1218/{{ revealButtonHref }}
https://github.com/python/cpython/pull/1218/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
https://github.com/python/cpython/pull/1218/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
Misc/NEWS.d/next/Windows/2017-08-18-18-00-24.bpo-19764.ODpc9y.rsthttps://github.com/python/cpython/pull/1218/files#diff-e64873d90202f9021a51160ddad5a552b17d32cf54f7f622d203ccd48f3e2298
View file https://github.com/segevfiner/cpython/blob/3b0426e188575ef5fe7a8e63072f7897ce70e169/Misc/NEWS.d/next/Windows/2017-08-18-18-00-24.bpo-19764.ODpc9y.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/1218/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/1218/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.