René's URL Explorer Experiment


Title: bpo-19764: Implemented support for subprocess.Popen(close_fds=True) on Windows by segevfiner · Pull Request #1218 · python/cpython · GitHub

Open Graph Title: bpo-19764: Implemented support for subprocess.Popen(close_fds=True) on Windows by segevfiner · Pull Request #1218 · python/cpython

X Title: bpo-19764: Implemented support for subprocess.Popen(close_fds=True) on Windows by segevfiner · Pull Request #1218 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Even though Python marks any handles it opens as non-inheritable there is still a race when using subprocess.Popen since creating a process with redirected stdio requires temporarily creating inher...

X Description: Even though Python marks any handles it opens as non-inheritable there is still a race when using subprocess.Popen since creating a process with redirected stdio requires temporarily creating inher...

Opengraph URL: https://github.com/python/cpython/pull/1218

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:59d0369d-0db1-aba3-48dc-6e4b8cb2e279
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE71C:D0A70:10AD16:1730BA:6A505BDE
html-safe-noncea10827436b6bb667842d4cf9b8ae48e1ae527d553a589a5c0600f39ba72147ea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzFDOkQwQTcwOjEwQUQxNjoxNzMwQkE6NkE1MDVCREUiLCJ2aXNpdG9yX2lkIjoiMTE4NjcxNjA3NDMwNjk4NDkyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac43d1133551d3c281d9c03fe0189f25581eaee09e58d0fb22f00b1bb3dc70e1ab
hovercard-subject-tagpull_request:116850318
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/1218/commits
twitter:imagehttps://opengraph.githubassets.com/36a168051786e5e6920376635ed059e6ab10e8f61771e566e324b7fe0d01c1c1/python/cpython/pull/1218
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/36a168051786e5e6920376635ed059e6ab10e8f61771e566e324b7fe0d01c1c1/python/cpython/pull/1218
og:image:altEven though Python marks any handles it opens as non-inheritable there is still a race when using subprocess.Popen since creating a process with redirected stdio requires temporarily creating inher...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesegevfiner
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/1218/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1218%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1218%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/1218/commits
Reloadhttps://github.com/python/cpython/pull/1218/commits
Reloadhttps://github.com/python/cpython/pull/1218/commits
Please reload this pagehttps://github.com/python/cpython/pull/1218/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/1218/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
segevfiner:windows-subprocess-close-fdshttps://github.com/segevfiner/cpython/tree/windows-subprocess-close-fds
Conversationhttps://github.com/python/cpython/pull/1218
Commits24 (24)https://github.com/python/cpython/pull/1218/commits
Checkshttps://github.com/python/cpython/pull/1218/checks
Files changedhttps://github.com/python/cpython/pull/1218/files
bpo-19764: Implemented support for subprocess.Popen(close_fds=True) on Windowshttps://github.com/python/cpython/pull/1218/commits#top
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
segevfiner:windows-subprocess-close-fdshttps://github.com/segevfiner/cpython/tree/windows-subprocess-close-fds
bpo-19764: Implemented support for subprocess.Popen(close_fds=True) on Windowshttps://github.com/python/cpython/pull/1218/commits/7e680162690327c35ddde943c6b065e686d464d3
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
7e68016https://github.com/python/cpython/pull/1218/commits/7e680162690327c35ddde943c6b065e686d464d3
https://github.com/python/cpython/tree/7e680162690327c35ddde943c6b065e686d464d3
bpo-19764: Convert subprocess.Handle to int in handle_listhttps://github.com/python/cpython/pull/1218/commits/ad07b107b825ad7b70897143cba3ed615312dcf1
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
ad07b10https://github.com/python/cpython/pull/1218/commits/ad07b107b825ad7b70897143cba3ed615312dcf1
https://github.com/python/cpython/tree/ad07b107b825ad7b70897143cba3ed615312dcf1
bpo-19764: Fixed the handle_list warning with close_fds=Truehttps://github.com/python/cpython/pull/1218/commits/9ad94f36432bb83d5e83548870b895f6af461bac
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
9ad94f3https://github.com/python/cpython/pull/1218/commits/9ad94f36432bb83d5e83548870b895f6af461bac
https://github.com/python/cpython/tree/9ad94f36432bb83d5e83548870b895f6af461bac
bpo-19764: Added a test for the overriding close_fds warninghttps://github.com/python/cpython/pull/1218/commits/24f3f3920613f73b7a2cbe3f6a06833d5a5f9857
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
24f3f39https://github.com/python/cpython/pull/1218/commits/24f3f3920613f73b7a2cbe3f6a06833d5a5f9857
https://github.com/python/cpython/tree/24f3f3920613f73b7a2cbe3f6a06833d5a5f9857
bpo-19764: The warning should be emitted for handle_list and close_fds=Truehttps://github.com/python/cpython/pull/1218/commits/1eab24290b9005e0abf63dc52ae2206cfa053ab2
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
1eab242https://github.com/python/cpython/pull/1218/commits/1eab24290b9005e0abf63dc52ae2206cfa053ab2
https://github.com/python/cpython/tree/1eab24290b9005e0abf63dc52ae2206cfa053ab2
Minor fixes in _winapi.chttps://github.com/python/cpython/pull/1218/commits/5b3cccc0e1333db6b6140f15bdf07b89d7972404
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
5b3cccchttps://github.com/python/cpython/pull/1218/commits/5b3cccc0e1333db6b6140f15bdf07b89d7972404
https://github.com/python/cpython/tree/5b3cccc0e1333db6b6140f15bdf07b89d7972404
bpo-19764: Addressed review comments by haypohttps://github.com/python/cpython/pull/1218/commits/c84449c179fe59a94d4f3e80aa529c3cb8a97ae2
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
c84449chttps://github.com/python/cpython/pull/1218/commits/c84449c179fe59a94d4f3e80aa529c3cb8a97ae2
https://github.com/python/cpython/tree/c84449c179fe59a94d4f3e80aa529c3cb8a97ae2
Merge remote-tracking branch 'upstream/master' into windows-subprocess-close-fdshttps://github.com/python/cpython/pull/1218/commits/f849f9203f3aaefd98b11a15aabcb996542e70eb
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
f849f92https://github.com/python/cpython/pull/1218/commits/f849f9203f3aaefd98b11a15aabcb996542e70eb
https://github.com/python/cpython/tree/f849f9203f3aaefd98b11a15aabcb996542e70eb
bpo-19764: Simplified the handle_list cast to listhttps://github.com/python/cpython/pull/1218/commits/0e60d28d4c1f50dec9608aeecf833f242ed0d8cd
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
0e60d28https://github.com/python/cpython/pull/1218/commits/0e60d28d4c1f50dec9608aeecf833f242ed0d8cd
https://github.com/python/cpython/tree/0e60d28d4c1f50dec9608aeecf833f242ed0d8cd
bpo-19764: Add some extra documentation about handle_listhttps://github.com/python/cpython/pull/1218/commits/167590b4f20d226e31925eed75dedfb2a4aba5e2
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
167590bhttps://github.com/python/cpython/pull/1218/commits/167590b4f20d226e31925eed75dedfb2a4aba5e2
https://github.com/python/cpython/tree/167590b4f20d226e31925eed75dedfb2a4aba5e2
bpo-19764: Documentation updatehttps://github.com/python/cpython/pull/1218/commits/59af91f1aa87d509e5274cf20ced97258c92405d
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
59af91fhttps://github.com/python/cpython/pull/1218/commits/59af91f1aa87d509e5274cf20ced97258c92405d
https://github.com/python/cpython/tree/59af91f1aa87d509e5274cf20ced97258c92405d
bpo-19764: Fixed bad reStructuredText markuphttps://github.com/python/cpython/pull/1218/commits/d4a9cdbcebb2ebf050297549d264638c20d61e18
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
d4a9cdbhttps://github.com/python/cpython/pull/1218/commits/d4a9cdbcebb2ebf050297549d264638c20d61e18
https://github.com/python/cpython/tree/d4a9cdbcebb2ebf050297549d264638c20d61e18
Merge remote-tracking branch 'upstream/master' into windows-subprocess-close-fdshttps://github.com/python/cpython/pull/1218/commits/15424fa55de0939ba43e430bc80072a2dea57062
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
15424fahttps://github.com/python/cpython/pull/1218/commits/15424fa55de0939ba43e430bc80072a2dea57062
https://github.com/python/cpython/tree/15424fa55de0939ba43e430bc80072a2dea57062
Merge remote-tracking branch 'upstream/master' into windows-subprocess-close-fdshttps://github.com/python/cpython/pull/1218/commits/dc1e5516fe4aec16da7b4a3f188dec34f2ce4500
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
dc1e551https://github.com/python/cpython/pull/1218/commits/dc1e5516fe4aec16da7b4a3f188dec34f2ce4500
https://github.com/python/cpython/tree/dc1e5516fe4aec16da7b4a3f188dec34f2ce4500
Merge branch 'master' into windows-subprocess-close-fdshttps://github.com/python/cpython/pull/1218/commits/d99af74103ba0278c63eaa876248319047e56022
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
d99af74https://github.com/python/cpython/pull/1218/commits/d99af74103ba0278c63eaa876248319047e56022
https://github.com/python/cpython/tree/d99af74103ba0278c63eaa876248319047e56022
Merge remote-tracking branch 'upstream/master' into windows-subprocess-close-fdshttps://github.com/python/cpython/pull/1218/commits/c63e0454859c644c06c7b4f548e0aa5d235ed483
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
c63e045https://github.com/python/cpython/pull/1218/commits/c63e0454859c644c06c7b4f548e0aa5d235ed483
https://github.com/python/cpython/tree/c63e0454859c644c06c7b4f548e0aa5d235ed483
Merge branch 'master' into windows-subprocess-close-fdshttps://github.com/python/cpython/pull/1218/commits/f50ca378e324d9697ed11fec286a7438cba065a8
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
f50ca37https://github.com/python/cpython/pull/1218/commits/f50ca378e324d9697ed11fec286a7438cba065a8
https://github.com/python/cpython/tree/f50ca378e324d9697ed11fec286a7438cba065a8
Merge remote-tracking branch 'upstream/master' into windows-subprocess-close-fdshttps://github.com/python/cpython/pull/1218/commits/38b45262386220c8a9ef6d0b70e6452fd60485e2
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
38b4526https://github.com/python/cpython/pull/1218/commits/38b45262386220c8a9ef6d0b70e6452fd60485e2
https://github.com/python/cpython/tree/38b45262386220c8a9ef6d0b70e6452fd60485e2
bpo-19764: Fix whitespacehttps://github.com/python/cpython/pull/1218/commits/8e5d21f1cf5f4c982bd8a8d09497fadb5e2e565f
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
8e5d21fhttps://github.com/python/cpython/pull/1218/commits/8e5d21f1cf5f4c982bd8a8d09497fadb5e2e565f
https://github.com/python/cpython/tree/8e5d21f1cf5f4c982bd8a8d09497fadb5e2e565f
bpo-19764: Add NEWS.d entryhttps://github.com/python/cpython/pull/1218/commits/208274c8df26b5dca9cbc332500316023529fcf5
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
208274chttps://github.com/python/cpython/pull/1218/commits/208274c8df26b5dca9cbc332500316023529fcf5
https://github.com/python/cpython/tree/208274c8df26b5dca9cbc332500316023529fcf5
Merge branch 'master' into windows-subprocess-close-fdshttps://github.com/python/cpython/pull/1218/commits/869b54c6210d256ac6efae1e31da9ee9b49caf56
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
869b54chttps://github.com/python/cpython/pull/1218/commits/869b54c6210d256ac6efae1e31da9ee9b49caf56
https://github.com/python/cpython/tree/869b54c6210d256ac6efae1e31da9ee9b49caf56
Merge remote-tracking branch 'upstream/master' into windows-subprocess-close-fdshttps://github.com/python/cpython/pull/1218/commits/66b74f62ace47d52a0d382869bd5ec26fcdd4758
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
66b74f6https://github.com/python/cpython/pull/1218/commits/66b74f62ace47d52a0d382869bd5ec26fcdd4758
https://github.com/python/cpython/tree/66b74f62ace47d52a0d382869bd5ec26fcdd4758
Merge remote-tracking branch 'upstream/master' into windows-subprocess-close-fdshttps://github.com/python/cpython/pull/1218/commits/ba19bd8062d629315aa9c9e47cf5fa3b0c1f8179
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
ba19bd8https://github.com/python/cpython/pull/1218/commits/ba19bd8062d629315aa9c9e47cf5fa3b0c1f8179
https://github.com/python/cpython/tree/ba19bd8062d629315aa9c9e47cf5fa3b0c1f8179
Add Segev Finer to Misc/ACKShttps://github.com/python/cpython/pull/1218/commits/3b0426e188575ef5fe7a8e63072f7897ce70e169
https://github.com/segevfiner
segevfinerhttps://github.com/python/cpython/commits?author=segevfiner
3b0426ehttps://github.com/python/cpython/pull/1218/commits/3b0426e188575ef5fe7a8e63072f7897ce70e169
https://github.com/python/cpython/tree/3b0426e188575ef5fe7a8e63072f7897ce70e169
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.