René's URL Explorer Experiment


Title: bpo-19764: Implemented support for subprocess.Popen(close_fds=True) on Windows by segevfiner · Pull Request #1218 · python/cpython · GitHub

Open Graph Title: bpo-19764: Implemented support for subprocess.Popen(close_fds=True) on Windows by segevfiner · Pull Request #1218 · python/cpython

X Title: bpo-19764: Implemented support for subprocess.Popen(close_fds=True) on Windows by segevfiner · Pull Request #1218 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Even though Python marks any handles it opens as non-inheritable there is still a race when using subprocess.Popen since creating a process with redirected stdio requires temporarily creating inher...

X Description: Even though Python marks any handles it opens as non-inheritable there is still a race when using subprocess.Popen since creating a process with redirected stdio requires temporarily creating inher...

Opengraph URL: https://github.com/python/cpython/pull/1218

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9818415b-0cab-e43b-fbb8-ba581355da1a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC0F6:4EB39:D441F4:11A17F0:6A502596
html-safe-nonceb8523ca9dd05bdb55d88ff9e68480627952a2063960ef0735f7fea4516a5cd54
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEY2OjRFQjM5OkQ0NDFGNDoxMUExN0YwOjZBNTAyNTk2IiwidmlzaXRvcl9pZCI6IjE5NzU4OTg5OTMzNDM4NjYyNjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac918f32cbc19bf1d74bc7970704a9864106ef6c0d342e0165e05533e8c566d67d
hovercard-subject-tagpull_request:116850318
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/1218/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/36a168051786e5e6920376635ed059e6ab10e8f61771e566e324b7fe0d01c1c1/python/cpython/pull/1218
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/36a168051786e5e6920376635ed059e6ab10e8f61771e566e324b7fe0d01c1c1/python/cpython/pull/1218
og:image:altEven though Python marks any handles it opens as non-inheritable there is still a race when using subprocess.Popen since creating a process with redirected stdio requires temporarily creating inher...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesegevfiner
hostnamegithub.com
expected-hostnamegithub.com
Nonea08040246389072795e3b4e7b33c6d9a0c564eee02e829a809326d67c418b069
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released1b91b18e7330fc458dfd824c61eaed7daa830d6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/1218#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1218
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1218
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/1218
Reloadhttps://github.com/python/cpython/pull/1218
Reloadhttps://github.com/python/cpython/pull/1218
Please reload this pagehttps://github.com/python/cpython/pull/1218
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/1218
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
segevfiner:windows-subprocess-close-fdshttps://github.com/segevfiner/cpython/tree/windows-subprocess-close-fds
Conversationhttps://github.com/python/cpython/pull/1218
Commits24 (24)https://github.com/python/cpython/pull/1218/commits
Checkshttps://github.com/python/cpython/pull/1218/checks
Files changedhttps://github.com/python/cpython/pull/1218/files
bpo-19764: Implemented support for subprocess.Popen(close_fds=True) on Windowshttps://github.com/python/cpython/pull/1218#top
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
segevfiner:windows-subprocess-close-fdshttps://github.com/segevfiner/cpython/tree/windows-subprocess-close-fds
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Apr 20, 2017https://github.com/python/cpython/pull/1218#issue-223179063
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://bugs.python.org/issue19764https://bugs.python.org/issue19764
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
Apr 20, 2017https://github.com/python/cpython/pull/1218#issuecomment-295878694
PSF contributor agreementhttps://www.python.org/psf/contrib/contrib-form/
bugs.python.orghttp://bugs.python.org/
the steps outlined in the CPython devguidehttps://cpython-devguide.readthedocs.io/pullrequest.html#licensing
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Apr 20, 2017https://github.com/python/cpython/pull/1218#event-1051216118
https://github.com/mention-bot
mention-bothttps://github.com/mention-bot
Apr 20, 2017https://github.com/python/cpython/pull/1218#issuecomment-295878717
@segevfinerhttps://github.com/segevfiner
@gpsheadhttps://github.com/gpshead
@zwarehttps://github.com/zware
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
force-pushedhttps://github.com/python/cpython/compare/2573232a94b1b80b3dfcd9c1efdd5ab67673b599..cd2a32247d06ba3884b05a309ba55811a7be0b2a
2573232https://github.com/python/cpython/commit/2573232a94b1b80b3dfcd9c1efdd5ab67673b599
cd2a322https://github.com/python/cpython/commit/cd2a32247d06ba3884b05a309ba55811a7be0b2a
Compare https://github.com/python/cpython/compare/2573232a94b1b80b3dfcd9c1efdd5ab67673b599..cd2a32247d06ba3884b05a309ba55811a7be0b2a
April 20, 2017 19:52https://github.com/python/cpython/pull/1218#event-1051221805
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Apr 20, 2017https://github.com/python/cpython/pull/1218#event-1051221835
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Apr 20, 2017https://github.com/python/cpython/pull/1218#issuecomment-295881395
@eryksunhttps://github.com/eryksun
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/eryksun
eryksunhttps://github.com/eryksun
Apr 20, 2017 https://github.com/python/cpython/pull/1218#pullrequestreview-33875953
View reviewed changes https://github.com/python/cpython/pull/1218/files
Lib/subprocess.pyhttps://github.com/python/cpython/pull/1218/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
eryksunhttps://github.com/eryksun
Apr 20, 2017https://github.com/python/cpython/pull/1218#discussion_r112550959
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
segevfinerhttps://github.com/segevfiner
Apr 20, 2017https://github.com/python/cpython/pull/1218#discussion_r112573861
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
segevfinerhttps://github.com/segevfiner
Apr 20, 2017https://github.com/python/cpython/pull/1218#discussion_r112576741
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Issue #30121http://bugs.python.org/issue30121
Please reload this pagehttps://github.com/python/cpython/pull/1218
eryksunhttps://github.com/eryksun
Apr 20, 2017https://github.com/python/cpython/pull/1218#discussion_r112579386
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/eryksun
eryksunhttps://github.com/eryksun
Apr 21, 2017 https://github.com/python/cpython/pull/1218#pullrequestreview-33939491
View reviewed changes https://github.com/python/cpython/pull/1218/files
Lib/subprocess.pyhttps://github.com/python/cpython/pull/1218/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
eryksunhttps://github.com/eryksun
Apr 21, 2017https://github.com/python/cpython/pull/1218#discussion_r112611081
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
segevfinerhttps://github.com/segevfiner
Apr 21, 2017https://github.com/python/cpython/pull/1218#discussion_r112643528
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
line 989https://github.com/python/cpython/pull/1218/files/af4e1d59213b729e9a5d1c3be59c7b948888a203#diff-cc136486b4a8e112e64b57436a0619ebR989
Please reload this pagehttps://github.com/python/cpython/pull/1218
eryksunhttps://github.com/eryksun
Apr 21, 2017https://github.com/python/cpython/pull/1218#discussion_r112650449
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
segevfinerhttps://github.com/segevfiner
Apr 21, 2017https://github.com/python/cpython/pull/1218#discussion_r112655491
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
eryksunhttps://github.com/eryksun
Apr 21, 2017https://github.com/python/cpython/pull/1218#discussion_r112687565
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
segevfinerhttps://github.com/segevfiner
Apr 21, 2017https://github.com/python/cpython/pull/1218#discussion_r112729431
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
segevfinerhttps://github.com/segevfiner
April 21, 2017 13:03https://github.com/python/cpython/pull/1218#commits-pushed-7e68016
https://github.com/segevfiner
bpo-19764: Implemented support for subprocess.Popen(close_fds=True) o…https://github.com/python/cpython/pull/1218/commits/7e680162690327c35ddde943c6b065e686d464d3
7e68016https://github.com/python/cpython/pull/1218/commits/7e680162690327c35ddde943c6b065e686d464d3
https://github.com/segevfiner
bpo-19764: Convert subprocess.Handle to int in handle_listhttps://github.com/python/cpython/pull/1218/commits/ad07b107b825ad7b70897143cba3ed615312dcf1
ad07b10https://github.com/python/cpython/pull/1218/commits/ad07b107b825ad7b70897143cba3ed615312dcf1
https://github.com/segevfiner
bpo-19764: Fixed the handle_list warning with close_fds=Truehttps://github.com/python/cpython/pull/1218/commits/9ad94f36432bb83d5e83548870b895f6af461bac
9ad94f3https://github.com/python/cpython/pull/1218/commits/9ad94f36432bb83d5e83548870b895f6af461bac
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
force-pushedhttps://github.com/python/cpython/compare/af4e1d59213b729e9a5d1c3be59c7b948888a203..9ad94f36432bb83d5e83548870b895f6af461bac
af4e1d5https://github.com/python/cpython/commit/af4e1d59213b729e9a5d1c3be59c7b948888a203
9ad94f3https://github.com/python/cpython/commit/9ad94f36432bb83d5e83548870b895f6af461bac
Compare https://github.com/python/cpython/compare/af4e1d59213b729e9a5d1c3be59c7b948888a203..9ad94f36432bb83d5e83548870b895f6af461bac
April 21, 2017 10:03https://github.com/python/cpython/pull/1218#event-1052176020
segevfinerhttps://github.com/segevfiner
April 21, 2017 13:35https://github.com/python/cpython/pull/1218#commits-pushed-24f3f39
https://github.com/segevfiner
bpo-19764: Added a test for the overriding close_fds warninghttps://github.com/python/cpython/pull/1218/commits/24f3f3920613f73b7a2cbe3f6a06833d5a5f9857
24f3f39https://github.com/python/cpython/pull/1218/commits/24f3f3920613f73b7a2cbe3f6a06833d5a5f9857
https://github.com/segevfiner
bpo-19764: The warning should be emitted for handle_list and close_fd…https://github.com/python/cpython/pull/1218/commits/1eab24290b9005e0abf63dc52ae2206cfa053ab2
1eab242https://github.com/python/cpython/pull/1218/commits/1eab24290b9005e0abf63dc52ae2206cfa053ab2
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Apr 21, 2017https://github.com/python/cpython/pull/1218#issuecomment-296241855
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/zware
zwarehttps://github.com/zware
Apr 21, 2017https://github.com/python/cpython/pull/1218#issuecomment-296244483
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Apr 21, 2017https://github.com/python/cpython/pull/1218#issuecomment-296244882
@zwarehttps://github.com/zware
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 29, 2017https://github.com/python/cpython/pull/1218#issuecomment-304630265
@zoobahttps://github.com/zooba
@eryksunhttps://github.com/eryksun
http://bugs.python.org/issue19764http://bugs.python.org/issue19764
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/zooba
zoobahttps://github.com/zooba
May 31, 2017 https://github.com/python/cpython/pull/1218#pullrequestreview-41280632
View reviewed changes https://github.com/python/cpython/pull/1218/files/1eab24290b9005e0abf63dc52ae2206cfa053ab2
zoobahttps://github.com/zooba
https://github.com/python/cpython/pull/1218#pullrequestreview-41280632
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
Modules/_winapi.chttps://github.com/python/cpython/pull/1218/files/1eab24290b9005e0abf63dc52ae2206cfa053ab2#diff-42415407f8d0ef2d42e29d13d979f633e3543770e62c3871e1101ad532d336a8
zoobahttps://github.com/zooba
May 31, 2017https://github.com/python/cpython/pull/1218#discussion_r119403584
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
Modules/_winapi.chttps://github.com/python/cpython/pull/1218/files/1eab24290b9005e0abf63dc52ae2206cfa053ab2#diff-42415407f8d0ef2d42e29d13d979f633e3543770e62c3871e1101ad532d336a8
zoobahttps://github.com/zooba
May 31, 2017https://github.com/python/cpython/pull/1218#discussion_r119404375
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
Modules/_winapi.chttps://github.com/python/cpython/pull/1218/files/1eab24290b9005e0abf63dc52ae2206cfa053ab2#diff-42415407f8d0ef2d42e29d13d979f633e3543770e62c3871e1101ad532d336a8
zoobahttps://github.com/zooba
May 31, 2017https://github.com/python/cpython/pull/1218#discussion_r119404693
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/segevfiner
Minor fixes in _winapi.chttps://github.com/python/cpython/pull/1218/commits/5b3cccc0e1333db6b6140f15bdf07b89d7972404
5b3cccchttps://github.com/python/cpython/pull/1218/commits/5b3cccc0e1333db6b6140f15bdf07b89d7972404
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 31, 2017https://github.com/python/cpython/pull/1218#issuecomment-305245598
Please reload this pagehttps://github.com/python/cpython/pull/1218
Codecovhttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=h1
#1218https://codecov.io/gh/python/cpython/pull/1218?src=pr&el=desc
masterhttps://codecov.io/gh/python/cpython/commit/28205b203a4742c40080b4a2b4b2dcd800716edc?src=pr&el=desc
https://codecov.io/gh/python/cpython/pull/1218?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=tree
Lib/subprocess.pyhttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=tree#diff-TGliL3N1YnByb2Nlc3MucHk=
Lib/test/test_subprocess.pyhttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=tree#diff-TGliL3Rlc3QvdGVzdF9zdWJwcm9jZXNzLnB5
Lib/__future__.pyhttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=tree#diff-TGliL19fZnV0dXJlX18ucHk=
Lib/idlelib/idle_test/test_help_about.pyhttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=tree#diff-TGliL2lkbGVsaWIvaWRsZV90ZXN0L3Rlc3RfaGVscF9hYm91dC5weQ==
Lib/test/libregrtest/runtest.pyhttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=tree#diff-TGliL3Rlc3QvbGlicmVncnRlc3QvcnVudGVzdC5weQ==
Lib/sre_compile.pyhttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=tree#diff-TGliL3NyZV9jb21waWxlLnB5
Lib/re.pyhttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=tree#diff-TGliL3JlLnB5
Lib/idlelib/idle_test/test_textview.pyhttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=tree#diff-TGliL2lkbGVsaWIvaWRsZV90ZXN0L3Rlc3RfdGV4dHZpZXcucHk=
Lib/test/test_select.pyhttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=tree#diff-TGliL3Rlc3QvdGVzdF9zZWxlY3QucHk=
Lib/test/libregrtest/cmdline.pyhttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=tree#diff-TGliL3Rlc3QvbGlicmVncnRlc3QvY21kbGluZS5weQ==
198 morehttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=tree-more
Continue to review full report at Codecovhttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=footer
28205b2...c84449chttps://codecov.io/gh/python/cpython/pull/1218?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Jun 4, 2017https://github.com/python/cpython/pull/1218#issuecomment-306054651
@zoobahttps://github.com/zooba
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/zooba
zoobahttps://github.com/zooba
Jun 5, 2017https://github.com/python/cpython/pull/1218#issuecomment-306285478
@eryksunhttps://github.com/eryksun
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 6, 2017 https://github.com/python/cpython/pull/1218#pullrequestreview-42348683
View reviewed changes https://github.com/python/cpython/pull/1218/files/5b3cccc0e1333db6b6140f15bdf07b89d7972404
Doc/library/subprocess.rsthttps://github.com/python/cpython/pull/1218/files/5b3cccc0e1333db6b6140f15bdf07b89d7972404#diff-346949b57abf9f17798d03d93244ab8f54b1cebcef518df03b21134bf7411f1d
vstinnerhttps://github.com/vstinner
Jun 6, 2017https://github.com/python/cpython/pull/1218#discussion_r120390547
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
Lib/subprocess.pyhttps://github.com/python/cpython/pull/1218/files/5b3cccc0e1333db6b6140f15bdf07b89d7972404#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
vstinnerhttps://github.com/vstinner
Jun 6, 2017https://github.com/python/cpython/pull/1218#discussion_r120390835
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
eryksunhttps://github.com/eryksun
Jun 7, 2017https://github.com/python/cpython/pull/1218#discussion_r120517053
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
segevfinerhttps://github.com/segevfiner
Jun 7, 2017https://github.com/python/cpython/pull/1218#discussion_r120535796
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
eryksunhttps://github.com/eryksun
Jun 7, 2017https://github.com/python/cpython/pull/1218#discussion_r120546336
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
segevfinerhttps://github.com/segevfiner
Jun 7, 2017https://github.com/python/cpython/pull/1218#discussion_r120697927
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
Lib/subprocess.pyhttps://github.com/python/cpython/pull/1218/files/5b3cccc0e1333db6b6140f15bdf07b89d7972404#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
vstinnerhttps://github.com/vstinner
Jun 6, 2017https://github.com/python/cpython/pull/1218#discussion_r120390974
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
Lib/subprocess.pyhttps://github.com/python/cpython/pull/1218/files/5b3cccc0e1333db6b6140f15bdf07b89d7972404#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
vstinnerhttps://github.com/vstinner
Jun 6, 2017https://github.com/python/cpython/pull/1218#discussion_r120391374
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 6, 2017https://github.com/python/cpython/pull/1218#issuecomment-306522050
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/segevfiner
bpo-19764: Addressed review comments by haypohttps://github.com/python/cpython/pull/1218/commits/c84449c179fe59a94d4f3e80aa529c3cb8a97ae2
c84449chttps://github.com/python/cpython/pull/1218/commits/c84449c179fe59a94d4f3e80aa529c3cb8a97ae2
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Jun 6, 2017https://github.com/python/cpython/pull/1218#issuecomment-306576517
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 6, 2017https://github.com/python/cpython/pull/1218#issuecomment-306577590
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/segevfiner
Merge remote-tracking branch 'upstream/master' into windows-subproces…https://github.com/python/cpython/pull/1218/commits/f849f9203f3aaefd98b11a15aabcb996542e70eb
f849f92https://github.com/python/cpython/pull/1218/commits/f849f9203f3aaefd98b11a15aabcb996542e70eb
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 7, 2017https://github.com/python/cpython/pull/1218#issuecomment-306729938
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/segevfiner
bpo-19764: Add some extra documentation about handle_listhttps://github.com/python/cpython/pull/1218/commits/167590b4f20d226e31925eed75dedfb2a4aba5e2
167590bhttps://github.com/python/cpython/pull/1218/commits/167590b4f20d226e31925eed75dedfb2a4aba5e2
https://github.com/eryksun
eryksunhttps://github.com/eryksun
Jun 7, 2017 https://github.com/python/cpython/pull/1218#pullrequestreview-42729221
View reviewed changes https://github.com/python/cpython/pull/1218/files/167590b4f20d226e31925eed75dedfb2a4aba5e2
Doc/library/subprocess.rsthttps://github.com/python/cpython/pull/1218/files/167590b4f20d226e31925eed75dedfb2a4aba5e2#diff-346949b57abf9f17798d03d93244ab8f54b1cebcef518df03b21134bf7411f1d
eryksunhttps://github.com/eryksun
Jun 7, 2017https://github.com/python/cpython/pull/1218#discussion_r120739848
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
segevfinerhttps://github.com/segevfiner
June 8, 2017 00:25https://github.com/python/cpython/pull/1218#commits-pushed-59af91f
https://github.com/segevfiner
bpo-19764: Documentation updatehttps://github.com/python/cpython/pull/1218/commits/59af91f1aa87d509e5274cf20ced97258c92405d
59af91fhttps://github.com/python/cpython/pull/1218/commits/59af91f1aa87d509e5274cf20ced97258c92405d
https://github.com/segevfiner
bpo-19764: Fixed bad reStructuredText markuphttps://github.com/python/cpython/pull/1218/commits/d4a9cdbcebb2ebf050297549d264638c20d61e18
d4a9cdbhttps://github.com/python/cpython/pull/1218/commits/d4a9cdbcebb2ebf050297549d264638c20d61e18
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
force-pushedhttps://github.com/python/cpython/compare/4ce6fd093469a350f4405823340ebb4ac8e64e5a..d4a9cdbcebb2ebf050297549d264638c20d61e18
4ce6fd0https://github.com/python/cpython/commit/4ce6fd093469a350f4405823340ebb4ac8e64e5a
d4a9cdbhttps://github.com/python/cpython/commit/d4a9cdbcebb2ebf050297549d264638c20d61e18
Compare https://github.com/python/cpython/compare/4ce6fd093469a350f4405823340ebb4ac8e64e5a..d4a9cdbcebb2ebf050297549d264638c20d61e18
June 8, 2017 16:44https://github.com/python/cpython/pull/1218#event-1115864855
https://github.com/segevfiner
Merge remote-tracking branch 'upstream/master' into windows-subproces…https://github.com/python/cpython/pull/1218/commits/15424fa55de0939ba43e430bc80072a2dea57062
15424fahttps://github.com/python/cpython/pull/1218/commits/15424fa55de0939ba43e430bc80072a2dea57062
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Jun 10, 2017https://github.com/python/cpython/pull/1218#issuecomment-307549383
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/segevfiner
Merge remote-tracking branch 'upstream/master' into windows-subproces…https://github.com/python/cpython/pull/1218/commits/dc1e5516fe4aec16da7b4a3f188dec34f2ce4500
dc1e551https://github.com/python/cpython/pull/1218/commits/dc1e5516fe4aec16da7b4a3f188dec34f2ce4500
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Jun 24, 2017https://github.com/python/cpython/pull/1218#issuecomment-310857971
@eryksunhttps://github.com/eryksun
Please reload this pagehttps://github.com/python/cpython/pull/1218
segevfinerhttps://github.com/segevfiner
July 2, 2017 23:46https://github.com/python/cpython/pull/1218#commits-pushed-d99af74
https://github.com/segevfiner
Merge branch 'master' into windows-subprocess-close-fdshttps://github.com/python/cpython/pull/1218/commits/d99af74103ba0278c63eaa876248319047e56022
d99af74https://github.com/python/cpython/pull/1218/commits/d99af74103ba0278c63eaa876248319047e56022
https://github.com/segevfiner
Merge remote-tracking branch 'upstream/master' into windows-subproces…https://github.com/python/cpython/pull/1218/commits/c63e0454859c644c06c7b4f548e0aa5d235ed483
c63e045https://github.com/python/cpython/pull/1218/commits/c63e0454859c644c06c7b4f548e0aa5d235ed483
https://github.com/segevfiner
Merge branch 'master' into windows-subprocess-close-fdshttps://github.com/python/cpython/pull/1218/commits/f50ca378e324d9697ed11fec286a7438cba065a8
f50ca37https://github.com/python/cpython/pull/1218/commits/f50ca378e324d9697ed11fec286a7438cba065a8
https://github.com/segevfiner
Merge remote-tracking branch 'upstream/master' into windows-subproces…https://github.com/python/cpython/pull/1218/commits/38b45262386220c8a9ef6d0b70e6452fd60485e2
38b4526https://github.com/python/cpython/pull/1218/commits/38b45262386220c8a9ef6d0b70e6452fd60485e2
https://github.com/segevfiner
bpo-19764: Fix whitespacehttps://github.com/python/cpython/pull/1218/commits/8e5d21f1cf5f4c982bd8a8d09497fadb5e2e565f
8e5d21fhttps://github.com/python/cpython/pull/1218/commits/8e5d21f1cf5f4c982bd8a8d09497fadb5e2e565f
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
gpsheadhttps://github.com/gpshead
code ownerhttps://github.com/python/cpython/blob/4d3851727fb82195e4995c6064b0b2d6cbc031c4/.github/CODEOWNERS#L31
August 18, 2017 14:56https://github.com/python/cpython/pull/1218#event-1212037920
https://github.com/segevfiner
bpo-19764: Add NEWS.d entryhttps://github.com/python/cpython/pull/1218/commits/208274c8df26b5dca9cbc332500316023529fcf5
208274chttps://github.com/python/cpython/pull/1218/commits/208274c8df26b5dca9cbc332500316023529fcf5
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Aug 29, 2017 https://github.com/python/cpython/pull/1218#pullrequestreview-59269718
View reviewed changes https://github.com/python/cpython/pull/1218/files/208274c8df26b5dca9cbc332500316023529fcf5
gpsheadhttps://github.com/gpshead
https://github.com/python/cpython/pull/1218#pullrequestreview-59269718
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Aug 29, 2017https://github.com/python/cpython/pull/1218#event-1225829953
segevfinerhttps://github.com/segevfiner
September 19, 2017 13:10https://github.com/python/cpython/pull/1218#commits-pushed-869b54c
https://github.com/segevfiner
Merge branch 'master' into windows-subprocess-close-fdshttps://github.com/python/cpython/pull/1218/commits/869b54c6210d256ac6efae1e31da9ee9b49caf56
869b54chttps://github.com/python/cpython/pull/1218/commits/869b54c6210d256ac6efae1e31da9ee9b49caf56
https://github.com/segevfiner
Merge remote-tracking branch 'upstream/master' into windows-subproces…https://github.com/python/cpython/pull/1218/commits/66b74f62ace47d52a0d382869bd5ec26fcdd4758
66b74f6https://github.com/python/cpython/pull/1218/commits/66b74f62ace47d52a0d382869bd5ec26fcdd4758
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Nov 17, 2017https://github.com/python/cpython/pull/1218#issuecomment-345227488
Please reload this pagehttps://github.com/python/cpython/pull/1218
segevfinerhttps://github.com/segevfiner
December 16, 2017 12:05https://github.com/python/cpython/pull/1218#commits-pushed-ba19bd8
https://github.com/segevfiner
Merge remote-tracking branch 'upstream/master' into windows-subproces…https://github.com/python/cpython/pull/1218/commits/ba19bd8062d629315aa9c9e47cf5fa3b0c1f8179
ba19bd8https://github.com/python/cpython/pull/1218/commits/ba19bd8062d629315aa9c9e47cf5fa3b0c1f8179
https://github.com/segevfiner
Add Segev Finer to Misc/ACKShttps://github.com/python/cpython/pull/1218/commits/3b0426e188575ef5fe7a8e63072f7897ce70e169
3b0426ehttps://github.com/python/cpython/pull/1218/commits/3b0426e188575ef5fe7a8e63072f7897ce70e169
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
Dec 16, 2017https://github.com/python/cpython/pull/1218#issuecomment-352173947
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
b2a6083https://github.com/python/cpython/commit/b2a6083eb0384f38839d3f1ed32262a3852026fa
Dec 18, 2017https://github.com/python/cpython/pull/1218#event-1391707224
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Dec 18, 2017https://github.com/python/cpython/pull/1218#event-1391707282
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Dec 18, 2017https://github.com/python/cpython/pull/1218#issuecomment-352372211
@zoobahttps://github.com/zooba
@gpsheadhttps://github.com/gpshead
@segevfinerhttps://github.com/segevfiner
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/segevfiner
segevfinerhttps://github.com/segevfiner
January 9, 2018 21:34https://github.com/python/cpython/pull/1218#event-1416536185
https://github.com/alecmev
alecmevhttps://github.com/alecmev
Aug 13, 2022 https://github.com/python/cpython/pull/1218#ref-pullrequest-1333304337
Add --node-ipc support sublimelsp/LSP#2015 https://github.com/sublimelsp/LSP/pull/2015
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F1218
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/1218/files/5b3cccc0e1333db6b6140f15bdf07b89d7972404
https://github.com/eryksun
eryksun https://github.com/eryksun
https://github.com/python/cpython/pull/1218/files/167590b4f20d226e31925eed75dedfb2a4aba5e2
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/1218/files/208274c8df26b5dca9cbc332500316023529fcf5
https://github.com/zooba
zooba https://github.com/zooba
https://github.com/python/cpython/pull/1218/files/1eab24290b9005e0abf63dc52ae2206cfa053ab2
Please reload this pagehttps://github.com/python/cpython/pull/1218
https://github.com/segevfiner
https://github.com/the-knights-who-say-ni
https://github.com/mention-bot
https://github.com/zware
https://github.com/vstinner
https://github.com/zooba
https://github.com/serhiy-storchaka
https://github.com/eryksun
https://github.com/gpshead
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.