René's URL Explorer Experiment


Title: gh-113993: Don't immortalize in PyUnicode_InternInPlace; keep immortalizing in other API by encukou · Pull Request #121364 · python/cpython · GitHub

Open Graph Title: gh-113993: Don't immortalize in PyUnicode_InternInPlace; keep immortalizing in other API by encukou · Pull Request #121364 · python/cpython

X Title: gh-113993: Don't immortalize in PyUnicode_InternInPlace; keep immortalizing in other API by encukou · Pull Request #121364 · python/cpython

Description: Switch PyUnicode_InternInPlace to _PyUnicode_InternMortal Keep immortalizing in functions that take char*, and are almost exclusively used with strings known at compile-time: PyUnicode_InternFromS...

Open Graph Description: Switch PyUnicode_InternInPlace to _PyUnicode_InternMortal Keep immortalizing in functions that take char*, and are almost exclusively used with strings known at compile-time: PyUnicode_InternFromS...

X Description: Switch PyUnicode_InternInPlace to _PyUnicode_InternMortal Keep immortalizing in functions that take char*, and are almost exclusively used with strings known at compile-time: PyUnicode_InternFromS...

Opengraph URL: https://github.com/python/cpython/pull/121364

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:67e907dc-049c-8483-e2cc-faa1121977d7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB27A:1219C5:13DBDA0:1BCA8F1:696A3FEF
html-safe-nonce2b89df7ec8bd55297f354fecaa444cbadd8a08f3c5849119075dad225adab97d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjdBOjEyMTlDNToxM0RCREEwOjFCQ0E4RjE6Njk2QTNGRUYiLCJ2aXNpdG9yX2lkIjoiMTQxMTgxMTYxMjMwODQyMjYzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4292a6e39163dca40cee418b9b00be6414ff9f9b62c1c552cb60e5b5818d2b5b
hovercard-subject-tagpull_request:1953686123
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/121364/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a2fc798ed0e726d7f25de3ccc2045cee930a2d739fdcca597cf15f5f326e8dae/python/cpython/pull/121364
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a2fc798ed0e726d7f25de3ccc2045cee930a2d739fdcca597cf15f5f326e8dae/python/cpython/pull/121364
og:image:altSwitch PyUnicode_InternInPlace to _PyUnicode_InternMortal Keep immortalizing in functions that take char*, and are almost exclusively used with strings known at compile-time: PyUnicode_InternFromS...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release13581a31d51edf4a3aca179e10890a4d4f9b6d76
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/121364#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121364
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121364
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/121364
Reloadhttps://github.com/python/cpython/pull/121364
Reloadhttps://github.com/python/cpython/pull/121364
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/121364
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/121364
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/121364#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:intern-immortal-iiphttps://github.com/encukou/cpython/tree/intern-immortal-iip
gh-113993: Don't immortalize in PyUnicode_InternInPlace; keep immortalizing in other API https://github.com/python/cpython/pull/121364#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:intern-immortal-iiphttps://github.com/encukou/cpython/tree/intern-immortal-iip
Conversation 4 https://github.com/python/cpython/pull/121364
Commits 5 https://github.com/python/cpython/pull/121364/commits
Checks 0 https://github.com/python/cpython/pull/121364/checks
Files changed https://github.com/python/cpython/pull/121364/files
Please reload this pagehttps://github.com/python/cpython/pull/121364
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/encukou
encukouhttps://github.com/encukou
Jul 4, 2024https://github.com/python/cpython/pull/121364#issue-2390919387
Please reload this pagehttps://github.com/python/cpython/pull/121364
Interned strings are immortal, despite what the documentation says #113993https://github.com/python/cpython/issues/113993
https://cpython-previews--121364.org.readthedocs.build/https://cpython-previews--121364.org.readthedocs.build/
Please reload this pagehttps://github.com/python/cpython/pull/121364
encukouhttps://github.com/encukou
July 4, 2024 15:07https://github.com/python/cpython/pull/121364#commits-pushed-89ef034
https://github.com/encukou
Switch PyUnicode_InternInPlace to _PyUnicode_InternMortal, clarify docshttps://github.com/python/cpython/pull/121364/commits/89ef0348db221e4a35f441454eec12eba03e9332
89ef034https://github.com/python/cpython/pull/121364/commits/89ef0348db221e4a35f441454eec12eba03e9332
https://github.com/encukou
Document immortality in some functions that take const char *https://github.com/python/cpython/pull/121364/commits/a98caa5e6714ebb4477d5fb85951c0498b620c30
a98caa5https://github.com/python/cpython/pull/121364/commits/a98caa5e6714ebb4477d5fb85951c0498b620c30
https://github.com/encukou
.https://github.com/python/cpython/pull/121364/commits/0576943493aa849159cfc7b602cc6214969a4855
0576943https://github.com/python/cpython/pull/121364/commits/0576943493aa849159cfc7b602cc6214969a4855
https://github.com/encukou
Don't immortalize user-provided attr names in _ctypeshttps://github.com/python/cpython/pull/121364/commits/f2d457e7f10e228378d63b4235cc03825defd0a4
f2d457ehttps://github.com/python/cpython/pull/121364/commits/f2d457e7f10e228378d63b4235cc03825defd0a4
https://github.com/encukou
Add a blurbhttps://github.com/python/cpython/pull/121364/commits/caaa470c7f92e945fb236b6ebb9b8c204e0bfa14
caaa470https://github.com/python/cpython/pull/121364/commits/caaa470c7f92e945fb236b6ebb9b8c204e0bfa14
https://github.com/encukou
encukouhttps://github.com/encukou
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
code ownerhttps://github.com/python/cpython/blob/715ec630dd78819ed79cad5ac28617daefe1e745/.github/CODEOWNERS#L123
July 4, 2024 13:45https://github.com/python/cpython/pull/121364#event-13395307543
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 4, 2024 https://github.com/python/cpython/pull/121364#ref-issue-2079272299
Interned strings are immortal, despite what the documentation says #113993 https://github.com/python/cpython/issues/113993
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 4, 2024https://github.com/python/cpython/pull/121364#event-13395308773
https://github.com/encukou
encukouhttps://github.com/encukou
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jul 16, 2024https://github.com/python/cpython/pull/121364#event-13520053657
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jul 16, 2024https://github.com/python/cpython/pull/121364#issuecomment-2230751571
@encukouhttps://github.com/encukou
caaa470https://github.com/python/cpython/commit/caaa470c7f92e945fb236b6ebb9b8c204e0bfa14
Please reload this pagehttps://github.com/python/cpython/pull/121364
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jul 16, 2024https://github.com/python/cpython/pull/121364#event-13520054080
https://github.com/encukou
encukouhttps://github.com/encukou
b4aedb2https://github.com/python/cpython/commit/b4aedb23ae7954fb58084dda16cd41786819a8cf
Jul 16, 2024https://github.com/python/cpython/pull/121364#event-13521146273
https://github.com/encukou
encukouhttps://github.com/encukou
July 16, 2024 13:36https://github.com/python/cpython/pull/121364#event-13521147080
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 16, 2024https://github.com/python/cpython/pull/121364#event-13521147093
https://github.com/encukou
encukouhttps://github.com/encukou
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Jul 16, 2024https://github.com/python/cpython/pull/121364#event-13521148958
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jul 16, 2024https://github.com/python/cpython/pull/121364#issuecomment-2230913958
@encukouhttps://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/121364
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jul 16, 2024https://github.com/python/cpython/pull/121364#issuecomment-2230914100
@encukouhttps://github.com/encukou
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/121364
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
encukouhttps://github.com/encukou
Jul 16, 2024https://github.com/python/cpython/pull/121364#event-13521150626
encukouhttps://github.com/encukou
Jul 16, 2024 https://github.com/python/cpython/pull/121364#ref-commit-e65f4da
https://github.com/encukou
[3.13]https://github.com/encukou/cpython/commit/e65f4dac09c69edb58ca8266fae0a84434f39e6f
pythongh-113993https://github.com/python/cpython/issues/113993
: Don't immortalize in PyUnicode_InternInPlace;…https://github.com/encukou/cpython/commit/e65f4dac09c69edb58ca8266fae0a84434f39e6f
e65f4dahttps://github.com/encukou/cpython/commit/e65f4dac09c69edb58ca8266fae0a84434f39e6f
pythonGH-121364https://github.com/python/cpython/pull/121364
b4aedb2https://github.com/encukou/cpython/commit/b4aedb23ae7954fb58084dda16cd41786819a8cf
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 16, 2024https://github.com/python/cpython/pull/121364#issuecomment-2230936827
GH-121854https://github.com/python/cpython/pull/121854
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/121364
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Jul 16, 2024https://github.com/python/cpython/pull/121364#event-13521305437
estyxxhttps://github.com/estyxx
Jul 17, 2024 https://github.com/python/cpython/pull/121364#ref-commit-741774c
https://github.com/encukou
https://github.com/estyxx
pythongh-113993https://github.com/python/cpython/issues/113993
: Don't immortalize in PyUnicode_InternInPlace; keep i…https://github.com/estyxx/cpython/commit/741774cc9fbc3ff5db8485ed45fe4ff41beec1d4
741774chttps://github.com/estyxx/cpython/commit/741774cc9fbc3ff5db8485ed45fe4ff41beec1d4
python#121364https://github.com/python/cpython/pull/121364
encukouhttps://github.com/encukou
Jul 17, 2024 https://github.com/python/cpython/pull/121364#ref-commit-4395d68
https://github.com/encukou
[3.13]https://github.com/python/cpython/commit/4395d68c7017eacf0ad643befe1f1e0bc6149f26
gh-113993https://github.com/python/cpython/issues/113993
: Don't immortalize in PyUnicode_InternInPlace; keep …https://github.com/python/cpython/commit/4395d68c7017eacf0ad643befe1f1e0bc6149f26
4395d68https://github.com/python/cpython/commit/4395d68c7017eacf0ad643befe1f1e0bc6149f26
GH-121364https://github.com/python/cpython/pull/121364
GH-121854https://github.com/python/cpython/pull/121854
b4aedb2https://github.com/python/cpython/commit/b4aedb23ae7954fb58084dda16cd41786819a8cf
encukouhttps://github.com/encukou
Aug 16, 2024 https://github.com/python/cpython/pull/121364#ref-commit-aaa8afe
https://github.com/encukou
[3.12]https://github.com/encukou/cpython/commit/aaa8afe5a82a7c4af4601e5ec57e2125ff8b5545
pythongh-113993https://github.com/python/cpython/issues/113993
: Don't immortalize in PyUnicode_InternInPlace;…https://github.com/encukou/cpython/commit/aaa8afe5a82a7c4af4601e5ec57e2125ff8b5545
aaa8afehttps://github.com/encukou/cpython/commit/aaa8afe5a82a7c4af4601e5ec57e2125ff8b5545
pythonGH-121364https://github.com/python/cpython/pull/121364
b4aedb2https://github.com/encukou/cpython/commit/b4aedb23ae7954fb58084dda16cd41786819a8cf
https://github.com/encukou
encukouhttps://github.com/encukou
Aug 16, 2024 https://github.com/python/cpython/pull/121364#ref-pullrequest-2470158473
[3.12] gh-113993: Make interned strings mortal (GH-120520, GH-121364, GH-121903, GH-122303) #123065 https://github.com/python/cpython/pull/123065
Yhg1shttps://github.com/Yhg1s
Sep 27, 2024 https://github.com/python/cpython/pull/121364#ref-commit-49f6beb
https://github.com/encukou
https://github.com/ericsnowcurrently
[3.12]https://github.com/python/cpython/commit/49f6beb56a64dd0b688e8c728928a38eb6d78fef
gh-113993https://github.com/python/cpython/issues/113993
: Make interned strings mortal (https://github.com/python/cpython/commit/49f6beb56a64dd0b688e8c728928a38eb6d78fef
GH-120520https://github.com/python/cpython/pull/120520
,https://github.com/python/cpython/commit/49f6beb56a64dd0b688e8c728928a38eb6d78fef
GH-121364https://github.com/python/cpython/pull/121364
,https://github.com/python/cpython/commit/49f6beb56a64dd0b688e8c728928a38eb6d78fef
G…https://github.com/python/cpython/pull/121903
49f6bebhttps://github.com/python/cpython/commit/49f6beb56a64dd0b688e8c728928a38eb6d78fef
…H-121903https://github.com/python/cpython/pull/121903
GH-122303https://github.com/python/cpython/pull/122303
#123065https://github.com/python/cpython/pull/123065
gh-113993https://github.com/python/cpython/issues/113993
GH-120520https://github.com/python/cpython/pull/120520
GH-121364https://github.com/python/cpython/pull/121364
GH-121903https://github.com/python/cpython/pull/121903
GH-122303https://github.com/python/cpython/pull/122303
https://github.com/yuyichao
yuyichaohttps://github.com/yuyichao
May 1, 2025 https://github.com/python/cpython/pull/121364#ref-issue-3034121155
PyUnicode_InternFromString does not immortalize the string as the document claims #133260 https://github.com/python/cpython/issues/133260
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121364
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/encukou
encukou https://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/121364
https://github.com/encukou
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.