René's URL Explorer Experiment


Title: gh-113993: For string interning, do not rely on (or assert) _Py_IsImmortal by encukou · Pull Request #121358 · python/cpython · GitHub

Open Graph Title: gh-113993: For string interning, do not rely on (or assert) _Py_IsImmortal by encukou · Pull Request #121358 · python/cpython

X Title: gh-113993: For string interning, do not rely on (or assert) _Py_IsImmortal by encukou · Pull Request #121358 · python/cpython

Description: Older stable ABI extensions are allowed to make immortal objects mortal. Instead of _Py_IsImmortal, use _PyUnicode_STATE (interned and statically_allocated), or skip asserts altogether. Issue: I...

Open Graph Description: Older stable ABI extensions are allowed to make immortal objects mortal. Instead of _Py_IsImmortal, use _PyUnicode_STATE (interned and statically_allocated), or skip asserts altogether. Issue: I...

X Description: Older stable ABI extensions are allowed to make immortal objects mortal. Instead of _Py_IsImmortal, use _PyUnicode_STATE (interned and statically_allocated), or skip asserts altogether. Issue: I...

Opengraph URL: https://github.com/python/cpython/pull/121358

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f84d85ec-5fdb-ccaf-cde5-5db553fba043
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC4AC:29E881:167083:1F056A:696A3FDA
html-safe-noncedce403c9038a9efd0f8198cb23187016de4756ff0cb389aef02524002a6c2698
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNEFDOjI5RTg4MToxNjcwODM6MUYwNTZBOjY5NkEzRkRBIiwidmlzaXRvcl9pZCI6IjYyNDQ4NjU2MTM4ODA3NzA1MjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8d49e3a7bbf207654ff025a02bf39157edbb919fb830a0bc25140767d8c43efc
hovercard-subject-tagpull_request:1953454459
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/121358/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/77fa1868f5f599122264b32af181a9e2acd9f8c56f411aacd0a3dd0066289ebd/python/cpython/pull/121358
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/77fa1868f5f599122264b32af181a9e2acd9f8c56f411aacd0a3dd0066289ebd/python/cpython/pull/121358
og:image:altOlder stable ABI extensions are allowed to make immortal objects mortal. Instead of _Py_IsImmortal, use _PyUnicode_STATE (interned and statically_allocated), or skip asserts altogether. Issue: I...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release13581a31d51edf4a3aca179e10890a4d4f9b6d76
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/121358#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121358
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121358
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/121358
Reloadhttps://github.com/python/cpython/pull/121358
Reloadhttps://github.com/python/cpython/pull/121358
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/121358
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/121358
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/121358#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:no-assert-immortalhttps://github.com/encukou/cpython/tree/no-assert-immortal
gh-113993: For string interning, do not rely on (or assert) _Py_IsImmortal https://github.com/python/cpython/pull/121358#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:no-assert-immortalhttps://github.com/encukou/cpython/tree/no-assert-immortal
Conversation 4 https://github.com/python/cpython/pull/121358
Commits 2 https://github.com/python/cpython/pull/121358/commits
Checks 0 https://github.com/python/cpython/pull/121358/checks
Files changed https://github.com/python/cpython/pull/121358/files
Please reload this pagehttps://github.com/python/cpython/pull/121358
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/encukou
encukouhttps://github.com/encukou
Jul 4, 2024https://github.com/python/cpython/pull/121358#issue-2390653684
Please reload this pagehttps://github.com/python/cpython/pull/121358
Interned strings are immortal, despite what the documentation says #113993https://github.com/python/cpython/issues/113993
Please reload this pagehttps://github.com/python/cpython/pull/121358
encukouhttps://github.com/encukou
July 4, 2024 13:24https://github.com/python/cpython/pull/121358#commits-pushed-70b46c9
https://github.com/encukou
Add blurbhttps://github.com/python/cpython/pull/121358/commits/70b46c95c8bd8b70c1e420b1165e58a8a96827d7
70b46c9https://github.com/python/cpython/pull/121358/commits/70b46c95c8bd8b70c1e420b1165e58a8a96827d7
https://github.com/encukou
pythongh-113993https://github.com/python/cpython/issues/113993
: For string interning, do not assert or rely on _Py_I…https://github.com/python/cpython/pull/121358/commits/4d92f62c7ddea826aa916081eded4d234621304a
4d92f62https://github.com/python/cpython/pull/121358/commits/4d92f62c7ddea826aa916081eded4d234621304a
https://github.com/encukou
encukouhttps://github.com/encukou
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Jul 4, 2024https://github.com/python/cpython/pull/121358#event-13393600171
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 4, 2024 https://github.com/python/cpython/pull/121358#ref-issue-2079272299
Interned strings are immortal, despite what the documentation says #113993 https://github.com/python/cpython/issues/113993
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 4, 2024https://github.com/python/cpython/pull/121358#event-13393601165
https://github.com/encukou
encukouhttps://github.com/encukou
Jul 4, 2024 https://github.com/python/cpython/pull/121358#ref-issue-2388913456
python: Objects/unicodeobject.c:15052: intern_static: Assertion '_Py_IsImmortal(s)' failed. in various projects with pyo3-0.21.2 and Python 3.13.0b3 PyO3/pyo3#4309 https://github.com/PyO3/pyo3/issues/4309
https://github.com/mgorny
mgornyhttps://github.com/mgorny
Jul 4, 2024https://github.com/python/cpython/pull/121358#issuecomment-2208871232
Please reload this pagehttps://github.com/python/cpython/pull/121358
https://github.com/mgorny
mgornyhttps://github.com/mgorny
Jul 4, 2024 https://github.com/python/cpython/pull/121358#ref-issue-2390907079
[py3.13] rustworkx: python: ./Include/internal/pycore_object.h:268: _PyObject_Init: Assertion '_PyType_HasFeature(typeobj, Py_TPFLAGS_HEAPTYPE) || _Py_IsImmortal(typeobj)' failed. PyO3/pyo3#4311 https://github.com/PyO3/pyo3/issues/4311
https://github.com/encukou
encukouhttps://github.com/encukou
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jul 16, 2024https://github.com/python/cpython/pull/121358#event-13520067323
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jul 16, 2024https://github.com/python/cpython/pull/121358#issuecomment-2230753800
@encukouhttps://github.com/encukou
4d92f62https://github.com/python/cpython/commit/4d92f62c7ddea826aa916081eded4d234621304a
Please reload this pagehttps://github.com/python/cpython/pull/121358
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jul 16, 2024https://github.com/python/cpython/pull/121358#event-13520068535
https://github.com/encukou
encukouhttps://github.com/encukou
956270dhttps://github.com/python/cpython/commit/956270d08d5c23f59937e2f29f8e0b7f63d68afd
Jul 16, 2024https://github.com/python/cpython/pull/121358#event-13520842234
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jul 16, 2024https://github.com/python/cpython/pull/121358#issuecomment-2230869081
@encukouhttps://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/121358
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 16, 2024https://github.com/python/cpython/pull/121358#event-13520843082
https://github.com/encukou
encukouhttps://github.com/encukou
July 16, 2024 13:17https://github.com/python/cpython/pull/121358#event-13520843191
miss-islingtonhttps://github.com/miss-islington
Jul 16, 2024 https://github.com/python/cpython/pull/121358#ref-commit-ff54019
https://github.com/encukou
https://github.com/miss-islington
pythongh-113993https://github.com/python/cpython/issues/113993
: For string interning, do not rely on (or assert) _Py…https://github.com/miss-islington/cpython/commit/ff54019d3101eedf938c833e5d5836ae3ba9b884
ff54019https://github.com/miss-islington/cpython/commit/ff54019d3101eedf938c833e5d5836ae3ba9b884
pythonGH-121358https://github.com/python/cpython/pull/121358
956270dhttps://github.com/miss-islington/cpython/commit/956270d08d5c23f59937e2f29f8e0b7f63d68afd
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 16, 2024https://github.com/python/cpython/pull/121358#issuecomment-2230869648
GH-121851https://github.com/python/cpython/pull/121851
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/121358
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Jul 16, 2024https://github.com/python/cpython/pull/121358#event-13520846726
encukouhttps://github.com/encukou
Jul 16, 2024 https://github.com/python/cpython/pull/121358#ref-commit-281ffb6
https://github.com/miss-islington
https://github.com/encukou
[3.13]https://github.com/python/cpython/commit/281ffb60cc194c4eefee3e112888251abd1a749a
gh-113993https://github.com/python/cpython/issues/113993
: For string interning, do not rely on (or assert) _P…https://github.com/python/cpython/commit/281ffb60cc194c4eefee3e112888251abd1a749a
281ffb6https://github.com/python/cpython/commit/281ffb60cc194c4eefee3e112888251abd1a749a
GH-121358https://github.com/python/cpython/pull/121358
GH-121851https://github.com/python/cpython/pull/121851
gh-113993https://github.com/python/cpython/issues/113993
GH-121358https://github.com/python/cpython/pull/121358
956270dhttps://github.com/python/cpython/commit/956270d08d5c23f59937e2f29f8e0b7f63d68afd
estyxxhttps://github.com/estyxx
Jul 17, 2024 https://github.com/python/cpython/pull/121358#ref-commit-309b6e6
https://github.com/encukou
https://github.com/estyxx
pythongh-113993https://github.com/python/cpython/issues/113993
: For string interning, do not rely on (or assert) _Py…https://github.com/estyxx/cpython/commit/309b6e621c05455c81f695a443782d8c746b3376
309b6e6https://github.com/estyxx/cpython/commit/309b6e621c05455c81f695a443782d8c746b3376
pythonGH-121358https://github.com/python/cpython/pull/121358
encukouhttps://github.com/encukou
Oct 3, 2024 https://github.com/python/cpython/pull/121358#ref-commit-3e07c20
https://github.com/miss-islington
https://github.com/encukou
[3.12]https://github.com/encukou/cpython/commit/3e07c20277cda90941953426f7bddc71d009388a
pythongh-113993https://github.com/python/cpython/issues/113993
: For string interning, do not rely on (or asse…https://github.com/encukou/cpython/commit/3e07c20277cda90941953426f7bddc71d009388a
3e07c20https://github.com/encukou/cpython/commit/3e07c20277cda90941953426f7bddc71d009388a
pythonGH-121358https://github.com/python/cpython/pull/121358
pythonGH-121851https://github.com/python/cpython/pull/121851
pythongh-113993https://github.com/python/cpython/issues/113993
pythonGH-121358https://github.com/python/cpython/pull/121358
956270dhttps://github.com/encukou/cpython/commit/956270d08d5c23f59937e2f29f8e0b7f63d68afd
encukouhttps://github.com/encukou
Oct 4, 2024 https://github.com/python/cpython/pull/121358#ref-commit-b3e2c02
https://github.com/encukou
https://github.com/miss-islington
[3.12]https://github.com/python/cpython/commit/b3e2c0291595edddc968680689bec7707d27d2d1
gh-113993https://github.com/python/cpython/issues/113993
: For string interning, do not rely on (or assert) _P…https://github.com/python/cpython/commit/b3e2c0291595edddc968680689bec7707d27d2d1
b3e2c02https://github.com/python/cpython/commit/b3e2c0291595edddc968680689bec7707d27d2d1
GH-121358https://github.com/python/cpython/pull/121358
GH-124938https://github.com/python/cpython/pull/124938
gh-113993https://github.com/python/cpython/issues/113993
GH-121358https://github.com/python/cpython/pull/121358
956270dhttps://github.com/python/cpython/commit/956270d08d5c23f59937e2f29f8e0b7f63d68afd
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121358
Please reload this pagehttps://github.com/python/cpython/pull/121358
https://github.com/encukou
https://github.com/mgorny
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.