René's URL Explorer Experiment


Title: gh-121160: Add a test for readline.set_history_length by encukou · Pull Request #121326 · python/cpython · GitHub

Open Graph Title: gh-121160: Add a test for readline.set_history_length by encukou · Pull Request #121326 · python/cpython

X Title: gh-121160: Add a test for readline.set_history_length by encukou · Pull Request #121326 · python/cpython

Description: I could not reproduce the reported issue, but, I didn't try very hard to test on various readline libraries. Regardless, set_history_length was missing a test. This PR should show if the error exists on CPython's buildbot platforms. (And if it doesn't and it's merged, it should fail for redistributors with who build with different libraries.) My copy of readline (Fedora 40) reports an extra history element after reading the file; IMO that's not the end of the world. Issue: gh-121160

Open Graph Description: I could not reproduce the reported issue, but, I didn't try very hard to test on various readline libraries. Regardless, set_history_length was missing a test. This PR should show if the error ...

X Description: I could not reproduce the reported issue, but, I didn't try very hard to test on various readline libraries. Regardless, set_history_length was missing a test. This PR should show if the er...

Opengraph URL: https://github.com/python/cpython/pull/121326

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6c33266b-3032-8768-5b0a-92c55e7ece1b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8888:317608:40D024B:5200FC6:6B021726
html-safe-nonce462161ba45008315bfdbf2a77d4e3bb9c84afa35a0a32235364255cc7d55624c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODg4OjMxNzYwODo0MEQwMjRCOjUyMDBGQzY6NkIwMjE3MjYiLCJ2aXNpdG9yX2lkIjoiNjE5MzM2MzU0ODY2NDYzMzEyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbb6c99b1598baa224670dd283c431b68d4acc4105e878a95c92865b9a09e76c1
hovercard-subject-tagpull_request:1951448443
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/121326/files
twitter:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
og:image:altI could not reproduce the reported issue, but, I didn't try very hard to test on various readline libraries. Regardless, set_history_length was missing a test. This PR should show if the error ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/121326/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121326%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121326%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/121326/files
Reloadhttps://github.com/python/cpython/pull/121326/files
Reloadhttps://github.com/python/cpython/pull/121326/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:readline-history-testhttps://github.com/encukou/cpython/tree/readline-history-test
Conversation 6 https://github.com/python/cpython/pull/121326
Commits 3 https://github.com/python/cpython/pull/121326/commits
Checks 0 https://github.com/python/cpython/pull/121326/checks
Files changed https://github.com/python/cpython/pull/121326/files
Please reload this pagehttps://github.com/python/cpython/pull/121326/files
gh-121160: Add a test for readline.set_history_length https://github.com/python/cpython/pull/121326/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/121326/files
ba60eae gh-121160: Add a test for readline.set_history_length encukou Jul 3, 2024 https://github.com/python/cpython/pull/121326/commits/ba60eae46b4f925a72925da638ea0b2b9f3edd85
49b4e50 Add blurb encukou Jul 3, 2024 https://github.com/python/cpython/pull/121326/commits/49b4e50e5e50ff0581f35a949964f0328bb8c15a
626439e Add a test that runs even when clear_history() is not available encukou Jul 4, 2024 https://github.com/python/cpython/pull/121326/commits/626439e77f854f1eb8016532f0e5d86b2fb7cd35
Clear filters https://github.com/python/cpython/pull/121326/files
Please reload this pagehttps://github.com/python/cpython/pull/121326/files
Please reload this pagehttps://github.com/python/cpython/pull/121326/files
test_readline.py https://github.com/python/cpython/pull/121326/files#diff-b4ac044a458e81aaaf6aad0767e5f5af8e27c310be9ed216e88dfb0839281bfd
2024-07-03-14-41-00.gh-issue-121160.LEtiTd.rst https://github.com/python/cpython/pull/121326/files#diff-b8e885263b0ada1853da2387f297f2ead80cfc149cd69b36e775f7365b6afa68
Lib/test/test_readline.pyhttps://github.com/python/cpython/pull/121326/files#diff-b4ac044a458e81aaaf6aad0767e5f5af8e27c310be9ed216e88dfb0839281bfd
View file https://github.com/encukou/cpython/blob/626439e77f854f1eb8016532f0e5d86b2fb7cd35/Lib/test/test_readline.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/121326/{{ revealButtonHref }}
https://github.com/python/cpython/pull/121326/files#diff-b4ac044a458e81aaaf6aad0767e5f5af8e27c310be9ed216e88dfb0839281bfd
https://github.com/python/cpython/pull/121326/files#diff-b4ac044a458e81aaaf6aad0767e5f5af8e27c310be9ed216e88dfb0839281bfd
https://github.com/python/cpython/pull/121326/files#diff-b4ac044a458e81aaaf6aad0767e5f5af8e27c310be9ed216e88dfb0839281bfd
Misc/NEWS.d/next/Tests/2024-07-03-14-41-00.gh-issue-121160.LEtiTd.rsthttps://github.com/python/cpython/pull/121326/files#diff-b8e885263b0ada1853da2387f297f2ead80cfc149cd69b36e775f7365b6afa68
View file https://github.com/encukou/cpython/blob/626439e77f854f1eb8016532f0e5d86b2fb7cd35/Misc/NEWS.d/next/Tests/2024-07-03-14-41-00.gh-issue-121160.LEtiTd.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/121326/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.