René's URL Explorer Experiment


Title: gh-121160: Add a test for readline.set_history_length by encukou · Pull Request #121326 · python/cpython · GitHub

Open Graph Title: gh-121160: Add a test for readline.set_history_length by encukou · Pull Request #121326 · python/cpython

X Title: gh-121160: Add a test for readline.set_history_length by encukou · Pull Request #121326 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: I could not reproduce the reported issue, but, I didn't try very hard to test on various readline libraries. Regardless, set_history_length was missing a test. This PR should show if the error ...

X Description: I could not reproduce the reported issue, but, I didn't try very hard to test on various readline libraries. Regardless, set_history_length was missing a test. This PR should show if the er...

Opengraph URL: https://github.com/python/cpython/pull/121326

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:347fe651-43c9-d885-8907-6dc99a2c72a6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA494:1F927B:174FECE:1EC2F7F:6B02031E
html-safe-nonce76a5b09e7a9cc33eaae2ec73ef373830410c234e0ee68b6e8a412cd7196e9bb9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDk0OjFGOTI3QjoxNzRGRUNFOjFFQzJGN0Y6NkIwMjAzMUUiLCJ2aXNpdG9yX2lkIjoiMzk0NTA1NTA4MjgwNzMwMzk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb6583a38639e9679c4df39d7a5443ffc78732a0190966894a5b96ae94cbf9156
hovercard-subject-tagpull_request:1951448443
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/121326/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6dc60aae19765880a608438a1e8a5a7a5b3f0f432b73f9b3422e17e62238da1d/python/cpython/pull/121326
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6dc60aae19765880a608438a1e8a5a7a5b3f0f432b73f9b3422e17e62238da1d/python/cpython/pull/121326
og:image:altI could not reproduce the reported issue, but, I didn't try very hard to test on various readline libraries. Regardless, set_history_length was missing a test. This PR should show if the error ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/121326#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121326
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121326
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/121326
Reloadhttps://github.com/python/cpython/pull/121326
Reloadhttps://github.com/python/cpython/pull/121326
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:readline-history-testhttps://github.com/encukou/cpython/tree/readline-history-test
Conversationhttps://github.com/python/cpython/pull/121326
Commits3 (3)https://github.com/python/cpython/pull/121326/commits
Checkshttps://github.com/python/cpython/pull/121326/checks
Files changedhttps://github.com/python/cpython/pull/121326/files
gh-121160: Add a test for readline.set_history_lengthhttps://github.com/python/cpython/pull/121326#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:readline-history-testhttps://github.com/encukou/cpython/tree/readline-history-test
https://github.com/encukou
encukouhttps://github.com/encukou
Jul 3, 2024https://github.com/python/cpython/pull/121326#issue-2388418118
Please reload this pagehttps://github.com/python/cpython/pull/121326
readline.set_history_length corrupts history files when used in a libedit build #121160https://github.com/python/cpython/issues/121160
Please reload this pagehttps://github.com/python/cpython/pull/121326
https://github.com/encukou
pythongh-121160https://github.com/python/cpython/issues/121160
: Add a test for readline.set_history_lengthhttps://github.com/python/cpython/pull/121326/commits/ba60eae46b4f925a72925da638ea0b2b9f3edd85
ba60eaehttps://github.com/python/cpython/pull/121326/commits/ba60eae46b4f925a72925da638ea0b2b9f3edd85
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 3, 2024 https://github.com/python/cpython/pull/121326#ref-issue-2381826981
readline.set_history_length corrupts history files when used in a libedit build #121160 https://github.com/python/cpython/issues/121160
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 3, 2024https://github.com/python/cpython/pull/121326#event-13379291369
https://github.com/encukou
encukouhttps://github.com/encukou
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jul 3, 2024https://github.com/python/cpython/pull/121326#event-13379489652
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jul 3, 2024https://github.com/python/cpython/pull/121326#issuecomment-2205909557
@encukouhttps://github.com/encukou
ba60eaehttps://github.com/python/cpython/commit/ba60eae46b4f925a72925da638ea0b2b9f3edd85
Please reload this pagehttps://github.com/python/cpython/pull/121326
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jul 3, 2024https://github.com/python/cpython/pull/121326#event-13379490520
encukouhttps://github.com/encukou
July 3, 2024 14:41https://github.com/python/cpython/pull/121326#commits-pushed-49b4e50
https://github.com/encukou
Add blurbhttps://github.com/python/cpython/pull/121326/commits/49b4e50e5e50ff0581f35a949964f0328bb8c15a
49b4e50https://github.com/python/cpython/pull/121326/commits/49b4e50e5e50ff0581f35a949964f0328bb8c15a
https://github.com/encukou
Add a test that runs even when clear_history() is not availablehttps://github.com/python/cpython/pull/121326/commits/626439e77f854f1eb8016532f0e5d86b2fb7cd35
626439ehttps://github.com/python/cpython/pull/121326/commits/626439e77f854f1eb8016532f0e5d86b2fb7cd35
https://github.com/encukou
encukouhttps://github.com/encukou
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jul 4, 2024https://github.com/python/cpython/pull/121326#event-13394802361
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jul 4, 2024https://github.com/python/cpython/pull/121326#issuecomment-2208946392
@encukouhttps://github.com/encukou
626439ehttps://github.com/python/cpython/commit/626439e77f854f1eb8016532f0e5d86b2fb7cd35
Please reload this pagehttps://github.com/python/cpython/pull/121326
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jul 4, 2024https://github.com/python/cpython/pull/121326#event-13394803043
https://github.com/encukou
encukouhttps://github.com/encukou
263c7e6https://github.com/python/cpython/commit/263c7e611bb24715e513d457a3477a61fff15162
Jul 16, 2024https://github.com/python/cpython/pull/121326#event-13521707296
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 16, 2024https://github.com/python/cpython/pull/121326#event-13521708846
https://github.com/encukou
encukouhttps://github.com/encukou
July 16, 2024 14:09https://github.com/python/cpython/pull/121326#event-13521709479
https://github.com/encukou
encukouhttps://github.com/encukou
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Jul 16, 2024https://github.com/python/cpython/pull/121326#event-13521720572
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jul 16, 2024https://github.com/python/cpython/pull/121326#issuecomment-2230997703
@encukouhttps://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/121326
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Jul 16, 2024https://github.com/python/cpython/pull/121326#issuecomment-2230997714
@encukouhttps://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/121326
miss-islingtonhttps://github.com/miss-islington
Jul 16, 2024 https://github.com/python/cpython/pull/121326#ref-commit-7bda4da
https://github.com/encukou
https://github.com/miss-islington
pythongh-121160https://github.com/python/cpython/issues/121160
: Add some tests for readline.set_history_length (https://github.com/miss-islington/cpython/commit/7bda4da1b1fc775dfdbda0bdbab5f0b6f4b464be
pyth…https://github.com/python/cpython/pull/121326
7bda4dahttps://github.com/miss-islington/cpython/commit/7bda4da1b1fc775dfdbda0bdbab5f0b6f4b464be
…onGH-121326https://github.com/python/cpython/pull/121326
263c7e6https://github.com/miss-islington/cpython/commit/263c7e611bb24715e513d457a3477a61fff15162
miss-islingtonhttps://github.com/miss-islington
Jul 16, 2024 https://github.com/python/cpython/pull/121326#ref-commit-a65b2da
https://github.com/encukou
https://github.com/miss-islington
pythongh-121160https://github.com/python/cpython/issues/121160
: Add some tests for readline.set_history_length (https://github.com/miss-islington/cpython/commit/a65b2da30edf8d82261fe11b4e334cc9e69a34b4
pyth…https://github.com/python/cpython/pull/121326
a65b2dahttps://github.com/miss-islington/cpython/commit/a65b2da30edf8d82261fe11b4e334cc9e69a34b4
…onGH-121326https://github.com/python/cpython/pull/121326
263c7e6https://github.com/miss-islington/cpython/commit/263c7e611bb24715e513d457a3477a61fff15162
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 16, 2024https://github.com/python/cpython/pull/121326#issuecomment-2230998404
GH-121856https://github.com/python/cpython/pull/121856
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/121326
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Jul 16, 2024https://github.com/python/cpython/pull/121326#event-13521725433
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 16, 2024https://github.com/python/cpython/pull/121326#issuecomment-2230998593
GH-121857https://github.com/python/cpython/pull/121857
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/121326
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jul 16, 2024https://github.com/python/cpython/pull/121326#event-13521726589
encukouhttps://github.com/encukou
Jul 16, 2024 https://github.com/python/cpython/pull/121326#ref-commit-7c9861f
https://github.com/miss-islington
https://github.com/encukou
[3.13]https://github.com/python/cpython/commit/7c9861f9d98975e12cefed40708650742efccb2c
gh-121160https://github.com/python/cpython/issues/121160
: Add some tests for readline.set_history_length (https://github.com/python/cpython/commit/7c9861f9d98975e12cefed40708650742efccb2c
GH-…https://github.com/python/cpython/pull/121326
7c9861fhttps://github.com/python/cpython/commit/7c9861f9d98975e12cefed40708650742efccb2c
…121326https://github.com/python/cpython/pull/121326
GH-121856https://github.com/python/cpython/pull/121856
263c7e6https://github.com/python/cpython/commit/263c7e611bb24715e513d457a3477a61fff15162
encukouhttps://github.com/encukou
Jul 16, 2024 https://github.com/python/cpython/pull/121326#ref-commit-9d996b5
https://github.com/miss-islington
https://github.com/encukou
[3.12]https://github.com/python/cpython/commit/9d996b5205fbcd89509615788cd893cc0b0bfd22
gh-121160https://github.com/python/cpython/issues/121160
: Add some tests for readline.set_history_length (https://github.com/python/cpython/commit/9d996b5205fbcd89509615788cd893cc0b0bfd22
GH-…https://github.com/python/cpython/pull/121326
9d996b5https://github.com/python/cpython/commit/9d996b5205fbcd89509615788cd893cc0b0bfd22
…121326https://github.com/python/cpython/pull/121326
GH-121857https://github.com/python/cpython/pull/121857
263c7e6https://github.com/python/cpython/commit/263c7e611bb24715e513d457a3477a61fff15162
estyxxhttps://github.com/estyxx
Jul 17, 2024 https://github.com/python/cpython/pull/121326#ref-commit-9acf6d2
https://github.com/encukou
https://github.com/estyxx
pythongh-121160https://github.com/python/cpython/issues/121160
: Add some tests for readline.set_history_length (https://github.com/estyxx/cpython/commit/9acf6d20124ccadba74421d35db31c667d098999
pyth…https://github.com/python/cpython/pull/121326
9acf6d2https://github.com/estyxx/cpython/commit/9acf6d20124ccadba74421d35db31c667d098999
…onGH-121326https://github.com/python/cpython/pull/121326
https://github.com/encukou
encukouhttps://github.com/encukou
Jul 18, 2024 https://github.com/python/cpython/pull/121326#ref-issue-2416120728
readline.set_history_length results in unreadable history files astral-sh/python-build-standalone#281 https://github.com/astral-sh/python-build-standalone/issues/281
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121326
Please reload this pagehttps://github.com/python/cpython/pull/121326
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/121326
https://github.com/encukou
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.