| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:347fe651-43c9-d885-8907-6dc99a2c72a6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A494:1F927B:174FECE:1EC2F7F:6B02031E |
| html-safe-nonce | 76a5b09e7a9cc33eaae2ec73ef373830410c234e0ee68b6e8a412cd7196e9bb9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDk0OjFGOTI3QjoxNzRGRUNFOjFFQzJGN0Y6NkIwMjAzMUUiLCJ2aXNpdG9yX2lkIjoiMzk0NTA1NTA4MjgwNzMwMzk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b6583a38639e9679c4df39d7a5443ffc78732a0190966894a5b96ae94cbf9156 |
| hovercard-subject-tag | pull_request:1951448443 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/121326/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6dc60aae19765880a608438a1e8a5a7a5b3f0f432b73f9b3422e17e62238da1d/python/cpython/pull/121326 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6dc60aae19765880a608438a1e8a5a7a5b3f0f432b73f9b3422e17e62238da1d/python/cpython/pull/121326 |
| og:image:alt | I could not reproduce the reported issue, but, I didn't try very hard to test on various readline libraries.
Regardless, set_history_length was missing a test. This PR should show if the error ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | encukou |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/cpython/pull/121326#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121326 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121326 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/121326 |
| Reload | https://github.com/python/cpython/pull/121326 |
| Reload | https://github.com/python/cpython/pull/121326 |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| https://github.com/python/cpython |
| encukou | https://github.com/encukou |
| python:main | https://github.com/python/cpython/tree/main |
| encukou:readline-history-test | https://github.com/encukou/cpython/tree/readline-history-test |
| Conversation | https://github.com/python/cpython/pull/121326 |
| Commits3 (3) | https://github.com/python/cpython/pull/121326/commits |
| Checks | https://github.com/python/cpython/pull/121326/checks |
| Files changed | https://github.com/python/cpython/pull/121326/files |
| gh-121160: Add a test for readline.set_history_length | https://github.com/python/cpython/pull/121326#top |
| encukou | https://github.com/encukou |
| python:main | https://github.com/python/cpython/tree/main |
| encukou:readline-history-test | https://github.com/encukou/cpython/tree/readline-history-test |
|
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| Jul 3, 2024 | https://github.com/python/cpython/pull/121326#issue-2388418118 |
| Please reload this page | https://github.com/python/cpython/pull/121326 |
| readline.set_history_length corrupts history files when used in a libedit build #121160 | https://github.com/python/cpython/issues/121160 |
| Please reload this page | https://github.com/python/cpython/pull/121326 |
|
| https://github.com/encukou |
| pythongh-121160 | https://github.com/python/cpython/issues/121160 |
| : Add a test for readline.set_history_length | https://github.com/python/cpython/pull/121326/commits/ba60eae46b4f925a72925da638ea0b2b9f3edd85 |
| ba60eae | https://github.com/python/cpython/pull/121326/commits/ba60eae46b4f925a72925da638ea0b2b9f3edd85 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Jul 3, 2024
| https://github.com/python/cpython/pull/121326#ref-issue-2381826981 |
|
readline.set_history_length corrupts history files when used in a libedit build
#121160
| https://github.com/python/cpython/issues/121160 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
tests
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jul 3, 2024 | https://github.com/python/cpython/pull/121326#event-13379291369 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
🔨 test-with-buildbots
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22 |
| Jul 3, 2024 | https://github.com/python/cpython/pull/121326#event-13379489652 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Jul 3, 2024 | https://github.com/python/cpython/pull/121326#issuecomment-2205909557 |
| @encukou | https://github.com/encukou |
| ba60eae | https://github.com/python/cpython/commit/ba60eae46b4f925a72925da638ea0b2b9f3edd85 |
| Please reload this page | https://github.com/python/cpython/pull/121326 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
🔨 test-with-buildbots
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22 |
| Jul 3, 2024 | https://github.com/python/cpython/pull/121326#event-13379490520 |
| encukou | https://github.com/encukou |
| July 3, 2024 14:41 | https://github.com/python/cpython/pull/121326#commits-pushed-49b4e50 |
|
| https://github.com/encukou |
| Add blurb | https://github.com/python/cpython/pull/121326/commits/49b4e50e5e50ff0581f35a949964f0328bb8c15a |
| 49b4e50 | https://github.com/python/cpython/pull/121326/commits/49b4e50e5e50ff0581f35a949964f0328bb8c15a |
|
| https://github.com/encukou |
| Add a test that runs even when clear_history() is not available | https://github.com/python/cpython/pull/121326/commits/626439e77f854f1eb8016532f0e5d86b2fb7cd35 |
| 626439e | https://github.com/python/cpython/pull/121326/commits/626439e77f854f1eb8016532f0e5d86b2fb7cd35 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
|
🔨 test-with-buildbots
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22 |
| Jul 4, 2024 | https://github.com/python/cpython/pull/121326#event-13394802361 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Jul 4, 2024 | https://github.com/python/cpython/pull/121326#issuecomment-2208946392 |
| @encukou | https://github.com/encukou |
| 626439e | https://github.com/python/cpython/commit/626439e77f854f1eb8016532f0e5d86b2fb7cd35 |
| Please reload this page | https://github.com/python/cpython/pull/121326 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
🔨 test-with-buildbots
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22 |
| Jul 4, 2024 | https://github.com/python/cpython/pull/121326#event-13394803043 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| 263c7e6 | https://github.com/python/cpython/commit/263c7e611bb24715e513d457a3477a61fff15162 |
| Jul 16, 2024 | https://github.com/python/cpython/pull/121326#event-13521707296 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jul 16, 2024 | https://github.com/python/cpython/pull/121326#event-13521708846 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
| July 16, 2024 14:09 | https://github.com/python/cpython/pull/121326#event-13521709479 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
|
needs backport to 3.12
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22 |
|
needs backport to 3.13
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22 |
| Jul 16, 2024 | https://github.com/python/cpython/pull/121326#event-13521720572 |
| https://github.com/apps/miss-islington-app |
| miss-islington-app | https://github.com/apps/miss-islington-app |
| Jul 16, 2024 | https://github.com/python/cpython/pull/121326#issuecomment-2230997703 |
| @encukou | https://github.com/encukou |
| Please reload this page | https://github.com/python/cpython/pull/121326 |
| https://github.com/apps/miss-islington-app |
| miss-islington-app | https://github.com/apps/miss-islington-app |
| Jul 16, 2024 | https://github.com/python/cpython/pull/121326#issuecomment-2230997714 |
| @encukou | https://github.com/encukou |
| Please reload this page | https://github.com/python/cpython/pull/121326 |
| miss-islington | https://github.com/miss-islington |
|
Jul 16, 2024
| https://github.com/python/cpython/pull/121326#ref-commit-7bda4da |
|
| https://github.com/encukou |
|
| https://github.com/miss-islington |
| pythongh-121160 | https://github.com/python/cpython/issues/121160 |
| : Add some tests for readline.set_history_length ( | https://github.com/miss-islington/cpython/commit/7bda4da1b1fc775dfdbda0bdbab5f0b6f4b464be |
| pyth… | https://github.com/python/cpython/pull/121326 |
| 7bda4da | https://github.com/miss-islington/cpython/commit/7bda4da1b1fc775dfdbda0bdbab5f0b6f4b464be |
| …onGH-121326 | https://github.com/python/cpython/pull/121326 |
| 263c7e6 | https://github.com/miss-islington/cpython/commit/263c7e611bb24715e513d457a3477a61fff15162 |
| miss-islington | https://github.com/miss-islington |
|
Jul 16, 2024
| https://github.com/python/cpython/pull/121326#ref-commit-a65b2da |
|
| https://github.com/encukou |
|
| https://github.com/miss-islington |
| pythongh-121160 | https://github.com/python/cpython/issues/121160 |
| : Add some tests for readline.set_history_length ( | https://github.com/miss-islington/cpython/commit/a65b2da30edf8d82261fe11b4e334cc9e69a34b4 |
| pyth… | https://github.com/python/cpython/pull/121326 |
| a65b2da | https://github.com/miss-islington/cpython/commit/a65b2da30edf8d82261fe11b4e334cc9e69a34b4 |
| …onGH-121326 | https://github.com/python/cpython/pull/121326 |
| 263c7e6 | https://github.com/miss-islington/cpython/commit/263c7e611bb24715e513d457a3477a61fff15162 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
| Jul 16, 2024 | https://github.com/python/cpython/pull/121326#issuecomment-2230998404 |
| GH-121856 | https://github.com/python/cpython/pull/121856 |
| 3.13 branch | https://github.com/python/cpython/tree/3.13 |
| Please reload this page | https://github.com/python/cpython/pull/121326 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
needs backport to 3.13
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22 |
| Jul 16, 2024 | https://github.com/python/cpython/pull/121326#event-13521725433 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
| Jul 16, 2024 | https://github.com/python/cpython/pull/121326#issuecomment-2230998593 |
| GH-121857 | https://github.com/python/cpython/pull/121857 |
| 3.12 branch | https://github.com/python/cpython/tree/3.12 |
| Please reload this page | https://github.com/python/cpython/pull/121326 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
needs backport to 3.12
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22 |
| Jul 16, 2024 | https://github.com/python/cpython/pull/121326#event-13521726589 |
| encukou | https://github.com/encukou |
|
Jul 16, 2024
| https://github.com/python/cpython/pull/121326#ref-commit-7c9861f |
|
| https://github.com/miss-islington |
|
| https://github.com/encukou |
| [3.13] | https://github.com/python/cpython/commit/7c9861f9d98975e12cefed40708650742efccb2c |
| gh-121160 | https://github.com/python/cpython/issues/121160 |
| : Add some tests for readline.set_history_length ( | https://github.com/python/cpython/commit/7c9861f9d98975e12cefed40708650742efccb2c |
| GH-… | https://github.com/python/cpython/pull/121326 |
| 7c9861f | https://github.com/python/cpython/commit/7c9861f9d98975e12cefed40708650742efccb2c |
| …121326 | https://github.com/python/cpython/pull/121326 |
| GH-121856 | https://github.com/python/cpython/pull/121856 |
| 263c7e6 | https://github.com/python/cpython/commit/263c7e611bb24715e513d457a3477a61fff15162 |
| encukou | https://github.com/encukou |
|
Jul 16, 2024
| https://github.com/python/cpython/pull/121326#ref-commit-9d996b5 |
|
| https://github.com/miss-islington |
|
| https://github.com/encukou |
| [3.12] | https://github.com/python/cpython/commit/9d996b5205fbcd89509615788cd893cc0b0bfd22 |
| gh-121160 | https://github.com/python/cpython/issues/121160 |
| : Add some tests for readline.set_history_length ( | https://github.com/python/cpython/commit/9d996b5205fbcd89509615788cd893cc0b0bfd22 |
| GH-… | https://github.com/python/cpython/pull/121326 |
| 9d996b5 | https://github.com/python/cpython/commit/9d996b5205fbcd89509615788cd893cc0b0bfd22 |
| …121326 | https://github.com/python/cpython/pull/121326 |
| GH-121857 | https://github.com/python/cpython/pull/121857 |
| 263c7e6 | https://github.com/python/cpython/commit/263c7e611bb24715e513d457a3477a61fff15162 |
| estyxx | https://github.com/estyxx |
|
Jul 17, 2024
| https://github.com/python/cpython/pull/121326#ref-commit-9acf6d2 |
|
| https://github.com/encukou |
|
| https://github.com/estyxx |
| pythongh-121160 | https://github.com/python/cpython/issues/121160 |
| : Add some tests for readline.set_history_length ( | https://github.com/estyxx/cpython/commit/9acf6d20124ccadba74421d35db31c667d098999 |
| pyth… | https://github.com/python/cpython/pull/121326 |
| 9acf6d2 | https://github.com/estyxx/cpython/commit/9acf6d20124ccadba74421d35db31c667d098999 |
| …onGH-121326 | https://github.com/python/cpython/pull/121326 |
| https://github.com/encukou |
| encukou | https://github.com/encukou |
|
Jul 18, 2024
| https://github.com/python/cpython/pull/121326#ref-issue-2416120728 |
|
readline.set_history_length results in unreadable history files
astral-sh/python-build-standalone#281
| https://github.com/astral-sh/python-build-standalone/issues/281 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121326 |
| Please reload this page | https://github.com/python/cpython/pull/121326 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
tests
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests |
| Please reload this page | https://github.com/python/cpython/pull/121326 |
|
| https://github.com/encukou |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |