René's URL Explorer Experiment


Title: gh-121263: Macro-ify most stackref functions for MSVC by Fidget-Spinner · Pull Request #121270 · python/cpython · GitHub

Open Graph Title: gh-121263: Macro-ify most stackref functions for MSVC by Fidget-Spinner · Pull Request #121270 · python/cpython

X Title: gh-121263: Macro-ify most stackref functions for MSVC by Fidget-Spinner · Pull Request #121270 · python/cpython

Description: Issue: Stackrefs (#118450) introduced a large performance regression on Windows  #121263

Open Graph Description: Issue: Stackrefs (#118450) introduced a large performance regression on Windows  #121263

X Description: Issue: Stackrefs (#118450) introduced a large performance regression on Windows  #121263

Opengraph URL: https://github.com/python/cpython/pull/121270

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:75d6f00f-45e4-7811-932e-eb0bb2da208a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAFF8:14EAEF:7A22AD:A2E3D1:696BA9D7
html-safe-nonceffbbe27415f01827a7a520eda4aee99b571e7ade68275559772774d6b512a56e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkY4OjE0RUFFRjo3QTIyQUQ6QTJFM0QxOjY5NkJBOUQ3IiwidmlzaXRvcl9pZCI6IjU3MDI2NTM5NTI5OTc5NjAxNTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc6d2950beecf5f9abcf0fc44fa36193f84570c98d77fa1de53e97d0dcdde9e2a
hovercard-subject-tagpull_request:1949646195
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/121270/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7af148f5c0f6e72b53b55e014c98fdf6950c0470ea45c63b7504fa0874d3b1a5/python/cpython/pull/121270
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7af148f5c0f6e72b53b55e014c98fdf6950c0470ea45c63b7504fa0874d3b1a5/python/cpython/pull/121270
og:image:altIssue: Stackrefs (#118450) introduced a large performance regression on Windows  #121263
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFidget-Spinner
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/121270#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121270
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121270
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/121270
Reloadhttps://github.com/python/cpython/pull/121270
Reloadhttps://github.com/python/cpython/pull/121270
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/121270
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/121270
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/121270#issue-comment-box
Fidget-Spinnerhttps://github.com/Fidget-Spinner
python:mainhttps://github.com/python/cpython/tree/main
Fidget-Spinner:macro-ifyhttps://github.com/Fidget-Spinner/cpython/tree/macro-ify
gh-121263: Macro-ify most stackref functions for MSVC https://github.com/python/cpython/pull/121270#top
Fidget-Spinnerhttps://github.com/Fidget-Spinner
python:mainhttps://github.com/python/cpython/tree/main
Fidget-Spinner:macro-ifyhttps://github.com/Fidget-Spinner/cpython/tree/macro-ify
Conversation 4 https://github.com/python/cpython/pull/121270
Commits 1 https://github.com/python/cpython/pull/121270/commits
Checks 0 https://github.com/python/cpython/pull/121270/checks
Files changed https://github.com/python/cpython/pull/121270/files
Please reload this pagehttps://github.com/python/cpython/pull/121270
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Jul 2, 2024https://github.com/python/cpython/pull/121270#issue-2386414278
Please reload this pagehttps://github.com/python/cpython/pull/121270
Stackrefs (#118450) introduced a large performance regression on Windows  #121263https://github.com/python/cpython/issues/121263
Please reload this pagehttps://github.com/python/cpython/pull/121270
https://github.com/Fidget-Spinner
Macro-ify most stackref functions for MSVChttps://github.com/python/cpython/pull/121270/commits/2302696a9af2df4e2aaec5f6d9cab9dad3eb3e2f
2302696https://github.com/python/cpython/pull/121270/commits/2302696a9af2df4e2aaec5f6d9cab9dad3eb3e2f
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 2, 2024 https://github.com/python/cpython/pull/121270#ref-issue-2386074795
Stackrefs (#118450) introduced a large performance regression on Windows #121263 https://github.com/python/cpython/issues/121263
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 2, 2024https://github.com/python/cpython/pull/121270#event-13367114948
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jul 2, 2024https://github.com/python/cpython/pull/121270#event-13367117524
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Jul 2, 2024https://github.com/python/cpython/pull/121270#issuecomment-2203428484
@mdboomhttps://github.com/mdboom
Please reload this pagehttps://github.com/python/cpython/pull/121270
https://github.com/mdboom
mdboomhttps://github.com/mdboom
Jul 2, 2024https://github.com/python/cpython/pull/121270#issuecomment-2203656558
Please reload this pagehttps://github.com/python/cpython/pull/121270
https://github.com/mdboom
mdboomhttps://github.com/mdboom
Jul 2, 2024https://github.com/python/cpython/pull/121270#issuecomment-2204441782
Please reload this pagehttps://github.com/python/cpython/pull/121270
raw benchmaring results are herehttps://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20240702-3.14.0a0-2302696
#118450https://github.com/python/cpython/pull/118450
#118450https://github.com/python/cpython/pull/118450
@zoobahttps://github.com/zooba
pragma "hack" to disable optimization on MSVC for the main eval loophttps://github.com/python/cpython/blob/main/Python/ceval.c#L738
introduced to work around a compiler crashhttps://github.com/python/cpython/issues/111786
no longer include the Tier 2 interpreterhttps://github.com/python/cpython/pull/118339
Please reload this pagehttps://github.com/python/cpython/pull/121270
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Jul 3, 2024https://github.com/python/cpython/pull/121270#issuecomment-2205598747
Please reload this pagehttps://github.com/python/cpython/pull/121270
https://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20240702-3.14.0a0-a03affdhttps://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20240702-3.14.0a0-a03affd
Please reload this pagehttps://github.com/python/cpython/pull/121270
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
722229ehttps://github.com/python/cpython/commit/722229e5dc1e499664966e50bb98065670033300
Jul 3, 2024https://github.com/python/cpython/pull/121270#event-13377828144
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 3, 2024https://github.com/python/cpython/pull/121270#event-13377828814
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
July 3, 2024 09:49https://github.com/python/cpython/pull/121270#event-13377830837
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Jul 3, 2024https://github.com/python/cpython/pull/121270#event-13380691882
noahbkimhttps://github.com/noahbkim
Jul 11, 2024 https://github.com/python/cpython/pull/121270#ref-commit-4745a33
https://github.com/Fidget-Spinner
https://github.com/noahbkim
pythongh-121263https://github.com/python/cpython/issues/121263
: Macro-ify most stackref functions for MSVC (https://github.com/hudson-trading/cpython/commit/4745a33768e4e9b3bd3048338f4a41f9d43de116
pythonGH…https://github.com/python/cpython/pull/121270
4745a33https://github.com/hudson-trading/cpython/commit/4745a33768e4e9b3bd3048338f4a41f9d43de116
…-121270https://github.com/python/cpython/pull/121270
estyxxhttps://github.com/estyxx
Jul 17, 2024 https://github.com/python/cpython/pull/121270#ref-commit-d2927af
https://github.com/Fidget-Spinner
https://github.com/estyxx
pythongh-121263https://github.com/python/cpython/issues/121263
: Macro-ify most stackref functions for MSVC (https://github.com/estyxx/cpython/commit/d2927af873f951022964345ce772bc6542697288
pythonGH…https://github.com/python/cpython/pull/121270
d2927afhttps://github.com/estyxx/cpython/commit/d2927af873f951022964345ce772bc6542697288
…-121270https://github.com/python/cpython/pull/121270
mdboomhttps://github.com/mdboom
Jul 19, 2024 https://github.com/python/cpython/pull/121270#ref-commit-0853d0e
https://github.com/mdboom
Revert "https://github.com/mdboom/cpython/commit/0853d0ec5d263b5b3541f8bf93a1a4c47deb2f80
pythongh-121263https://github.com/python/cpython/issues/121263
: Macro-ify most stackref functions for MSVC (https://github.com/mdboom/cpython/commit/0853d0ec5d263b5b3541f8bf93a1a4c47deb2f80
p…https://github.com/python/cpython/pull/121270
0853d0ehttps://github.com/mdboom/cpython/commit/0853d0ec5d263b5b3541f8bf93a1a4c47deb2f80
…ythonGH-121270https://github.com/python/cpython/pull/121270
722229ehttps://github.com/mdboom/cpython/commit/722229e5dc1e499664966e50bb98065670033300
https://github.com/mdboom
mdboomhttps://github.com/mdboom
Jul 19, 2024 https://github.com/python/cpython/pull/121270#ref-issue-2386357812
Change MSBuild to use the Clang backend faster-cpython/ideas#690 https://github.com/faster-cpython/ideas/issues/690
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F121270
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Please reload this pagehttps://github.com/python/cpython/pull/121270
https://github.com/Fidget-Spinner
https://github.com/mdboom
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.