| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a65bd323-035f-c503-2f02-7823a2785780 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AA9C:24645:207C93F:2AAA463:6B023B46 |
| html-safe-nonce | 2c963e7f50265556fe859c0a96b041359673c4fdba0a34805cb126f6ff3cf0fc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTlDOjI0NjQ1OjIwN0M5M0Y6MkFBQTQ2Mzo2QjAyM0I0NiIsInZpc2l0b3JfaWQiOiI1ODE0Njg1ODEyNzA4NzUyMTk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 25a6dc9d29fd13a3fdc843345aa29fc684c8d8100af6ece01b07e84c65b1bd41 |
| hovercard-subject-tag | pull_request:1930367051 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/120793/files |
| twitter:image | https://avatars.githubusercontent.com/u/9448417?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/9448417?s=400&v=4 |
| og:image:alt | Makes BINARY_SUBSCR_GETITEM suitable for tier 2, including fix for #118540
Issue: gh-118095 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/120793/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120793%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120793%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/120793/files |
| Reload | https://github.com/python/cpython/pull/120793/files |
| Reload | https://github.com/python/cpython/pull/120793/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| brandtbucher | https://github.com/brandtbucher |
| python:main | https://github.com/python/cpython/tree/main |
| faster-cpython:binary-subscr-getitem-tier-2 | https://github.com/faster-cpython/cpython/tree/binary-subscr-getitem-tier-2 |
|
Conversation
11
| https://github.com/python/cpython/pull/120793 |
|
Commits
11
| https://github.com/python/cpython/pull/120793/commits |
|
Checks
0
| https://github.com/python/cpython/pull/120793/checks |
|
Files changed
| https://github.com/python/cpython/pull/120793/files |
| Please reload this page | https://github.com/python/cpython/pull/120793/files |
|
GH-118095: Make BINARY_SUBSCR_GETITEM suitable for tier 2
| https://github.com/python/cpython/pull/120793/files#top |
|
Show all changes
11 commits
| https://github.com/python/cpython/pull/120793/files |
|
392c520
Make BINARY_SUBSCR_GETITEM suitable for tier 2
markshannon Jun 20, 2024
| https://github.com/python/cpython/pull/120793/commits/392c520b883228aaf8a75b44a3c029c456b355cf |
|
2af2a91
Add guard for code object when projecting traces through calls
markshannon Jun 20, 2024
| https://github.com/python/cpython/pull/120793/commits/2af2a919174e5cee5b9ae8341460443ee72945c8 |
|
4948eb1
Don't project through _PUSH_FRAME in BINARY_SUBSCR_GETITEM
markshannon Jun 21, 2024
| https://github.com/python/cpython/pull/120793/commits/4948eb122c08f1ba5cfe3c5c1b777c1e45900539 |
|
75bdac3
Fix typo
markshannon Jun 21, 2024
| https://github.com/python/cpython/pull/120793/commits/75bdac33bd86a69a570c990424f11d07f74624b8 |
|
cde0f02
Refactor BINARY_SUBSCR_GETITEM to use less stack space
markshannon Jun 25, 2024
| https://github.com/python/cpython/pull/120793/commits/cde0f02f6a13b30a7c0c1e2e9bd528ad37c6d123 |
|
138cd41
Be more consistent about what terminates a trace in the optimizer
markshannon Jun 25, 2024
| https://github.com/python/cpython/pull/120793/commits/138cd41c31ff23e73ec52681635e29a6edcf7d23 |
|
8ea721e
fix whitespace
markshannon Jun 25, 2024
| https://github.com/python/cpython/pull/120793/commits/8ea721e8b7ce40c9e5ba46abb273d6fadc6d8c63 |
|
2b7cd34
Merge branch 'main' into binary-subscr-getitem-tier-2
markshannon Jul 18, 2024
| https://github.com/python/cpython/pull/120793/commits/2b7cd3467b1893674448180b5de6011c1036b3ab |
|
71920f1
Merge branch 'main' into binary-subscr-getitem-tier-2
markshannon Jul 30, 2024
| https://github.com/python/cpython/pull/120793/commits/71920f148843ebded83d38609214a82d38894c7a |
|
da2671e
Revert "Add guard for code object when projecting traces through calls"
brandtbucher Aug 1, 2024
| https://github.com/python/cpython/pull/120793/commits/da2671ef90c9150de745fe7a9ab60f88f222b7b5 |
|
d4df441
typo
brandtbucher Aug 1, 2024
| https://github.com/python/cpython/pull/120793/commits/d4df441468362b4514f79cf7bc4d954044cdc14b |
|
Clear filters
| https://github.com/python/cpython/pull/120793/files |
| Please reload this page | https://github.com/python/cpython/pull/120793/files |
| Please reload this page | https://github.com/python/cpython/pull/120793/files |
|
pycore_opcode_metadata.h
| https://github.com/python/cpython/pull/120793/files#diff-72bc4c0445516cc3eabd536220b2459617491ffaabbdb8a7c5381f36c991e378 |
|
pycore_optimizer.h
| https://github.com/python/cpython/pull/120793/files#diff-04d62d99f4a2b418ae2fd0eecece5b153dee4ac843c706a8de03c45a2d65efcc |
|
pycore_uop_ids.h
| https://github.com/python/cpython/pull/120793/files#diff-2a420e4d0d58009249c0f73f7c822167b053bd51cb213b20179bd2aebfc66ff9 |
|
pycore_uop_metadata.h
| https://github.com/python/cpython/pull/120793/files#diff-55e65a72fa31e9b746e03076d2c74b716c0c1171663f36960b2339fcbfae9bab |
|
bytecodes.c
| https://github.com/python/cpython/pull/120793/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342 |
|
executor_cases.c.h
| https://github.com/python/cpython/pull/120793/files#diff-a1c3430c42a66c16e6d2e154491a6da993b187b27c628545a12a02c7b2a06b81 |
|
generated_cases.c.h
| https://github.com/python/cpython/pull/120793/files#diff-4ef46fa654f95502e49a24f7dc8ee31a4cac9b3433fe9cd2b2d4dd78cfbad448 |
|
optimizer.c
| https://github.com/python/cpython/pull/120793/files#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7 |
|
optimizer_analysis.c
| https://github.com/python/cpython/pull/120793/files#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2 |
|
optimizer_cases.c.h
| https://github.com/python/cpython/pull/120793/files#diff-ed4567b3e67709ec57bf4df91ef058cfcbe00d7da11cd2a75e38241fa1ca99d2 |
| Include/internal/pycore_opcode_metadata.h | https://github.com/python/cpython/pull/120793/files#diff-72bc4c0445516cc3eabd536220b2459617491ffaabbdb8a7c5381f36c991e378 |
|
View file
| https://github.com/faster-cpython/cpython/blob/d4df441468362b4514f79cf7bc4d954044cdc14b/Include/internal/pycore_opcode_metadata.h |
|
Open in desktop
| https://desktop.github.com |
| how customized files appear on GitHub | https://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github |
| Please reload this page | https://github.com/python/cpython/pull/120793/files |
| Include/internal/pycore_optimizer.h | https://github.com/python/cpython/pull/120793/files#diff-04d62d99f4a2b418ae2fd0eecece5b153dee4ac843c706a8de03c45a2d65efcc |
|
View file
| https://github.com/faster-cpython/cpython/blob/d4df441468362b4514f79cf7bc4d954044cdc14b/Include/internal/pycore_optimizer.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/120793/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/120793/files#diff-04d62d99f4a2b418ae2fd0eecece5b153dee4ac843c706a8de03c45a2d65efcc |
|
| https://github.com/python/cpython/pull/120793/files#diff-04d62d99f4a2b418ae2fd0eecece5b153dee4ac843c706a8de03c45a2d65efcc |
| Please reload this page | https://github.com/python/cpython/pull/120793/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |