René's URL Explorer Experiment


Title: GH-118095: Make BINARY_SUBSCR_GETITEM suitable for tier 2 by markshannon · Pull Request #120793 · python/cpython · GitHub

Open Graph Title: GH-118095: Make BINARY_SUBSCR_GETITEM suitable for tier 2 by markshannon · Pull Request #120793 · python/cpython

X Title: GH-118095: Make BINARY_SUBSCR_GETITEM suitable for tier 2 by markshannon · Pull Request #120793 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Makes BINARY_SUBSCR_GETITEM suitable for tier 2, including fix for #118540 Issue: Increase the number of micro-ops that we can handle in tier 2 #118095

X Description: Makes BINARY_SUBSCR_GETITEM suitable for tier 2, including fix for #118540 Issue: Increase the number of micro-ops that we can handle in tier 2 #118095

Opengraph URL: https://github.com/python/cpython/pull/120793

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:757979e4-c9ee-5078-948a-78c5b1405a90
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDAD2:27E5CD:461A3B3:5971106:6B023602
html-safe-nonce5a2171d2d5191c040f706c96d7cd7ba1782a5f46ca52c56999d7c7de5ea69e17
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUQyOjI3RTVDRDo0NjFBM0IzOjU5NzExMDY6NkIwMjM2MDIiLCJ2aXNpdG9yX2lkIjoiMjUwMjU3MDM0MTU3NTA0NjY1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfb90153e995df51bf4455fe1b34265ef5f4a164258167c238d7dc15d47a221ae
hovercard-subject-tagpull_request:1930367051
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/120793/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f09177b8846f8a5b2c39c5b6327b5347d58707002032853fd2e2611b4a6ce60d/python/cpython/pull/120793
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f09177b8846f8a5b2c39c5b6327b5347d58707002032853fd2e2611b4a6ce60d/python/cpython/pull/120793
og:image:altMakes BINARY_SUBSCR_GETITEM suitable for tier 2, including fix for #118540 Issue: Increase the number of micro-ops that we can handle in tier 2 #118095
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemarkshannon
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/120793#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120793
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120793
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/120793
Reloadhttps://github.com/python/cpython/pull/120793
Reloadhttps://github.com/python/cpython/pull/120793
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
faster-cpython:binary-subscr-getitem-tier-2https://github.com/faster-cpython/cpython/tree/binary-subscr-getitem-tier-2
Conversationhttps://github.com/python/cpython/pull/120793
Commits11 (11)https://github.com/python/cpython/pull/120793/commits
Checkshttps://github.com/python/cpython/pull/120793/checks
Files changedhttps://github.com/python/cpython/pull/120793/files
GH-118095: Make BINARY_SUBSCR_GETITEM suitable for tier 2https://github.com/python/cpython/pull/120793#top
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
faster-cpython:binary-subscr-getitem-tier-2https://github.com/faster-cpython/cpython/tree/binary-subscr-getitem-tier-2
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Jun 20, 2024https://github.com/python/cpython/pull/120793#issue-2364164648
Please reload this pagehttps://github.com/python/cpython/pull/120793
#118540https://github.com/python/cpython/issues/118540
Increase the number of micro-ops that we can handle in tier 2 #118095https://github.com/python/cpython/issues/118095
Please reload this pagehttps://github.com/python/cpython/pull/120793
https://github.com/markshannon
Make BINARY_SUBSCR_GETITEM suitable for tier 2https://github.com/python/cpython/pull/120793/commits/392c520b883228aaf8a75b44a3c029c456b355cf
392c520https://github.com/python/cpython/pull/120793/commits/392c520b883228aaf8a75b44a3c029c456b355cf
https://github.com/markshannon
markshannonhttps://github.com/markshannon
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
Jun 20, 2024https://github.com/python/cpython/pull/120793#event-13227414641
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 20, 2024 https://github.com/python/cpython/pull/120793#ref-issue-2252568347
Increase the number of micro-ops that we can handle in tier 2 #118095 https://github.com/python/cpython/issues/118095
https://github.com/markshannon
Add guard for code object when projecting traces through callshttps://github.com/python/cpython/pull/120793/commits/2af2a919174e5cee5b9ae8341460443ee72945c8
2af2a91https://github.com/python/cpython/pull/120793/commits/2af2a919174e5cee5b9ae8341460443ee72945c8
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jun 20, 2024https://github.com/python/cpython/pull/120793#issuecomment-2181219312
Please reload this pagehttps://github.com/python/cpython/pull/120793
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Jun 21, 2024https://github.com/python/cpython/pull/120793#issuecomment-2182309403
@brandtbucherhttps://github.com/brandtbucher
Please reload this pagehttps://github.com/python/cpython/pull/120793
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Jun 21, 2024https://github.com/python/cpython/pull/120793#issuecomment-2182316021
Please reload this pagehttps://github.com/python/cpython/pull/120793
https://github.com/markshannon
Don't project through _PUSH_FRAME in BINARY_SUBSCR_GETITEMhttps://github.com/python/cpython/pull/120793/commits/4948eb122c08f1ba5cfe3c5c1b777c1e45900539
4948eb1https://github.com/python/cpython/pull/120793/commits/4948eb122c08f1ba5cfe3c5c1b777c1e45900539
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Jun 21, 2024https://github.com/python/cpython/pull/120793#issuecomment-2182840649
Please reload this pagehttps://github.com/python/cpython/pull/120793
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jun 21, 2024 https://github.com/python/cpython/pull/120793#pullrequestreview-2132948621
View reviewed changes https://github.com/python/cpython/pull/120793/files/4948eb122c08f1ba5cfe3c5c1b777c1e45900539
Python/optimizer.chttps://github.com/python/cpython/pull/120793/files/4948eb122c08f1ba5cfe3c5c1b777c1e45900539#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
Please reload this pagehttps://github.com/python/cpython/pull/120793
https://github.com/markshannon
Fix typohttps://github.com/python/cpython/pull/120793/commits/75bdac33bd86a69a570c990424f11d07f74624b8
75bdac3https://github.com/python/cpython/pull/120793/commits/75bdac33bd86a69a570c990424f11d07f74624b8
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jun 21, 2024https://github.com/python/cpython/pull/120793#issuecomment-2183118339
Please reload this pagehttps://github.com/python/cpython/pull/120793
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Jun 25, 2024 https://github.com/python/cpython/pull/120793#ref-issue-2371924825
Evaluation stack bounds are not checked in debug builds. #120982 https://github.com/python/cpython/issues/120982
markshannonhttps://github.com/markshannon
June 25, 2024 11:42https://github.com/python/cpython/pull/120793#commits-pushed-cde0f02
https://github.com/markshannon
Refactor BINARY_SUBSCR_GETITEM to use less stack spacehttps://github.com/python/cpython/pull/120793/commits/cde0f02f6a13b30a7c0c1e2e9bd528ad37c6d123
cde0f02https://github.com/python/cpython/pull/120793/commits/cde0f02f6a13b30a7c0c1e2e9bd528ad37c6d123
https://github.com/markshannon
Be more consistent about what terminates a trace in the optimizerhttps://github.com/python/cpython/pull/120793/commits/138cd41c31ff23e73ec52681635e29a6edcf7d23
138cd41https://github.com/python/cpython/pull/120793/commits/138cd41c31ff23e73ec52681635e29a6edcf7d23
https://github.com/markshannon
markshannonhttps://github.com/markshannon
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jun 25, 2024https://github.com/python/cpython/pull/120793#event-13279721579
https://github.com/markshannon
markshannonhttps://github.com/markshannon
June 25, 2024 12:47https://github.com/python/cpython/pull/120793#event-13280795231
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Fidget-Spinnerhttps://github.com/Fidget-Spinner
code ownerhttps://github.com/python/cpython/blob/ead676516d4687b5e6d947a5c0808b5b93ba87e3/.github/CODEOWNERS#L43
June 25, 2024 12:47https://github.com/python/cpython/pull/120793#event-13280795376
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 25, 2024https://github.com/python/cpython/pull/120793#event-13280796038
https://github.com/markshannon
markshannonhttps://github.com/markshannon
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
Jun 25, 2024https://github.com/python/cpython/pull/120793#event-13280797627
https://github.com/markshannon
fix whitespacehttps://github.com/python/cpython/pull/120793/commits/8ea721e8b7ce40c9e5ba46abb273d6fadc6d8c63
8ea721ehttps://github.com/python/cpython/pull/120793/commits/8ea721e8b7ce40c9e5ba46abb273d6fadc6d8c63
https://github.com/markshannon
markshannonhttps://github.com/markshannon
brandtbucherhttps://github.com/brandtbucher
June 25, 2024 13:32https://github.com/python/cpython/pull/120793#event-13281478131
markshannonhttps://github.com/markshannon
July 18, 2024 15:54https://github.com/python/cpython/pull/120793#commits-pushed-2b7cd34
https://github.com/markshannon
Merge branch 'main' into binary-subscr-getitem-tier-2https://github.com/python/cpython/pull/120793/commits/2b7cd3467b1893674448180b5de6011c1036b3ab
2b7cd34https://github.com/python/cpython/pull/120793/commits/2b7cd3467b1893674448180b5de6011c1036b3ab
https://github.com/markshannon
Merge branch 'main' into binary-subscr-getitem-tier-2https://github.com/python/cpython/pull/120793/commits/71920f148843ebded83d38609214a82d38894c7a
71920f1https://github.com/python/cpython/pull/120793/commits/71920f148843ebded83d38609214a82d38894c7a
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Aug 1, 2024 https://github.com/python/cpython/pull/120793#pullrequestreview-2211700707
View reviewed changes https://github.com/python/cpython/pull/120793/files/71920f148843ebded83d38609214a82d38894c7a
brandtbucherhttps://github.com/brandtbucher
https://github.com/python/cpython/pull/120793#pullrequestreview-2211700707
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/120793
Python/optimizer.chttps://github.com/python/cpython/pull/120793/files/71920f148843ebded83d38609214a82d38894c7a#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
Please reload this pagehttps://github.com/python/cpython/pull/120793
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 1, 2024https://github.com/python/cpython/pull/120793#event-13720197194
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Aug 1, 2024https://github.com/python/cpython/pull/120793#issuecomment-2262118133
Please reload this pagehttps://github.com/python/cpython/pull/120793
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Aug 1, 2024 https://github.com/python/cpython/pull/120793#pullrequestreview-2213055728
View reviewed changes https://github.com/python/cpython/pull/120793/files/71920f148843ebded83d38609214a82d38894c7a
Python/optimizer.chttps://github.com/python/cpython/pull/120793/files/71920f148843ebded83d38609214a82d38894c7a#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
Please reload this pagehttps://github.com/python/cpython/pull/120793
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Aug 1, 2024https://github.com/python/cpython/pull/120793#event-13728974105
brandtbucherhttps://github.com/brandtbucher
August 1, 2024 10:42https://github.com/python/cpython/pull/120793#commits-pushed-da2671e
https://github.com/brandtbucher
Revert "Add guard for code object when projecting traces through calls"https://github.com/python/cpython/pull/120793/commits/da2671ef90c9150de745fe7a9ab60f88f222b7b5
da2671ehttps://github.com/python/cpython/pull/120793/commits/da2671ef90c9150de745fe7a9ab60f88f222b7b5
2af2a91https://github.com/faster-cpython/cpython/commit/2af2a919174e5cee5b9ae8341460443ee72945c8
https://github.com/brandtbucher
typohttps://github.com/python/cpython/pull/120793/commits/d4df441468362b4514f79cf7bc4d954044cdc14b
d4df441https://github.com/python/cpython/pull/120793/commits/d4df441468362b4514f79cf7bc4d954044cdc14b
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Aug 1, 2024https://github.com/python/cpython/pull/120793#issuecomment-2264188233
15% fasterhttps://raw.githubusercontent.com/faster-cpython/benchmarking-public/main/results/bm-20240801-3.14.0a0-d4df441-JIT/bm-20240801-linux-x86_64-faster%252dcpython-binary_subscr_getite-3.14.0a0-d4df441-vs-base.svg
Please reload this pagehttps://github.com/python/cpython/pull/120793
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
df13a18https://github.com/python/cpython/commit/df13a1821a90fcfb75eca59aad6af1f0893b1e77
Aug 1, 2024https://github.com/python/cpython/pull/120793#event-13733550952
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Aug 1, 2024https://github.com/python/cpython/pull/120793#event-13733551832
https://github.com/markshannon
markshannonhttps://github.com/markshannon
August 6, 2024 10:13https://github.com/python/cpython/pull/120793#event-13776266974
blhsinghttps://github.com/blhsing
Aug 22, 2024 https://github.com/python/cpython/pull/120793#ref-commit-96ce287
https://github.com/markshannon
https://github.com/blhsing
pythonGH-118095https://github.com/python/cpython/issues/118095
: Add tier two support for BINARY_SUBSCR_GETITEM (https://github.com/blhsing/cpython/commit/96ce2878e46a7e6899577f95ef32a541b7810bf9
pyth…https://github.com/python/cpython/pull/120793
96ce287https://github.com/blhsing/cpython/commit/96ce2878e46a7e6899577f95ef32a541b7810bf9
…onGH-120793https://github.com/python/cpython/pull/120793
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120793
https://github.com/brandtbucher
brandtbucher https://github.com/brandtbucher
https://github.com/python/cpython/pull/120793/files/71920f148843ebded83d38609214a82d38894c7a
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
Please reload this pagehttps://github.com/python/cpython/pull/120793
https://github.com/brandtbucher
brandtbucher https://github.com/brandtbucher
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/120793
https://github.com/markshannon
https://github.com/brandtbucher
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.