René's URL Explorer Experiment


Title: gh-120196: Reuse find_max_char for bytes objects by rhpvorderman · Pull Request #120497 · python/cpython · GitHub

Open Graph Title: gh-120196: Reuse find_max_char for bytes objects by rhpvorderman · Pull Request #120497 · python/cpython

X Title: gh-120196: Reuse find_max_char for bytes objects by rhpvorderman · Pull Request #120497 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Simple duplicate code removal and reuse of other function. Issue: Faster decode and find_max_char implementations. #120196

X Description: Simple duplicate code removal and reuse of other function. Issue: Faster decode and find_max_char implementations. #120196

Opengraph URL: https://github.com/python/cpython/pull/120497

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:139cf488-99c6-39cc-f4e0-5cc4823a3c77
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCDBA:D4E59:F041F5:12E467F:6B022F0B
html-safe-nonce6fb7791667eb9ac9aa9f4d312193ced24398b087841e0d770e731ecd49b40633
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDREJBOkQ0RTU5OkYwNDFGNToxMkU0NjdGOjZCMDIyRjBCIiwidmlzaXRvcl9pZCI6IjczMTcyMzI5NzEwNjMzNzM1NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7a1bf8ddf28f94374b3b6e2573e4999ed043d7888c0318b07fe507e402cadb16
hovercard-subject-tagpull_request:1920559349
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/120497/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/913291c736cebf1c1e175b078576069e86e2b127240141a2c31740b172d72162/python/cpython/pull/120497
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/913291c736cebf1c1e175b078576069e86e2b127240141a2c31740b172d72162/python/cpython/pull/120497
og:image:altSimple duplicate code removal and reuse of other function. Issue: Faster decode and find_max_char implementations. #120196
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerhpvorderman
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/120497#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120497
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120497
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/120497
Reloadhttps://github.com/python/cpython/pull/120497
Reloadhttps://github.com/python/cpython/pull/120497
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
rhpvorderman:bytesasciiredundanthttps://github.com/rhpvorderman/cpython/tree/bytesasciiredundant
Conversationhttps://github.com/python/cpython/pull/120497
Commits2 (2)https://github.com/python/cpython/pull/120497/commits
Checkshttps://github.com/python/cpython/pull/120497/checks
Files changedhttps://github.com/python/cpython/pull/120497/files
gh-120196: Reuse find_max_char for bytes objectshttps://github.com/python/cpython/pull/120497#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
rhpvorderman:bytesasciiredundanthttps://github.com/rhpvorderman/cpython/tree/bytesasciiredundant
https://github.com/rhpvorderman
rhpvordermanhttps://github.com/rhpvorderman
Jun 14, 2024https://github.com/python/cpython/pull/120497#issue-2353222763
Please reload this pagehttps://github.com/python/cpython/pull/120497
Faster decode and find_max_char implementations. #120196https://github.com/python/cpython/issues/120196
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/rhpvorderman
Reuse find_max_char for bytes objectshttps://github.com/python/cpython/pull/120497/commits/59bbd60592cffb714d5a9b75265d323c310e55ce
59bbd60https://github.com/python/cpython/pull/120497/commits/59bbd60592cffb714d5a9b75265d323c310e55ce
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jun 14, 2024https://github.com/python/cpython/pull/120497#event-13160024194
https://github.com/rhpvorderman
rhpvordermanhttps://github.com/rhpvorderman
Jun 14, 2024 https://github.com/python/cpython/pull/120497#ref-pullrequest-2340106612
gh-120196: Faster ascii_decode and find_max_char implementations #120212 https://github.com/python/cpython/pull/120212
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 14, 2024 https://github.com/python/cpython/pull/120497#pullrequestreview-2118224428
View reviewed changes https://github.com/python/cpython/pull/120497/files/59bbd60592cffb714d5a9b75265d323c310e55ce
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/120497#pullrequestreview-2118224428
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/rhpvorderman
rhpvordermanhttps://github.com/rhpvorderman
Jun 14, 2024https://github.com/python/cpython/pull/120497#issuecomment-2167890102
#120196https://github.com/python/cpython/issues/120196
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 14, 2024https://github.com/python/cpython/pull/120497#issuecomment-2167898652
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/rhpvorderman
Fix compiler warningshttps://github.com/python/cpython/pull/120497/commits/5852ce33ed72be08e1094e25f9f3a9ab4746eb1b
5852ce3https://github.com/python/cpython/pull/120497/commits/5852ce33ed72be08e1094e25f9f3a9ab4746eb1b
https://github.com/rhpvorderman
rhpvordermanhttps://github.com/rhpvorderman
Jun 14, 2024https://github.com/python/cpython/pull/120497#issuecomment-2167910877
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 14, 2024 https://github.com/python/cpython/pull/120497#pullrequestreview-2118256096
View reviewed changes https://github.com/python/cpython/pull/120497/files/5852ce33ed72be08e1094e25f9f3a9ab4746eb1b
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/120497#pullrequestreview-2118256096
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@pitrouhttps://github.com/pitrou
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jun 14, 2024https://github.com/python/cpython/pull/120497#event-13160247583
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 14, 2024https://github.com/python/cpython/pull/120497#issuecomment-2167933834
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/rhpvorderman
rhpvordermanhttps://github.com/rhpvorderman
Jun 14, 2024https://github.com/python/cpython/pull/120497#issuecomment-2167937227
Please reload this pagehttps://github.com/python/cpython/pull/120497
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 14, 2024https://github.com/python/cpython/pull/120497#issuecomment-2167943650
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 14, 2024https://github.com/python/cpython/pull/120497#issuecomment-2167946084
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/rhpvorderman
rhpvordermanhttps://github.com/rhpvorderman
Jun 14, 2024https://github.com/python/cpython/pull/120497#issuecomment-2167965602
Please reload this pagehttps://github.com/python/cpython/pull/120497
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/rhpvorderman
rhpvordermanhttps://github.com/rhpvorderman
Jun 14, 2024 https://github.com/python/cpython/pull/120497#pullrequestreview-2118391920
View reviewed changes https://github.com/python/cpython/pull/120497/files/5852ce33ed72be08e1094e25f9f3a9ab4746eb1b
Objects/bytes_methods.chttps://github.com/python/cpython/pull/120497/files/5852ce33ed72be08e1094e25f9f3a9ab4746eb1b#diff-1ff52799e69c723776ec4b4e3073b79455f51b75cbe7f6acf0f58ea70db35bd6
rhpvordermanhttps://github.com/rhpvorderman
Jun 14, 2024https://github.com/python/cpython/pull/120497#discussion_r1639826986
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/rhpvorderman
rhpvordermanhttps://github.com/rhpvorderman
Jun 17, 2024https://github.com/python/cpython/pull/120497#issuecomment-2172952883
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 17, 2024https://github.com/python/cpython/pull/120497#issuecomment-2172979169
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 17, 2024https://github.com/python/cpython/pull/120497#event-13183427523
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 17, 2024 https://github.com/python/cpython/pull/120497#ref-issue-2339809802
Faster decode and find_max_char implementations. #120196 https://github.com/python/cpython/issues/120196
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 17, 2024https://github.com/python/cpython/pull/120497#event-13183428685
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jun 17, 2024https://github.com/python/cpython/pull/120497#event-13183430098
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 17, 2024 https://github.com/python/cpython/pull/120497#pullrequestreview-2122513966
View reviewed changes https://github.com/python/cpython/pull/120497/files/5852ce33ed72be08e1094e25f9f3a9ab4746eb1b
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/120497#pullrequestreview-2122513966
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
945a89bhttps://github.com/python/cpython/commit/945a89b48f017d711055da039899eaecc2eb7ddd
Jun 17, 2024https://github.com/python/cpython/pull/120497#event-13183461808
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jun 17, 2024https://github.com/python/cpython/pull/120497#event-13183462293
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 17, 2024https://github.com/python/cpython/pull/120497#issuecomment-2172986928
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/rhpvorderman
rhpvordermanhttps://github.com/rhpvorderman
Jun 17, 2024https://github.com/python/cpython/pull/120497#issuecomment-2173114933
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/rhpvorderman
rhpvordermanhttps://github.com/rhpvorderman
June 17, 2024 11:17https://github.com/python/cpython/pull/120497#event-13184113159
mrahtzhttps://github.com/mrahtz
Jun 30, 2024 https://github.com/python/cpython/pull/120497#ref-commit-b93d655
https://github.com/rhpvorderman
https://github.com/mrahtz
pythongh-120196https://github.com/python/cpython/issues/120196
: Reuse find_max_char() for bytes objects (https://github.com/mrahtz/cpython/commit/b93d655557aa3c9a752006417ccd247b02b20f3d
python#120497https://github.com/python/cpython/pull/120497
)https://github.com/mrahtz/cpython/commit/b93d655557aa3c9a752006417ccd247b02b20f3d
b93d655https://github.com/mrahtz/cpython/commit/b93d655557aa3c9a752006417ccd247b02b20f3d
estyxxhttps://github.com/estyxx
Jul 17, 2024 https://github.com/python/cpython/pull/120497#ref-commit-9d3b846
https://github.com/rhpvorderman
https://github.com/estyxx
pythongh-120196https://github.com/python/cpython/issues/120196
: Reuse find_max_char() for bytes objects (https://github.com/estyxx/cpython/commit/9d3b8463c4bdee3cbc29ab8f5ed1fba608c3416e
python#120497https://github.com/python/cpython/pull/120497
)https://github.com/estyxx/cpython/commit/9d3b8463c4bdee3cbc29ab8f5ed1fba608c3416e
9d3b846https://github.com/estyxx/cpython/commit/9d3b8463c4bdee3cbc29ab8f5ed1fba608c3416e
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120497
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/120497/files/5852ce33ed72be08e1094e25f9f3a9ab4746eb1b
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/120497/files/5852ce33ed72be08e1094e25f9f3a9ab4746eb1b
Please reload this pagehttps://github.com/python/cpython/pull/120497
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/120497
https://github.com/rhpvorderman
https://github.com/vstinner
https://github.com/serhiy-storchaka
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.