| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1656f810-bb98-87ac-c2b1-8039a085ccab |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B030:16DC03:63D184:833883:6B024A92 |
| html-safe-nonce | 1f1b306196fe68924a537e7695a3e7601686212be518ccd998a1b0e02b1bed17 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDMwOjE2REMwMzo2M0QxODQ6ODMzODgzOjZCMDI0QTkyIiwidmlzaXRvcl9pZCI6IjM1MTY5MzkwODMxMzU5OTQ1MTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 84bb7e0163fefcdc251336cf04f4017a660203c054e961027267c3af25e99e75 |
| hovercard-subject-tag | pull_request:1920340040 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/120491/files |
| twitter:image | https://avatars.githubusercontent.com/u/65588599?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/65588599?s=400&v=4 |
| og:image:alt | Purpose
Currently consuming items from a queue is very complex. You need to
use an infinite while loop
call queue.task_done() after processing each item
add all worker tasks to a list
join the que... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/120491/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120491%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120491%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/120491/files |
| Reload | https://github.com/python/cpython/pull/120491/files |
| Reload | https://github.com/python/cpython/pull/120491/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| nineteendo | https://github.com/nineteendo |
| python:main | https://github.com/python/cpython/tree/main |
| nineteendo:add-asyncio.Queue.__aiter__ | https://github.com/nineteendo/cpython/tree/add-asyncio.Queue.__aiter__ |
|
Conversation
29
| https://github.com/python/cpython/pull/120491 |
|
Commits
33
| https://github.com/python/cpython/pull/120491/commits |
|
Checks
0
| https://github.com/python/cpython/pull/120491/checks |
|
Files changed
| https://github.com/python/cpython/pull/120491/files |
| Please reload this page | https://github.com/python/cpython/pull/120491/files |
|
gh-119154: Simplify consumers by making asyncio.Queue an asynchronous iterable
| https://github.com/python/cpython/pull/120491/files#top |
|
Show all changes
33 commits
| https://github.com/python/cpython/pull/120491/files |
|
e9c1a3e
Add `asyncio.Queue.__aiter__()`
nineteendo Jun 14, 2024
| https://github.com/python/cpython/pull/120491/commits/e9c1a3e381f5d919d837eba9ade321719d679f18 |
|
3cd59ee
Reduce diff
nineteendo Jun 14, 2024
| https://github.com/python/cpython/pull/120491/commits/3cd59ee95949448cef6e9adb68897c4788390ed5 |
|
16fc429
Add test
nineteendo Jun 14, 2024
| https://github.com/python/cpython/pull/120491/commits/16fc429f43738f546db8b94613c5b48f8e0c3cda |
|
f13ddb3
Simplify code
nineteendo Jun 14, 2024
| https://github.com/python/cpython/pull/120491/commits/f13ddb3912e1e6efbf613f80ea7b51993a86f246 |
|
afd7ad4
Add to `__all__`
nineteendo Jun 14, 2024
| https://github.com/python/cpython/pull/120491/commits/afd7ad4a0ea2d3535946ba775d3fc2cb0cf04629 |
|
214548c
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 14, 2024
| https://github.com/python/cpython/pull/120491/commits/214548c4b2a774b0fef2098ec59a51d7337fbccc |
|
9824b63
Simplify example
nineteendo Jun 14, 2024
| https://github.com/python/cpython/pull/120491/commits/9824b639a8b001db0f3b94e2a2319dc32f2d5110 |
|
6358b8e
Fix indentation
nineteendo Jun 14, 2024
| https://github.com/python/cpython/pull/120491/commits/6358b8ec6bc4b8665b3a47a8a48cfdfe2b8875c6 |
|
316b800
Improve order
nineteendo Jun 14, 2024
| https://github.com/python/cpython/pull/120491/commits/316b8006ef5c675a65758c660e00b700e654138a |
|
92f3295
Test `StopAsyncIteration`
nineteendo Jun 14, 2024
| https://github.com/python/cpython/pull/120491/commits/92f32954db74d624f37306d427b6d710b588dc42 |
|
a18767d
Document `AsyncQueueIterator`
nineteendo Jun 14, 2024
| https://github.com/python/cpython/pull/120491/commits/a18767df829a4f65fe921a3a043c44810f5dbbd2 |
|
320691c
Apply suggestions from code review
nineteendo Jun 15, 2024
| https://github.com/python/cpython/pull/120491/commits/320691cd422e5a3f0c323985d5db399a524badcf |
|
f43bdb1
Unpack for loop
nineteendo Jun 15, 2024
| https://github.com/python/cpython/pull/120491/commits/f43bdb17235fee0bdf6680854d01affba49d0ac5 |
|
4ca4a93
Insert newline
nineteendo Jun 15, 2024
| https://github.com/python/cpython/pull/120491/commits/4ca4a93e18a239521da1a359bd8af6e9020a873c |
|
fffacb2
Simplify example
nineteendo Jun 15, 2024
| https://github.com/python/cpython/pull/120491/commits/fffacb2cbfd5ca588bfa348068ca101edd628925 |
|
92d7b16
Indent correctly
nineteendo Jun 15, 2024
| https://github.com/python/cpython/pull/120491/commits/92d7b16d0f511b49e40a709a4144d2b416572db7 |
|
ce23fce
Document `__aiter__()`
nineteendo Jun 15, 2024
| https://github.com/python/cpython/pull/120491/commits/ce23fcedf1bb3686ed85ab4f9b10e0337ca88409 |
|
640d2a8
Fix indent attempt 1
nineteendo Jun 15, 2024
| https://github.com/python/cpython/pull/120491/commits/640d2a8a59f7385ccd806462cf2a255df032311f |
|
6c9aa6d
Make `AsyncQueueIterator` private
nineteendo Jun 18, 2024
| https://github.com/python/cpython/pull/120491/commits/6c9aa6d6e7ec3668e3b12c4869ec7bac063e6c9d |
|
e6a5849
Use term
nineteendo Jun 18, 2024
| https://github.com/python/cpython/pull/120491/commits/e6a5849ac8db0269c27e5d36717b1c339340491e |
|
583f642
Re-order
nineteendo Jun 18, 2024
| https://github.com/python/cpython/pull/120491/commits/583f642bb2d5044c863d77cdaf6c9568e372bb3d |
|
1b6e781
Remove comment
nineteendo Jun 18, 2024
| https://github.com/python/cpython/pull/120491/commits/1b6e78135503dfa4feafc83bf4f728d853286993 |
|
2d5998a
Update whatsnew
nineteendo Jun 19, 2024
| https://github.com/python/cpython/pull/120491/commits/2d5998ada601b06a84158b16ee0e4db56b72f477 |
|
841d50c
Update blurb
nineteendo Jun 19, 2024
| https://github.com/python/cpython/pull/120491/commits/841d50c8dbfa49117f5d90fa4e0b0a67ffff7588 |
|
d624bea
Apply suggestions from code review
nineteendo Jun 19, 2024
| https://github.com/python/cpython/pull/120491/commits/d624beaa4925d99a30900df2ac7a705876c324a3 |
|
0a8a72b
Update Doc/library/asyncio-queue.rst
nineteendo Jun 19, 2024
| https://github.com/python/cpython/pull/120491/commits/0a8a72b59b42abc67c8084053bf3e4cf2259bbb7 |
|
b3199df
Rename 2024-06-14-10-30-43.gh-issue-119154.1MHWA-.rst to 2024-06-14-1…
nineteendo Jun 19, 2024
| https://github.com/python/cpython/pull/120491/commits/b3199dfad4fdc8d5ea6383e7d61145011a885ced |
|
d71eb91
Make queue a private attribute
nineteendo Jun 19, 2024
| https://github.com/python/cpython/pull/120491/commits/d71eb91e9474111af26dc8f3e4dce94ba1be8c31 |
|
23e37f4
Clarify behaviour
nineteendo Jun 20, 2024
| https://github.com/python/cpython/pull/120491/commits/23e37f4e7b47779920ae8222f4554442ea669df2 |
|
3bb4e65
Fix grammar
nineteendo Jun 20, 2024
| https://github.com/python/cpython/pull/120491/commits/3bb4e6585c0b8a27d521cfbfce37d936a5176718 |
|
9eff835
Update 2024-06-14-10-30-43.gh-issue-119154.1MHWA-.rst
nineteendo Jun 24, 2024
| https://github.com/python/cpython/pull/120491/commits/9eff83514e27369f53d74f1488cfa95eb243db81 |
|
8580e98
Remove parentheses
nineteendo Jun 24, 2024
| https://github.com/python/cpython/pull/120491/commits/8580e987ee691a05cc449ecbf9429e1e8feea388 |
|
670611f
Update Doc/whatsnew/3.14.rst
nineteendo Jun 24, 2024
| https://github.com/python/cpython/pull/120491/commits/670611f8aee3dbf6ae33943f762316bb77345158 |
|
Clear filters
| https://github.com/python/cpython/pull/120491/files |
| Please reload this page | https://github.com/python/cpython/pull/120491/files |
| Please reload this page | https://github.com/python/cpython/pull/120491/files |
|
asyncio-queue.rst
| https://github.com/python/cpython/pull/120491/files#diff-3b25acd4f063b2ccb930c10bc327d1abf97577b1d830afe084cf8e03f37de0e8 |
|
3.14.rst
| https://github.com/python/cpython/pull/120491/files#diff-24e6cbe61d91e61059c44a7cf5f712499a11eb47a82d5f1a8db16ec7f9023c31 |
|
queues.py
| https://github.com/python/cpython/pull/120491/files#diff-22a6bcb03e783378149a3e9411c185b13c908e61886ffd55145634b7ab12caac |
|
test_queues.py
| https://github.com/python/cpython/pull/120491/files#diff-e1e38d6442dc7d84b4eabf47d2080772baff9c6b94f997af273f7d8ff4a37d5d |
|
2024-06-14-10-30-43.gh-issue-119154.1MHWA-.rst
| https://github.com/python/cpython/pull/120491/files#diff-22efb59d483c692a5be7fed74e2c487edfcf08778e92c60c027508cd31686631 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L374 |
| Doc/library/asyncio-queue.rst | https://github.com/python/cpython/pull/120491/files#diff-3b25acd4f063b2ccb930c10bc327d1abf97577b1d830afe084cf8e03f37de0e8 |
|
View file
| https://github.com/nineteendo/cpython/blob/670611f8aee3dbf6ae33943f762316bb77345158/Doc/library/asyncio-queue.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/120491/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/120491/files#diff-3b25acd4f063b2ccb930c10bc327d1abf97577b1d830afe084cf8e03f37de0e8 |
|
| https://github.com/python/cpython/pull/120491/files#diff-3b25acd4f063b2ccb930c10bc327d1abf97577b1d830afe084cf8e03f37de0e8 |
|
| https://github.com/python/cpython/pull/120491/files#diff-3b25acd4f063b2ccb930c10bc327d1abf97577b1d830afe084cf8e03f37de0e8 |
|
| https://github.com/python/cpython/pull/120491/files#diff-3b25acd4f063b2ccb930c10bc327d1abf97577b1d830afe084cf8e03f37de0e8 |
|
| https://github.com/python/cpython/pull/120491/files#diff-3b25acd4f063b2ccb930c10bc327d1abf97577b1d830afe084cf8e03f37de0e8 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L116 |
| Doc/whatsnew/3.14.rst | https://github.com/python/cpython/pull/120491/files#diff-24e6cbe61d91e61059c44a7cf5f712499a11eb47a82d5f1a8db16ec7f9023c31 |
|
View file
| https://github.com/nineteendo/cpython/blob/670611f8aee3dbf6ae33943f762316bb77345158/Doc/whatsnew/3.14.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/120491/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/120491/files#diff-24e6cbe61d91e61059c44a7cf5f712499a11eb47a82d5f1a8db16ec7f9023c31 |
|
| https://github.com/python/cpython/pull/120491/files#diff-24e6cbe61d91e61059c44a7cf5f712499a11eb47a82d5f1a8db16ec7f9023c31 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L376 |
| Lib/asyncio/queues.py | https://github.com/python/cpython/pull/120491/files#diff-22a6bcb03e783378149a3e9411c185b13c908e61886ffd55145634b7ab12caac |
|
View file
| https://github.com/nineteendo/cpython/blob/670611f8aee3dbf6ae33943f762316bb77345158/Lib/asyncio/queues.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/120491/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/120491/files#diff-22a6bcb03e783378149a3e9411c185b13c908e61886ffd55145634b7ab12caac |
| kumaraditya303 | https://github.com/kumaraditya303 |
| Jun 19, 2024 | https://github.com/python/cpython/pull/120491/files#r1645878198 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/120491/files |
| nineteendo | https://github.com/nineteendo |
| Jun 19, 2024 | https://github.com/python/cpython/pull/120491/files#r1645894204 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #119154 (comment) | https://github.com/python/cpython/issues/119154#issuecomment-2119554265 |
| Please reload this page | https://github.com/python/cpython/pull/120491/files |
|
| https://github.com/python/cpython/pull/120491/files#diff-22a6bcb03e783378149a3e9411c185b13c908e61886ffd55145634b7ab12caac |
|
| https://github.com/python/cpython/pull/120491/files#diff-22a6bcb03e783378149a3e9411c185b13c908e61886ffd55145634b7ab12caac |
|
| https://github.com/python/cpython/pull/120491/files#diff-22a6bcb03e783378149a3e9411c185b13c908e61886ffd55145634b7ab12caac |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L377 |
| Lib/test/test_asyncio/test_queues.py | https://github.com/python/cpython/pull/120491/files#diff-e1e38d6442dc7d84b4eabf47d2080772baff9c6b94f997af273f7d8ff4a37d5d |
|
View file
| https://github.com/nineteendo/cpython/blob/670611f8aee3dbf6ae33943f762316bb77345158/Lib/test/test_asyncio/test_queues.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/120491/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/120491/files#diff-e1e38d6442dc7d84b4eabf47d2080772baff9c6b94f997af273f7d8ff4a37d5d |
|
| https://github.com/python/cpython/pull/120491/files#diff-e1e38d6442dc7d84b4eabf47d2080772baff9c6b94f997af273f7d8ff4a37d5d |
|
| https://github.com/python/cpython/pull/120491/files#diff-e1e38d6442dc7d84b4eabf47d2080772baff9c6b94f997af273f7d8ff4a37d5d |
|
| https://github.com/python/cpython/pull/120491/files#diff-e1e38d6442dc7d84b4eabf47d2080772baff9c6b94f997af273f7d8ff4a37d5d |
| Misc/NEWS.d/next/Library/2024-06-14-10-30-43.gh-issue-119154.1MHWA-.rst | https://github.com/python/cpython/pull/120491/files#diff-22efb59d483c692a5be7fed74e2c487edfcf08778e92c60c027508cd31686631 |
|
View file
| https://github.com/nineteendo/cpython/blob/670611f8aee3dbf6ae33943f762316bb77345158/Misc/NEWS.d/next/Library/2024-06-14-10-30-43.gh-issue-119154.1MHWA-.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/120491/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |