René's URL Explorer Experiment


Title: bpo-26228: Fix pty EOF handling by RadicalZephyr · Pull Request #12049 · python/cpython · GitHub

Open Graph Title: bpo-26228: Fix pty EOF handling by RadicalZephyr · Pull Request #12049 · python/cpython

X Title: bpo-26228: Fix pty EOF handling by RadicalZephyr · Pull Request #12049 · python/cpython

Description: I took a shot at fixing this in a smaller more targeted patch. I don't have a BSD system to test this on, but I think this should still solve the major issue of pty.spawn hanging on platforms that don't raise an error. In addition, pty.spawn should now ALWAYS return the terminal to the previous settings. Co-authored with @reillysiemens. https://bugs.python.org/issue26228

Open Graph Description: I took a shot at fixing this in a smaller more targeted patch. I don't have a BSD system to test this on, but I think this should still solve the major issue of pty.spawn hanging on platforms ...

X Description: I took a shot at fixing this in a smaller more targeted patch. I don't have a BSD system to test this on, but I think this should still solve the major issue of pty.spawn hanging on platfo...

Opengraph URL: https://github.com/python/cpython/pull/12049

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:46a3cdd0-cc97-829b-b780-9888e6bb24a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB7BE:47423:65FD9A5:8EC6D54:6A501EAF
html-safe-nonceeb8ac85f8acfc9bca5cfdce48b8a23a456a3c8591ebe2aee8fae27f368090ccf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0JFOjQ3NDIzOjY1RkQ5QTU6OEVDNkQ1NDo2QTUwMUVBRiIsInZpc2l0b3JfaWQiOiIyNzYyNzAyMzExNTIwMjE0NzAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac66c3248c394b38af63c6e23bd7467ed958a5890cc6e2735985d4b56907955199
hovercard-subject-tagpull_request:256204048
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/12049/files
twitter:imagehttps://avatars.githubusercontent.com/u/113102?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/113102?s=400&v=4
og:image:altI took a shot at fixing this in a smaller more targeted patch. I don't have a BSD system to test this on, but I think this should still solve the major issue of pty.spawn hanging on platforms ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None14f013003d3992e8746116a6f2f55cd2fdaccd329ee0423392831ae051ecb535
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26ee7c1a62943cf19a6fcc1d1ac93ac83465c885
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/12049/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F12049%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F12049%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/12049/files
Reloadhttps://github.com/python/cpython/pull/12049/files
Reloadhttps://github.com/python/cpython/pull/12049/files
Please reload this pagehttps://github.com/python/cpython/pull/12049/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/12049/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ambvhttps://github.com/ambv
python:mainhttps://github.com/python/cpython/tree/main
RadicalZephyr:bpo-26228-fix-pty-eof-handlinghttps://github.com/RadicalZephyr/cpython/tree/bpo-26228-fix-pty-eof-handling
Conversation 26 https://github.com/python/cpython/pull/12049
Commits 2 https://github.com/python/cpython/pull/12049/commits
Checks 0 https://github.com/python/cpython/pull/12049/checks
Files changed https://github.com/python/cpython/pull/12049/files
Please reload this pagehttps://github.com/python/cpython/pull/12049/files
bpo-26228: Fix pty EOF handling https://github.com/python/cpython/pull/12049/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/12049/files
9613c98 Change pty.spawn to not block indefinitely RadicalZephyr Feb 26, 2019 https://github.com/python/cpython/pull/12049/commits/9613c9880c38475306e0f0bae7f404832428d2ed
9f62b82 Make a high-level test, remove outdated comments, add more cleanups ambv Aug 11, 2021 https://github.com/python/cpython/pull/12049/commits/9f62b8229ca852b4b07e840a5b5632ba1f5bdde2
Clear filters https://github.com/python/cpython/pull/12049/files
Please reload this pagehttps://github.com/python/cpython/pull/12049/files
Please reload this pagehttps://github.com/python/cpython/pull/12049/files
pty.rst https://github.com/python/cpython/pull/12049/files#diff-d827b28854eb16794889d6a7d19c79c1c3cccc6ddce18e996d46c9864d93bd73
pty.py https://github.com/python/cpython/pull/12049/files#diff-6951c8bf11da0d5912302a24b778e2c968fae9212bfeb2e73de06ec257b2d1da
test_pty.py https://github.com/python/cpython/pull/12049/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
ACKS https://github.com/python/cpython/pull/12049/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
2019-02-26-09-31-59.bpo-26228.wyrHKc.rst https://github.com/python/cpython/pull/12049/files#diff-b583de3d4ebde320e2299a91f0cc142eeebfbc55a080000f46c807333b1d2af1
Doc/library/pty.rsthttps://github.com/python/cpython/pull/12049/files#diff-d827b28854eb16794889d6a7d19c79c1c3cccc6ddce18e996d46c9864d93bd73
View file https://github.com/RadicalZephyr/cpython/blob/9f62b8229ca852b4b07e840a5b5632ba1f5bdde2/Doc/library/pty.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/12049/{{ revealButtonHref }}
https://github.com/python/cpython/pull/12049/files#diff-d827b28854eb16794889d6a7d19c79c1c3cccc6ddce18e996d46c9864d93bd73
https://github.com/python/cpython/pull/12049/files#diff-d827b28854eb16794889d6a7d19c79c1c3cccc6ddce18e996d46c9864d93bd73
https://github.com/python/cpython/pull/12049/files#diff-d827b28854eb16794889d6a7d19c79c1c3cccc6ddce18e996d46c9864d93bd73
Lib/pty.pyhttps://github.com/python/cpython/pull/12049/files#diff-6951c8bf11da0d5912302a24b778e2c968fae9212bfeb2e73de06ec257b2d1da
View file https://github.com/RadicalZephyr/cpython/blob/9f62b8229ca852b4b07e840a5b5632ba1f5bdde2/Lib/pty.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/12049/{{ revealButtonHref }}
https://github.com/python/cpython/pull/12049/files#diff-6951c8bf11da0d5912302a24b778e2c968fae9212bfeb2e73de06ec257b2d1da
https://github.com/python/cpython/pull/12049/files#diff-6951c8bf11da0d5912302a24b778e2c968fae9212bfeb2e73de06ec257b2d1da
https://github.com/python/cpython/pull/12049/files#diff-6951c8bf11da0d5912302a24b778e2c968fae9212bfeb2e73de06ec257b2d1da
https://github.com/python/cpython/pull/12049/files#diff-6951c8bf11da0d5912302a24b778e2c968fae9212bfeb2e73de06ec257b2d1da
Please reload this pagehttps://github.com/python/cpython/pull/12049/files
https://github.com/python/cpython/pull/12049/files#diff-6951c8bf11da0d5912302a24b778e2c968fae9212bfeb2e73de06ec257b2d1da
Please reload this pagehttps://github.com/python/cpython/pull/12049/files
Lib/test/test_pty.pyhttps://github.com/python/cpython/pull/12049/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
View file https://github.com/RadicalZephyr/cpython/blob/9f62b8229ca852b4b07e840a5b5632ba1f5bdde2/Lib/test/test_pty.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/12049/{{ revealButtonHref }}
https://github.com/python/cpython/pull/12049/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/12049/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/12049/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/12049/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/12049/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/12049/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/12049/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/12049/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/12049/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/12049/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/12049/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
Misc/ACKShttps://github.com/python/cpython/pull/12049/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
View file https://github.com/RadicalZephyr/cpython/blob/9f62b8229ca852b4b07e840a5b5632ba1f5bdde2/Misc/ACKS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/12049/{{ revealButtonHref }}
https://github.com/python/cpython/pull/12049/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
https://github.com/python/cpython/pull/12049/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
Misc/NEWS.d/next/Library/2019-02-26-09-31-59.bpo-26228.wyrHKc.rsthttps://github.com/python/cpython/pull/12049/files#diff-b583de3d4ebde320e2299a91f0cc142eeebfbc55a080000f46c807333b1d2af1
View file https://github.com/RadicalZephyr/cpython/blob/9f62b8229ca852b4b07e840a5b5632ba1f5bdde2/Misc/NEWS.d/next/Library/2019-02-26-09-31-59.bpo-26228.wyrHKc.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/12049/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.