| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ea210dde-7994-ea1d-fea3-5d86feed06d8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9AE0:88BC0:20187D:27E235:6B023406 |
| html-safe-nonce | 564ba3c980d116e570e964620f12253097adfe2cc33ca1c078afdf1dafbf1f4d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUUwOjg4QkMwOjIwMTg3RDoyN0UyMzU6NkIwMjM0MDYiLCJ2aXNpdG9yX2lkIjoiNDA2MDA5NzU5OTYyNDA2NjA1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d35d49a0aee5003d24afa5a9239789e85aa35824297fc6f8f12772a4ea6feb92 |
| hovercard-subject-tag | pull_request:1916401441 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/120398/files |
| twitter:image | https://avatars.githubusercontent.com/u/26142226?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/26142226?s=400&v=4 |
| og:image:alt | Issue: gh-120397
Benchmarks using:
./python -m timeit -s "seq='TTTATGGTTATTTATATTTATTTATTTTTGAGATGGAGTTTTGCTCTTGCTGCCTAGGCTGGAGTGCAATGGCACGATCTCGGCTCACTGCAACCTCCGCCTCCCAGGTTCAAGCGATTCTCCT... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/120398/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120398%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120398%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/120398/files |
| Reload | https://github.com/python/cpython/pull/120398/files |
| Reload | https://github.com/python/cpython/pull/120398/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| vstinner | https://github.com/vstinner |
| python:main | https://github.com/python/cpython/tree/main |
| rhpvorderman:fastercount | https://github.com/rhpvorderman/cpython/tree/fastercount |
|
Conversation
48
| https://github.com/python/cpython/pull/120398 |
|
Commits
16
| https://github.com/python/cpython/pull/120398/commits |
|
Checks
0
| https://github.com/python/cpython/pull/120398/checks |
|
Files changed
| https://github.com/python/cpython/pull/120398/files |
| Please reload this page | https://github.com/python/cpython/pull/120398/files |
|
gh-120397: improve the speed of str.count, bytes.count et al. for single characters by about 2x.
| https://github.com/python/cpython/pull/120398/files#top |
|
Show all changes
16 commits
| https://github.com/python/cpython/pull/120398/files |
|
b2f9fb5
Faster counting of characters due to autovectorization
rhpvorderman Jun 12, 2024
| https://github.com/python/cpython/pull/120398/commits/b2f9fb52d3cdec8f56944574a1c2ac152925fea1 |
|
cb56443
Add blurb entry for faster count method
rhpvorderman Jun 12, 2024
| https://github.com/python/cpython/pull/120398/commits/cb564438a1afc062d9e4b220ce16e87c3a859596 |
|
fff610b
Rewrite count function as a for loop
rhpvorderman Jun 12, 2024
| https://github.com/python/cpython/pull/120398/commits/fff610bd4cf152a7c0ac8ebb3ef6446718f17870 |
|
1359366
Do the max count check in the inner loop
rhpvorderman Jun 12, 2024
| https://github.com/python/cpython/pull/120398/commits/1359366d20b4768d7ec89150c826ea20d12f6d2c |
|
5837e41
Remove extraneous newline
rhpvorderman Jun 12, 2024
| https://github.com/python/cpython/pull/120398/commits/5837e412f2fad138cf8030060f3f1e80b263b851 |
|
c6f4068
Add an explanatory comment
rhpvorderman Jun 12, 2024
| https://github.com/python/cpython/pull/120398/commits/c6f40682b444c9ca007dcf333a4a4323e0ffd9c9 |
|
0eaccd5
Revert changes
rhpvorderman Jun 12, 2024
| https://github.com/python/cpython/pull/120398/commits/0eaccd590ae575b2c38cab13b88402d17984b025 |
|
a85202c
Use a no maximum count function
rhpvorderman Jun 12, 2024
| https://github.com/python/cpython/pull/120398/commits/a85202cc36333c50b57c2e0b065e481b7f55ce0f |
|
807706d
Update Misc/NEWS.d/next/Core and Builtins/2024-06-12-13-47-25.gh-issu…
rhpvorderman Jun 12, 2024
| https://github.com/python/cpython/pull/120398/commits/807706d005fb8cedbe97afab16a5333a92e2cc9f |
|
fb83c6a
Formatting
rhpvorderman Jun 12, 2024
| https://github.com/python/cpython/pull/120398/commits/fb83c6adb6eec0fd3f0d76cd6f741d6e054344ed |
|
05a1fc2
Give a speed indication
rhpvorderman Jun 13, 2024
| https://github.com/python/cpython/pull/120398/commits/05a1fc200991764d15c21cdc6172a5ae8a288152 |
|
2fab99b
Update comment
rhpvorderman Jun 13, 2024
| https://github.com/python/cpython/pull/120398/commits/2fab99b0a915611546dd191f9fc440b14a8fbb1b |
|
ce9ab9b
rename function
rhpvorderman Jun 13, 2024
| https://github.com/python/cpython/pull/120398/commits/ce9ab9beacea812c42c2d930e59bad1371642386 |
|
0cc9369
Update Objects/stringlib/fastsearch.h
vstinner Jun 13, 2024
| https://github.com/python/cpython/pull/120398/commits/0cc9369fc22836bee234d43a2e5415089dcb9dd9 |
|
30a65a7
Fix changing oversights
rhpvorderman Jun 13, 2024
| https://github.com/python/cpython/pull/120398/commits/30a65a7f1efadb01ec4b95b6eefd9e0a1b0dfe54 |
|
a16c7ec
Merge branch 'fastercount' of github.com:rhpvorderman/cpython into fa…
rhpvorderman Jun 13, 2024
| https://github.com/python/cpython/pull/120398/commits/a16c7ec071530510aabd87eb332535472d0d84e2 |
|
Clear filters
| https://github.com/python/cpython/pull/120398/files |
| Please reload this page | https://github.com/python/cpython/pull/120398/files |
| Please reload this page | https://github.com/python/cpython/pull/120398/files |
|
2024-06-12-13-47-25.gh-issue-120397.n-I_cc.rst
| https://github.com/python/cpython/pull/120398/files#diff-5bc5cacd17ac111eeaf9f2a3350646cbcea2a87836d7eaaaab128be6a53e5fb6 |
|
fastsearch.h
| https://github.com/python/cpython/pull/120398/files#diff-67ae1b84396bc0119774489a3e62be151a8e1b1317a63c540f976d57d3e0489d |
| Misc/NEWS.d/next/Core and Builtins/2024-06-12-13-47-25.gh-issue-120397.n-I_cc.rst | https://github.com/python/cpython/pull/120398/files#diff-5bc5cacd17ac111eeaf9f2a3350646cbcea2a87836d7eaaaab128be6a53e5fb6 |
|
View file
| https://github.com/rhpvorderman/cpython/blob/a16c7ec071530510aabd87eb332535472d0d84e2/Misc/NEWS.d/next/Core%20and%20Builtins/2024-06-12-13-47-25.gh-issue-120397.n-I_cc.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/120398/{{ revealButtonHref }} |
| Objects/stringlib/fastsearch.h | https://github.com/python/cpython/pull/120398/files#diff-67ae1b84396bc0119774489a3e62be151a8e1b1317a63c540f976d57d3e0489d |
|
View file
| https://github.com/rhpvorderman/cpython/blob/a16c7ec071530510aabd87eb332535472d0d84e2/Objects/stringlib/fastsearch.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/120398/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/120398/files#diff-67ae1b84396bc0119774489a3e62be151a8e1b1317a63c540f976d57d3e0489d |
|
| https://github.com/python/cpython/pull/120398/files#diff-67ae1b84396bc0119774489a3e62be151a8e1b1317a63c540f976d57d3e0489d |
| nineteendo | https://github.com/nineteendo |
| Jun 13, 2024 | https://github.com/python/cpython/pull/120398/files#r1638104094 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/120398/files |
| rhpvorderman | https://github.com/rhpvorderman |
| Jun 13, 2024 | https://github.com/python/cpython/pull/120398/files#r1638110307 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/120398/files |
| nineteendo | https://github.com/nineteendo |
| Jun 13, 2024 | https://github.com/python/cpython/pull/120398/files#r1638116554 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/120398/files |
| rhpvorderman | https://github.com/rhpvorderman |
| Jun 13, 2024 | https://github.com/python/cpython/pull/120398/files#r1638515754 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/120398/files |
|
| https://github.com/python/cpython/pull/120398/files#diff-67ae1b84396bc0119774489a3e62be151a8e1b1317a63c540f976d57d3e0489d |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |