René's URL Explorer Experiment


Title: gh-71587: Drop local reference cache to `_strptime` module in `_datetime` by neonene · Pull Request #120224 · python/cpython · GitHub

Open Graph Title: gh-71587: Drop local reference cache to `_strptime` module in `_datetime` by neonene · Pull Request #120224 · python/cpython

X Title: gh-71587: Drop local reference cache to `_strptime` module in `_datetime` by neonene · Pull Request #120224 · python/cpython

Description: For 3.13 and newer, this PR fixes the following errors by making each loaded _datetime module use its own reference cache to _strptime module. The cache will be the same as the reference in sys.modules of the corresponding interpreter by importing _strptime module on each strptime() function call. Main interpreter: >_testembed_d test_repeated_init_exec "import datetime; datetime.datetime.strptime('200001', '%Y%m')" --- Loop #1 --- --- Loop #2 --- Traceback (most recent call last): File "", line 1, in TypeError: 'NoneType' object is not callable Sub interpreter: >>> import _interpreters >>> for i in range(1,3): ... print('Sub Loop', i) ... interp = _interpreters.create() ... s = "import datetime; datetime.datetime.strptime('200001', '%Y%m')" ... _interpreters.run_string(interp, s) ... _interpreters.destroy(interp) ... Sub Loop 1 Sub Loop 2 Assertion failed: PyUnicode_CheckExact(ep_key), file C:\cp\Objects\dictobject.c, line 1126 cc @ericsnowcurrently @erlend-aasland Issue: gh-71587 Issue: gh-117914 Issue: gh-117398

Open Graph Description: For 3.13 and newer, this PR fixes the following errors by making each loaded _datetime module use its own reference cache to _strptime module. The cache will be the same as the reference in sys.mo...

X Description: For 3.13 and newer, this PR fixes the following errors by making each loaded _datetime module use its own reference cache to _strptime module. The cache will be the same as the reference in sys.mo...

Opengraph URL: https://github.com/python/cpython/pull/120224

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f4ebbf1b-8484-75b9-0e8c-182a7de38a83
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8746:8ADEB:271889:34B9B1:6969D1D0
html-safe-nonce233efa03071b8230e1ce3d93673adec02513dbc9aeef495c7477661715ea9ef9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzQ2OjhBREVCOjI3MTg4OTozNEI5QjE6Njk2OUQxRDAiLCJ2aXNpdG9yX2lkIjoiNzI0Njg3MjYxNDkzMDA3NjExMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccb316ace69ed51e67a9b11085e0b3d364671b6d0c324f659e855689e1989bcb7
hovercard-subject-tagpull_request:1909107586
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/120224/files
twitter:imagehttps://avatars.githubusercontent.com/u/53406459?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/53406459?s=400&v=4
og:image:altFor 3.13 and newer, this PR fixes the following errors by making each loaded _datetime module use its own reference cache to _strptime module. The cache will be the same as the reference in sys.mo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/120224/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120224%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120224%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/120224/files
Reloadhttps://github.com/python/cpython/pull/120224/files
Reloadhttps://github.com/python/cpython/pull/120224/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/120224/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/120224/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
Conversation 24 https://github.com/python/cpython/pull/120224
Commits 10 https://github.com/python/cpython/pull/120224/commits
Checks 0 https://github.com/python/cpython/pull/120224/checks
Files changed https://github.com/python/cpython/pull/120224/files
Please reload this pagehttps://github.com/python/cpython/pull/120224/files
gh-71587: Drop local reference cache to _strptime module in _datetime https://github.com/python/cpython/pull/120224/files#top
Show all changes 10 commits https://github.com/python/cpython/pull/120224/files
2b82d53 add test neonene Jun 7, 2024 https://github.com/python/cpython/pull/120224/commits/2b82d533a1bcd6ebfa655e09f02c64082c50e91b
085e37c make cache per-module neonene Jun 7, 2024 https://github.com/python/cpython/pull/120224/commits/085e37c9c419607e0c655d7afba9240db40fa271
e65bec3 add NEWS neonene Jun 7, 2024 https://github.com/python/cpython/pull/120224/commits/e65bec37c111cc1cd55288d114025e9aac063ee5
6bb0141 fix NEWS neonene Jun 7, 2024 https://github.com/python/cpython/pull/120224/commits/6bb01410e4dd3f83393348fa6627f319587be92d
8a0ea7b do not copy _strptime from old module state neonene Jun 7, 2024 https://github.com/python/cpython/pull/120224/commits/8a0ea7beeb18d6aa8f115b6665ff6ce8c8799a37
39a4259 Apply suggestions from code review neonene Jun 7, 2024 https://github.com/python/cpython/pull/120224/commits/39a425984133c852a9e12afed08c44cd6e2a5d35
33e0966 insert a comment neonene Jun 7, 2024 https://github.com/python/cpython/pull/120224/commits/33e0966855c2653fc62e20980a812fd1e64bcf76
12fad4c use PyImport_Import(&_Py_ID(_strptime)) without cache neonene Jun 7, 2024 https://github.com/python/cpython/pull/120224/commits/12fad4c4d09908f52f1c1a98344bcd9d55580f9f
341561b Update globals-to-fix.tsv neonene Jun 8, 2024 https://github.com/python/cpython/pull/120224/commits/341561b1ea7a300757895b987867726de5346a2e
ba2d0a5 Merge branch 'main' into strptime neonene Jun 8, 2024 https://github.com/python/cpython/pull/120224/commits/ba2d0a556fe1e962374ccd4fa5a91e52d4e38118
Clear filters https://github.com/python/cpython/pull/120224/files
Please reload this pagehttps://github.com/python/cpython/pull/120224/files
Please reload this pagehttps://github.com/python/cpython/pull/120224/files
pycore_global_objects_fini_generated.h https://github.com/python/cpython/pull/120224/files#diff-31f682b2a04cda997f449a9816ee5fae305e3bfa7357afcb794615921c6a88d2
pycore_global_strings.h https://github.com/python/cpython/pull/120224/files#diff-7656e411eccd63ff8aab3e11de3f45035665f6b639206d3f440727dfb5e0ebcf
pycore_runtime_init_generated.h https://github.com/python/cpython/pull/120224/files#diff-69a1fc720f0b1e9005cf7717dd81c823399da81dd2f6480664b51238c1ef93f0
pycore_unicodeobject_generated.h https://github.com/python/cpython/pull/120224/files#diff-510f6084b63d39305481b719ae0a29475ba759e259a8e4cee4f07c451ffbb2d6
test_embed.py https://github.com/python/cpython/pull/120224/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
2024-06-07-11-23-31.gh-issue-71587.IjFajE.rst https://github.com/python/cpython/pull/120224/files#diff-8328babf6131c743e8506b172d97dc3f373f70b8f4591eaab7c006bd42491ba5
_datetimemodule.c https://github.com/python/cpython/pull/120224/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
globals-to-fix.tsv https://github.com/python/cpython/pull/120224/files#diff-8d1e9a0d5771dfc3a628047509e2d4a1027327bd89392e5a3ec5fbd3d08cfa19
Include/internal/pycore_global_objects_fini_generated.hhttps://github.com/python/cpython/pull/120224/files#diff-31f682b2a04cda997f449a9816ee5fae305e3bfa7357afcb794615921c6a88d2
View file https://github.com/python/cpython/blob/ba2d0a556fe1e962374ccd4fa5a91e52d4e38118/Include/internal/pycore_global_objects_fini_generated.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/120224/files
Include/internal/pycore_global_strings.hhttps://github.com/python/cpython/pull/120224/files#diff-7656e411eccd63ff8aab3e11de3f45035665f6b639206d3f440727dfb5e0ebcf
View file https://github.com/python/cpython/blob/ba2d0a556fe1e962374ccd4fa5a91e52d4e38118/Include/internal/pycore_global_strings.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/120224/{{ revealButtonHref }}
https://github.com/python/cpython/pull/120224/files#diff-7656e411eccd63ff8aab3e11de3f45035665f6b639206d3f440727dfb5e0ebcf
https://github.com/python/cpython/pull/120224/files#diff-7656e411eccd63ff8aab3e11de3f45035665f6b639206d3f440727dfb5e0ebcf
Include/internal/pycore_runtime_init_generated.hhttps://github.com/python/cpython/pull/120224/files#diff-69a1fc720f0b1e9005cf7717dd81c823399da81dd2f6480664b51238c1ef93f0
View file https://github.com/python/cpython/blob/ba2d0a556fe1e962374ccd4fa5a91e52d4e38118/Include/internal/pycore_runtime_init_generated.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/120224/files
Include/internal/pycore_unicodeobject_generated.hhttps://github.com/python/cpython/pull/120224/files#diff-510f6084b63d39305481b719ae0a29475ba759e259a8e4cee4f07c451ffbb2d6
View file https://github.com/python/cpython/blob/ba2d0a556fe1e962374ccd4fa5a91e52d4e38118/Include/internal/pycore_unicodeobject_generated.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/120224/files
Lib/test/test_embed.pyhttps://github.com/python/cpython/pull/120224/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
View file https://github.com/python/cpython/blob/ba2d0a556fe1e962374ccd4fa5a91e52d4e38118/Lib/test/test_embed.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/120224/{{ revealButtonHref }}
https://github.com/python/cpython/pull/120224/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
https://github.com/python/cpython/pull/120224/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
Misc/NEWS.d/next/Library/2024-06-07-11-23-31.gh-issue-71587.IjFajE.rsthttps://github.com/python/cpython/pull/120224/files#diff-8328babf6131c743e8506b172d97dc3f373f70b8f4591eaab7c006bd42491ba5
View file https://github.com/python/cpython/blob/ba2d0a556fe1e962374ccd4fa5a91e52d4e38118/Misc/NEWS.d/next/Library/2024-06-07-11-23-31.gh-issue-71587.IjFajE.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/120224/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L429
Modules/_datetimemodule.chttps://github.com/python/cpython/pull/120224/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
View file https://github.com/python/cpython/blob/ba2d0a556fe1e962374ccd4fa5a91e52d4e38118/Modules/_datetimemodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/120224/{{ revealButtonHref }}
https://github.com/python/cpython/pull/120224/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
Please reload this pagehttps://github.com/python/cpython/pull/120224/files
Please reload this pagehttps://github.com/python/cpython/pull/120224/files
https://github.com/python/cpython/pull/120224/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L127
Tools/c-analyzer/cpython/globals-to-fix.tsvhttps://github.com/python/cpython/pull/120224/files#diff-8d1e9a0d5771dfc3a628047509e2d4a1027327bd89392e5a3ec5fbd3d08cfa19
View file https://github.com/python/cpython/blob/ba2d0a556fe1e962374ccd4fa5a91e52d4e38118/Tools/c-analyzer/cpython/globals-to-fix.tsv
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/120224/{{ revealButtonHref }}
https://github.com/python/cpython/pull/120224/files#diff-8d1e9a0d5771dfc3a628047509e2d4a1027327bd89392e5a3ec5fbd3d08cfa19
https://github.com/python/cpython/pull/120224/files#diff-8d1e9a0d5771dfc3a628047509e2d4a1027327bd89392e5a3ec5fbd3d08cfa19
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.