René's URL Explorer Experiment


Title: [3.13] gh-117657: Fix TSAN race involving import lock (GH-118523) by miss-islington · Pull Request #120169 · python/cpython · GitHub

Open Graph Title: [3.13] gh-117657: Fix TSAN race involving import lock (GH-118523) by miss-islington · Pull Request #120169 · python/cpython

X Title: [3.13] gh-117657: Fix TSAN race involving import lock (GH-118523) by miss-islington · Pull Request #120169 · python/cpython

Description: This adds a _PyRecursiveMutex type based on PyMutex and uses that for the import lock. This fixes some data races in the free-threaded build and generally simplifies the import lock code. (cherry picked from commit e21057b) Co-authored-by: Sam Gross colesbury@gmail.com Issue: gh-117657

Open Graph Description: This adds a _PyRecursiveMutex type based on PyMutex and uses that for the import lock. This fixes some data races in the free-threaded build and generally simplifies the import lock code. (cherry p...

X Description: This adds a _PyRecursiveMutex type based on PyMutex and uses that for the import lock. This fixes some data races in the free-threaded build and generally simplifies the import lock code. (cherry p...

Opengraph URL: https://github.com/python/cpython/pull/120169

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:648a1d1f-9c0e-63f4-63f0-e84f86539515
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id864A:1DD20D:13507CC:19EB17C:6A5AB408
html-safe-nonce7583ca6e81d5430329ef10492b29e2e9ef2b3aef5d3c48c78c0847a3f3b215bc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjRBOjFERDIwRDoxMzUwN0NDOjE5RUIxN0M6NkE1QUI0MDgiLCJ2aXNpdG9yX2lkIjoiMjczMDY5Mzg0NDQwOTE2ODkwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac34b42b24478e5a888fa5343bd67127a78330264f09280560852533681298dda0
hovercard-subject-tagpull_request:1907780697
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/120169/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altThis adds a _PyRecursiveMutex type based on PyMutex and uses that for the import lock. This fixes some data races in the free-threaded build and generally simplifies the import lock code. (cherry p...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2702febe50e53f9152dda552dc2049a5eb182778b2655abd5b8619e82e899b4a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec0211a077f9b056c5e115f996d9049616d85c3b5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/120169/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120169%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120169%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/120169/files
Reloadhttps://github.com/python/cpython/pull/120169/files
Reloadhttps://github.com/python/cpython/pull/120169/files
Please reload this pagehttps://github.com/python/cpython/pull/120169/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/120169/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
colesburyhttps://github.com/colesbury
python:3.13https://github.com/python/cpython/tree/3.13
miss-islington:backport-e21057b-3.13https://github.com/miss-islington/cpython/tree/backport-e21057b-3.13
Conversation 0 https://github.com/python/cpython/pull/120169
Commits 1 https://github.com/python/cpython/pull/120169/commits
Checks 0 https://github.com/python/cpython/pull/120169/checks
Files changed https://github.com/python/cpython/pull/120169/files
Please reload this pagehttps://github.com/python/cpython/pull/120169/files
[3.13] gh-117657: Fix TSAN race involving import lock (GH-118523) https://github.com/python/cpython/pull/120169/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/120169/files
c1cbacc gh-117657: Fix TSAN race involving import lock (GH-118523) colesbury Jun 6, 2024 https://github.com/python/cpython/pull/120169/commits/c1cbacc3127315e799627d63acfb454072fa94ac
Clear filters https://github.com/python/cpython/pull/120169/files
Please reload this pagehttps://github.com/python/cpython/pull/120169/files
Please reload this pagehttps://github.com/python/cpython/pull/120169/files
pycore_import.h https://github.com/python/cpython/pull/120169/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
pycore_lock.h https://github.com/python/cpython/pull/120169/files#diff-c4ea3ba1b986b7045be6c6260113e2b765c497ec9842e5c6c30abe466d1f2c73
test_lock.c https://github.com/python/cpython/pull/120169/files#diff-12acc51f85bb5675198b5a0f1b017880dca294530f747c211c16b22030da22ca
posixmodule.c https://github.com/python/cpython/pull/120169/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
import.c https://github.com/python/cpython/pull/120169/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
lock.c https://github.com/python/cpython/pull/120169/files#diff-8a628e2db62193e1be26995ded4a1da56d11a156b4e9190984c910f1b019a962
suppressions_free_threading.txt https://github.com/python/cpython/pull/120169/files#diff-e0bd286d26ab448230ebe522b9086f5e93c33327108faff3a3957a34bb605f62
https://github.com/python/cpython/blob/3.13/.github/CODEOWNERS#L111
Include/internal/pycore_import.hhttps://github.com/python/cpython/pull/120169/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
View file https://github.com/miss-islington/cpython/blob/c1cbacc3127315e799627d63acfb454072fa94ac/Include/internal/pycore_import.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/120169/{{ revealButtonHref }}
https://github.com/python/cpython/pull/120169/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
https://github.com/python/cpython/pull/120169/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
https://github.com/python/cpython/pull/120169/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
https://github.com/python/cpython/pull/120169/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
https://github.com/python/cpython/pull/120169/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
https://github.com/python/cpython/pull/120169/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
https://github.com/python/cpython/pull/120169/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
Include/internal/pycore_lock.hhttps://github.com/python/cpython/pull/120169/files#diff-c4ea3ba1b986b7045be6c6260113e2b765c497ec9842e5c6c30abe466d1f2c73
View file https://github.com/miss-islington/cpython/blob/c1cbacc3127315e799627d63acfb454072fa94ac/Include/internal/pycore_lock.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/120169/{{ revealButtonHref }}
https://github.com/python/cpython/pull/120169/files#diff-c4ea3ba1b986b7045be6c6260113e2b765c497ec9842e5c6c30abe466d1f2c73
https://github.com/python/cpython/pull/120169/files#diff-c4ea3ba1b986b7045be6c6260113e2b765c497ec9842e5c6c30abe466d1f2c73
Modules/_testinternalcapi/test_lock.chttps://github.com/python/cpython/pull/120169/files#diff-12acc51f85bb5675198b5a0f1b017880dca294530f747c211c16b22030da22ca
View file https://github.com/miss-islington/cpython/blob/c1cbacc3127315e799627d63acfb454072fa94ac/Modules/_testinternalcapi/test_lock.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/120169/{{ revealButtonHref }}
https://github.com/python/cpython/pull/120169/files#diff-12acc51f85bb5675198b5a0f1b017880dca294530f747c211c16b22030da22ca
https://github.com/python/cpython/pull/120169/files#diff-12acc51f85bb5675198b5a0f1b017880dca294530f747c211c16b22030da22ca
https://github.com/python/cpython/pull/120169/files#diff-12acc51f85bb5675198b5a0f1b017880dca294530f747c211c16b22030da22ca
https://github.com/python/cpython/pull/120169/files#diff-12acc51f85bb5675198b5a0f1b017880dca294530f747c211c16b22030da22ca
https://github.com/python/cpython/pull/120169/files#diff-12acc51f85bb5675198b5a0f1b017880dca294530f747c211c16b22030da22ca
Modules/posixmodule.chttps://github.com/python/cpython/pull/120169/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
View file https://github.com/miss-islington/cpython/blob/c1cbacc3127315e799627d63acfb454072fa94ac/Modules/posixmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/120169/{{ revealButtonHref }}
https://github.com/python/cpython/pull/120169/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/120169/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/120169/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/120169/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/120169/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/120169/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/blob/3.13/.github/CODEOWNERS#L112
Python/import.chttps://github.com/python/cpython/pull/120169/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
View file https://github.com/miss-islington/cpython/blob/c1cbacc3127315e799627d63acfb454072fa94ac/Python/import.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/120169/{{ revealButtonHref }}
https://github.com/python/cpython/pull/120169/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/120169/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/120169/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/120169/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/120169/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/120169/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/120169/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/120169/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/120169/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
Python/lock.chttps://github.com/python/cpython/pull/120169/files#diff-8a628e2db62193e1be26995ded4a1da56d11a156b4e9190984c910f1b019a962
View file https://github.com/miss-islington/cpython/blob/c1cbacc3127315e799627d63acfb454072fa94ac/Python/lock.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/120169/{{ revealButtonHref }}
https://github.com/python/cpython/pull/120169/files#diff-8a628e2db62193e1be26995ded4a1da56d11a156b4e9190984c910f1b019a962
https://github.com/python/cpython/pull/120169/files#diff-8a628e2db62193e1be26995ded4a1da56d11a156b4e9190984c910f1b019a962
Tools/tsan/suppressions_free_threading.txthttps://github.com/python/cpython/pull/120169/files#diff-e0bd286d26ab448230ebe522b9086f5e93c33327108faff3a3957a34bb605f62
View file https://github.com/miss-islington/cpython/blob/c1cbacc3127315e799627d63acfb454072fa94ac/Tools/tsan/suppressions_free_threading.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/120169/{{ revealButtonHref }}
https://github.com/python/cpython/pull/120169/files#diff-e0bd286d26ab448230ebe522b9086f5e93c33327108faff3a3957a34bb605f62
https://github.com/python/cpython/pull/120169/files#diff-e0bd286d26ab448230ebe522b9086f5e93c33327108faff3a3957a34bb605f62
https://github.com/python/cpython/pull/120169/files#diff-e0bd286d26ab448230ebe522b9086f5e93c33327108faff3a3957a34bb605f62
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.