René's URL Explorer Experiment


Title: gh-93691: fix too broad source locations of with-statement instructions by iritkatriel · Pull Request #120125 · python/cpython · GitHub

Open Graph Title: gh-93691: fix too broad source locations of with-statement instructions by iritkatriel · Pull Request #120125 · python/cpython

X Title: gh-93691: fix too broad source locations of with-statement instructions by iritkatriel · Pull Request #120125 · python/cpython

Description: Previously an exception from the __init__, __enter__ and __exit__ would give the whole with-statement, with the body, as the location. Now it pinpoints which context manager failed. Issue: Byteco...

Open Graph Description: Previously an exception from the __init__, __enter__ and __exit__ would give the whole with-statement, with the body, as the location. Now it pinpoints which context manager failed. Issue: Byteco...

X Description: Previously an exception from the __init__, __enter__ and __exit__ would give the whole with-statement, with the body, as the location. Now it pinpoints which context manager failed. Issue: Byteco...

Opengraph URL: https://github.com/python/cpython/pull/120125

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7b4f8b65-dd9b-4414-9c7e-bafd5016683c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB95A:2DE4E0:A62320:D9D3A2:696B5816
html-safe-nonce389637dbf478ba6b140ad40193bda2bdf7563920232ca5d0acd57b8164bd6b02
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTVBOjJERTRFMDpBNjIzMjA6RDlEM0EyOjY5NkI1ODE2IiwidmlzaXRvcl9pZCI6IjQ0NzA0MjQ4ODgxNjU4ODgyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbbd218f6016a9a07eb631a538195e6b0acad15d1e11adb93a37fd2c9a16add22
hovercard-subject-tagpull_request:1905631557
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/120125/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c48d0be88cd1d9fc0d612c98c6d55cf0d73ccb78ceae72bac41f7f79947c0e88/python/cpython/pull/120125
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c48d0be88cd1d9fc0d612c98c6d55cf0d73ccb78ceae72bac41f7f79947c0e88/python/cpython/pull/120125
og:image:altPreviously an exception from the __init__, __enter__ and __exit__ would give the whole with-statement, with the body, as the location. Now it pinpoints which context manager failed. Issue: Byteco...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameiritkatriel
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/120125#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120125
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120125
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/120125
Reloadhttps://github.com/python/cpython/pull/120125
Reloadhttps://github.com/python/cpython/pull/120125
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/120125
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/120125
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/120125#issue-comment-box
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
iritkatriel:with_locationhttps://github.com/iritkatriel/cpython/tree/with_location
gh-93691: fix too broad source locations of with-statement instructions https://github.com/python/cpython/pull/120125#top
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
iritkatriel:with_locationhttps://github.com/iritkatriel/cpython/tree/with_location
Conversation 4 https://github.com/python/cpython/pull/120125
Commits 3 https://github.com/python/cpython/pull/120125/commits
Checks 0 https://github.com/python/cpython/pull/120125/checks
Files changed https://github.com/python/cpython/pull/120125/files
Please reload this pagehttps://github.com/python/cpython/pull/120125
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Jun 5, 2024https://github.com/python/cpython/pull/120125#issue-2336453849
Please reload this pagehttps://github.com/python/cpython/pull/120125
Bytecode positions seem way too broad #93691https://github.com/python/cpython/issues/93691
Please reload this pagehttps://github.com/python/cpython/pull/120125
https://github.com/iritkatriel
pythongh-93691https://github.com/python/cpython/issues/93691
: fix too broad source locations of with-statement inst…https://github.com/python/cpython/pull/120125/commits/5a91e79d9d45e24a15f85037ec4e2f1e844f038e
5a91e79https://github.com/python/cpython/pull/120125/commits/5a91e79d9d45e24a15f85037ec4e2f1e844f038e
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/10eac0269bce4e2ba575e5b549d3dd9a6da9349a/.github/CODEOWNERS#L34
June 5, 2024 17:27https://github.com/python/cpython/pull/120125#event-13054995321
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 5, 2024https://github.com/python/cpython/pull/120125#event-13054996209
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 5, 2024 https://github.com/python/cpython/pull/120125#ref-issue-1267866640
Bytecode positions seem way too broad #93691 https://github.com/python/cpython/issues/93691
iritkatrielhttps://github.com/iritkatriel
June 5, 2024 18:29https://github.com/python/cpython/pull/120125#commits-pushed-8936ea0
https://github.com/iritkatriel
add newshttps://github.com/python/cpython/pull/120125/commits/8936ea00d52a66911b632a299e38dad4b681b138
8936ea0https://github.com/python/cpython/pull/120125/commits/8936ea00d52a66911b632a299e38dad4b681b138
https://github.com/iritkatriel
Merge branch 'main' into with_locationhttps://github.com/python/cpython/pull/120125/commits/5b9c586efa5756f5525fc9228269090d096d12ba
5b9c586https://github.com/python/cpython/pull/120125/commits/5b9c586efa5756f5525fc9228269090d096d12ba
https://github.com/carljm
carljmhttps://github.com/carljm
Jun 6, 2024 https://github.com/python/cpython/pull/120125#pullrequestreview-2102336594
View reviewed changes https://github.com/python/cpython/pull/120125/files/5b9c586efa5756f5525fc9228269090d096d12ba
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 6, 2024https://github.com/python/cpython/pull/120125#event-13068774118
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
eca3f77https://github.com/python/cpython/commit/eca3f7762c23b22a73a5e0b09520748c88aab4a0
Jun 7, 2024https://github.com/python/cpython/pull/120125#event-13080586462
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jun 7, 2024https://github.com/python/cpython/pull/120125#event-13080587112
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Jun 10, 2024https://github.com/python/cpython/pull/120125#event-13107655816
noahbkimhttps://github.com/noahbkim
Jul 11, 2024 https://github.com/python/cpython/pull/120125#ref-commit-fa240f6
https://github.com/iritkatriel
https://github.com/noahbkim
pythongh-93691https://github.com/python/cpython/issues/93691
: fix too broad source locations of with-statement inst…https://github.com/hudson-trading/cpython/commit/fa240f6f7bb09f2cf5c07adb9ebb54e66a11b561
fa240f6https://github.com/hudson-trading/cpython/commit/fa240f6f7bb09f2cf5c07adb9ebb54e66a11b561
python#120125https://github.com/python/cpython/pull/120125
https://github.com/dmadisetti
dmadisettihttps://github.com/dmadisetti
Jul 17, 2024 https://github.com/python/cpython/pull/120125#ref-issue-2411669751
White space causes inconsistent frame traversal in With blocks #121865 https://github.com/python/cpython/issues/121865
estyxxhttps://github.com/estyxx
Jul 17, 2024 https://github.com/python/cpython/pull/120125#ref-commit-e9cefff
https://github.com/iritkatriel
https://github.com/estyxx
pythongh-93691https://github.com/python/cpython/issues/93691
: fix too broad source locations of with-statement inst…https://github.com/estyxx/cpython/commit/e9cefffe8924844b440b0dc873e3704c79f565c0
e9cefffhttps://github.com/estyxx/cpython/commit/e9cefffe8924844b440b0dc873e3704c79f565c0
python#120125https://github.com/python/cpython/pull/120125
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Sep 2, 2024https://github.com/python/cpython/pull/120125#event-14104474323
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Sep 2, 2024https://github.com/python/cpython/pull/120125#issuecomment-2324881822
@iritkatrielhttps://github.com/iritkatriel
Please reload this pagehttps://github.com/python/cpython/pull/120125
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Sep 2, 2024https://github.com/python/cpython/pull/120125#issuecomment-2324881828
@iritkatrielhttps://github.com/iritkatriel
Please reload this pagehttps://github.com/python/cpython/pull/120125
miss-islingtonhttps://github.com/miss-islington
Sep 2, 2024 https://github.com/python/cpython/pull/120125#ref-commit-0da05d4
https://github.com/iritkatriel
https://github.com/miss-islington
pythongh-93691https://github.com/python/cpython/issues/93691
: fix too broad source locations of with-statement inst…https://github.com/miss-islington/cpython/commit/0da05d4e2d6582bd15d3e2678395ef55bfa763a3
0da05d4https://github.com/miss-islington/cpython/commit/0da05d4e2d6582bd15d3e2678395ef55bfa763a3
pythonGH-120125https://github.com/python/cpython/pull/120125
eca3f77https://github.com/miss-islington/cpython/commit/eca3f7762c23b22a73a5e0b09520748c88aab4a0
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 2, 2024https://github.com/python/cpython/pull/120125#issuecomment-2324882079
GH-123604https://github.com/python/cpython/pull/123604
3.13 branchhttps://github.com/python/cpython/tree/3.13
Please reload this pagehttps://github.com/python/cpython/pull/120125
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.13 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22
Sep 2, 2024https://github.com/python/cpython/pull/120125#event-14104476865
miss-islingtonhttps://github.com/miss-islington
Sep 2, 2024 https://github.com/python/cpython/pull/120125#ref-commit-35f1856
https://github.com/iritkatriel
https://github.com/miss-islington
pythongh-93691https://github.com/python/cpython/issues/93691
: fix too broad source locations of with-statement inst…https://github.com/miss-islington/cpython/commit/35f1856fa3a727ac178e0d8b09e0284dcfd8bd86
35f1856https://github.com/miss-islington/cpython/commit/35f1856fa3a727ac178e0d8b09e0284dcfd8bd86
pythonGH-120125https://github.com/python/cpython/pull/120125
eca3f77https://github.com/miss-islington/cpython/commit/eca3f7762c23b22a73a5e0b09520748c88aab4a0
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 2, 2024https://github.com/python/cpython/pull/120125#issuecomment-2324882250
GH-123605https://github.com/python/cpython/pull/123605
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/120125
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Sep 2, 2024https://github.com/python/cpython/pull/120125#event-14104477887
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Sep 2, 2024 https://github.com/python/cpython/pull/120125#ref-pullrequest-2363858095
[3.13] gh-98442: fix locations of with statement's cleanup instructions (GH-120763) #120786 https://github.com/python/cpython/pull/120786
iritkatrielhttps://github.com/iritkatriel
Sep 2, 2024 https://github.com/python/cpython/pull/120125#ref-commit-22ec9cb
https://github.com/miss-islington
https://github.com/iritkatriel
[3.12]https://github.com/python/cpython/commit/22ec9cb823359e8e89b35d0f371bdfdb1b299626
gh-93691https://github.com/python/cpython/issues/93691
: fix too broad source locations of with-statement ins…https://github.com/python/cpython/commit/22ec9cb823359e8e89b35d0f371bdfdb1b299626
22ec9cbhttps://github.com/python/cpython/commit/22ec9cb823359e8e89b35d0f371bdfdb1b299626
GH-120125https://github.com/python/cpython/pull/120125
#123605https://github.com/python/cpython/pull/123605
gh-93691https://github.com/python/cpython/issues/93691
GH-120125https://github.com/python/cpython/pull/120125
eca3f77https://github.com/python/cpython/commit/eca3f7762c23b22a73a5e0b09520748c88aab4a0
iritkatrielhttps://github.com/iritkatriel
Sep 2, 2024 https://github.com/python/cpython/pull/120125#ref-commit-494181e
https://github.com/miss-islington
https://github.com/iritkatriel
[3.13]https://github.com/python/cpython/commit/494181e44db809204f55eaebc88a255acb09a18f
gh-93691https://github.com/python/cpython/issues/93691
: fix too broad source locations of with-statement ins…https://github.com/python/cpython/commit/494181e44db809204f55eaebc88a255acb09a18f
494181ehttps://github.com/python/cpython/commit/494181e44db809204f55eaebc88a255acb09a18f
GH-120125https://github.com/python/cpython/pull/120125
#123604https://github.com/python/cpython/pull/123604
gh-93691https://github.com/python/cpython/issues/93691
GH-120125https://github.com/python/cpython/pull/120125
eca3f77https://github.com/python/cpython/commit/eca3f7762c23b22a73a5e0b09520748c88aab4a0
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F120125
https://github.com/carljm
carljm https://github.com/carljm
https://github.com/python/cpython/pull/120125/files/5b9c586efa5756f5525fc9228269090d096d12ba
https://github.com/markshannon
markshannon https://github.com/markshannon
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/120125
https://github.com/iritkatriel
https://github.com/carljm
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.