René's URL Explorer Experiment


Title: GH-89727: Fix `shutil.rmtree()` recursion error on deep trees by barneygale · Pull Request #119808 · python/cpython · GitHub

Open Graph Title: GH-89727: Fix `shutil.rmtree()` recursion error on deep trees by barneygale · Pull Request #119808 · python/cpython

X Title: GH-89727: Fix `shutil.rmtree()` recursion error on deep trees by barneygale · Pull Request #119808 · python/cpython

Description: Implement shutil._rmtree_safe_fd() using a list as a stack to avoid emitting recursion errors on deeply nested trees. shutil._rmtree_unsafe() was fixed in #119634. Issue: gh-89727

Open Graph Description: Implement shutil._rmtree_safe_fd() using a list as a stack to avoid emitting recursion errors on deeply nested trees. shutil._rmtree_unsafe() was fixed in #119634. Issue: gh-89727

X Description: Implement shutil._rmtree_safe_fd() using a list as a stack to avoid emitting recursion errors on deeply nested trees. shutil._rmtree_unsafe() was fixed in #119634. Issue: gh-89727

Opengraph URL: https://github.com/python/cpython/pull/119808

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1438dcb8-a201-4f70-a4cb-2e7824a86031
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCB2:1C02DC:20E24CA:2DC5F7F:69693D6A
html-safe-nonce74819a25b1f14a4259c14f8b679cda692447c332139111935f6296dd1e7623f5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0IyOjFDMDJEQzoyMEUyNENBOjJEQzVGN0Y6Njk2OTNENkEiLCJ2aXNpdG9yX2lkIjoiNDQ5MDM0NjE0NjA0MjU1OTg1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7c737304c18eb1ac46e1cfdb3661332f2356dae128a21b0652e33fa599a64180
hovercard-subject-tagpull_request:1896768709
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/119808/files
twitter:imagehttps://avatars.githubusercontent.com/u/960340?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/960340?s=400&v=4
og:image:altImplement shutil._rmtree_safe_fd() using a list as a stack to avoid emitting recursion errors on deeply nested trees. shutil._rmtree_unsafe() was fixed in #119634. Issue: gh-89727
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released69ac0477df0f87da03b8b06cebd187012d7a930
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/119808/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F119808%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F119808%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/119808/files
Reloadhttps://github.com/python/cpython/pull/119808/files
Reloadhttps://github.com/python/cpython/pull/119808/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/119808/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/119808/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
barneygalehttps://github.com/barneygale
python:mainhttps://github.com/python/cpython/tree/main
barneygale:gh-89727-rmtree-safehttps://github.com/barneygale/cpython/tree/gh-89727-rmtree-safe
Conversation 19 https://github.com/python/cpython/pull/119808
Commits 13 https://github.com/python/cpython/pull/119808/commits
Checks 0 https://github.com/python/cpython/pull/119808/checks
Files changed https://github.com/python/cpython/pull/119808/files
Please reload this pagehttps://github.com/python/cpython/pull/119808/files
GH-89727: Fix shutil.rmtree() recursion error on deep trees https://github.com/python/cpython/pull/119808/files#top
Show all changes 13 commits https://github.com/python/cpython/pull/119808/files
417b829 Tidy up `_rmtree_safe_fd()` implementation. barneygale May 30, 2024 https://github.com/python/cpython/pull/119808/commits/417b829af9dce5edcf963e664f40461fcd816b8f
8d42ea8 Rewrite using list as stack. barneygale May 30, 2024 https://github.com/python/cpython/pull/119808/commits/8d42ea89661599ceebf6ae31f8262faf316c3e61
7018370 Add NEWS barneygale May 30, 2024 https://github.com/python/cpython/pull/119808/commits/70183709e3a33f1aa6a12407206a81a25c492c5e
9f13194 Enable test barneygale May 30, 2024 https://github.com/python/cpython/pull/119808/commits/9f13194cc27edfa4d977749d413fff2d561921f2
aee87db Use DirEntry.stat() where possible. barneygale May 30, 2024 https://github.com/python/cpython/pull/119808/commits/aee87db34504dd05682fcbe3ad5d0661337f27ab
d9d0386 Comments, naming, line limit. barneygale May 30, 2024 https://github.com/python/cpython/pull/119808/commits/d9d0386949299c2f0a3bf15fc0ca49dae2937513
4daf2f2 Restore comment. barneygale May 30, 2024 https://github.com/python/cpython/pull/119808/commits/4daf2f20a5922230eab6b970a8103f9c6982f0e9
a335a63 Simplify overall diff barneygale May 30, 2024 https://github.com/python/cpython/pull/119808/commits/a335a63d1e81640e86b9302fcf152c340b2a43b6
1d4772a Address some review feedback barneygale May 31, 2024 https://github.com/python/cpython/pull/119808/commits/1d4772aece7e38e78b5fab37491e07c4a08127a5
462cfc1 Handle further errors in finally: block barneygale May 31, 2024 https://github.com/python/cpython/pull/119808/commits/462cfc13ef85015804f6b0953506573c0ccfb554
8d7ba83 Comments. barneygale May 31, 2024 https://github.com/python/cpython/pull/119808/commits/8d7ba8386304d34ddcb0f39837584302dd9eb184
11deeab Handle os.close explicitly barneygale May 31, 2024 https://github.com/python/cpython/pull/119808/commits/11deeabb9dfa27b64d00dcfaca610bcb36f5cff4
a53e473 Skip os.unlink() if os.DirEntry.is_dir() raises FileNotFoundError barneygale May 31, 2024 https://github.com/python/cpython/pull/119808/commits/a53e4736d6ce28cc11e68b63b69fec3951831dcb
Clear filters https://github.com/python/cpython/pull/119808/files
Please reload this pagehttps://github.com/python/cpython/pull/119808/files
Please reload this pagehttps://github.com/python/cpython/pull/119808/files
shutil.py https://github.com/python/cpython/pull/119808/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
test_shutil.py https://github.com/python/cpython/pull/119808/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
2024-05-30-21-37-05.gh-issue-89727.D6S9ig.rst https://github.com/python/cpython/pull/119808/files#diff-b4ef730aa09f64671dfc004277b02466d2ac5d524756545d304f738ed7acbe4c
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L560
Lib/shutil.pyhttps://github.com/python/cpython/pull/119808/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
View file https://github.com/barneygale/cpython/blob/a53e4736d6ce28cc11e68b63b69fec3951831dcb/Lib/shutil.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/119808/{{ revealButtonHref }}
https://github.com/python/cpython/pull/119808/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
Please reload this pagehttps://github.com/python/cpython/pull/119808/files
Please reload this pagehttps://github.com/python/cpython/pull/119808/files
https://github.com/python/cpython/pull/119808/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
https://github.com/python/cpython/pull/119808/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
https://github.com/python/cpython/pull/119808/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L561
Lib/test/test_shutil.pyhttps://github.com/python/cpython/pull/119808/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
View file https://github.com/barneygale/cpython/blob/a53e4736d6ce28cc11e68b63b69fec3951831dcb/Lib/test/test_shutil.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/119808/{{ revealButtonHref }}
https://github.com/python/cpython/pull/119808/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/119808/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
Misc/NEWS.d/next/Library/2024-05-30-21-37-05.gh-issue-89727.D6S9ig.rsthttps://github.com/python/cpython/pull/119808/files#diff-b4ef730aa09f64671dfc004277b02466d2ac5d524756545d304f738ed7acbe4c
View file https://github.com/barneygale/cpython/blob/a53e4736d6ce28cc11e68b63b69fec3951831dcb/Misc/NEWS.d/next/Library/2024-05-30-21-37-05.gh-issue-89727.D6S9ig.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/119808/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.