René's URL Explorer Experiment


Title: GH-89727: Fix `shutil.rmtree()` recursion error on deep trees by barneygale · Pull Request #119808 · python/cpython · GitHub

Open Graph Title: GH-89727: Fix `shutil.rmtree()` recursion error on deep trees by barneygale · Pull Request #119808 · python/cpython

X Title: GH-89727: Fix `shutil.rmtree()` recursion error on deep trees by barneygale · Pull Request #119808 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Implement shutil._rmtree_safe_fd() using a list as a stack to avoid emitting recursion errors on deeply nested trees. shutil._rmtree_unsafe() was fixed in #119634. Issue: Change shutil.rmtree and...

X Description: Implement shutil._rmtree_safe_fd() using a list as a stack to avoid emitting recursion errors on deeply nested trees. shutil._rmtree_unsafe() was fixed in #119634. Issue: Change shutil.rmtree and...

Opengraph URL: https://github.com/python/cpython/pull/119808

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:a2d615cf-51e5-26fa-2fee-966957d6dfc1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB19A:256A62:2BE429:3B6EC6:6969D2E6
html-safe-noncec88ae2c99bbdfea450713e9f2e7f0209897752465dc9161122f0512e11fd83a6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTlBOjI1NkE2MjoyQkU0Mjk6M0I2RUM2OjY5NjlEMkU2IiwidmlzaXRvcl9pZCI6IjcyNjU1Nzk3ODMwNzQ0Njg1ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac41b5cb6c7713e0ebc99b52334e2c507a5cd63e17b8e27d97387143c219b13d3b
hovercard-subject-tagpull_request:1896768709
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/119808/commits
twitter:imagehttps://opengraph.githubassets.com/d08e5486b4e4391fde59c1ae84413cf230468b2e56e4a19a1333322366a5b9c6/python/cpython/pull/119808
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d08e5486b4e4391fde59c1ae84413cf230468b2e56e4a19a1333322366a5b9c6/python/cpython/pull/119808
og:image:altImplement shutil._rmtree_safe_fd() using a list as a stack to avoid emitting recursion errors on deeply nested trees. shutil._rmtree_unsafe() was fixed in #119634. Issue: Change shutil.rmtree and...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebarneygale
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/119808/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F119808%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F119808%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/119808/commits
Reloadhttps://github.com/python/cpython/pull/119808/commits
Reloadhttps://github.com/python/cpython/pull/119808/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/119808/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/119808/commits
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
barneygalehttps://github.com/barneygale
python:mainhttps://github.com/python/cpython/tree/main
barneygale:gh-89727-rmtree-safehttps://github.com/barneygale/cpython/tree/gh-89727-rmtree-safe
Conversationhttps://github.com/python/cpython/pull/119808
Commits13 (13)https://github.com/python/cpython/pull/119808/commits
Checkshttps://github.com/python/cpython/pull/119808/checks
Files changedhttps://github.com/python/cpython/pull/119808/files
GH-89727: Fix shutil.rmtree() recursion error on deep treeshttps://github.com/python/cpython/pull/119808/commits#top
barneygalehttps://github.com/barneygale
python:mainhttps://github.com/python/cpython/tree/main
barneygale:gh-89727-rmtree-safehttps://github.com/barneygale/cpython/tree/gh-89727-rmtree-safe
Tidy up `_rmtree_safe_fd()` implementation.https://github.com/python/cpython/pull/119808/commits/417b829af9dce5edcf963e664f40461fcd816b8f
https://github.com/barneygale
barneygalehttps://github.com/python/cpython/commits?author=barneygale
417b829https://github.com/python/cpython/pull/119808/commits/417b829af9dce5edcf963e664f40461fcd816b8f
https://github.com/python/cpython/tree/417b829af9dce5edcf963e664f40461fcd816b8f
Rewrite using list as stack.https://github.com/python/cpython/pull/119808/commits/8d42ea89661599ceebf6ae31f8262faf316c3e61
https://github.com/barneygale
barneygalehttps://github.com/python/cpython/commits?author=barneygale
8d42ea8https://github.com/python/cpython/pull/119808/commits/8d42ea89661599ceebf6ae31f8262faf316c3e61
https://github.com/python/cpython/tree/8d42ea89661599ceebf6ae31f8262faf316c3e61
Add NEWShttps://github.com/python/cpython/pull/119808/commits/70183709e3a33f1aa6a12407206a81a25c492c5e
https://github.com/barneygale
barneygalehttps://github.com/python/cpython/commits?author=barneygale
7018370https://github.com/python/cpython/pull/119808/commits/70183709e3a33f1aa6a12407206a81a25c492c5e
https://github.com/python/cpython/tree/70183709e3a33f1aa6a12407206a81a25c492c5e
Enable testhttps://github.com/python/cpython/pull/119808/commits/9f13194cc27edfa4d977749d413fff2d561921f2
https://github.com/barneygale
barneygalehttps://github.com/python/cpython/commits?author=barneygale
9f13194https://github.com/python/cpython/pull/119808/commits/9f13194cc27edfa4d977749d413fff2d561921f2
https://github.com/python/cpython/tree/9f13194cc27edfa4d977749d413fff2d561921f2
Use DirEntry.stat() where possible.https://github.com/python/cpython/pull/119808/commits/aee87db34504dd05682fcbe3ad5d0661337f27ab
https://github.com/barneygale
barneygalehttps://github.com/python/cpython/commits?author=barneygale
aee87dbhttps://github.com/python/cpython/pull/119808/commits/aee87db34504dd05682fcbe3ad5d0661337f27ab
https://github.com/python/cpython/tree/aee87db34504dd05682fcbe3ad5d0661337f27ab
Comments, naming, line limit.https://github.com/python/cpython/pull/119808/commits/d9d0386949299c2f0a3bf15fc0ca49dae2937513
https://github.com/barneygale
barneygalehttps://github.com/python/cpython/commits?author=barneygale
d9d0386https://github.com/python/cpython/pull/119808/commits/d9d0386949299c2f0a3bf15fc0ca49dae2937513
https://github.com/python/cpython/tree/d9d0386949299c2f0a3bf15fc0ca49dae2937513
Restore comment.https://github.com/python/cpython/pull/119808/commits/4daf2f20a5922230eab6b970a8103f9c6982f0e9
https://github.com/barneygale
barneygalehttps://github.com/python/cpython/commits?author=barneygale
4daf2f2https://github.com/python/cpython/pull/119808/commits/4daf2f20a5922230eab6b970a8103f9c6982f0e9
https://github.com/python/cpython/tree/4daf2f20a5922230eab6b970a8103f9c6982f0e9
Simplify overall diffhttps://github.com/python/cpython/pull/119808/commits/a335a63d1e81640e86b9302fcf152c340b2a43b6
https://github.com/barneygale
barneygalehttps://github.com/python/cpython/commits?author=barneygale
a335a63https://github.com/python/cpython/pull/119808/commits/a335a63d1e81640e86b9302fcf152c340b2a43b6
https://github.com/python/cpython/tree/a335a63d1e81640e86b9302fcf152c340b2a43b6
Address some review feedbackhttps://github.com/python/cpython/pull/119808/commits/1d4772aece7e38e78b5fab37491e07c4a08127a5
https://github.com/barneygale
barneygalehttps://github.com/python/cpython/commits?author=barneygale
1d4772ahttps://github.com/python/cpython/pull/119808/commits/1d4772aece7e38e78b5fab37491e07c4a08127a5
https://github.com/python/cpython/tree/1d4772aece7e38e78b5fab37491e07c4a08127a5
Handle further errors in finally: blockhttps://github.com/python/cpython/pull/119808/commits/462cfc13ef85015804f6b0953506573c0ccfb554
https://github.com/barneygale
barneygalehttps://github.com/python/cpython/commits?author=barneygale
462cfc1https://github.com/python/cpython/pull/119808/commits/462cfc13ef85015804f6b0953506573c0ccfb554
https://github.com/python/cpython/tree/462cfc13ef85015804f6b0953506573c0ccfb554
Comments.https://github.com/python/cpython/pull/119808/commits/8d7ba8386304d34ddcb0f39837584302dd9eb184
https://github.com/barneygale
barneygalehttps://github.com/python/cpython/commits?author=barneygale
8d7ba83https://github.com/python/cpython/pull/119808/commits/8d7ba8386304d34ddcb0f39837584302dd9eb184
https://github.com/python/cpython/tree/8d7ba8386304d34ddcb0f39837584302dd9eb184
Handle os.close explicitlyhttps://github.com/python/cpython/pull/119808/commits/11deeabb9dfa27b64d00dcfaca610bcb36f5cff4
https://github.com/barneygale
barneygalehttps://github.com/python/cpython/commits?author=barneygale
11deeabhttps://github.com/python/cpython/pull/119808/commits/11deeabb9dfa27b64d00dcfaca610bcb36f5cff4
https://github.com/python/cpython/tree/11deeabb9dfa27b64d00dcfaca610bcb36f5cff4
Skip os.unlink() if os.DirEntry.is_dir() raises FileNotFoundErrorhttps://github.com/python/cpython/pull/119808/commits/a53e4736d6ce28cc11e68b63b69fec3951831dcb
https://github.com/barneygale
barneygalehttps://github.com/python/cpython/commits?author=barneygale
a53e473https://github.com/python/cpython/pull/119808/commits/a53e4736d6ce28cc11e68b63b69fec3951831dcb
https://github.com/python/cpython/tree/a53e4736d6ce28cc11e68b63b69fec3951831dcb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.