| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9c28d475-204e-1cc0-1636-b0c6032829d4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9E68:2D4026:275BF:368FB:69693E45 |
| html-safe-nonce | aba2c965ee9e370992e785d8997ee698592f85da6d171830c68ae5eae1bacf9c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTY4OjJENDAyNjoyNzVCRjozNjhGQjo2OTY5M0U0NSIsInZpc2l0b3JfaWQiOiIxODY1ODc0ODkzNDE2NTEzMDkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f3a83c1b776c427ea25ed4b14a74c4eaec7ba99ffaac7d93e0b6c54e9a8eb596 |
| hovercard-subject-tag | pull_request:1890859557 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/119638/files |
| twitter:image | https://avatars.githubusercontent.com/u/960340?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/960340?s=400&v=4 |
| og:image:alt | Implement os.fwalk() using a list as a stack to avoid emitting recursion errors on deeply nested trees.
Issue: gh-89727 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d69ac0477df0f87da03b8b06cebd187012d7a930 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/119638/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F119638%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F119638%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/119638/files |
| Reload | https://github.com/python/cpython/pull/119638/files |
| Reload | https://github.com/python/cpython/pull/119638/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/119638/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/119638/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| barneygale | https://github.com/barneygale |
| python:main | https://github.com/python/cpython/tree/main |
| barneygale:gh-89727-os-fwalk | https://github.com/barneygale/cpython/tree/gh-89727-os-fwalk |
|
Conversation
14
| https://github.com/python/cpython/pull/119638 |
|
Commits
9
| https://github.com/python/cpython/pull/119638/commits |
|
Checks
0
| https://github.com/python/cpython/pull/119638/checks |
|
Files changed
3
| https://github.com/python/cpython/pull/119638/files |
|
GH-89727: Fix os.fwalk() recursion error on deep trees
| https://github.com/python/cpython/pull/119638/files#top |
|
Show all changes
9 commits
| https://github.com/python/cpython/pull/119638/files |
|
49e3cfb
GH-89727: Fix `os.fwalk()` recursion error on deep trees
barneygale May 27, 2024
| https://github.com/python/cpython/pull/119638/commits/49e3cfba61b524bfeb7745a99a660755bb53445c |
|
409f5ea
Defer open()ing
barneygale May 28, 2024
| https://github.com/python/cpython/pull/119638/commits/409f5ea747ab2074c699e560d4b17309fb5f017d |
|
82606a4
De-duplicate stat()ing
barneygale May 29, 2024
| https://github.com/python/cpython/pull/119638/commits/82606a4fad7d0d0432ea47e45bf5d1aa6b9f8c5c |
|
c9d0134
Defer `DirEntry.stat()`
barneygale May 29, 2024
| https://github.com/python/cpython/pull/119638/commits/c9d0134656f6cbe9899b866ec2222a1cab5f3284 |
|
5d908c4
Fix tests, line length.
barneygale May 29, 2024
| https://github.com/python/cpython/pull/119638/commits/5d908c4b611813da4bc01b64f9cc463a76006ba8 |
|
df60bc7
Simplify handling of root dir slightly.
barneygale May 30, 2024
| https://github.com/python/cpython/pull/119638/commits/df60bc7ed0f21179359bf33d9898e8357aac7afb |
|
e600988
Simplify some naming, tuple unpacking.
barneygale May 30, 2024
| https://github.com/python/cpython/pull/119638/commits/e600988926d04ce39a65708799efc24fea2420a2 |
|
46a557f
Merge similar walk actions.
barneygale May 30, 2024
| https://github.com/python/cpython/pull/119638/commits/46a557f2f417b0bc57c58af1b741e87d2f7f11ed |
|
1434604
Merge branch 'main' into gh-89727-os-fwalk
barneygale May 30, 2024
| https://github.com/python/cpython/pull/119638/commits/143460458d5f4f61c579fc2656ed4dd2a8968e44 |
|
Clear filters
| https://github.com/python/cpython/pull/119638/files |
| Please reload this page | https://github.com/python/cpython/pull/119638/files |
| Please reload this page | https://github.com/python/cpython/pull/119638/files |
|
os.py
| https://github.com/python/cpython/pull/119638/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431 |
|
test_os.py
| https://github.com/python/cpython/pull/119638/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc |
|
2024-05-28-00-56-59.gh-issue-89727._bxoL3.rst
| https://github.com/python/cpython/pull/119638/files#diff-1f9a0b45500f5e6c288dcdbf7ad38ba35762f26a6328c2e203fca2fe19b6ccf4 |
| Lib/os.py | https://github.com/python/cpython/pull/119638/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431 |
|
View file
| https://github.com/barneygale/cpython/blob/143460458d5f4f61c579fc2656ed4dd2a8968e44/Lib/os.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/119638/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/119638/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431 |
|
| https://github.com/python/cpython/pull/119638/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431 |
| Please reload this page | https://github.com/python/cpython/pull/119638/files |
|
| https://github.com/python/cpython/pull/119638/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431 |
| Lib/test/test_os.py | https://github.com/python/cpython/pull/119638/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc |
|
View file
| https://github.com/barneygale/cpython/blob/143460458d5f4f61c579fc2656ed4dd2a8968e44/Lib/test/test_os.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/119638/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/119638/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc |
|
| https://github.com/python/cpython/pull/119638/files#diff-5007f0845419916c8b0294481e2ee212ca36661d9843f86338ec42254645edfc |
| Misc/NEWS.d/next/Library/2024-05-28-00-56-59.gh-issue-89727._bxoL3.rst | https://github.com/python/cpython/pull/119638/files#diff-1f9a0b45500f5e6c288dcdbf7ad38ba35762f26a6328c2e203fca2fe19b6ccf4 |
|
View file
| https://github.com/barneygale/cpython/blob/143460458d5f4f61c579fc2656ed4dd2a8968e44/Misc/NEWS.d/next/Library/2024-05-28-00-56-59.gh-issue-89727._bxoL3.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/119638/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |