René's URL Explorer Experiment


Title: GH-89727: Partially fix `shutil.rmtree()` recursion error on deep trees by barneygale · Pull Request #119634 · python/cpython · GitHub

Open Graph Title: GH-89727: Partially fix `shutil.rmtree()` recursion error on deep trees by barneygale · Pull Request #119634 · python/cpython

X Title: GH-89727: Partially fix `shutil.rmtree()` recursion error on deep trees by barneygale · Pull Request #119634 · python/cpython

Description: Make shutil._rmtree_unsafe() call os.walk(), which is implemented without recursion. shutil._rmtree_safe_fd() is not affected and can still raise a recursion error. Issue: gh-89727

Open Graph Description: Make shutil._rmtree_unsafe() call os.walk(), which is implemented without recursion. shutil._rmtree_safe_fd() is not affected and can still raise a recursion error. Issue: gh-89727

X Description: Make shutil._rmtree_unsafe() call os.walk(), which is implemented without recursion. shutil._rmtree_safe_fd() is not affected and can still raise a recursion error. Issue: gh-89727

Opengraph URL: https://github.com/python/cpython/pull/119634

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:63b8a6bd-d487-615e-eb9c-e60776df60e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBEE8:FB44E:2FA1C:41933:69693E73
html-safe-nonce1627014928ad6ae7947fd3160a508fcb18165da11153151c0fb6aa1b4773998a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUU4OkZCNDRFOjJGQTFDOjQxOTMzOjY5NjkzRTczIiwidmlzaXRvcl9pZCI6IjYxOTg2OTM3NjE5NjU5NjQ5MTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac16211dfb99649bb07ecb5e6d11936092e32d31e7d5bab046fe834935542a2f82
hovercard-subject-tagpull_request:1890715473
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/119634/files
twitter:imagehttps://avatars.githubusercontent.com/u/960340?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/960340?s=400&v=4
og:image:altMake shutil._rmtree_unsafe() call os.walk(), which is implemented without recursion. shutil._rmtree_safe_fd() is not affected and can still raise a recursion error. Issue: gh-89727
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released69ac0477df0f87da03b8b06cebd187012d7a930
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/119634/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F119634%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F119634%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/119634/files
Reloadhttps://github.com/python/cpython/pull/119634/files
Reloadhttps://github.com/python/cpython/pull/119634/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/119634/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/119634/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
barneygalehttps://github.com/barneygale
python:mainhttps://github.com/python/cpython/tree/main
barneygale:gh-89727-use-os-walkhttps://github.com/barneygale/cpython/tree/gh-89727-use-os-walk
Conversation 13 https://github.com/python/cpython/pull/119634
Commits 7 https://github.com/python/cpython/pull/119634/commits
Checks 0 https://github.com/python/cpython/pull/119634/checks
Files changed 4 https://github.com/python/cpython/pull/119634/files
GH-89727: Partially fix shutil.rmtree() recursion error on deep trees https://github.com/python/cpython/pull/119634/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/119634/files
55adfeb GH-89727: Partially fix `shutil.rmtree()` recursion error on deep trees barneygale May 27, 2024 https://github.com/python/cpython/pull/119634/commits/55adfebdf10fd0ccaa87515bad3ab5f940c1fb87
e5c8ceb Simplify diff barneygale May 27, 2024 https://github.com/python/cpython/pull/119634/commits/e5c8cebf4aaa8dd1b318c33cc8ba49d2f6bbf4cf
96293a5 Update Lib/shutil.py barneygale May 29, 2024 https://github.com/python/cpython/pull/119634/commits/96293a557e6256ac030dc81011060644805cc74d
3b1b15e Undo premature optimisation barneygale May 29, 2024 https://github.com/python/cpython/pull/119634/commits/3b1b15e3024b2f7460bdeb3b9737cd536fcf3b3a
4fe3075 Add NEWS barneygale May 29, 2024 https://github.com/python/cpython/pull/119634/commits/4fe3075a2e654d26e999548f5cfe4ba6043c6e45
857bcfa Merge branch 'main' into gh-89727-use-os-walk barneygale May 29, 2024 https://github.com/python/cpython/pull/119634/commits/857bcfa1a9e9ddf3aadc108af13d75fbdad20cc7
27ee6f0 Update Misc/NEWS.d/next/Library/2024-05-29-20-42-17.gh-issue-89727.5l… barneygale May 29, 2024 https://github.com/python/cpython/pull/119634/commits/27ee6f0b9e1d519074dd0a3c192f8b2decb67713
Clear filters https://github.com/python/cpython/pull/119634/files
Please reload this pagehttps://github.com/python/cpython/pull/119634/files
Please reload this pagehttps://github.com/python/cpython/pull/119634/files
os.py https://github.com/python/cpython/pull/119634/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
shutil.py https://github.com/python/cpython/pull/119634/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
test_shutil.py https://github.com/python/cpython/pull/119634/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
2024-05-29-20-42-17.gh-issue-89727.5lPTTW.rst https://github.com/python/cpython/pull/119634/files#diff-088baedb15c95c7a42eaa6ed8d87ae9823c43e5e9297a3889caf57b952f6341b
Lib/os.pyhttps://github.com/python/cpython/pull/119634/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
View file https://github.com/barneygale/cpython/blob/27ee6f0b9e1d519074dd0a3c192f8b2decb67713/Lib/os.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/119634/{{ revealButtonHref }}
https://github.com/python/cpython/pull/119634/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
https://github.com/python/cpython/pull/119634/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
https://github.com/python/cpython/pull/119634/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
https://github.com/python/cpython/pull/119634/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L560
Lib/shutil.pyhttps://github.com/python/cpython/pull/119634/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
View file https://github.com/barneygale/cpython/blob/27ee6f0b9e1d519074dd0a3c192f8b2decb67713/Lib/shutil.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/119634/{{ revealButtonHref }}
https://github.com/python/cpython/pull/119634/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
https://github.com/python/cpython/pull/119634/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L561
Lib/test/test_shutil.pyhttps://github.com/python/cpython/pull/119634/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
View file https://github.com/barneygale/cpython/blob/27ee6f0b9e1d519074dd0a3c192f8b2decb67713/Lib/test/test_shutil.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/119634/{{ revealButtonHref }}
https://github.com/python/cpython/pull/119634/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/119634/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
Misc/NEWS.d/next/Library/2024-05-29-20-42-17.gh-issue-89727.5lPTTW.rsthttps://github.com/python/cpython/pull/119634/files#diff-088baedb15c95c7a42eaa6ed8d87ae9823c43e5e9297a3889caf57b952f6341b
View file https://github.com/barneygale/cpython/blob/27ee6f0b9e1d519074dd0a3c192f8b2decb67713/Misc/NEWS.d/next/Library/2024-05-29-20-42-17.gh-issue-89727.5lPTTW.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/119634/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.