René's URL Explorer Experiment


Title: GH-119169: Implement `pathlib.Path.walk()` using `os.walk()` by barneygale · Pull Request #119573 · python/cpython · GitHub

Open Graph Title: GH-119169: Implement `pathlib.Path.walk()` using `os.walk()` by barneygale · Pull Request #119573 · python/cpython

X Title: GH-119169: Implement `pathlib.Path.walk()` using `os.walk()` by barneygale · Pull Request #119573 · python/cpython

Description: For silly reasons, pathlib's generic implementation of walk() currently resides in glob._Globber. This commit moves it into pathlib._abc.PathBase.walk() where it really belongs, and makes pathlib.Path.walk() call though to os.walk() rather than using the generic impl. Symlink handling is a little different between the two walk() implementations when followlinks=False. In pathlib it means never following symlinks, not even for distinguishing between files and directories. In os it means never walking into symlinks, including any symlinks created by the user between iterations. We smooth over these differences with a private sentinel - os._walk_symlinks_as_files - that enables the pathlib behaviour. No change of behaviour. Issue: gh-119169

Open Graph Description: For silly reasons, pathlib's generic implementation of walk() currently resides in glob._Globber. This commit moves it into pathlib._abc.PathBase.walk() where it really belongs, and makes pathl...

X Description: For silly reasons, pathlib's generic implementation of walk() currently resides in glob._Globber. This commit moves it into pathlib._abc.PathBase.walk() where it really belongs, and makes p...

Opengraph URL: https://github.com/python/cpython/pull/119573

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cc72a8a0-9a5e-4347-b790-eeff4f518ccc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB236:AA1C4:97BB27:C61582:69699340
html-safe-nonce8710242b6d4f86951cfb0b2e79f35b41bb609490640896e303b19e9d10b41d93
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjM2OkFBMUM0Ojk3QkIyNzpDNjE1ODI6Njk2OTkzNDAiLCJ2aXNpdG9yX2lkIjoiMTgzODU1NjQzNjEwMjc0Njk0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5b3187ce50f12c18d1e9fa4dfd0c18ec354c170284f54f03a89672f642d1876a
hovercard-subject-tagpull_request:1888862324
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/119573/files
twitter:imagehttps://avatars.githubusercontent.com/u/960340?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/960340?s=400&v=4
og:image:altFor silly reasons, pathlib's generic implementation of walk() currently resides in glob._Globber. This commit moves it into pathlib._abc.PathBase.walk() where it really belongs, and makes pathl...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3542e147982176a7ebaa23dfb559c8af16f721c03ec560c68c56b64a0f35e751
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaf80af7cc9e3de9c336f18b208a600950a3c187c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/119573/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F119573%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F119573%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/119573/files
Reloadhttps://github.com/python/cpython/pull/119573/files
Reloadhttps://github.com/python/cpython/pull/119573/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/119573/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/119573/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
barneygalehttps://github.com/barneygale
python:mainhttps://github.com/python/cpython/tree/main
barneygale:os-walk-unifyhttps://github.com/barneygale/cpython/tree/os-walk-unify
Conversation 3 https://github.com/python/cpython/pull/119573
Commits 2 https://github.com/python/cpython/pull/119573/commits
Checks 0 https://github.com/python/cpython/pull/119573/checks
Files changed https://github.com/python/cpython/pull/119573/files
Please reload this pagehttps://github.com/python/cpython/pull/119573/files
GH-119169: Implement pathlib.Path.walk() using os.walk() https://github.com/python/cpython/pull/119573/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/119573/files
1f7d5ad GH-119169: Implement `pathlib.Path.walk()` using `os.walk()` barneygale May 26, 2024 https://github.com/python/cpython/pull/119573/commits/1f7d5adcf5b2124b3a896488c0dec38a8224fe40
33ee9f7 Merge branch 'main' into os-walk-unify barneygale May 29, 2024 https://github.com/python/cpython/pull/119573/commits/33ee9f7b644fc45fac255cb18810d01f63dd272c
Clear filters https://github.com/python/cpython/pull/119573/files
Please reload this pagehttps://github.com/python/cpython/pull/119573/files
Please reload this pagehttps://github.com/python/cpython/pull/119573/files
glob.py https://github.com/python/cpython/pull/119573/files#diff-aca8a30d5728898dc8623ab33adb548567e7a0092079954afa1b594b7f83c828
_abc.py https://github.com/python/cpython/pull/119573/files#diff-80172c23421c1dd13d79623c67c24cee61b300f18a55ab5d2d33d69d490abe9a
_local.py https://github.com/python/cpython/pull/119573/files#diff-605d7dbf8e86b830b276d61a776a8d7da625b34316c59e154441624beabbe70a
Lib/glob.pyhttps://github.com/python/cpython/pull/119573/files#diff-aca8a30d5728898dc8623ab33adb548567e7a0092079954afa1b594b7f83c828
View file https://github.com/barneygale/cpython/blob/33ee9f7b644fc45fac255cb18810d01f63dd272c/Lib/glob.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/119573/{{ revealButtonHref }}
https://github.com/python/cpython/pull/119573/files#diff-aca8a30d5728898dc8623ab33adb548567e7a0092079954afa1b594b7f83c828
https://github.com/python/cpython/pull/119573/files#diff-aca8a30d5728898dc8623ab33adb548567e7a0092079954afa1b594b7f83c828
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L526
Lib/pathlib/_abc.pyhttps://github.com/python/cpython/pull/119573/files#diff-80172c23421c1dd13d79623c67c24cee61b300f18a55ab5d2d33d69d490abe9a
View file https://github.com/barneygale/cpython/blob/33ee9f7b644fc45fac255cb18810d01f63dd272c/Lib/pathlib/_abc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/119573/{{ revealButtonHref }}
https://github.com/python/cpython/pull/119573/files#diff-80172c23421c1dd13d79623c67c24cee61b300f18a55ab5d2d33d69d490abe9a
https://github.com/python/cpython/pull/119573/files#diff-80172c23421c1dd13d79623c67c24cee61b300f18a55ab5d2d33d69d490abe9a
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L526
Lib/pathlib/_local.pyhttps://github.com/python/cpython/pull/119573/files#diff-605d7dbf8e86b830b276d61a776a8d7da625b34316c59e154441624beabbe70a
View file https://github.com/barneygale/cpython/blob/33ee9f7b644fc45fac255cb18810d01f63dd272c/Lib/pathlib/_local.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/119573/{{ revealButtonHref }}
https://github.com/python/cpython/pull/119573/files#diff-605d7dbf8e86b830b276d61a776a8d7da625b34316c59e154441624beabbe70a
https://github.com/python/cpython/pull/119573/files#diff-605d7dbf8e86b830b276d61a776a8d7da625b34316c59e154441624beabbe70a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.