René's URL Explorer Experiment


Title: GH-119169: Skip reversing sibling directories in `os.[f]walk(topdown=False)` by barneygale · Pull Request #119473 · python/cpython · GitHub

Open Graph Title: GH-119169: Skip reversing sibling directories in `os.[f]walk(topdown=False)` by barneygale · Pull Request #119473 · python/cpython

X Title: GH-119169: Skip reversing sibling directories in `os.[f]walk(topdown=False)` by barneygale · Pull Request #119473 · python/cpython

Description: In os.walk(topdown=False), don't bother reversing walk_dirs. This means that sibling directories are visited in a different order, but 1) that order is arbitrary and comes from os.scandir(), and 2)...

Open Graph Description: In os.walk(topdown=False), don't bother reversing walk_dirs. This means that sibling directories are visited in a different order, but 1) that order is arbitrary and comes from os.scandir(), an...

X Description: In os.walk(topdown=False), don't bother reversing walk_dirs. This means that sibling directories are visited in a different order, but 1) that order is arbitrary and comes from os.scandir()...

Opengraph URL: https://github.com/python/cpython/pull/119473

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:82886609-6932-b1b4-d129-37b2c46bc05b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA5B4:27F114:B4AF62:F5F156:6969361C
html-safe-nonceb9207ef6c3738af831840ac842739a998d6a145847c63e1e8ad0fc85ebfb4136
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUI0OjI3RjExNDpCNEFGNjI6RjVGMTU2OjY5NjkzNjFDIiwidmlzaXRvcl9pZCI6IjQxNTAwMzUzNDg2NDY4Njg1MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0ef78e8c6c91fa5837654f96665cc59401f4a7bfc742dedd6e12a83e591df483
hovercard-subject-tagpull_request:1885285162
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/119473/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7a24919bca4c6c14b99f68afcce877e4638d1e6ed00243be1dae16a3a42dfd60/python/cpython/pull/119473
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7a24919bca4c6c14b99f68afcce877e4638d1e6ed00243be1dae16a3a42dfd60/python/cpython/pull/119473
og:image:altIn os.walk(topdown=False), don't bother reversing walk_dirs. This means that sibling directories are visited in a different order, but 1) that order is arbitrary and comes from os.scandir(), an...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebarneygale
hostnamegithub.com
expected-hostnamegithub.com
None54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released69ac0477df0f87da03b8b06cebd187012d7a930
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/119473#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F119473
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F119473
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/119473
Reloadhttps://github.com/python/cpython/pull/119473
Reloadhttps://github.com/python/cpython/pull/119473
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/119473
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/119473
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/119473#issue-comment-box
barneygalehttps://github.com/barneygale
python:mainhttps://github.com/python/cpython/tree/main
barneygale:os-walk-bottom-reversalhttps://github.com/barneygale/cpython/tree/os-walk-bottom-reversal
GH-119169: Skip reversing sibling directories in os.[f]walk(topdown=False) https://github.com/python/cpython/pull/119473#top
barneygalehttps://github.com/barneygale
python:mainhttps://github.com/python/cpython/tree/main
barneygale:os-walk-bottom-reversalhttps://github.com/barneygale/cpython/tree/os-walk-bottom-reversal
Conversation 7 https://github.com/python/cpython/pull/119473
Commits 4 https://github.com/python/cpython/pull/119473/commits
Checks 0 https://github.com/python/cpython/pull/119473/checks
Files changed https://github.com/python/cpython/pull/119473/files
Please reload this pagehttps://github.com/python/cpython/pull/119473
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/barneygale
barneygalehttps://github.com/barneygale
May 23, 2024https://github.com/python/cpython/pull/119473#issue-2313669034
Please reload this pagehttps://github.com/python/cpython/pull/119473
Improve performance of os.walk() #119169https://github.com/python/cpython/issues/119169
Please reload this pagehttps://github.com/python/cpython/pull/119473
https://github.com/barneygale
pythonGH-119169https://github.com/python/cpython/issues/119169
: Skip reversing sibling directories in `os.walk(topdo…https://github.com/python/cpython/pull/119473/commits/469a9cfbdf28e8091ceadcfe75f56097493456b8
469a9cfhttps://github.com/python/cpython/pull/119473/commits/469a9cfbdf28e8091ceadcfe75f56097493456b8
https://github.com/barneygale
barneygalehttps://github.com/barneygale
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 23, 2024https://github.com/python/cpython/pull/119473#event-12914266091
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 23, 2024https://github.com/python/cpython/pull/119473#event-12914266759
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 23, 2024 https://github.com/python/cpython/pull/119473#ref-issue-2304394456
Improve performance of os.walk() #119169 https://github.com/python/cpython/issues/119169
GH-119169: Speed up os.walk(topdown=False) #119186 https://github.com/python/cpython/pull/119186
GH-89727: Fix os.fwalk() recursion error on deep trees #119638 https://github.com/python/cpython/pull/119638
barneygalehttps://github.com/barneygale
May 30, 2024 04:38https://github.com/python/cpython/pull/119473#commits-pushed-f81864c
https://github.com/barneygale
Merge branch 'main' into os-walk-bottom-reversalhttps://github.com/python/cpython/pull/119473/commits/f81864c55d5877183831b3af40076a8a108329da
f81864chttps://github.com/python/cpython/pull/119473/commits/f81864c55d5877183831b3af40076a8a108329da
https://github.com/barneygale
Also undo reversals in os.fwalk()https://github.com/python/cpython/pull/119473/commits/cfc60ceb3bddd04bdd90485c11c25765f18395ce
cfc60cehttps://github.com/python/cpython/pull/119473/commits/cfc60ceb3bddd04bdd90485c11c25765f18395ce
https://github.com/barneygale
barneygalehttps://github.com/barneygale
May 30, 2024https://github.com/python/cpython/pull/119473#event-12979752578
https://github.com/barneygale
Merge branch 'main' into os-walk-bottom-reversalhttps://github.com/python/cpython/pull/119473/commits/ca9c16a52b4747e33dc9beb42ecf190e8b561afb
ca9c16ahttps://github.com/python/cpython/pull/119473/commits/ca9c16a52b4747e33dc9beb42ecf190e8b561afb
https://github.com/barneygale
barneygalehttps://github.com/barneygale
serhiy-storchakahttps://github.com/serhiy-storchaka
July 6, 2024 13:15https://github.com/python/cpython/pull/119473#event-13411523631
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Jul 6, 2024https://github.com/python/cpython/pull/119473#issuecomment-2211767365
@serhiy-storchakahttps://github.com/serhiy-storchaka
GH-119186https://github.com/python/cpython/pull/119186
Please reload this pagehttps://github.com/python/cpython/pull/119473
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Jul 6, 2024 https://github.com/python/cpython/pull/119473#ref-pullrequest-2393583852
GH-119169: Speed up os.fwalk(topdown=False) #121433 https://github.com/python/cpython/pull/121433
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 8, 2024https://github.com/python/cpython/pull/119473#issuecomment-2213135786
Please reload this pagehttps://github.com/python/cpython/pull/119473
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Jul 8, 2024https://github.com/python/cpython/pull/119473#issuecomment-2213946245
Please reload this pagehttps://github.com/python/cpython/pull/119473
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Jul 8, 2024https://github.com/python/cpython/pull/119473#issuecomment-2214697575
Please reload this pagehttps://github.com/python/cpython/pull/119473
Please reload this pagehttps://github.com/python/cpython/pull/119473
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 8, 2024https://github.com/python/cpython/pull/119473#issuecomment-2214808841
Please reload this pagehttps://github.com/python/cpython/pull/119473
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Jul 8, 2024https://github.com/python/cpython/pull/119473#issuecomment-2214836056
GH-119186https://github.com/python/cpython/pull/119186
GH-121433https://github.com/python/cpython/pull/121433
Please reload this pagehttps://github.com/python/cpython/pull/119473
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Jul 8, 2024https://github.com/python/cpython/pull/119473#issuecomment-2214937204
Please reload this pagehttps://github.com/python/cpython/pull/119473
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Jul 8, 2024https://github.com/python/cpython/pull/119473#event-13428286684
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F119473
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/119473
https://github.com/barneygale
https://github.com/serhiy-storchaka
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.