| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bb3d8db1-623d-a007-ad6e-31f880012d52 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EA3A:1860A8:1345E9E:1AB0371:696A9119 |
| html-safe-nonce | 54d83cc08aa98a435e0f2fae0e68a04ae0c1f6a1c84784abceb04b256240dcba |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTNBOjE4NjBBODoxMzQ1RTlFOjFBQjAzNzE6Njk2QTkxMTkiLCJ2aXNpdG9yX2lkIjoiMzYzNDM4NTU0NzkzMzk0NjEzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6126631b7b5791d074e811366f91983208162164ec3cc8c984633cb33ae64f3d |
| hovercard-subject-tag | pull_request:1877265430 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/119186/files |
| twitter:image | https://avatars.githubusercontent.com/u/960340?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/960340?s=400&v=4 |
| og:image:alt | Add entries to the stack while iterating over os.scandir() results, rather than afterwards.
Issue: gh-119169 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/119186/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F119186%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F119186%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/119186/files |
| Reload | https://github.com/python/cpython/pull/119186/files |
| Reload | https://github.com/python/cpython/pull/119186/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/119186/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/119186/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| barneygale | https://github.com/barneygale |
| python:main | https://github.com/python/cpython/tree/main |
| barneygale:os-walk-speedup | https://github.com/barneygale/cpython/tree/os-walk-speedup |
|
Conversation
3
| https://github.com/python/cpython/pull/119186 |
|
Commits
12
| https://github.com/python/cpython/pull/119186/commits |
|
Checks
0
| https://github.com/python/cpython/pull/119186/checks |
|
Files changed
| https://github.com/python/cpython/pull/119186/files |
| Please reload this page | https://github.com/python/cpython/pull/119186/files |
|
GH-119169: Speed up os.walk(topdown=False)
| https://github.com/python/cpython/pull/119186/files#top |
|
Show all changes
12 commits
| https://github.com/python/cpython/pull/119186/files |
|
74a495c
GH-119169: Speed up `os.walk()`
barneygale May 19, 2024
| https://github.com/python/cpython/pull/119186/commits/74a495c6b1dee7b1c71e0b82ca1ab8362aceda78 |
|
eb4b6ff
Merge branch 'main' into os-walk-speedup
barneygale May 23, 2024
| https://github.com/python/cpython/pull/119186/commits/eb4b6ff605cbec93497b1aa8fd6768fd2cc7eaf3 |
|
46a3ba5
Simplify bottom-up implementation.
barneygale May 23, 2024
| https://github.com/python/cpython/pull/119186/commits/46a3ba54ac805786649f8ab0e5dd0ace2051f58b |
|
2d957a8
Merge branch 'main' into os-walk-speedup
barneygale May 30, 2024
| https://github.com/python/cpython/pull/119186/commits/2d957a8474ff0979fe8056275d3f208c46732103 |
|
a638202
Apply the same changes to fwalk()
barneygale May 30, 2024
| https://github.com/python/cpython/pull/119186/commits/a6382026d696e3be9f6d057e347949bd1204e3b1 |
|
91b5a78
Simplify code slightly
barneygale May 30, 2024
| https://github.com/python/cpython/pull/119186/commits/91b5a78584c1701af18938870c7fb4b33cd5ba4c |
|
b32c1c0
Simplify exception handling in fwalk()
barneygale Jul 6, 2024
| https://github.com/python/cpython/pull/119186/commits/b32c1c0641f9cec2e6788b0ae49ba61d9b9b3d75 |
|
8c7cf04
Merge branch 'main' into os-walk-speedup
barneygale Jul 6, 2024
| https://github.com/python/cpython/pull/119186/commits/8c7cf04fd2bc9a7b80fc8da2a2e2f48757383d74 |
|
efd31e2
Undo trailing slash optimisation (moved to another PR)
barneygale Jul 6, 2024
| https://github.com/python/cpython/pull/119186/commits/efd31e2ef5ce2c8d5132d165bef861b8dca6ae90 |
|
5b89c57
Undo fwalk() changes.
barneygale Jul 6, 2024
| https://github.com/python/cpython/pull/119186/commits/5b89c5759f898f616fd2c51f3b38294c8c079369 |
|
525618c
Fix news entry.
barneygale Jul 6, 2024
| https://github.com/python/cpython/pull/119186/commits/525618ce65a525eae29c64d414644f45f994647f |
|
d3af655
Merge branch 'main' into os-walk-speedup
barneygale Jul 8, 2024
| https://github.com/python/cpython/pull/119186/commits/d3af6550b7b128c851dc530f7bc7160cdedec5f5 |
|
Clear filters
| https://github.com/python/cpython/pull/119186/files |
| Please reload this page | https://github.com/python/cpython/pull/119186/files |
| Please reload this page | https://github.com/python/cpython/pull/119186/files |
|
os.py
| https://github.com/python/cpython/pull/119186/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431 |
|
2024-05-19-20-13-09.gh-issue-119169.CuE7q0.rst
| https://github.com/python/cpython/pull/119186/files#diff-9476cfb53040e5cf72374148935d44fb418d6d17d117e4b0f520253c068c0e83 |
| Lib/os.py | https://github.com/python/cpython/pull/119186/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431 |
|
View file
| https://github.com/barneygale/cpython/blob/d3af6550b7b128c851dc530f7bc7160cdedec5f5/Lib/os.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/119186/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/119186/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431 |
|
| https://github.com/python/cpython/pull/119186/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431 |
|
| https://github.com/python/cpython/pull/119186/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431 |
|
| https://github.com/python/cpython/pull/119186/files#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431 |
| Misc/NEWS.d/next/Library/2024-05-19-20-13-09.gh-issue-119169.CuE7q0.rst | https://github.com/python/cpython/pull/119186/files#diff-9476cfb53040e5cf72374148935d44fb418d6d17d117e4b0f520253c068c0e83 |
|
View file
| https://github.com/barneygale/cpython/blob/d3af6550b7b128c851dc530f7bc7160cdedec5f5/Misc/NEWS.d/next/Library/2024-05-19-20-13-09.gh-issue-119169.CuE7q0.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/119186/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |