René's URL Explorer Experiment


Title: gh-118824: Remove deprecated `master_open` and `slave_open` from `pty` by sobolevn · Pull Request #118826 · python/cpython · GitHub

Open Graph Title: gh-118824: Remove deprecated `master_open` and `slave_open` from `pty` by sobolevn · Pull Request #118826 · python/cpython

X Title: gh-118824: Remove deprecated `master_open` and `slave_open` from `pty` by sobolevn · Pull Request #118826 · python/cpython

Description: CC @gpshead who reviewed #92365 Issue: Remove deprecated master_open and slave_open from pty #118824 📚 Documentation preview 📚: https://cpython-previews--118826.org.readthedocs.build/

Open Graph Description: CC @gpshead who reviewed #92365 Issue: Remove deprecated master_open and slave_open from pty #118824 📚 Documentation preview 📚: https://cpython-previews--118826.org.readthedocs.build/

X Description: CC @gpshead who reviewed #92365 Issue: Remove deprecated master_open and slave_open from pty #118824 📚 Documentation preview 📚: https://cpython-previews--118826.org.readthedocs.build/

Opengraph URL: https://github.com/python/cpython/pull/118826

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c3790877-1af9-60bd-a582-3f71751597d7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8BDA:3346BC:72627E:9B3C80:6969DA5F
html-safe-nonce4da7311f20bd2e6f3d257341500b13720544faa8c20a92ed1e214a557d29825b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkRBOjMzNDZCQzo3MjYyN0U6OUIzQzgwOjY5NjlEQTVGIiwidmlzaXRvcl9pZCI6Ijc4OTQ4MDU2NjQ2MDMxNjczMjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac075079e989f524cc8fc534fed79dfe755edae802eb6c5a82fdc3b39acb8f88e1
hovercard-subject-tagpull_request:1861693121
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/118826/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f6172065c0a406306026e458586a8351f23f2c9c6afb574a10307ec20a2de70c/python/cpython/pull/118826
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f6172065c0a406306026e458586a8351f23f2c9c6afb574a10307ec20a2de70c/python/cpython/pull/118826
og:image:altCC @gpshead who reviewed #92365 Issue: Remove deprecated master_open and slave_open from pty #118824 📚 Documentation preview 📚: https://cpython-previews--118826.org.readthedocs.build/
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/118826#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118826
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118826
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/118826
Reloadhttps://github.com/python/cpython/pull/118826
Reloadhttps://github.com/python/cpython/pull/118826
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/118826
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/118826
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/118826#issue-comment-box
sobolevnhttps://github.com/sobolevn
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-118824https://github.com/sobolevn/cpython/tree/issue-118824
gh-118824: Remove deprecated master_open and slave_open from pty https://github.com/python/cpython/pull/118826#top
sobolevnhttps://github.com/sobolevn
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-118824https://github.com/sobolevn/cpython/tree/issue-118824
Conversation 8 https://github.com/python/cpython/pull/118826
Commits 5 https://github.com/python/cpython/pull/118826/commits
Checks 0 https://github.com/python/cpython/pull/118826/checks
Files changed https://github.com/python/cpython/pull/118826/files
Please reload this pagehttps://github.com/python/cpython/pull/118826
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
May 9, 2024https://github.com/python/cpython/pull/118826#issue-2287217459
Please reload this pagehttps://github.com/python/cpython/pull/118826
@gpsheadhttps://github.com/gpshead
#92365https://github.com/python/cpython/pull/92365
Remove deprecated master_open and slave_open from pty #118824https://github.com/python/cpython/issues/118824
https://cpython-previews--118826.org.readthedocs.build/https://cpython-previews--118826.org.readthedocs.build/
Please reload this pagehttps://github.com/python/cpython/pull/118826
https://github.com/sobolevn
pythongh-118824https://github.com/python/cpython/issues/118824
: Remove deprecatedhttps://github.com/python/cpython/pull/118826/commits/37b23888715f2a48e63465677fc0fa3f495bb101
master_openhttps://github.com/python/cpython/pull/118826/commits/37b23888715f2a48e63465677fc0fa3f495bb101
andhttps://github.com/python/cpython/pull/118826/commits/37b23888715f2a48e63465677fc0fa3f495bb101
slave_openhttps://github.com/python/cpython/pull/118826/commits/37b23888715f2a48e63465677fc0fa3f495bb101
fro…https://github.com/python/cpython/pull/118826/commits/37b23888715f2a48e63465677fc0fa3f495bb101
37b2388https://github.com/python/cpython/pull/118826/commits/37b23888715f2a48e63465677fc0fa3f495bb101
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
gpsheadhttps://github.com/gpshead
May 9, 2024 08:52https://github.com/python/cpython/pull/118826#event-12754333905
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 9, 2024https://github.com/python/cpython/pull/118826#event-12754334784
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
May 9, 2024 https://github.com/python/cpython/pull/118826#ref-issue-2287212036
Remove deprecated master_open and slave_open from pty #118824 https://github.com/python/cpython/issues/118824
https://github.com/ronaldoussoren
ronaldoussorenhttps://github.com/ronaldoussoren
May 9, 2024 https://github.com/python/cpython/pull/118826#pullrequestreview-2047578232
View reviewed changes https://github.com/python/cpython/pull/118826/files
Lib/pty.pyhttps://github.com/python/cpython/pull/118826/files#diff-6951c8bf11da0d5912302a24b778e2c968fae9212bfeb2e73de06ec257b2d1da
Please reload this pagehttps://github.com/python/cpython/pull/118826
https://github.com/hugovk
hugovkhttps://github.com/hugovk
May 9, 2024 https://github.com/python/cpython/pull/118826#pullrequestreview-2047600799
View reviewed changes https://github.com/python/cpython/pull/118826/files
Doc/whatsnew/3.14.rsthttps://github.com/python/cpython/pull/118826/files#diff-24e6cbe61d91e61059c44a7cf5f712499a11eb47a82d5f1a8db16ec7f9023c31
Please reload this pagehttps://github.com/python/cpython/pull/118826
https://github.com/sobolevn
Address reviewhttps://github.com/python/cpython/pull/118826/commits/95fc77b4a6025c9f3c5c6783acdd308f74fd7c0c
95fc77bhttps://github.com/python/cpython/pull/118826/commits/95fc77b4a6025c9f3c5c6783acdd308f74fd7c0c
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
force-pushedhttps://github.com/python/cpython/compare/e194f94ff65cbaedaa633f58c946cd03d2add340..95fc77b4a6025c9f3c5c6783acdd308f74fd7c0c
e194f94https://github.com/python/cpython/commit/e194f94ff65cbaedaa633f58c946cd03d2add340
95fc77bhttps://github.com/python/cpython/commit/95fc77b4a6025c9f3c5c6783acdd308f74fd7c0c
Compare https://github.com/python/cpython/compare/e194f94ff65cbaedaa633f58c946cd03d2add340..95fc77b4a6025c9f3c5c6783acdd308f74fd7c0c
May 9, 2024 10:19https://github.com/python/cpython/pull/118826#event-12755325515
https://github.com/hugovk
Merge branch 'main' into issue-118824https://github.com/python/cpython/pull/118826/commits/1a0dcd0e3f8a625f4ce75c8730b869277297ad79
1a0dcd0https://github.com/python/cpython/pull/118826/commits/1a0dcd0e3f8a625f4ce75c8730b869277297ad79
https://github.com/hugovk
hugovkhttps://github.com/hugovk
May 26, 2024 https://github.com/python/cpython/pull/118826#pullrequestreview-2079544014
View reviewed changes https://github.com/python/cpython/pull/118826/files/1a0dcd0e3f8a625f4ce75c8730b869277297ad79
Doc/whatsnew/3.14.rsthttps://github.com/python/cpython/pull/118826/files/1a0dcd0e3f8a625f4ce75c8730b869277297ad79#diff-24e6cbe61d91e61059c44a7cf5f712499a11eb47a82d5f1a8db16ec7f9023c31
Please reload this pagehttps://github.com/python/cpython/pull/118826
Misc/NEWS.d/next/Library/2024-05-09-11-50-26.gh-issue-118824.-jBJQC.rsthttps://github.com/python/cpython/pull/118826/files/1a0dcd0e3f8a625f4ce75c8730b869277297ad79#diff-5b8cb714fe630bd7a9da868313db1e6189945a5aa8be21448ffe355a6ae9467b
Please reload this pagehttps://github.com/python/cpython/pull/118826
sobolevnhttps://github.com/sobolevn
May 28, 2024 13:52https://github.com/python/cpython/pull/118826#commits-pushed-c73b325
https://github.com/sobolevn
https://github.com/hugovk
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/118826/commits/c73b3252633c47bd2a3e3960576453df9b2c9d1f
c73b325https://github.com/python/cpython/pull/118826/commits/c73b3252633c47bd2a3e3960576453df9b2c9d1f
https://github.com/sobolevn
Merge branch 'main' into issue-118824https://github.com/python/cpython/pull/118826/commits/70793495c7ac120984b2d315cf7cf739a95c944c
7079349https://github.com/python/cpython/pull/118826/commits/70793495c7ac120984b2d315cf7cf739a95c944c
https://github.com/hugovk
hugovkhttps://github.com/hugovk
May 28, 2024 https://github.com/python/cpython/pull/118826#pullrequestreview-2082728802
View reviewed changes https://github.com/python/cpython/pull/118826/files/70793495c7ac120984b2d315cf7cf739a95c944c
hugovkhttps://github.com/hugovk
https://github.com/python/cpython/pull/118826#pullrequestreview-2082728802
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/118826
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 28, 2024https://github.com/python/cpython/pull/118826#event-12957332481
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
f912e5ahttps://github.com/python/cpython/commit/f912e5a2f6d128b17f85229b722422e4a2478e23
May 28, 2024https://github.com/python/cpython/pull/118826#event-12957925692
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 28, 2024https://github.com/python/cpython/pull/118826#event-12957926560
estyxxhttps://github.com/estyxx
Jul 17, 2024 https://github.com/python/cpython/pull/118826#ref-commit-9fe427c
https://github.com/sobolevn
https://github.com/hugovk
https://github.com/estyxx
pythongh-118824https://github.com/python/cpython/issues/118824
: Remove deprecatedhttps://github.com/estyxx/cpython/commit/9fe427c743981db615fca0491b12102874fe520c
master_openhttps://github.com/estyxx/cpython/commit/9fe427c743981db615fca0491b12102874fe520c
andhttps://github.com/estyxx/cpython/commit/9fe427c743981db615fca0491b12102874fe520c
slave_openhttps://github.com/estyxx/cpython/commit/9fe427c743981db615fca0491b12102874fe520c
fro…https://github.com/estyxx/cpython/commit/9fe427c743981db615fca0491b12102874fe520c
9fe427chttps://github.com/estyxx/cpython/commit/9fe427c743981db615fca0491b12102874fe520c
python#118826https://github.com/python/cpython/pull/118826
https://github.com/ambv
ambvhttps://github.com/ambv
Sep 24, 2024 https://github.com/python/cpython/pull/118826#pullrequestreview-2323716813
View reviewed changes https://github.com/python/cpython/pull/118826/files/70793495c7ac120984b2d315cf7cf739a95c944c
Lib/pty.pyhttps://github.com/python/cpython/pull/118826/files/70793495c7ac120984b2d315cf7cf739a95c944c#diff-6951c8bf11da0d5912302a24b778e2c968fae9212bfeb2e73de06ec257b2d1da
ambvhttps://github.com/ambv
Sep 24, 2024https://github.com/python/cpython/pull/118826#discussion_r1772355423
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/118826
sobolevnhttps://github.com/sobolevn
Sep 24, 2024https://github.com/python/cpython/pull/118826#discussion_r1772482278
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#124406https://github.com/python/cpython/pull/124406
Please reload this pagehttps://github.com/python/cpython/pull/118826
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Sep 24, 2024 https://github.com/python/cpython/pull/118826#ref-issue-2544134233
NameError in openpty after #118826 #124405 https://github.com/python/cpython/issues/124405
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Sep 24, 2024 https://github.com/python/cpython/pull/118826#ref-pullrequest-2544136698
gh-124405: Fix NameError in openpty #124406 https://github.com/python/cpython/pull/124406
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118826
https://github.com/ambv
ambv https://github.com/ambv
https://github.com/python/cpython/pull/118826/files/70793495c7ac120984b2d315cf7cf739a95c944c
https://github.com/ronaldoussoren
ronaldoussoren https://github.com/ronaldoussoren
https://github.com/python/cpython/pull/118826/files/e194f94ff65cbaedaa633f58c946cd03d2add340
https://github.com/hugovk
hugovk https://github.com/hugovk
https://github.com/python/cpython/pull/118826/files/70793495c7ac120984b2d315cf7cf739a95c944c
https://github.com/gpshead
gpshead https://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/118826
https://github.com/sobolevn
https://github.com/ambv
https://github.com/ronaldoussoren
https://github.com/hugovk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.