René's URL Explorer Experiment


Title: [3.5] bpo-35746: Fix segfault in ssl's cert parser (GH-11569) by vstinner · Pull Request #11867 · python/cpython · GitHub

Open Graph Title: [3.5] bpo-35746: Fix segfault in ssl's cert parser (GH-11569) by vstinner · Pull Request #11867 · python/cpython

X Title: [3.5] bpo-35746: Fix segfault in ssl's cert parser (GH-11569) by vstinner · Pull Request #11867 · python/cpython

Description: Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL distribution points with empty DP or URI correctly. A malicious or buggy certificate can result into segfault. Vulnerability (TALOS-2018-0758) reported by Colin Read and Nicolas Edet of Cisco. Signed-off-by: Christian Heimes christian@python.org (cherry picked from commit a37f524) https://bugs.python.org/issue35746

Open Graph Description: Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL distribution points with empty DP or URI correctly. A malicious or buggy certificate can result into segfault. Vulnerabili...

X Description: Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL distribution points with empty DP or URI correctly. A malicious or buggy certificate can result into segfault. Vulnerabili...

Opengraph URL: https://github.com/python/cpython/pull/11867

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d341134e-ed9a-8fd6-9d1e-420949999ab8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85FE:1D19FE:E693E0:1393119:6A521C71
html-safe-nonce03ff9410e89fe588f272687ca3ccbc45f6d2884635e6d8a8f1ef4f03fd4f271a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUZFOjFEMTlGRTpFNjkzRTA6MTM5MzExOTo2QTUyMUM3MSIsInZpc2l0b3JfaWQiOiI2ODEzMzUwNjM2NTc0NTQ3MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3e602c2852789f5e12f46d206493cba8dd56121e7b879acda522d9ff44c64515
hovercard-subject-tagpull_request:253398160
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/11867/files
twitter:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
og:image:altFix a NULL pointer deref in ssl module. The cert parser did not handle CRL distribution points with empty DP or URI correctly. A malicious or buggy certificate can result into segfault. Vulnerabili...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/11867/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11867%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11867%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/11867/files
Reloadhttps://github.com/python/cpython/pull/11867/files
Reloadhttps://github.com/python/cpython/pull/11867/files
Please reload this pagehttps://github.com/python/cpython/pull/11867/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/11867/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
larryhastingshttps://github.com/larryhastings
python:3.5https://github.com/python/cpython/tree/3.5
Conversation 8 https://github.com/python/cpython/pull/11867
Commits 3 https://github.com/python/cpython/pull/11867/commits
Checks 0 https://github.com/python/cpython/pull/11867/checks
Files changed https://github.com/python/cpython/pull/11867/files
Please reload this pagehttps://github.com/python/cpython/pull/11867/files
[3.5] bpo-35746: Fix segfault in ssl's cert parser (GH-11569) https://github.com/python/cpython/pull/11867/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/11867/files
f567e5a bpo-35746: Fix segfault in ssl's cert parser (GH-11569) tiran Jan 15, 2019 https://github.com/python/cpython/pull/11867/commits/f567e5a401ae899ccca1702797d20e0d30d786ed
5daa533 Merge branch '3.5' into ssl_crl_bug35 larryhastings Feb 25, 2019 https://github.com/python/cpython/pull/11867/commits/5daa53300729ca3084bea335f22d6901fa07a548
6f3c9da Merge branch '3.5' into ssl_crl_bug35 larryhastings Feb 25, 2019 https://github.com/python/cpython/pull/11867/commits/6f3c9dafeec954ab874fe8939cbf26af8e8af1a5
Clear filters https://github.com/python/cpython/pull/11867/files
Please reload this pagehttps://github.com/python/cpython/pull/11867/files
Please reload this pagehttps://github.com/python/cpython/pull/11867/files
talos-2019-0758.pem https://github.com/python/cpython/pull/11867/files#diff-d1bdc3b809461a9d47a44b6cc8ec491d52bec65241fb3af65e90ddb382335ceb
test_ssl.py https://github.com/python/cpython/pull/11867/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
2019-01-15-18-16-05.bpo-35746.nMSd0j.rst https://github.com/python/cpython/pull/11867/files#diff-894d628c8e4da1eb315f49685b5dac3370a6c58f953797b13a197b3934523986
_ssl.c https://github.com/python/cpython/pull/11867/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
Lib/test/talos-2019-0758.pemhttps://github.com/python/cpython/pull/11867/files#diff-d1bdc3b809461a9d47a44b6cc8ec491d52bec65241fb3af65e90ddb382335ceb
View file https://github.com/python/cpython/blob/6f3c9dafeec954ab874fe8939cbf26af8e8af1a5/Lib/test/talos-2019-0758.pem
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11867/{{ revealButtonHref }}
Lib/test/test_ssl.pyhttps://github.com/python/cpython/pull/11867/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
View file https://github.com/python/cpython/blob/6f3c9dafeec954ab874fe8939cbf26af8e8af1a5/Lib/test/test_ssl.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11867/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11867/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/11867/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/11867/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/11867/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
Misc/NEWS.d/next/Security/2019-01-15-18-16-05.bpo-35746.nMSd0j.rsthttps://github.com/python/cpython/pull/11867/files#diff-894d628c8e4da1eb315f49685b5dac3370a6c58f953797b13a197b3934523986
View file https://github.com/python/cpython/blob/6f3c9dafeec954ab874fe8939cbf26af8e8af1a5/Misc/NEWS.d/next/Security/2019-01-15-18-16-05.bpo-35746.nMSd0j.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11867/{{ revealButtonHref }}
Modules/_ssl.chttps://github.com/python/cpython/pull/11867/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
View file https://github.com/python/cpython/blob/6f3c9dafeec954ab874fe8939cbf26af8e8af1a5/Modules/_ssl.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11867/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11867/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
https://github.com/python/cpython/pull/11867/files#diff-89879be484d86da4e77c90d5408b2e10190ee27cc86337cd0f8efc3520d60621
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.