René's URL Explorer Experiment


Title: gh-117657: Fix TSAN race involving import lock by colesbury · Pull Request #118523 · python/cpython · GitHub

Open Graph Title: gh-117657: Fix TSAN race involving import lock by colesbury · Pull Request #118523 · python/cpython

X Title: gh-117657: Fix TSAN race involving import lock by colesbury · Pull Request #118523 · python/cpython

Description: This adds a _PyRecursiveMutex type based on PyMutex and uses that for the import lock. This fixes some data races in the free-threaded build and simplifies the import lock code. Issue: gh-117657

Open Graph Description: This adds a _PyRecursiveMutex type based on PyMutex and uses that for the import lock. This fixes some data races in the free-threaded build and simplifies the import lock code. Issue: gh-117657

X Description: This adds a _PyRecursiveMutex type based on PyMutex and uses that for the import lock. This fixes some data races in the free-threaded build and simplifies the import lock code. Issue: gh-117657

Opengraph URL: https://github.com/python/cpython/pull/118523

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2bd99fb5-f8ca-a95f-267e-2f5b4b53abae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id981C:DAF2E:43242:5E712:6A59CDB2
html-safe-nonce83d57b357b4e7fb5c91583849f0710e03c5b3729def43972903fe73ec2827c10
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODFDOkRBRjJFOjQzMjQyOjVFNzEyOjZBNTlDREIyIiwidmlzaXRvcl9pZCI6IjgxNDM2NTcwMTQ2NDE5Mzc4NDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac54b5a49cd5d1f8f110aa8bb4410a4646bda348992ce4f4c20a4413748d5a05fe
hovercard-subject-tagpull_request:1852287790
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/118523/files
twitter:imagehttps://avatars.githubusercontent.com/u/655866?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/655866?s=400&v=4
og:image:altThis adds a _PyRecursiveMutex type based on PyMutex and uses that for the import lock. This fixes some data races in the free-threaded build and simplifies the import lock code. Issue: gh-117657
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneba3976babb66479b1c943a8edc0777d96157da48fadc0161f9ddb219deee8353
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseab680789ae4a316cdaf0d5a292a1760140931cc4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/118523/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118523%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F118523%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/118523/files
Reloadhttps://github.com/python/cpython/pull/118523/files
Reloadhttps://github.com/python/cpython/pull/118523/files
Please reload this pagehttps://github.com/python/cpython/pull/118523/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/118523/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
colesburyhttps://github.com/colesbury
python:mainhttps://github.com/python/cpython/tree/main
colesbury:gh-117657-import-lockhttps://github.com/colesbury/cpython/tree/gh-117657-import-lock
Conversation 4 https://github.com/python/cpython/pull/118523
Commits 7 https://github.com/python/cpython/pull/118523/commits
Checks 0 https://github.com/python/cpython/pull/118523/checks
Files changed https://github.com/python/cpython/pull/118523/files
Please reload this pagehttps://github.com/python/cpython/pull/118523/files
gh-117657: Fix TSAN race involving import lock https://github.com/python/cpython/pull/118523/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/118523/files
0fa9fa3 gh-117657: Use PyMutex based recursive lock for import lock colesbury May 2, 2024 https://github.com/python/cpython/pull/118523/commits/0fa9fa309a6c008525d093adbd9e557a9f95f143
143f7eb Merge branch 'main' into gh-117657-import-lock colesbury May 3, 2024 https://github.com/python/cpython/pull/118523/commits/143f7eb4a45e4c09746571da01fe2c0b20bceadb
60f6060 Merge branch 'main' into gh-117657-import-lock colesbury May 31, 2024 https://github.com/python/cpython/pull/118523/commits/60f6060b680eb525184e19298ff51bfb548a88b5
72f4797 Remove fixed races colesbury May 31, 2024 https://github.com/python/cpython/pull/118523/commits/72f4797406f9c83856ee65cb7a11d85913ae4553
42eaae0 Remove fixed race colesbury May 31, 2024 https://github.com/python/cpython/pull/118523/commits/42eaae0711f9e7d646ce721c68edbae21f5cf154
7191cda Remove another fixed race colesbury May 31, 2024 https://github.com/python/cpython/pull/118523/commits/7191cda5536fd0fb62add26c9a6c46de0acbf2c3
225e5b9 Merge branch 'main' into gh-117657-import-lock colesbury Jun 4, 2024 https://github.com/python/cpython/pull/118523/commits/225e5b99766ce8f6e0d6570df87d78913223949a
Clear filters https://github.com/python/cpython/pull/118523/files
Please reload this pagehttps://github.com/python/cpython/pull/118523/files
Please reload this pagehttps://github.com/python/cpython/pull/118523/files
pycore_import.h https://github.com/python/cpython/pull/118523/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
pycore_lock.h https://github.com/python/cpython/pull/118523/files#diff-c4ea3ba1b986b7045be6c6260113e2b765c497ec9842e5c6c30abe466d1f2c73
test_lock.c https://github.com/python/cpython/pull/118523/files#diff-12acc51f85bb5675198b5a0f1b017880dca294530f747c211c16b22030da22ca
posixmodule.c https://github.com/python/cpython/pull/118523/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
import.c https://github.com/python/cpython/pull/118523/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
lock.c https://github.com/python/cpython/pull/118523/files#diff-8a628e2db62193e1be26995ded4a1da56d11a156b4e9190984c910f1b019a962
suppressions_free_threading.txt https://github.com/python/cpython/pull/118523/files#diff-e0bd286d26ab448230ebe522b9086f5e93c33327108faff3a3957a34bb605f62
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L264
Include/internal/pycore_import.hhttps://github.com/python/cpython/pull/118523/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
View file https://github.com/colesbury/cpython/blob/225e5b99766ce8f6e0d6570df87d78913223949a/Include/internal/pycore_import.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/118523/{{ revealButtonHref }}
https://github.com/python/cpython/pull/118523/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
https://github.com/python/cpython/pull/118523/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
https://github.com/python/cpython/pull/118523/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
https://github.com/python/cpython/pull/118523/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
https://github.com/python/cpython/pull/118523/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
https://github.com/python/cpython/pull/118523/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
https://github.com/python/cpython/pull/118523/files#diff-f0d0635a621a67c4105f6b306ecabc7b6f8e1fe1518ae49baf006c26f71520b5
Include/internal/pycore_lock.hhttps://github.com/python/cpython/pull/118523/files#diff-c4ea3ba1b986b7045be6c6260113e2b765c497ec9842e5c6c30abe466d1f2c73
View file https://github.com/colesbury/cpython/blob/225e5b99766ce8f6e0d6570df87d78913223949a/Include/internal/pycore_lock.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/118523/{{ revealButtonHref }}
https://github.com/python/cpython/pull/118523/files#diff-c4ea3ba1b986b7045be6c6260113e2b765c497ec9842e5c6c30abe466d1f2c73
https://github.com/python/cpython/pull/118523/files#diff-c4ea3ba1b986b7045be6c6260113e2b765c497ec9842e5c6c30abe466d1f2c73
Modules/_testinternalcapi/test_lock.chttps://github.com/python/cpython/pull/118523/files#diff-12acc51f85bb5675198b5a0f1b017880dca294530f747c211c16b22030da22ca
View file https://github.com/colesbury/cpython/blob/225e5b99766ce8f6e0d6570df87d78913223949a/Modules/_testinternalcapi/test_lock.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/118523/{{ revealButtonHref }}
https://github.com/python/cpython/pull/118523/files#diff-12acc51f85bb5675198b5a0f1b017880dca294530f747c211c16b22030da22ca
https://github.com/python/cpython/pull/118523/files#diff-12acc51f85bb5675198b5a0f1b017880dca294530f747c211c16b22030da22ca
https://github.com/python/cpython/pull/118523/files#diff-12acc51f85bb5675198b5a0f1b017880dca294530f747c211c16b22030da22ca
https://github.com/python/cpython/pull/118523/files#diff-12acc51f85bb5675198b5a0f1b017880dca294530f747c211c16b22030da22ca
https://github.com/python/cpython/pull/118523/files#diff-12acc51f85bb5675198b5a0f1b017880dca294530f747c211c16b22030da22ca
Modules/posixmodule.chttps://github.com/python/cpython/pull/118523/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
View file https://github.com/colesbury/cpython/blob/225e5b99766ce8f6e0d6570df87d78913223949a/Modules/posixmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/118523/{{ revealButtonHref }}
https://github.com/python/cpython/pull/118523/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/118523/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/118523/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/118523/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/118523/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/118523/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L265
Python/import.chttps://github.com/python/cpython/pull/118523/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
View file https://github.com/colesbury/cpython/blob/225e5b99766ce8f6e0d6570df87d78913223949a/Python/import.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/118523/{{ revealButtonHref }}
https://github.com/python/cpython/pull/118523/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/118523/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/118523/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/118523/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/118523/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/118523/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/118523/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/118523/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
https://github.com/python/cpython/pull/118523/files#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
Python/lock.chttps://github.com/python/cpython/pull/118523/files#diff-8a628e2db62193e1be26995ded4a1da56d11a156b4e9190984c910f1b019a962
View file https://github.com/colesbury/cpython/blob/225e5b99766ce8f6e0d6570df87d78913223949a/Python/lock.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/118523/{{ revealButtonHref }}
https://github.com/python/cpython/pull/118523/files#diff-8a628e2db62193e1be26995ded4a1da56d11a156b4e9190984c910f1b019a962
https://github.com/python/cpython/pull/118523/files#diff-8a628e2db62193e1be26995ded4a1da56d11a156b4e9190984c910f1b019a962
Tools/tsan/suppressions_free_threading.txthttps://github.com/python/cpython/pull/118523/files#diff-e0bd286d26ab448230ebe522b9086f5e93c33327108faff3a3957a34bb605f62
View file https://github.com/colesbury/cpython/blob/225e5b99766ce8f6e0d6570df87d78913223949a/Tools/tsan/suppressions_free_threading.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/118523/{{ revealButtonHref }}
https://github.com/python/cpython/pull/118523/files#diff-e0bd286d26ab448230ebe522b9086f5e93c33327108faff3a3957a34bb605f62
https://github.com/python/cpython/pull/118523/files#diff-e0bd286d26ab448230ebe522b9086f5e93c33327108faff3a3957a34bb605f62
https://github.com/python/cpython/pull/118523/files#diff-e0bd286d26ab448230ebe522b9086f5e93c33327108faff3a3957a34bb605f62
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.